[PR] ObservationConfiguration add fix code [dubbo-samples]
xiaozhigang opened a new pull request, #1160: URL: https://github.com/apache/dubbo-samples/pull/1160 issue-14173：ObservationConfiguration add fix code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [I] [Bug] In the example dubco-samples-spring-boot-trace-skywalking, the run fails [dubbo]
xiaozhigang commented on issue #14173: URL: https://github.com/apache/dubbo/issues/14173#issuecomment-2156305224 issue-14173：ObservationConfiguration add fix code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] wip: change protobuf source [dubbo-kubernetes]
chickenlj closed pull request #103: wip: change protobuf source URL: https://github.com/apache/dubbo-kubernetes/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feature/竞赛/可观测 [dubbo-kubernetes]
chickenlj closed pull request #249: Feature/竞赛/可观测 URL: https://github.com/apache/dubbo-kubernetes/pull/249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feature/竞赛/可观测 星轨初赛文档 [dubbo-kubernetes]
chickenlj closed pull request #252: Feature/竞赛/可观测 星轨初赛文档 URL: https://github.com/apache/dubbo-kubernetes/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Feature/竞赛/跨集群 [dubbo-kubernetes]
chickenlj closed pull request #253: Feature/竞赛/跨集群 URL: https://github.com/apache/dubbo-kubernetes/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] build(deps): bump golang.org/x/sys from 0.0.0-20220114195835-da31bd327af9 to 0.1.0 in /templates/go/common [dubbo-kubernetes]
dependabot[bot] opened a new pull request, #300: URL: https://github.com/apache/dubbo-kubernetes/pull/300 Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.0.0-20220114195835-da31bd327af9 to 0.1.0. Commits See full diff in https://github.com/golang/sys/commits/v0.1.0";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/dubbo-kubernetes/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat(generate): add go generate directive [dubbo-kubernetes]
chickenlj merged PR #136: URL: https://github.com/apache/dubbo-kubernetes/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix the bug where Dubbo cp listens to mapping configuration [dubbo-kubernetes]
chickenlj merged PR #293: URL: https://github.com/apache/dubbo-kubernetes/pull/293 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat(creds): support containers-auth.json [dubbo-kubernetes]
chickenlj merged PR #134: URL: https://github.com/apache/dubbo-kubernetes/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat: pod-container-env-inject webhook [dubbo-kubernetes]
chickenlj commented on code in PR #299:
URL: https://github.com/apache/dubbo-kubernetes/pull/299#discussion_r1632068162
##
pkg/plugins/runtime/k8s/plugin.go:
##
@@ -149,5 +151,20 @@ func addMutators(mgr kube_ctrl.Manager, rt
core_runtime.Runtime, converter k8s_c
defaultMutator := k8s_webhooks.DefaultingWebhookFor(mgr.GetScheme(),
converter)
mgr.GetWebhookServer().Register("/default-dubbo-io-v1alpha1-mesh",
defaultMutator)
+
+ podEnvInjectMutator := k8s_webhooks.PodMutatingWebhook(
+ func(ctx context.Context, pod *kube_core.Pod) error {
+ RegistryCenterUrl := rt.RegistryCenter().GetURL()
+ if pod.Labels["app.kubernetes.io/name"] ==
"dubbo-admin" {
+ pod.Spec.Containers[0].Env =
append(pod.Spec.Containers[0].Env, kube_core.EnvVar{
+ Name: "REGISTRY_CENTER_URL",
Review Comment:
use `DUBBO_REGISTRY_ADDRESS` please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
(dubbo-samples) branch master updated: Update Dockerfile
This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git
The following commit(s) were added to refs/heads/master by this push:
new 6b5bc7574 Update Dockerfile
6b5bc7574 is described below
commit 6b5bc757429dfda8073b35769c07a7e66ea1ec92
Author: Ken Liu
AuthorDate: Sun Jun 9 00:02:40 2024 +0800
Update Dockerfile
---
11-quickstart/Dockerfile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/11-quickstart/Dockerfile b/11-quickstart/Dockerfile
index 1149a98de..0bdf43500 100644
--- a/11-quickstart/Dockerfile
+++ b/11-quickstart/Dockerfile
@@ -1,5 +1,5 @@
# This is the demo Dockerfile for the generated template project, please
change accordingly before building image from it.
-# Run the following command to build image: docker build -f ./Dockerfile
--build-arg APP_FILE=demo-0.0.1-SNAPSHOT.jar -t demo:latest .
+# Run the following command to build image: docker build -f ./Dockerfile
--build-arg APP_FILE=quickstart-service--0.0.1-SNAPSHOT.jar -t demo:latest .
FROM openjdk:17-jdk-alpine
# Set the working directory to /build
@@ -16,7 +16,7 @@ ARG APP_FILE
EXPOSE 50051
# copy the JAR file into the root and rename
-RUN cp ./target/${APP_FILE} app.jar
+RUN cp ./quickstart-service/target/${APP_FILE} app.jar
# Run java with the jar file when the container starts up
CMD ["java","-jar","app.jar"]
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
(dubbo-samples) branch master updated: Update Dockerfile
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new 010eaa7c2 Update Dockerfile 010eaa7c2 is described below commit 010eaa7c28e639ffcf64da5578a57ef805d13fcd Author: Ken Liu AuthorDate: Sat Jun 8 23:45:39 2024 +0800 Update Dockerfile --- 11-quickstart/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/11-quickstart/Dockerfile b/11-quickstart/Dockerfile index f167e0a07..1149a98de 100644 --- a/11-quickstart/Dockerfile +++ b/11-quickstart/Dockerfile @@ -7,7 +7,7 @@ WORKDIR /build COPY . /build RUN chmod +x ./mvnw -RUN ./mvnw clean package -U -skipTests +RUN ./mvnw clean package -U -DskipTests # JAR file will be specified by passing in a build time argument to docker build ARG APP_FILE - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
(dubbo-samples) 01/03: skip test
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git commit ac69f196bc55078c0da0d3b1223e630309f55fc9 Author: chickenlj AuthorDate: Sat Jun 8 23:39:08 2024 +0800 skip test --- 11-quickstart/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/11-quickstart/Dockerfile b/11-quickstart/Dockerfile index d68a30d8e..f167e0a07 100644 --- a/11-quickstart/Dockerfile +++ b/11-quickstart/Dockerfile @@ -7,7 +7,7 @@ WORKDIR /build COPY . /build RUN chmod +x ./mvnw -RUN ./mvnw clean package -U +RUN ./mvnw clean package -U -skipTests # JAR file will be specified by passing in a build time argument to docker build ARG APP_FILE - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
(dubbo-samples) 03/03: Merge remote-tracking branch 'origin/master'
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git commit 35a1a68198671eb385970c82dea8f867d41c4cf8 Merge: b016f9a14 e4f7a7603 Author: chickenlj AuthorDate: Sat Jun 8 23:42:29 2024 +0800 Merge remote-tracking branch 'origin/master' - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
(dubbo-samples) branch master updated (e4f7a7603 -> 35a1a6819)
This is an automated email from the ASF dual-hosted git repository. liujun pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git from e4f7a7603 Update Dockerfile new ac69f196b skip test new b016f9a14 Merge remote-tracking branch 'origin/master' new 35a1a6819 Merge remote-tracking branch 'origin/master' The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
(dubbo-samples) 02/03: Merge remote-tracking branch 'origin/master'
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git commit b016f9a145357ff748dc264151ead7e90d50ae3e Merge: ac69f196b 8d71505c7 Author: chickenlj AuthorDate: Sat Jun 8 23:42:04 2024 +0800 Merge remote-tracking branch 'origin/master' .github/workflows/dubbo-3_2.yml| 24 ++ .github/workflows/dubbo-3_3.yml| 25 ++ 10-task/dubbo-samples-benchmark/README.md | 11 + .../dubbo-samples-benchmark/case-configuration.yml | 86 ++ .../case-runtime-parameter.conf| 7 +- .../dubbo-samples-benchmark}/case-versions.conf| 7 +- .../dubbo-samples-benchmark-agent}/pom.xml | 38 +-- .../agent/CustomizeDubboInstrumentation.java | 93 ++ .../benchmark/agent/DubboInvokeInterceptor.java| 55 .../src/main/resources/skywalking-plugin.def | 14 +- .../dubbo-samples-benchmark-consumer}/pom.xml | 89 +++--- .../demo/consumer/ConsumerApplication.java | 9 +- .../src/main/resources/application.yml | 12 +- .../benchmark/demo/test/ConsumerApplication.java | 8 +- .../dubbo/benchmark/demo/test/ConsumerIT.java | 263 + .../src/test/resources/consumer.xml| 11 + .../src/test/resources/logback.xml | 1 + .../dubbo-samples-benchmark-interface}/pom.xml | 27 +- .../apache/dubbo/benchmark/demo/DemoService.java | 8 +- .../dubbo-samples-benchmark-provider/pom.xml | 78 + .../benchmark/demo/provider/DemoServiceImpl.java | 23 +- .../demo/provider/ProviderApplication.java | 11 +- .../src/main/resources/application.yml | 12 +- 10-task/dubbo-samples-benchmark/pom.xml| 195 + 10-task/pom.xml| 1 + 2-advanced/dubbo-samples-annotation/pom.xml| 5 + .../dubbo-samples-async-generated-future/pom.xml | 6 + .../dubbo-samples-async-onerror/pom.xml| 2 +- .../dubbo-samples-async-original-future/pom.xml| 6 + .../dubbo-samples-async-provider/pom.xml | 6 + .../dubbo-samples-async-simple/pom.xml | 11 + .../dubbo-samples-chain-backend/pom.xml| 6 + 2-advanced/dubbo-samples-chain/pom.xml | 5 + 2-advanced/dubbo-samples-compatible/pom.xml| 5 + 2-advanced/dubbo-samples-context/pom.xml | 5 + 2-advanced/dubbo-samples-docker/pom.xml| 5 + .../dubbo-samples-generic-call-consumer/pom.xml| 5 + .../dubbo-samples-generic-call-provider/pom.xml| 5 + .../dubbo-samples-generic-impl-consumer/pom.xml| 6 + .../dubbo-samples-generic-impl-provider/pom.xml| 5 + .../dubbo-samples-generic-type/pom.xml | 6 + 2-advanced/dubbo-samples-local/pom.xml | 5 + 2-advanced/dubbo-samples-merge/case-versions.conf | 6 +- 2-advanced/dubbo-samples-merge/pom.xml | 5 +- .../pom.xml| 14 + .../pom.xml| 14 + .../pom.xml| 4 + .../pom.xml| 14 +- .../pom.xml| 14 +- 2-advanced/dubbo-samples-native-image/pom.xml | 2 +- .../case-versions.conf | 2 +- 2-advanced/dubbo-samples-spi-compatible/pom.xml| 6 + 2-advanced/dubbo-samples-spring-xml/pom.xml| 7 + 2-advanced/dubbo-samples-version/pom.xml | 5 + .../dubbo-samples-configcenter-apollo/pom.xml | 6 + .../pom.xml| 5 + .../pom.xml| 10 + .../dubbo-samples-configcenter-xml/pom.xml | 6 + .../protocol/dubbo-samples-triple-reactor/pom.xml | 20 +- 3-extensions/protocol/dubbo-samples-triple/pom.xml | 21 +- .../dubbo-samples-mesh-consumer/pom.xml| 6 + .../dubbo-samples-mesh-provider/pom.xml| 6 + .../dubbo-samples-nacos-configcenter/pom.xml | 3 +- .../dubbo-samples-nacos-group/pom.xml | 6 + .../dubbo-samples-nacos-override/pom.xml | 6 + .../dubbo-samples-nacos-tagrouter/pom.xml | 6 + .../pom.xml| 6 + .../pom.xml| 5 + .../pom.xml| 5 + .../dubbo-samples-simplified-registry-xml/pom.xml | 6 + .../protobuf-json-serialization-demo/pom.xml | 5 + .../dubbo-samples-applevel-override/pom.xml| 6 + .../dubbo-samples-configconditionrouter/pom.xml| 6 + 4-governance/dubbo-samples-meshrule-router/pom.xml | 6 + .../dubbo-samples-servicelevel-override/pom.xml| 6 + 4-governance/dubbo-samples-spring-hystrix/pom.xml | 6 +
(dubbo-samples) branch master updated: Update Dockerfile
This is an automated email from the ASF dual-hosted git repository. liujun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git The following commit(s) were added to refs/heads/master by this push: new e4f7a7603 Update Dockerfile e4f7a7603 is described below commit e4f7a7603c5f927b80c77a2f50ccd59db4b78c3b Author: Ken Liu AuthorDate: Sat Jun 8 23:41:56 2024 +0800 Update Dockerfile --- 11-quickstart/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/11-quickstart/Dockerfile b/11-quickstart/Dockerfile index d68a30d8e..f167e0a07 100644 --- a/11-quickstart/Dockerfile +++ b/11-quickstart/Dockerfile @@ -7,7 +7,7 @@ WORKDIR /build COPY . /build RUN chmod +x ./mvnw -RUN ./mvnw clean package -U +RUN ./mvnw clean package -U -skipTests # JAR file will be specified by passing in a build time argument to docker build ARG APP_FILE - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] feat: pod-container-env-inject webhook [dubbo-kubernetes]
sjmshsh commented on PR #299: URL: https://github.com/apache/dubbo-kubernetes/pull/299#issuecomment-2156080622 Use dubbo-kubernetes instead of dubbo-admin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
sonarcloud[bot] commented on PR #14106: URL: https://github.com/apache/dubbo/pull/14106#issuecomment-2156033768 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) **Quality Gate passed** Issues  [105 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=14106&resolutions=WONTFIX) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=14106&resolved=false&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=14106&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=14106) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] Support for more types [dubbo-hessian-lite]
AlbumenJ opened a new pull request, #71: URL: https://github.com/apache/dubbo-hessian-lite/pull/71 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] add non-protobuf triple sample [dubbo-go-samples]
chickenlj merged PR #771: URL: https://github.com/apache/dubbo-go-samples/pull/771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] add non-protobuf triple sample [dubbo-go-samples]
chickenlj commented on PR #771: URL: https://github.com/apache/dubbo-go-samples/pull/771#issuecomment-2155984991  再就是上面的大小写问题，看起来java server这边还好的，go server那边又点问题： 1. 路径上go client发送的是 /org.apache.dubbo.tri.hessian2.api.GreetingsService/Greet，java server是能定位到 greet 方法的 2. 路径上java client发送的是 /org.apache.dubbo.tri.hessian2.api.GreetingsService/greet，go server那边定位不到 Greet 方法 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Support ImmutableCollection & Record [dubbo-hessian-lite]
AlbumenJ merged PR #70: URL: https://github.com/apache/dubbo-hessian-lite/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] add non-protobuf triple sample [dubbo-go-samples]
chickenlj opened a new pull request, #771: URL: https://github.com/apache/dubbo-go-samples/pull/771 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Separate the code for indicator monitoring [dubbo]
walklown commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1629302771
##
dubbo-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java:
##
@@ -14,24 +14,29 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.dubbo.metrics;
+package org.apache.dubbo.common.event;
import org.apache.dubbo.common.beans.factory.ScopeBeanFactory;
-import org.apache.dubbo.metrics.event.MetricsDispatcher;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;
import org.apache.dubbo.rpc.model.ScopeModelInitializer;
-public class MetricsScopeModelInitializer implements ScopeModelInitializer {
+/**
+ * Initialize {@link DubboLifecycleEventMulticaster} for {@link
ApplicationModel}
+ *
+ * @see DubboLifecycleEventMulticaster
+ * @since 3.3.0
+ */
+public class DubboApplicationMulticasterRegistry implements
ScopeModelInitializer {
Review Comment:
Rename DubboApplicationMulticasterRegistry to
DubboMulticasterScopeModelInitializer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
