[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393389089 @normanmaurer @justinmclean I have already add Netty header in files which I modified. And fix License file. The specific content can be viewed at here: https://github.com/apache/incubator-dubbo/pull/1866/files This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.
carryxyh commented on issue #1745: New threadLocal provides more performance.
URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393380659
```
org.apache.rat
apache-rat-plugin
${apache-rat-plugin.version}
verify.rat
verify
check
**/com/caucho/hessian/**
**/com/alibaba/common/threadlocal/InternalThreadLocal.java
**/com/alibaba/common/threadlocal/InternalThreadLocalMap.java
```
This is the new apache-rat-plugin content.
I add
```
**/com/alibaba/common/threadlocal/InternalThreadLocal.java
**/com/alibaba/common/threadlocal/InternalThreadLocalMap.java
```
to the tail of excludes.
Is this right ?
@lovepoem
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393376164 Ok, I will fix it as soon as possible. thx This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393161411 @normanmaurer @justinmclean https://github.com/apache/incubator-dubbo/pull/1865 I have submit a pull request to fix this problem. Pls help me to review. If other thing should I do, tell me. Thanks. Sorry again to @normanmaurer I am really a rookie in open source scope. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393148249 I have read this. And I will list sth which is not comply with Apache 2.0. If u agree, I will supplement this things as soon as possible. 1. You must give any other recipients of the Work or Derivative Works a copy of this License (done) 2. You must cause any modified files to carry prominent notices stating that You changed the files (will fix) 3. You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works (will fix) 4. If the Work includes a "NOTICE" text file as part of its distribution, then any Derivative Works that You distribute must include a readable copy of the attribution notices contained within such NOTICE file, excluding those notices that do not pertain to any part of the Derivative Works, in at least one of the following places: within a NOTICE text file distributed as part of the Derivative Works; within the Source form or documentation, if provided along with the Derivative Works; or, within a display generated by the Derivative Works, if and wherever such third-party notices normally appear. The contents of the NOTICE file are for informational purposes only and do not modify the License. You may add Your own attribution notices within Derivative Works that You distribute, alongside or as an addendum to the NOTICE text from the Work, provided that such additional attribution notices cannot be construed as modifying the License. （done） In conclusion, I will declare I have modify the file(FastThreadLocal and others) and retain original author in the source. What do you think about it @normanmaurer ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.
carryxyh commented on issue #1745: New threadLocal provides more performance.
URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393135489
In the doc, I mentiond `This design is learning from {@see
io.netty.util.concurrent.FastThreadLocal} which is in Netty.`
What other should we do?
@normanmaurer
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org
For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-393134212 @normanmaurer Oh, I mentioned this InternalThreadLocal isI inspired by FastThreadLocal in Netty in the doc. It means I reference most of code from Netty and tell everyone it is from Netty who looked the code. I am so sorry that I did not notice it. By the way, what`s meaning of `attributions is required as part of AL2`. Can u tell me ? And I will fix it as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[GitHub] carryxyh commented on issue #1745: New threadLocal provides more performance.
carryxyh commented on issue #1745: New threadLocal provides more performance. URL: https://github.com/apache/incubator-dubbo/pull/1745#issuecomment-388745592 @beiwei30 done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
