[GitHub] codecov-io commented on issue #1801: support generic invoke for http protocol #1768

2018-05-15 Thread GitBox
codecov-io commented on issue #1801: support generic invoke for http protocol 
#1768
URL: https://github.com/apache/incubator-dubbo/pull/1801#issuecomment-389065493
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr&el=h1) 
Report
   > Merging 
[#1801](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/f78f6d4fa2e600ec212371d5afdf4124fbfd46f0?src=pr&el=desc)
 will **increase** coverage by `0.73%`.
   > The diff coverage is `58.82%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/graphs/tree.svg?height=150&token=VnEIkiFQT0&width=650&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#1801  +/-   ##
   
   + Coverage 39.81%   40.54%   +0.73% 
   - Complexity 4327 4422  +95 
   
 Files   626  627   +1 
 Lines 3007830205 +127 
 Branches   5314 5343  +29 
   
   + Hits  1197512248 +273 
   + Misses1619016014 -176 
   - Partials   1913 1943  +30
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...baba/dubbo/rpc/protocol/AbstractProxyProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJvdG9jb2wvQWJzdHJhY3RQcm94eVByb3RvY29sLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[...om/alibaba/dubbo/rpc/filter/GenericImplFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0dlbmVyaWNJbXBsRmlsdGVyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[.../alibaba/dubbo/rpc/protocol/http/HttpProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1odHRwL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2h0dHAvSHR0cFByb3RvY29sLmphdmE=)
 | `64.28% <62.5%> (ø)` | `7 <2> (?)` | |
   | 
[...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=)
 | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | |
   | 
[...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh)
 | `51.89% <0%> (-3.8%)` | `11% <0%> (-2%)` | |
   | 
[...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==)
 | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | |
   | 
[...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==)
 | `61.81% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: |
   | 
[...m/alibaba/com/caucho/hessian/io/Hessian2Input.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW4ySW5wdXQuamF2YQ==)
 | `19.27% <0%> (+0.11%)` | `63% <0%> (ø)` | :arrow_down: |
   | 
[...on/src/main/java/com/alibaba/dubbo/common/URL.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL1VSTC5qYXZh)
 | `26.34% <0%> (+0.44%)` | `77% <0%> (+1%)` | :arrow_up: |
   | ... and [21 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr&el=footer).
 Last update 
[f78f6d4...6a5a354](https://codecov.io/gh/apache/incubato

[GitHub] codecov-io commented on issue #1801: support generic invoke for http protocol #1768

2018-05-15 Thread GitBox
codecov-io commented on issue #1801: support generic invoke for http protocol 
#1768
URL: https://github.com/apache/incubator-dubbo/pull/1801#issuecomment-389065493
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr&el=h1) 
Report
   > Merging 
[#1801](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/f78f6d4fa2e600ec212371d5afdf4124fbfd46f0?src=pr&el=desc)
 will **increase** coverage by `0.16%`.
   > The diff coverage is `62.5%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/graphs/tree.svg?token=VnEIkiFQT0&src=pr&height=150&width=650)](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master#1801  +/-   ##
   
   + Coverage 39.81%   39.97%   +0.16% 
   - Complexity 4327 4336   +9 
   
 Files   626  627   +1 
 Lines 3007830203 +125 
 Branches   5314 5343  +29 
   
   + Hits  1197512075 +100 
   - Misses1619016206  +16 
   - Partials   1913 1922   +9
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...om/alibaba/dubbo/rpc/filter/GenericImplFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0dlbmVyaWNJbXBsRmlsdGVyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[.../alibaba/dubbo/rpc/protocol/http/HttpProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1odHRwL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2h0dHAvSHR0cFByb3RvY29sLmphdmE=)
 | `64.8% <64.51%> (ø)` | `7 <2> (?)` | |
   | 
[...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==)
 | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | |
   | 
[...aba/dubbo/common/compiler/support/JdkCompiler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2NvbXBpbGVyL3N1cHBvcnQvSmRrQ29tcGlsZXIuamF2YQ==)
 | `61.81% <0%> (ø)` | `2% <0%> (ø)` | :arrow_down: |
   | 
[...m/alibaba/com/caucho/hessian/io/Hessian2Input.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL2lvL0hlc3NpYW4ySW5wdXQuamF2YQ==)
 | `19.27% <0%> (+0.11%)` | `63% <0%> (ø)` | :arrow_down: |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `54.68% <0%> (+1.56%)` | `3% <0%> (ø)` | :arrow_down: |
   | 
[.../dubbo/rpc/protocol/dubbo/DecodeableRpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EZWNvZGVhYmxlUnBjUmVzdWx0LmphdmE=)
 | `59.09% <0%> (+2.27%)` | `8% <0%> (ø)` | :arrow_down: |
   | 
[...a/com/alibaba/dubbo/remoting/exchange/Request.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2UvUmVxdWVzdC5qYXZh)
 | `85.71% <0%> (+2.38%)` | `20% <0%> (ø)` | :arrow_down: |
   | 
[...bo/rpc/protocol/dubbo/telnet/LogTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvTG9nVGVsbmV0SGFuZGxlci5qYXZh)
 | `71.42% <0%> (+2.85%)` | `3% <0%> (ø)` | :arrow_down: |
   | ... and [2 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1801/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1801?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apac