Re: [PR] Fix telnet ctrl+c issue #13812 [dubbo]
AlbumenJ merged PR #13921: URL: https://github.com/apache/dubbo/pull/13921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix telnet ctrl+c issue #13812 [dubbo]
sonarcloud[bot] commented on PR #13921: URL: https://github.com/apache/dubbo/pull/13921#issuecomment-2012051702 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=13921) **Quality Gate passed** Issues  [3 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=13921=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=13921=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=13921=false=true)  [96.8% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13921=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13921=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=13921) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix telnet ctrl+c issue #13812 [dubbo]
hengyoush commented on PR #13921: URL: https://github.com/apache/dubbo/pull/13921#issuecomment-2011951349 > Can you pls add some test cases verify it? I added a unit test, and tested manually: https://github.com/apache/dubbo/assets/32724602/e9f9e3d0-797f-4b12-8690-aa478d5e954f;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix telnet ctrl+c issue #13812 [dubbo]
codecov-commenter commented on PR #13921: URL: https://github.com/apache/dubbo/pull/13921#issuecomment-1998887948 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/13921?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 70.47%. Comparing base [(`0553d70`)](https://app.codecov.io/gh/apache/dubbo/commit/0553d70899253519bd6fab00fb647eababf1c911?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`1f5fbd6`)](https://app.codecov.io/gh/apache/dubbo/pull/13921?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). Additional details and impacted files ```diff @@Coverage Diff @@ ## 3.2 #13921 +/- ## == - Coverage 70.56% 70.47% -0.10% == Files1607 1608 +1 Lines 7007170092 +21 Branches1010010105 +5 == - Hits4944949394 -55 - Misses 1601016070 +60 - Partials 4612 4628 +16 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo/pull/13921?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Fix telnet ctrl+c issue #13812 [dubbo]
sonarcloud[bot] commented on PR #13921: URL: https://github.com/apache/dubbo/pull/13921#issuecomment-1998885309 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo=13921) **Quality Gate passed** Issues  [2 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo=13921=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo=13921=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo=13921=false=true)  [12.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13921=new_coverage=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo=13921=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo=13921) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
[PR] Fix telnet ctrl+c issue #13812 [dubbo]
hengyoush opened a new pull request, #13921: URL: https://github.com/apache/dubbo/pull/13921 ## What is the purpose of the change fix issue #13812. when user type 'Ctrl + C' in telnet client, telnet client will send the following sequence: `FF F4 FF FD 06` to server, it can be divided into two parts: 1. 'FF F4' is telnet interrupt process command. 2. 'FF FD 06' is to suppress the output of the process that is to be interrupted by the interrupt process command. We need to response with 'FF FC 06' to ignore it and tell the client continue display output. ## Brief changelog 1. add a `CtrlCHandler` to handle 'Ctrl + C' request 2. add CtrlCHandler to Netty pipeline , place it previous to `LineBasedFrameDecoder` ## Verifying this change ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
