Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
baerwang merged PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
sonarcloud[bot] commented on PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#issuecomment-2094222144 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=630) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu=630=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=630=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu=630=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=630=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=630) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
mark4z commented on code in PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#discussion_r1589995795 ## go.mod: ## @@ -3,23 +3,23 @@ module github.com/apache/dubbo-go-pixiu go 1.18 require ( - dubbo.apache.org/dubbo-go/v3 v3.0.2-0.20220519062747-f6405fa79d5c + dubbo.apache.org/dubbo-go/v3 v3.1.1-rc1 Review Comment: I'll fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
FoghostCn commented on code in PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#discussion_r1589872377 ## go.mod: ## @@ -3,23 +3,23 @@ module github.com/apache/dubbo-go-pixiu go 1.18 require ( - dubbo.apache.org/dubbo-go/v3 v3.0.2-0.20220519062747-f6405fa79d5c + dubbo.apache.org/dubbo-go/v3 v3.1.1-rc1 Review Comment: why rc version but not v3.1.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
sonarcloud[bot] commented on PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#issuecomment-2088233668 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=630) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu=630=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=630=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu=630=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=630=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=630) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
mark4z commented on code in PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#discussion_r1586110019 ## pkg/config/xds/apiclient/grpc_envoy.go: ## @@ -19,12 +19,12 @@ package apiclient import ( "context" + "github.com/apache/dubbo-go-pixiu/pkg/logger" Review Comment: dubbo go 的logger切到gost了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
AlexStocks commented on code in PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#discussion_r1584922175 ## pkg/config/xds/apiclient/grpc_envoy.go: ## @@ -19,12 +19,12 @@ package apiclient import ( "context" + "github.com/apache/dubbo-go-pixiu/pkg/logger" Review Comment: 这个不怎么 dubbogo 了，哈哈，换下位置吧 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
codecov-commenter commented on PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#issuecomment-2084688986 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/630?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 37.15%. Comparing base [(`26606a8`)](https://app.codecov.io/gh/apache/dubbo-go-pixiu/commit/26606a8317ac79fb8ce826138a34908b62beae1c?dropdown=coverage=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) to head [(`02da6ee`)](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/630?dropdown=coverage=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). > Report is 5 commits behind head on develop. > :exclamation: Current head 02da6ee differs from pull request most recent head e6158b0. Consider uploading reports for the commit e6158b0 to get more accurate results Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #630 +/- ## - Coverage54.67% 37.15% -17.53% Files 671 62 -609 Lines78658 4514-74144 - Hits 43006 1677-41329 + Misses 31981 2648-29333 + Partials 3671 189 -3482 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-go-pixiu/pull/630?dropdown=coverage=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade Dubbo go to v3.1.1 [dubbo-go-pixiu-samples]
mark4z merged PR #54: URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
sonarcloud[bot] commented on PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#issuecomment-2084347518 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=630) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu=630=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=630=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu=630=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=630=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=630) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
sonarcloud[bot] commented on PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#issuecomment-2084330032 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=630) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu=630=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=630=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu=630=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=630=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=630) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
sonarcloud[bot] commented on PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#issuecomment-2084271545 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=630) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu=630=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=630=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu=630=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=630=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=630) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
sonarcloud[bot] commented on PR #630: URL: https://github.com/apache/dubbo-go-pixiu/pull/630#issuecomment-2084266787 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=630) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu=630=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=630=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu=630=false=true)  No data about Coverage  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=630=new_duplicated_lines_density=list) [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=630) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
mark4z closed pull request #629: Upgrade dubbo-go to v3.1.1 URL: https://github.com/apache/dubbo-go-pixiu/pull/629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu]
sonarcloud[bot] commented on PR #629: URL: https://github.com/apache/dubbo-go-pixiu/pull/629#issuecomment-2084263015 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=629) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go-pixiu=629=false=true)  [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_dubbo-go-pixiu=629=new_accepted_issues=list) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go-pixiu=629=false=true)  No data about Coverage  No data about Duplication [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go-pixiu=629) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
Re: [PR] Upgrade dubbo-go to v3.1.1 [dubbo-go-pixiu-samples]
mark4z merged PR #53: URL: https://github.com/apache/dubbo-go-pixiu-samples/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@dubbo.apache.org For additional commands, e-mail: notifications-h...@dubbo.apache.org
