[jira] [Commented] (FREEMARKER-55) FM3 freemarker-spring module, Web MVC support

2018-01-02 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/FREEMARKER-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309125#comment-16309125
 ] 

ASF GitHub Bot commented on FREEMARKER-55:
--

GitHub user woonsan opened a pull request:

https://github.com/apache/incubator-freemarker/pull/41

FREEMARKER-55: Spring MVC Form Support (1) - :form and :input directives



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/woonsan/incubator-freemarker 
feature/FREEMARKER-55-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-freemarker/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #41


commit 150ad7f6039446e2d0e3ee66010abe5be920d8d1
Author: Woonsan Ko 
Date:   2017-12-23T04:21:37Z

FREEMARKER-55: skeletal design

commit fb2ae5cc81c4160c7bc694e0d85b8d979a61db49
Author: Woonsan Ko 
Date:   2017-12-23T22:43:33Z

FREEMARKER-55: skeletal unit test for input tag

commit ff2feb0402d806731bd64e6132952d1c14026b85
Author: Woonsan Ko 
Date:   2017-12-27T05:29:52Z

FREEMARKER-55: Adding TagOutputter

commit 2b5e9b7cb8bda5065e475339f3ec9dd854848b0a
Author: Woonsan Ko 
Date:   2017-12-28T06:26:54Z

FREEMARKER-55: make attribute arguments explicit

commit ae94a3d494ac1da64c89e70a4f021170f064730c
Author: Woonsan Ko 
Date:   2017-12-30T04:54:07Z

FREEMARKER-55: unit tests for form.input directive

commit aa264af1bce93e0891c9551b8c494185471e5727
Author: Woonsan Ko 
Date:   2017-12-30T04:59:13Z

FREEMARKER-55: make it public for consistency

commit 1f7100cee9ca2e1c2c28e4bc5bded6e4857677ec
Author: Woonsan Ko 
Date:   2017-12-30T06:07:12Z

FREEMARKER-55: Adding skeletal form directive

commit 045c980cfcbc96b258334aaf467145914864
Author: Woonsan Ko 
Date:   2018-01-03T04:03:55Z

FREEMARKER-55: Adding tests and polishing




> FM3 freemarker-spring module, Web MVC support
> -
>
> Key: FREEMARKER-55
> URL: https://issues.apache.org/jira/browse/FREEMARKER-55
> Project: Apache Freemarker
>  Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Add Spring "Web MVC framework" functionality to freemarker-spring.
> This can be complex task (and the issue possibly has to be subdivided), as it 
> involves things like:
> * Some aspects of the FreeMarker 2 integration (developed by the Spring 
> developers) are quite confusing ({{FreemarerConfigurer}}, etc.), and we are 
> looking into if it needs to be like that.
> * See if we can support {{@EnableWebMvc}} (note that FreeMarker 2 support is 
> hard coded into {{ViewResolverRegistry}}, which we can't modify)
> * Creating custom directives/methods to expose Spring features like the 
> Spring JSP Tag Library does (but in a way that firs FreeMarker better)
> * Expose JSP custom tag support from the {{freemarker-servlet}} module.
> Depends on: FREEMARKER-54



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] incubator-freemarker pull request #41: FREEMARKER-55: Spring MVC Form Suppor...

2018-01-02 Thread woonsan
GitHub user woonsan opened a pull request:

https://github.com/apache/incubator-freemarker/pull/41

FREEMARKER-55: Spring MVC Form Support (1) - :form and :input directives



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/woonsan/incubator-freemarker 
feature/FREEMARKER-55-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-freemarker/pull/41.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #41


commit 150ad7f6039446e2d0e3ee66010abe5be920d8d1
Author: Woonsan Ko 
Date:   2017-12-23T04:21:37Z

FREEMARKER-55: skeletal design

commit fb2ae5cc81c4160c7bc694e0d85b8d979a61db49
Author: Woonsan Ko 
Date:   2017-12-23T22:43:33Z

FREEMARKER-55: skeletal unit test for input tag

commit ff2feb0402d806731bd64e6132952d1c14026b85
Author: Woonsan Ko 
Date:   2017-12-27T05:29:52Z

FREEMARKER-55: Adding TagOutputter

commit 2b5e9b7cb8bda5065e475339f3ec9dd854848b0a
Author: Woonsan Ko 
Date:   2017-12-28T06:26:54Z

FREEMARKER-55: make attribute arguments explicit

commit ae94a3d494ac1da64c89e70a4f021170f064730c
Author: Woonsan Ko 
Date:   2017-12-30T04:54:07Z

FREEMARKER-55: unit tests for form.input directive

commit aa264af1bce93e0891c9551b8c494185471e5727
Author: Woonsan Ko 
Date:   2017-12-30T04:59:13Z

FREEMARKER-55: make it public for consistency

commit 1f7100cee9ca2e1c2c28e4bc5bded6e4857677ec
Author: Woonsan Ko 
Date:   2017-12-30T06:07:12Z

FREEMARKER-55: Adding skeletal form directive

commit 045c980cfcbc96b258334aaf467145914864
Author: Woonsan Ko 
Date:   2018-01-03T04:03:55Z

FREEMARKER-55: Adding tests and polishing




---