[jira] [Commented] (FREEMARKER-54) FM3 freemareker-spring module, basic functionality
[
https://issues.apache.org/jira/browse/FREEMARKER-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053065#comment-16053065
]
ASF GitHub Bot commented on FREEMARKER-54:
--
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/23
FREEMARKER-54: FM3 freemareker-spring module, basic functionality
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-54
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/23.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #23
commit dbbfe99074d22fa59437a6d90499f3f3199040ba
Author: Woonsan Ko
Date: 2017-06-15T01:03:35Z
FREEMARKER-54: Adding skeletal freemarker-spring module
commit 57270ecf85744c5c6ca566c89f21f721a7a9d59a
Author: Woonsan Ko
Date: 2017-06-15T04:10:58Z
FREEMARKER-54: initial ConfigurationFactoryBean design
commit 2783387eb495331042e72449f02b2a18527a9e13
Author: Woonsan Ko
Date: 2017-06-15T04:37:24Z
feature/FREEMARKER-54: ConfigurationFactoryBean tests
commit 99c3c0cb45cf500a0fc914332a88f78e17c9d5e6
Author: Woonsan Ko
Date: 2017-06-16T03:15:08Z
FREEMARKER-54: More setting tests through ConfigurationFactoryBean
commit 18ee8a0846dbbbf4b853af8f76509f331bfb07ae
Author: Woonsan Ko
Date: 2017-06-16T03:23:42Z
FREEMARKER-54: use property wherever easier than settings map.
commit a571c24f6fc9544e164eeaf71347044b3fe88182
Author: Woonsan Ko
Date: 2017-06-18T03:44:46Z
FREEMARKER-54: Adding SpringResourceTemplateLoader and test
commit fc1f429cc4174b8ced71617074718715b81ee575
Author: Woonsan Ko
Date: 2017-06-18T03:45:59Z
Merge branch '3' into feature/FREEMARKER-54
> FM3 freemareker-spring module, basic functionality
> --
>
> Key: FREEMARKER-54
> URL: https://issues.apache.org/jira/browse/FREEMARKER-54
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Create the Gradle module. Basic non-Web functionality. This certainly means:
> * Creating a FactoryBean by extending {{Configuration.ExtendableBuilder}}
> which has defaults that are practical for Spring.
> * Creating a {{SpringResourceTemplateLoader}} which relies on Spring's
> {{Resource}} abstraction
> It's also an important goal to polish the {{freemarker-core}} configuration
> and template loader API-s, and change them if that's needed for smoother
> Spring integration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-54) FM3 freemareker-spring module, basic functionality
[
https://issues.apache.org/jira/browse/FREEMARKER-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053066#comment-16053066
]
Woonsan Ko commented on FREEMARKER-54:
--
I've just opened a pull request for initial reviews. It contains (a)
FactoryBean by extending Configuration.ExtendableBuilder and (b)
SpringResourceTemplateLoader at the moment.
However, I didn't give enough consideration on the following yet:
- "defaults that are practical for Spring"
- "polish the freemarker-core configuration and template loader API-s"
I'd like to polish more about those two points with this PR.
> FM3 freemareker-spring module, basic functionality
> --
>
> Key: FREEMARKER-54
> URL: https://issues.apache.org/jira/browse/FREEMARKER-54
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Create the Gradle module. Basic non-Web functionality. This certainly means:
> * Creating a FactoryBean by extending {{Configuration.ExtendableBuilder}}
> which has defaults that are practical for Spring.
> * Creating a {{SpringResourceTemplateLoader}} which relies on Spring's
> {{Resource}} abstraction
> It's also an important goal to polish the {{freemarker-core}} configuration
> and template loader API-s, and change them if that's needed for smoother
> Spring integration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-54) FM3 freemareker-spring module, basic functionality
[
https://issues.apache.org/jira/browse/FREEMARKER-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053213#comment-16053213
]
ASF GitHub Bot commented on FREEMARKER-54:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/23
> FM3 freemareker-spring module, basic functionality
> --
>
> Key: FREEMARKER-54
> URL: https://issues.apache.org/jira/browse/FREEMARKER-54
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Create the Gradle module. Basic non-Web functionality. This certainly means:
> * Creating a FactoryBean by extending {{Configuration.ExtendableBuilder}}
> which has defaults that are practical for Spring.
> * Creating a {{SpringResourceTemplateLoader}} which relies on Spring's
> {{Resource}} abstraction
> It's also an important goal to polish the {{freemarker-core}} configuration
> and template loader API-s, and change them if that's needed for smoother
> Spring integration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-54) FM3 freemareker-spring module, basic functionality
[
https://issues.apache.org/jira/browse/FREEMARKER-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053218#comment-16053218
]
Daniel Dekany commented on FREEMARKER-54:
-
As of {{ConfigurationFactoryBean.setSettings(Map)}}, {{ExtendedBuilder}}
already has a very similar method inherited:
{{org.apache.freemarker.core.MutableProcessingConfiguration.setSettings(Properties)}}.
If a {{Map}} parameter is better than a {{Properties}}, then I think you
should change {{MutableProcessingConfiguration.setSettings}} (with considering
that Bean property setters can't be overloaded, and {{Properties}} extends
{{Map}}, not {{Map}}... so it will be a bit ugly,
and {{_CollectionUtil.safeCastMap}} will be needed).
> FM3 freemareker-spring module, basic functionality
> --
>
> Key: FREEMARKER-54
> URL: https://issues.apache.org/jira/browse/FREEMARKER-54
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Create the Gradle module. Basic non-Web functionality. This certainly means:
> * Creating a FactoryBean by extending {{Configuration.ExtendableBuilder}}
> which has defaults that are practical for Spring.
> * Creating a {{SpringResourceTemplateLoader}} which relies on Spring's
> {{Resource}} abstraction
> It's also an important goal to polish the {{freemarker-core}} configuration
> and template loader API-s, and change them if that's needed for smoother
> Spring integration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-54) FM3 freemareker-spring module, basic functionality
[
https://issues.apache.org/jira/browse/FREEMARKER-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053436#comment-16053436
]
ASF GitHub Bot commented on FREEMARKER-54:
--
GitHub user woonsan opened a pull request:
https://github.com/apache/incubator-freemarker/pull/24
FREEMARKER-54: Remove unnecessary #setSettings(); Logging correction;
VersionEditor for conversion between string and Version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/woonsan/incubator-freemarker
feature/FREEMARKER-54
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/24.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #24
commit 94828521fc30f0d51c7728d37b537404c8096bfe
Author: Woonsan Ko
Date: 2017-06-19T02:12:03Z
FREEMARKER-54: Remove ConfigurationFactoryBean#setSettings(...) because
ancestor already contains equivalent one. Also, separate spring logger.
commit cb43725a79e851c11d4552d3a5ab0b6d70d43e9d
Author: Woonsan Ko
Date: 2017-06-19T03:13:56Z
FREEMARKER-54: Support Version convertion editor between string and Version
object for spring community
> FM3 freemareker-spring module, basic functionality
> --
>
> Key: FREEMARKER-54
> URL: https://issues.apache.org/jira/browse/FREEMARKER-54
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Create the Gradle module. Basic non-Web functionality. This certainly means:
> * Creating a FactoryBean by extending {{Configuration.ExtendableBuilder}}
> which has defaults that are practical for Spring.
> * Creating a {{SpringResourceTemplateLoader}} which relies on Spring's
> {{Resource}} abstraction
> It's also an important goal to polish the {{freemarker-core}} configuration
> and template loader API-s, and change them if that's needed for smoother
> Spring integration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-54) FM3 freemareker-spring module, basic functionality
[
https://issues.apache.org/jira/browse/FREEMARKER-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053439#comment-16053439
]
Woonsan Ko commented on FREEMARKER-54:
--
Thanks for the pointer! I've corrected the following:
- {{#setSettings(Map)}} was removed as {{#setSetting(Properties)}} is totally
fine in spring (ref: bean definition example in commented block in unit test).
- Corrected logging in {{SpringResourceTemplateLoader}}.
- Added {{VersionEditor}} for Spring because it's more convenient to set by
string in XML bean definitions. (See "FooEditor" example in \[1\] for
reference.)
Since this PR includes {{VersionEditor}} in core, please take a review.
Regards,
Woonsan
\[1\]
https://docs.spring.io/spring/docs/current/spring-framework-reference/html/validation.html#beans-beans-conversion
> FM3 freemareker-spring module, basic functionality
> --
>
> Key: FREEMARKER-54
> URL: https://issues.apache.org/jira/browse/FREEMARKER-54
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Create the Gradle module. Basic non-Web functionality. This certainly means:
> * Creating a FactoryBean by extending {{Configuration.ExtendableBuilder}}
> which has defaults that are practical for Spring.
> * Creating a {{SpringResourceTemplateLoader}} which relies on Spring's
> {{Resource}} abstraction
> It's also an important goal to polish the {{freemarker-core}} configuration
> and template loader API-s, and change them if that's needed for smoother
> Spring integration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-54) FM3 freemareker-spring module, basic functionality
[
https://issues.apache.org/jira/browse/FREEMARKER-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16053701#comment-16053701
]
ASF GitHub Bot commented on FREEMARKER-54:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/24
> FM3 freemareker-spring module, basic functionality
> --
>
> Key: FREEMARKER-54
> URL: https://issues.apache.org/jira/browse/FREEMARKER-54
> Project: Apache Freemarker
> Issue Type: Task
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>
> Create the Gradle module. Basic non-Web functionality. This certainly means:
> * Creating a FactoryBean by extending {{Configuration.ExtendableBuilder}}
> which has defaults that are practical for Spring.
> * Creating a {{SpringResourceTemplateLoader}} which relies on Spring's
> {{Resource}} abstraction
> It's also an important goal to polish the {{freemarker-core}} configuration
> and template loader API-s, and change them if that's needed for smoother
> Spring integration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
