[jira] [Commented] (FREEMARKER-64) FM3 Unification and improvement of function-like constructs
[
https://issues.apache.org/jira/browse/FREEMARKER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118241#comment-16118241
]
ASF GitHub Bot commented on FREEMARKER-64:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/33
> FM3 Unification and improvement of function-like constructs
> ---
>
> Key: FREEMARKER-64
> URL: https://issues.apache.org/jira/browse/FREEMARKER-64
> Project: Apache Freemarker
> Issue Type: New Feature
> Components: engine
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>Assignee: Daniel Dekany
>
> FREEMARKER-63 has introduced {{TemplateFunctionModel}}, which is the type of
> values that {{#function}} creates. It should also replace
> {{TemplateMethodModel}} and {{TemplateMethodModelEx}}, so that we have only
> one interface for function-like things. (If that doesn't work out well, we at
> least should remove the deprecated {{TemplateMethodModel}}, and then rename
> {{TemplateMethodModelEx}} to that name. Also, we need to support the explicit
> selection overloaded Java methods - see in {{CallPlace}}).
> As {{TemplateFunctionModel}} supports both positional and named parameters,
> the expression language has to be upgraded to support that too.
> Things like `?isMethod` and `?isFunction` have to be reworked as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-64) FM3 Unification and improvement of function-like constructs
[
https://issues.apache.org/jira/browse/FREEMARKER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118228#comment-16118228
]
ASF GitHub Bot commented on FREEMARKER-64:
--
GitHub user ddekany opened a pull request:
https://github.com/apache/incubator-freemarker/pull/33
FREEMARKER-64: Function (and thus also method) call syntax now suppor…
…ts passing parameter by name.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ddekany/incubator-freemarker FREEMARKER-64
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
commit b59a03a8add0f47427ddd9594852f7bd86a8a7e9
Author: ddekany
Date: 2017-08-08T11:46:50Z
FREEMARKER-64: Function (and thus also method) call syntax now supports
passing parameter by name.
> FM3 Unification and improvement of function-like constructs
> ---
>
> Key: FREEMARKER-64
> URL: https://issues.apache.org/jira/browse/FREEMARKER-64
> Project: Apache Freemarker
> Issue Type: New Feature
> Components: engine
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>Assignee: Daniel Dekany
>
> FREEMARKER-63 has introduced {{TemplateFunctionModel}}, which is the type of
> values that {{#function}} creates. It should also replace
> {{TemplateMethodModel}} and {{TemplateMethodModelEx}}, so that we have only
> one interface for function-like things. (If that doesn't work out well, we at
> least should remove the deprecated {{TemplateMethodModel}}, and then rename
> {{TemplateMethodModelEx}} to that name. Also, we need to support the explicit
> selection overloaded Java methods - see in {{CallPlace}}).
> As {{TemplateFunctionModel}} supports both positional and named parameters,
> the expression language has to be upgraded to support that too.
> Things like `?isMethod` and `?isFunction` have to be reworked as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-64) FM3 Unification and improvement of function-like constructs
[
https://issues.apache.org/jira/browse/FREEMARKER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117466#comment-16117466
]
ASF GitHub Bot commented on FREEMARKER-64:
--
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/32
> FM3 Unification and improvement of function-like constructs
> ---
>
> Key: FREEMARKER-64
> URL: https://issues.apache.org/jira/browse/FREEMARKER-64
> Project: Apache Freemarker
> Issue Type: New Feature
> Components: engine
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>Assignee: Daniel Dekany
>
> FREEMARKER-63 has introduced {{TemplateFunctionModel}}, which is the type of
> values that {{#function}} creates. It should also replace
> {{TemplateMethodModel}} and {{TemplateMethodModelEx}}, so that we have only
> one interface for function-like things. (If that doesn't work out well, we at
> least should remove the deprecated {{TemplateMethodModel}}, and then rename
> {{TemplateMethodModelEx}} to that name. Also, we need to support the explicit
> selection overloaded Java methods - see in {{CallPlace}}).
> As {{TemplateFunctionModel}} supports both positional and named parameters,
> the expression language has to be upgraded to support that too.
> Things like `?isMethod` and `?isFunction` have to be reworked as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (FREEMARKER-64) FM3 Unification and improvement of function-like constructs
[
https://issues.apache.org/jira/browse/FREEMARKER-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117461#comment-16117461
]
ASF GitHub Bot commented on FREEMARKER-64:
--
GitHub user ddekany opened a pull request:
https://github.com/apache/incubator-freemarker/pull/32
FREEMARKER-64: FM3 Unification and improvement of function-like constructs
What's done: Replaced TemplateMethodModel and TemplateMethodModelEx with
TemplateFunctionModel. Some refinements in other TemplateCallableModel API-s.
Built-ins like `?isMethod`, `?isTransform`, `?isMacro` are not removed, in
favor of `?isDirective` and `?isFunction`.
What's still missing: calling functions with named parameters.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ddekany/incubator-freemarker FREEMARKER-64
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
> FM3 Unification and improvement of function-like constructs
> ---
>
> Key: FREEMARKER-64
> URL: https://issues.apache.org/jira/browse/FREEMARKER-64
> Project: Apache Freemarker
> Issue Type: New Feature
> Components: engine
>Affects Versions: 3.0.0
>Reporter: Daniel Dekany
>Assignee: Daniel Dekany
>
> FREEMARKER-63 has introduced {{TemplateFunctionModel}}, which is the type of
> values that {{#function}} creates. It should also replace
> {{TemplateMethodModel}} and {{TemplateMethodModelEx}}, so that we have only
> one interface for function-like things. (If that doesn't work out well, we at
> least should remove the deprecated {{TemplateMethodModel}}, and then rename
> {{TemplateMethodModelEx}} to that name. Also, we need to support the explicit
> selection overloaded Java methods - see in {{CallPlace}}).
> As {{TemplateFunctionModel}} supports both positional and named parameters,
> the expression language has to be upgraded to support that too.
> Things like `?isMethod` and `?isFunction` have to be reworked as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
