Re: [PR] GEODE-9002: Add New Statistic Type For /proc/schedstat [geode]
Bill commented on code in PR #6090:
URL: https://github.com/apache/geode/pull/6090#discussion_r1520395709
##
geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java:
##
@@ -1118,6 +1119,10 @@ private void forceDisconnect(String reason) {
joinResponse.notifyAll();
}
} else {
+
+ // TODO: consider either always doing this or putting it behind a system
property flag
+ OSProcess.printStacks(0);
Review Comment:
remove me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [SECURITY] Use HTTPS to resolve dependencies in Maven Build [geode-kafka-connector]
pjfanning commented on PR #21: URL: https://github.com/apache/geode-kafka-connector/pull/21#issuecomment-1969956132 I raised I raised https://issues.apache.org/jira/browse/GEODE-10451 for this for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SECURITY] Use HTTPS to resolve dependencies in Gradle Build [geode-kafka-connector]
pjfanning commented on PR #23: URL: https://github.com/apache/geode-kafka-connector/pull/23#issuecomment-1969954851 I raised https://issues.apache.org/jira/browse/GEODE-10451 for this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [SECURITY] Use HTTPS to resolve dependencies in Maven Build [geode-kafka-connector]
JLLeitschuh opened a new pull request, #28: URL: https://github.com/apache/geode-kafka-connector/pull/28 [](https://infosecwriteups.com/want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-1fc329d898fb) --- This is a security fix for a high severity vulnerability in your [Apache Maven](https://maven.apache.org/) `pom.xml` file(s). The build files indicate that this project is resolving dependencies over HTTP instead of HTTPS. This leaves your build vulnerable to allowing a [Man in the Middle](https://en.wikipedia.org/wiki/Man-in-the-middle_attack) (MITM) attackers to execute arbitrary code on your or your computer or CI/CD system. This vulnerability has a CVSS v3.0 Base Score of [8.1/10](https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator?vector=AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:H). [POC code](https://max.computer/blog/how-to-take-over-the-computer-of-any-java-or-clojure-or-scala-developer/) has existed since 2014 to maliciously compromise a JAR file in-flight. MITM attacks against HTTP are [increasingly common](https://security.stackexchange.com/a/12050), for example [Comcast is known to have done it to their own users](https://thenextweb.com/news/comcast-continues-to-inject-its-own-code-into-websites-you-visit). ## Resources - [Want to take over the Java ecosystem? All you need is a MITM!](https://infosecwriteups.com/want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-1fc329d898fb) - [Update: Want to take over the Java ecosystem? All you need is a MITM!](https://medium.com/bugbountywriteup/update-want-to-take-over-the-java-ecosystem-all-you-need-is-a-mitm-d069d253fe23?source=friends_link=8c8e52a7d57b98d0b7e541665688b454) - [CVE-2021-26291](https://nvd.nist.gov/vuln/detail/CVE-2021-26291) ## Source This contribution was automatically generated with an [OpenRewrite](https://github.com/openrewrite/rewrite) [refactoring recipe](https://docs.openrewrite.org/), which was lovingly handcrafted :heart: to bring this security fix to your repository. The source code that generated this PR can be found here: [UseHttpsForRepositories]() ## Detecting this and Future Vulnerabilities This vulnerability was automatically detected by GitHub's CodeQL using this [CodeQL Query](https://codeql.github.com/codeql-query-help/java/java-maven-non-https-url/). You can automatically detect future vulnerabilities, like this one, by enabling the free (for open-source) [CodeQL: GitHub Action](https://github.com/github/codeql-action). I'm not an employee of GitHub, I'm simply an open-source security researcher for the Open Source Security Foundation. ## Opting Out If you'd like to opt out of future automated security vulnerability fixes like this, please consider adding a file called `.github/GH-ROBOTS.txt` to your repository with the line: ``` User-agent: JLLeitschuh/security-research Disallow: * ``` This bot will respect the [ROBOTS.txt](https://moz.com/learn/seo/robotstxt) format for future contributions. Alternatively, if this project is no longer actively maintained, consider [archiving](https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-archiving-repositories) the repository. ## CLA Requirements _This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions._ All contributed commits are already automatically signed off. > The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin > (see [https://developercertificate.org/](https://developercertificate.org/) for more information). > > \- [Git Commit SignOff documentation](https://developercertificate.org/) ## Sponsorship & Support This work was originally sponsored by HUMAN Security Inc. and the new Dan Kaminsky Fellowship, a fellowship created to celebrate Dan's memory and legacy by funding open-source work that makes the world a better (and more secure) place. This work was later sponsored by [Open Source Security Foundation (OpenSSF)](https://openssf.org/): Project [Alpha-Omega](https://openssf.org/community/alpha-omega/). Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code – and get them fixed – to improve global software supply chain security. This PR was generated with [Moderne](https://www.moderne.io/), a free-for-open source SaaS offering that uses format-preserving AST transformations to fix bugs, standa
Re: [PR] GEODE-10414: Implement Region::putIfAbsent method [geode-native]
gaussianrecurrence closed pull request #984: GEODE-10414: Implement Region::putIfAbsent method URL: https://github.com/apache/geode-native/pull/984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GEODE-10414: Implement Region::putIfAbsent method [geode-native]
gaussianrecurrence commented on PR #984: URL: https://github.com/apache/geode-native/pull/984#issuecomment-1816770978 I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GEODE-10400: Fix metadata completion detection [geode-native]
gaussianrecurrence commented on PR #982: URL: https://github.com/apache/geode-native/pull/982#issuecomment-1816770813 I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GEODE-10396: Avoid endpoint closure upon exception [geode-native]
gaussianrecurrence commented on PR #977: URL: https://github.com/apache/geode-native/pull/977#issuecomment-1816770656 I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GEODE-10400: Fix metadata completion detection [geode-native]
gaussianrecurrence closed pull request #982: GEODE-10400: Fix metadata completion detection URL: https://github.com/apache/geode-native/pull/982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GEODE-10396: Avoid endpoint closure upon exception [geode-native]
gaussianrecurrence closed pull request #977: GEODE-10396: Avoid endpoint closure upon exception URL: https://github.com/apache/geode-native/pull/977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GEODE-10276: Refactor PDX (de)serialization code [geode-native]
gaussianrecurrence commented on PR #969: URL: https://github.com/apache/geode-native/pull/969#issuecomment-1816770033 I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GEODE-10276: Refactor PDX (de)serialization code [geode-native]
gaussianrecurrence closed pull request #969: GEODE-10276: Refactor PDX (de)serialization code URL: https://github.com/apache/geode-native/pull/969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GEODE-10044: Allow FunctionAttributes update [geode-native]
gaussianrecurrence commented on PR #930: URL: https://github.com/apache/geode-native/pull/930#issuecomment-1816768908 I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GEODE-10044: Allow FunctionAttributes update [geode-native]
gaussianrecurrence closed pull request #930: GEODE-10044: Allow FunctionAttributes update URL: https://github.com/apache/geode-native/pull/930 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GEODE-10012: Avoid non-HA function retries [geode-native]
gaussianrecurrence commented on PR #920: URL: https://github.com/apache/geode-native/pull/920#issuecomment-1816767907 I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GEODE-10012: Avoid non-HA function retries [geode-native]
gaussianrecurrence closed pull request #920: GEODE-10012: Avoid non-HA function retries URL: https://github.com/apache/geode-native/pull/920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GEODE-10017: Fix servers restart within new ITs [geode-native]
gaussianrecurrence commented on PR #919: URL: https://github.com/apache/geode-native/pull/919#issuecomment-1816767172 I haven't had the time to work on this for a long time or I think I'll have the opportunity to in the near future, hence I am closing this PR, if anyone wants to tackle this issue can take it up from its latest state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] GEODE-10017: Fix servers restart within new ITs [geode-native]
gaussianrecurrence closed pull request #919: GEODE-10017: Fix servers restart within new ITs URL: https://github.com/apache/geode-native/pull/919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.zookeeper:zookeeper from 3.5.7 to 3.7.2 [geode-kafka-connector]
dependabot[bot] opened a new pull request, #27: URL: https://github.com/apache/geode-kafka-connector/pull/27 Bumps org.apache.zookeeper:zookeeper from 3.5.7 to 3.7.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/geode-kafka-connector/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump puma from 5.3.2 to 6.3.1 in /geode-book [geode]
sboorlagadda commented on PR #7883: URL: https://github.com/apache/geode/pull/7883#issuecomment-1754358866 @CalvinKirs Could you describe a little bit more? is that a dependency checker? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda merged pull request #7884: Update shiro to 1.12.0 for CVE-2023-34478
sboorlagadda merged PR #7884: URL: https://github.com/apache/geode/pull/7884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] overmeulen opened a new pull request, #7884: Update shiro to 1.12.0 for CVE-2023-34478
overmeulen opened a new pull request, #7884: URL: https://github.com/apache/geode/pull/7884 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-kafka-connector] dependabot[bot] opened a new pull request, #26: Bump org.apache.kafka:kafka_2.12 from 2.3.1 to 2.6.3
dependabot[bot] opened a new pull request, #26: URL: https://github.com/apache/geode-kafka-connector/pull/26 Bumps org.apache.kafka:kafka_2.12 from 2.3.1 to 2.6.3. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/geode-kafka-connector/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] dependabot[bot] opened a new pull request, #989: Bump puma from 5.6.4 to 6.3.1 in /docs/geode-native-book-dotnet
re used (https://redirect.github.com/puma/puma/issues/3163;>#3163) Handle malformed request path (https://redirect.github.com/puma/puma/issues/3155;>#3155, https://redirect.github.com/puma/puma/issues/3148;>#3148) Misc lib file fixes - trapping additional errors, CI helper (https://redirect.github.com/puma/puma/issues/3129;>#3129) Fixup req form data file upload with r\n line endings (https://redirect.github.com/puma/puma/issues/3137;>#3137) Restore rack 1.6 compatibility (https://redirect.github.com/puma/puma/issues/3156;>#3156) Refactor const.rb - Update Puma::HTTP_STATUS_CODES (https://redirect.github.com/puma/puma/issues/3162;>#3162) Clarify Reactor#initialize (https://redirect.github.com/puma/puma/issues/3151;>#3151) 6.2.2 / 2023-04-17 Bugfixes Fix Rack-related NameError by adding :: operator (https://redirect.github.com/puma/puma/issues/3118;>#3118, https://redirect.github.com/puma/puma/issues/3117;>#3117) 6.2.1 / 2023-03-31 Bugfixes Fix java 8 compatibility (https://redirect.github.com/puma/puma/issues/3109;>#3109, https://redirect.github.com/puma/puma/issues/3108;>#3108) Always write io_buffer when in enum bodies branch. (https://redirect.github.com/puma/puma/issues/3113;>#3113, https://redirect.github.com/puma/puma/issues/3112;>#3112) Fix warn_if_in_single_mode incorrect message (https://redirect.github.com/puma/puma/issues/3111;>#3111) 6.2.0 / 2023-03-29 Features Ability to supply a custom logger (https://redirect.github.com/puma/puma/issues/2770;>#2770, https://redirect.github.com/puma/puma/issues/2511;>#2511) Warn when clustered-only hooks are defined in single mode (https://redirect.github.com/puma/puma/issues/3089;>#3089) Adds the on_booted event (https://redirect.github.com/puma/puma/issues/2709;>#2709) Bugfixes Loggers - internal_write - catch Errno::EINVAL (https://redirect.github.com/puma/puma/issues/3091;>#3091) commonlogger.rb - fix HIJACK time format, use constants, not strings (https://redirect.github.com/puma/puma/issues/3074;>#3074) Fixed some edge cases regarding request hijacking (https://redirect.github.com/puma/puma/issues/3072;>#3072) 6.1.1 / 2023-02-28 Bugfixes ... (truncated) Commits https://github.com/puma/puma/commit/72bdcd16cd680ab109a9df448b64ab53cb6bfccd;>72bdcd1 6.3.1 https://github.com/puma/puma/commit/ed0f2f94b56982c687452504b95d5f1fbbe3eed1;>ed0f2f9 Merge pull request from GHSA-68xg-gqqm-vgj8 https://github.com/puma/puma/commit/763d1a1a971d9bb17fc1478859d626a539c29970;>763d1a1 6.3.0 (https://redirect.github.com/puma/puma/issues/3169;>#3169) https://github.com/puma/puma/commit/dfd33df8b1c63091cfa56632a45542b75a2920f1;>dfd33df Add dsl method supported_http_methods (https://redirect.github.com/puma/puma/issues/3106;>#3106) https://github.com/puma/puma/commit/a434005e8fb53c80725d113079726ba0474bbe76;>a434005 Puma error responses - remove fingerprints to indicate Puma (https://redirect.github.com/puma/puma/issues/3161;>#3161) https://github.com/puma/puma/commit/7b7774ce67ec171c7ba70327ca2b6ca2f00a44c5;>7b7774c Don't send 103 early hints response when only invalid headers are used (https://redirect.github.com/puma/puma/issues/3163;>#3163) https://github.com/puma/puma/commit/2bb9143c4538f854ad0fd6aaf41aea47df5ee724;>2bb9143 const.rb - Update Puma::HTTP_STATUS_CODES (https://redirect.github.com/puma/puma/issues/3162;>#3162) https://github.com/puma/puma/commit/d244dc7eea842898e06d2a1a8a9c89e039eb5714;>d244dc7 [CI] - Use RubyGems 3.3.26 for Ruby 2.4 thru 2.6 (was 3.3.14) (https://redirect.github.com/puma/puma/issues/3160;>#3160) https://github.com/puma/puma/commit/c467e57f3d21dc3ffe3b8fd01c1d19e455ad721e;>c467e57 [CI] test_redirect_io.rb - fixup for intermittent failures (https://redirect.github.com/puma/puma/issues/3157;>#3157) https://github.com/puma/puma/commit/b61bbc740fd00408f3a70a63d8e477e7fdd06f16;>b61bbc7 [CI] Use ~ for heredocs (https://redirect.github.com/puma/puma/issues/3159;>#3159) Additional commits viewable in https://github.com/puma/puma/compare/v5.6.4...v6.3.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options
[GitHub] [geode-native] dependabot[bot] opened a new pull request, #990: Bump puma from 5.6.4 to 6.3.1 in /docs/geode-native-book-cpp
re used (https://redirect.github.com/puma/puma/issues/3163;>#3163) Handle malformed request path (https://redirect.github.com/puma/puma/issues/3155;>#3155, https://redirect.github.com/puma/puma/issues/3148;>#3148) Misc lib file fixes - trapping additional errors, CI helper (https://redirect.github.com/puma/puma/issues/3129;>#3129) Fixup req form data file upload with r\n line endings (https://redirect.github.com/puma/puma/issues/3137;>#3137) Restore rack 1.6 compatibility (https://redirect.github.com/puma/puma/issues/3156;>#3156) Refactor const.rb - Update Puma::HTTP_STATUS_CODES (https://redirect.github.com/puma/puma/issues/3162;>#3162) Clarify Reactor#initialize (https://redirect.github.com/puma/puma/issues/3151;>#3151) 6.2.2 / 2023-04-17 Bugfixes Fix Rack-related NameError by adding :: operator (https://redirect.github.com/puma/puma/issues/3118;>#3118, https://redirect.github.com/puma/puma/issues/3117;>#3117) 6.2.1 / 2023-03-31 Bugfixes Fix java 8 compatibility (https://redirect.github.com/puma/puma/issues/3109;>#3109, https://redirect.github.com/puma/puma/issues/3108;>#3108) Always write io_buffer when in enum bodies branch. (https://redirect.github.com/puma/puma/issues/3113;>#3113, https://redirect.github.com/puma/puma/issues/3112;>#3112) Fix warn_if_in_single_mode incorrect message (https://redirect.github.com/puma/puma/issues/3111;>#3111) 6.2.0 / 2023-03-29 Features Ability to supply a custom logger (https://redirect.github.com/puma/puma/issues/2770;>#2770, https://redirect.github.com/puma/puma/issues/2511;>#2511) Warn when clustered-only hooks are defined in single mode (https://redirect.github.com/puma/puma/issues/3089;>#3089) Adds the on_booted event (https://redirect.github.com/puma/puma/issues/2709;>#2709) Bugfixes Loggers - internal_write - catch Errno::EINVAL (https://redirect.github.com/puma/puma/issues/3091;>#3091) commonlogger.rb - fix HIJACK time format, use constants, not strings (https://redirect.github.com/puma/puma/issues/3074;>#3074) Fixed some edge cases regarding request hijacking (https://redirect.github.com/puma/puma/issues/3072;>#3072) 6.1.1 / 2023-02-28 Bugfixes ... (truncated) Commits https://github.com/puma/puma/commit/72bdcd16cd680ab109a9df448b64ab53cb6bfccd;>72bdcd1 6.3.1 https://github.com/puma/puma/commit/ed0f2f94b56982c687452504b95d5f1fbbe3eed1;>ed0f2f9 Merge pull request from GHSA-68xg-gqqm-vgj8 https://github.com/puma/puma/commit/763d1a1a971d9bb17fc1478859d626a539c29970;>763d1a1 6.3.0 (https://redirect.github.com/puma/puma/issues/3169;>#3169) https://github.com/puma/puma/commit/dfd33df8b1c63091cfa56632a45542b75a2920f1;>dfd33df Add dsl method supported_http_methods (https://redirect.github.com/puma/puma/issues/3106;>#3106) https://github.com/puma/puma/commit/a434005e8fb53c80725d113079726ba0474bbe76;>a434005 Puma error responses - remove fingerprints to indicate Puma (https://redirect.github.com/puma/puma/issues/3161;>#3161) https://github.com/puma/puma/commit/7b7774ce67ec171c7ba70327ca2b6ca2f00a44c5;>7b7774c Don't send 103 early hints response when only invalid headers are used (https://redirect.github.com/puma/puma/issues/3163;>#3163) https://github.com/puma/puma/commit/2bb9143c4538f854ad0fd6aaf41aea47df5ee724;>2bb9143 const.rb - Update Puma::HTTP_STATUS_CODES (https://redirect.github.com/puma/puma/issues/3162;>#3162) https://github.com/puma/puma/commit/d244dc7eea842898e06d2a1a8a9c89e039eb5714;>d244dc7 [CI] - Use RubyGems 3.3.26 for Ruby 2.4 thru 2.6 (was 3.3.14) (https://redirect.github.com/puma/puma/issues/3160;>#3160) https://github.com/puma/puma/commit/c467e57f3d21dc3ffe3b8fd01c1d19e455ad721e;>c467e57 [CI] test_redirect_io.rb - fixup for intermittent failures (https://redirect.github.com/puma/puma/issues/3157;>#3157) https://github.com/puma/puma/commit/b61bbc740fd00408f3a70a63d8e477e7fdd06f16;>b61bbc7 [CI] Use ~ for heredocs (https://redirect.github.com/puma/puma/issues/3159;>#3159) Additional commits viewable in https://github.com/puma/puma/compare/v5.6.4...v6.3.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options
[GitHub] [geode] dependabot[bot] closed pull request #7672: Bump puma from 5.3.2 to 5.6.4 in /geode-book
dependabot[bot] closed pull request #7672: Bump puma from 5.3.2 to 5.6.4 in /geode-book URL: https://github.com/apache/geode/pull/7672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] dependabot[bot] commented on pull request #7672: Bump puma from 5.3.2 to 5.6.4 in /geode-book
dependabot[bot] commented on PR #7672: URL: https://github.com/apache/geode/pull/7672#issuecomment-1684624785 Superseded by #7883. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] dependabot[bot] opened a new pull request, #7883: Bump puma from 5.3.2 to 6.3.1 in /geode-book
ed (https://redirect.github.com/puma/puma/issues/3163;>#3163) Handle malformed request path (https://redirect.github.com/puma/puma/issues/3155;>#3155, https://redirect.github.com/puma/puma/issues/3148;>#3148) Misc lib file fixes - trapping additional errors, CI helper (https://redirect.github.com/puma/puma/issues/3129;>#3129) Fixup req form data file upload with r\n line endings (https://redirect.github.com/puma/puma/issues/3137;>#3137) Restore rack 1.6 compatibility (https://redirect.github.com/puma/puma/issues/3156;>#3156) Refactor const.rb - Update Puma::HTTP_STATUS_CODES (https://redirect.github.com/puma/puma/issues/3162;>#3162) Clarify Reactor#initialize (https://redirect.github.com/puma/puma/issues/3151;>#3151) 6.2.2 / 2023-04-17 Bugfixes Fix Rack-related NameError by adding :: operator (https://redirect.github.com/puma/puma/issues/3118;>#3118, https://redirect.github.com/puma/puma/issues/3117;>#3117) 6.2.1 / 2023-03-31 Bugfixes Fix java 8 compatibility (https://redirect.github.com/puma/puma/issues/3109;>#3109, https://redirect.github.com/puma/puma/issues/3108;>#3108) Always write io_buffer when in enum bodies branch. (https://redirect.github.com/puma/puma/issues/3113;>#3113, https://redirect.github.com/puma/puma/issues/3112;>#3112) Fix warn_if_in_single_mode incorrect message (https://redirect.github.com/puma/puma/issues/3111;>#3111) 6.2.0 / 2023-03-29 Features Ability to supply a custom logger (https://redirect.github.com/puma/puma/issues/2770;>#2770, https://redirect.github.com/puma/puma/issues/2511;>#2511) Warn when clustered-only hooks are defined in single mode (https://redirect.github.com/puma/puma/issues/3089;>#3089) Adds the on_booted event (https://redirect.github.com/puma/puma/issues/2709;>#2709) Bugfixes Loggers - internal_write - catch Errno::EINVAL (https://redirect.github.com/puma/puma/issues/3091;>#3091) commonlogger.rb - fix HIJACK time format, use constants, not strings (https://redirect.github.com/puma/puma/issues/3074;>#3074) Fixed some edge cases regarding request hijacking (https://redirect.github.com/puma/puma/issues/3072;>#3072) 6.1.1 / 2023-02-28 Bugfixes ... (truncated) Commits https://github.com/puma/puma/commit/72bdcd16cd680ab109a9df448b64ab53cb6bfccd;>72bdcd1 6.3.1 https://github.com/puma/puma/commit/ed0f2f94b56982c687452504b95d5f1fbbe3eed1;>ed0f2f9 Merge pull request from GHSA-68xg-gqqm-vgj8 https://github.com/puma/puma/commit/763d1a1a971d9bb17fc1478859d626a539c29970;>763d1a1 6.3.0 (https://redirect.github.com/puma/puma/issues/3169;>#3169) https://github.com/puma/puma/commit/dfd33df8b1c63091cfa56632a45542b75a2920f1;>dfd33df Add dsl method supported_http_methods (https://redirect.github.com/puma/puma/issues/3106;>#3106) https://github.com/puma/puma/commit/a434005e8fb53c80725d113079726ba0474bbe76;>a434005 Puma error responses - remove fingerprints to indicate Puma (https://redirect.github.com/puma/puma/issues/3161;>#3161) https://github.com/puma/puma/commit/7b7774ce67ec171c7ba70327ca2b6ca2f00a44c5;>7b7774c Don't send 103 early hints response when only invalid headers are used (https://redirect.github.com/puma/puma/issues/3163;>#3163) https://github.com/puma/puma/commit/2bb9143c4538f854ad0fd6aaf41aea47df5ee724;>2bb9143 const.rb - Update Puma::HTTP_STATUS_CODES (https://redirect.github.com/puma/puma/issues/3162;>#3162) https://github.com/puma/puma/commit/d244dc7eea842898e06d2a1a8a9c89e039eb5714;>d244dc7 [CI] - Use RubyGems 3.3.26 for Ruby 2.4 thru 2.6 (was 3.3.14) (https://redirect.github.com/puma/puma/issues/3160;>#3160) https://github.com/puma/puma/commit/c467e57f3d21dc3ffe3b8fd01c1d19e455ad721e;>c467e57 [CI] test_redirect_io.rb - fixup for intermittent failures (https://redirect.github.com/puma/puma/issues/3157;>#3157) https://github.com/puma/puma/commit/b61bbc740fd00408f3a70a63d8e477e7fdd06f16;>b61bbc7 [CI] Use ~ for heredocs (https://redirect.github.com/puma/puma/issues/3159;>#3159) Additional commits viewable in https://github.com/puma/puma/compare/v5.3.2...v6.3.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options Yo
[GitHub] [geode-native] FlakeSn0w closed pull request #988: CI Test - don't review
FlakeSn0w closed pull request #988: CI Test - don't review URL: https://github.com/apache/geode-native/pull/988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-native] FlakeSn0w opened a new pull request, #988: CI Test - don't review
FlakeSn0w opened a new pull request, #988: URL: https://github.com/apache/geode-native/pull/988 Don't review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] CalvinKirs merged pull request #7869: Fix compile error in jdk11 due to toArray confusion
CalvinKirs merged PR #7869: URL: https://github.com/apache/geode/pull/7869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] CalvinKirs merged pull request #7868: GEODE-10401: Replace 1.15.0 with 1.15.1 as old version
CalvinKirs merged PR #7868: URL: https://github.com/apache/geode/pull/7868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] CalvinKirs merged pull request #7882: GEODE-10447: use getDeclaredConstructor() for supporting JDK11
CalvinKirs merged PR #7882: URL: https://github.com/apache/geode/pull/7882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] jackwener opened a new pull request, #7882: GEODE-10447: improve code for supporting JDK11
jackwener opened a new pull request, #7882: URL: https://github.com/apache/geode/pull/7882 ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] CalvinKirs merged pull request #7881: GEODE-10443: Update shiro-core to version 1.11.0 for CVE-2022-40664
CalvinKirs merged PR #7881: URL: https://github.com/apache/geode/pull/7881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] jackwener commented on pull request #7881: GEODE-10443: Update shiro-core to version 1.11.0 for CVE-2022-40664
jackwener commented on PR #7881: URL: https://github.com/apache/geode/pull/7881#issuecomment-1594763850 PTAL @CalvinKirs , thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] jackwener opened a new pull request, #7881: GEODE-10443: Update shiro-core to version 1.11.0 for CVE-2022-40664
jackwener opened a new pull request, #7881: URL: https://github.com/apache/geode/pull/7881 ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] CalvinKirs merged pull request #7879: GEODE-10446: Capture build scans on ge.apache.org to benefit from deep build insights
CalvinKirs merged PR #7879: URL: https://github.com/apache/geode/pull/7879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] CalvinKirs merged pull request #7880: Minor: correct README.md
CalvinKirs merged PR #7880: URL: https://github.com/apache/geode/pull/7880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] jackwener opened a new pull request, #7880: Minor: correct README.md
jackwener opened a new pull request, #7880: URL: https://github.com/apache/geode/pull/7880 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] clayburn opened a new pull request, #7879: GEODE-10446: Capture build scans on ge.apache.org to benefit from deep build insights
clayburn opened a new pull request, #7879: URL: https://github.com/apache/geode/pull/7879 This PR publishes a build scan for every CI build on Jenkins and GitHub Actions and for every local build from an authenticated Apache committer. The build will not fail if publishing fails. The build scans of the Apache Geode project are published to the Gradle Enterprise instance at [ge.apache.org](https://ge.apache.org/), hosted by the Apache Software Foundation and run in partnership between the ASF and Gradle. This Gradle Enterprise instance has all features and extensions enabled and is freely available for use by the Apache Geode project and all other Apache projects. This pull request enhances the functionality of publishing build scans to the publicly available [scans.gradle.com](https://scans.gradle.com/) by instead publishing build scans to [ge.apache.org](https://ge.apache.org/). On this Gradle Enterprise instance, Apache Geode will have access not only to all of the published build scans but other aggregate data features such as: - Dashboards to view all historical build scans, along with performance trends over time - Build failure analytics for enhanced investigation and diagnosis of build failures - Test failure analytics to better understand trends and causes around slow, failing, and flaky tests If interested in exploring a fully populated Gradle Enterprise instance, please explore the builds already connected to [ge.apache.org](https://ge.apache.org/), the [Spring project’s instance](https://ge.spring.io/scans?search.relativeStartTime=P28D=Europe/Zurich), or any number of other [OSS projects](https://gradle.com/enterprise-customers/oss-projects/) for which we sponsor instances of Gradle Enterprise. Please let me know if there are any questions about the value of Gradle Enterprise or the changes in this pull request and I’d be happy to address them. ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda merged pull request #7877: GEODE-10445: Add wan, cq, lucene, assembly, mgmt distributed tests to pipeline
sboorlagadda merged PR #7877: URL: https://github.com/apache/geode/pull/7877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda commented on a diff in pull request #7877: GEODE-10445: Add wan, cq, lucene, assembly, mgmt distributed tests to pipeline
sboorlagadda commented on code in PR #7877:
URL: https://github.com/apache/geode/pull/7877#discussion_r1167717702
##
.github/workflows/gradle.yml:
##
@@ -223,4 +223,46 @@ jobs:
with:
name: acceptance-test-reports-${{ matrix.os }}-${{ matrix.java }}
path: build/reports
+ retention-days: 5
+
+ distributedTest:
+needs: [apiCheck, unitTest]
+timeout-minutes: 600
Review Comment:
removed the timeout. it doesnt work for non-self hosted (free workers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode-benchmarks] kamilla1201 closed pull request #108: Add --iterations argument to run_tests.sh script
kamilla1201 closed pull request #108: Add --iterations argument to run_tests.sh script URL: https://github.com/apache/geode-benchmarks/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] CalvinKirs commented on a diff in pull request #7877: Draft: Add distributed tests step to GHA pipeline
CalvinKirs commented on code in PR #7877:
URL: https://github.com/apache/geode/pull/7877#discussion_r1154348695
##
.github/workflows/gradle.yml:
##
@@ -223,4 +223,46 @@ jobs:
with:
name: acceptance-test-reports-${{ matrix.os }}-${{ matrix.java }}
path: build/reports
+ retention-days: 5
+
+ distributedTest:
+needs: [apiCheck, unitTest]
+timeout-minutes: 600
Review Comment:
When the test is unstable, even if we set this value to be large, it is not
a good way. It should be kept within a reasonable range of values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [geode] sboorlagadda opened a new pull request, #7878: Draft: Added windows tests to gha pipeline
sboorlagadda opened a new pull request, #7878: URL: https://github.com/apache/geode/pull/7878 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda opened a new pull request, #7877: Draft: Add distributed tests step to GHA pipeline
sboorlagadda opened a new pull request, #7877: URL: https://github.com/apache/geode/pull/7877 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda merged pull request #7876: GEODE-10442: Add acceptanceTest step to GHA pipeline
sboorlagadda merged PR #7876: URL: https://github.com/apache/geode/pull/7876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda commented on pull request #7876: GEODE-10442: Add acceptanceTest step to GHA pipeline
sboorlagadda commented on PR #7876: URL: https://github.com/apache/geode/pull/7876#issuecomment-1487874823 > Looks like AcceptanceTests target cant find a jar, not sure what would cause that to fail in the migration @scmbuildguy What you are referring to? The pipeline failed for downloading a jar but then on a re-run it worked and now it all green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] scmbuildguy commented on pull request #7876: GEODE-10442: Add acceptanceTest step to GHA pipeline
scmbuildguy commented on PR #7876: URL: https://github.com/apache/geode/pull/7876#issuecomment-1487716764 Looks like AcceptanceTests target cant find a jar, not sure what would cause that to fail in the migration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-kafka-connector] dependabot[bot] closed pull request #22: Bump geode-core from 1.12.6 to 1.15.0
dependabot[bot] closed pull request #22: Bump geode-core from 1.12.6 to 1.15.0 URL: https://github.com/apache/geode-kafka-connector/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-kafka-connector] dependabot[bot] commented on pull request #22: Bump geode-core from 1.12.6 to 1.15.0
dependabot[bot] commented on PR #22: URL: https://github.com/apache/geode-kafka-connector/pull/22#issuecomment-1464632091 Superseded by #25. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-kafka-connector] dependabot[bot] opened a new pull request, #25: Bump geode-core from 1.12.6 to 1.15.1
72da0d984a89203a3a3d5746d509d2c2c1409c1;>e72da0d GEODE-10323: Add small changes after review (https://redirect.github.com/apache/geode/issues/7819;>#7819) https://github.com/apache/geode/commit/73aa4b3f72a5f517c9a281d476513a2886743299;>73aa4b3 GEODE-10323: Remove schedule threads in MemoryAllocatorImpl constructor (https://redirect.github.com/apache/geode/issues/7715;>#7715) Additional commits viewable in https://github.com/apache/geode/compare/rel/v1.12.6...rel/v1.15.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/geode-kafka-connector/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda merged pull request #7872: GEODE-10441: Migrate integrationTest to Github Action
sboorlagadda merged PR #7872: URL: https://github.com/apache/geode/pull/7872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda opened a new pull request, #7876: Draft: GHA acceptance tests
sboorlagadda opened a new pull request, #7876: URL: https://github.com/apache/geode/pull/7876 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda merged pull request #7870: GEODE-10434: Migrate to Github action
sboorlagadda merged PR #7870: URL: https://github.com/apache/geode/pull/7870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] CalvinKirs merged pull request #7875: GEODE-10433: remove concourse ci checks
CalvinKirs merged PR #7875: URL: https://github.com/apache/geode/pull/7875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda commented on pull request #7875: GEODE-10433: remove concourse ci checks
sboorlagadda commented on PR #7875: URL: https://github.com/apache/geode/pull/7875#issuecomment-1407461786 Removing concourse and LGTM checks. Will be adding them once we have the pipeline changes merged in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda commented on pull request #7870: GEODE-10434: Migrate to Github action
sboorlagadda commented on PR #7870: URL: https://github.com/apache/geode/pull/7870#issuecomment-1407461125 We have to migrate from concourse-ci to Github actions. i am creating another PR that removes these required checks for timebeing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda opened a new pull request, #7875: GEODE-10433: remove concourse ci checks
sboorlagadda opened a new pull request, #7875: URL: https://github.com/apache/geode/pull/7875 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] CalvinKirs closed pull request #7874: Fix Github not working settings
CalvinKirs closed pull request #7874: Fix Github not working settings URL: https://github.com/apache/geode/pull/7874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] CalvinKirs commented on pull request #7874: Fix Github not working settings
CalvinKirs commented on PR #7874: URL: https://github.com/apache/geode/pull/7874#issuecomment-1407429530 It can't override the previous workflow, I think we may need to seek help from INFRA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] CalvinKirs opened a new pull request, #7874: Fix Github not working settings
CalvinKirs opened a new pull request, #7874: URL: https://github.com/apache/geode/pull/7874 Use the dummy job as the aggregation result of the matrix ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] CalvinKirs commented on pull request #7870: GEODE-10434: Migrate to Github action
CalvinKirs commented on PR #7870: URL: https://github.com/apache/geode/pull/7870#issuecomment-1407290897 I don't know where our [concourse-ci](https://concourse.apachegeode-ci.info/) is deployed. it looks like the concourse-ci service is in an unavailable state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda commented on pull request #7870: GEODE-10434: Migrate to Github action
sboorlagadda commented on PR #7870: URL: https://github.com/apache/geode/pull/7870#issuecomment-1400845651 @rhoughton-pivot It was found that test order sequence was causing few tests to fail. These are related to how those tests are covering code that is setting static final constants which would not be reset. So I need to fix few tests in order for GH actions pipeline to pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda closed pull request #7873: Draft: Add apiCheck step to pipeline
sboorlagadda closed pull request #7873: Draft: Add apiCheck step to pipeline URL: https://github.com/apache/geode/pull/7873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-benchmarks] sboorlagadda merged pull request #170: GEODE-10438: Migrate to GH Actions
sboorlagadda merged PR #170: URL: https://github.com/apache/geode-benchmarks/pull/170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda commented on pull request #7869: Fix compile error in jdk11 due to toArray confusion
sboorlagadda commented on PR #7869: URL: https://github.com/apache/geode/pull/7869#issuecomment-1399628162 Yes. we should start building using JDK 11. But I would prefer we first spin up our pipelines before we make any code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda opened a new pull request, #7873: Draft: Add apiCheck step to pipeline
sboorlagadda opened a new pull request, #7873: URL: https://github.com/apache/geode/pull/7873 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda opened a new pull request, #7872: Draft: GHA integration tests on Ubuntu using Java 8
sboorlagadda opened a new pull request, #7872: URL: https://github.com/apache/geode/pull/7872 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda closed pull request #7871: Draft: Feature/gha1
sboorlagadda closed pull request #7871: Draft: Feature/gha1 URL: https://github.com/apache/geode/pull/7871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] sboorlagadda opened a new pull request, #7871: Draft: Feature/gha1
sboorlagadda opened a new pull request, #7871: URL: https://github.com/apache/geode/pull/7871 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-benchmarks] sboorlagadda commented on pull request #170: GEODE-10438: Migrate to GH Actions
sboorlagadda commented on PR #170: URL: https://github.com/apache/geode-benchmarks/pull/170#issuecomment-1399101806 @scmbuildguy Thanks Mark for checking on this. The build passed now. Would you mind approving this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode-benchmarks] scmbuildguy commented on pull request #170: GEODE-10438: Migrate to GH Actions
scmbuildguy commented on PR #170: URL: https://github.com/apache/geode-benchmarks/pull/170#issuecomment-1398791331 Looks like the build failed in Task :harness:test task with SSH issues. I see the line for the SSH key file changed, most likely related to the test failures? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] kirklund commented on issue #5033: DRAFT: GEODE-8040: Make BootstrappingFunction unit testable
@jdeppe-pivotal do you have any ideas why any changes to BootstrappingFunction causes the Tomcat session tests in UpgradeTest to fail? [ Full content available at: https://github.com/apache/geode/pull/5033 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund commented on pull request #5014: GEODE-8035: Parallel Disk Store Recovery when Cluster Restarts
I recommend replacing ExecutorService with ExecutorServiceRule. You can limit
the rule to a specific number of threads if you need to otherwise it defaults
to as many threads as tasks that you submit:
```
@Rule
public ExecutorServiceRule executorServiceRule = new ExecutorServiceRule();
```
The Rule will automatically do shutdown etc during tearDown().
Also, you might want to capture the `Future` return value from
`executorService/executorServiceRule.submit` to await on. You could even have a
`Collection>` if you wanted.
You could even move the assertions for locking/unlocking into the thread task
(ie what you're submitting). If you await on the Futures, then any assertion
failures will be thrown causing the test to fail:
```
Future doLockUnlock = executorService.submit(() -> {
try {
assertThat(gemFireCacheImpl.doLockDiskStore(diskStoreName)).isTrue();
} finally {
assertThat(gemFireCacheImpl. doUnlockDiskStore(diskStoreName)).isTrue();
}
}
doLockUnlock.get(GeodeAwaitility.getTimeout().toMillis(),
TimeUnit.MILLISECONDS);
```
[ Full content available at: https://github.com/apache/geode/pull/5014 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[GitHub] [geode] bschuchardt commented on issue #5048: GEODE-8020: buffer management problems
> Can we make the new geode property positive by dropping the no and flipping > the default. Good point, and the new property hints that nothing will use direct-buffers. How about this? GeodeGlossary.GEMFIRE_PREFIX + "BufferPool.useHeapBuffers" [ Full content available at: https://github.com/apache/geode/pull/5048 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] alb3rtobr closed pull request #5059: GEODE-7707: Tab completing '--url' on 'connect' gives two default values
[ pull request closed by alb3rtobr ] [ Full content available at: https://github.com/apache/geode/pull/5059 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] alb3rtobr opened pull request #5059: GEODE-7707: Tab completing '--url' on 'connect' gives two default values
with this change, the help is correctly shown when pressing tab after writting `connect --url` in `gfsh` : ``` gfsh>connect --url optional --url: Indicates the base URL to the Manager's HTTP service. For example: 'http://:/geode-mgmt/v1'; default: 'http://localhost:7070/geode-mgmt/v1' ``` I also realized documentation was not showing the correct default value. [ Full content available at: https://github.com/apache/geode/pull/5059 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] gesterzhou closed pull request #5053: GEODE-8072: check the null and stop the on-going query function when …
[ pull request closed by gesterzhou ] [ Full content available at: https://github.com/apache/geode/pull/5053 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-eshu commented on pull request #5055: GEODE-8073: Fix NPE after FetchKeysMessage failed.
Thanks for the explanation. Change has been made. [ Full content available at: https://github.com/apache/geode/pull/5055 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-eshu commented on pull request #5055: GEODE-8073: Fix NPE after FetchKeysMessage failed.
Is that a particular reason set should not be mocked? It is not being iterated through, just used as a placeholder. I would like to know the reason for the requested change so that I may gain some new knowledge. [ Full content available at: https://github.com/apache/geode/pull/5055 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] pivotal-eshu opened pull request #5055: GEODE-8073: Fix NPE after FetchKeysMessage failed.
[ Full content available at: https://github.com/apache/geode/pull/5055 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] metatype commented on pull request #5018: GEODE-8039: update incorrect versions in LICENSE
Nice work! Thanks for filling in the gaps in my memory :-) [ Full content available at: https://github.com/apache/geode/pull/5018 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] prettyClouds commented on pull request #5036: GEODE-8058: Update implementation of EXPIRE, PEXPIRE, EXPIREAT, and PEXPIREAT to be HA
why do we need to check the internal state in the integration test? everything else operates at the external, `jedis` level. [ Full content available at: https://github.com/apache/geode/pull/5036 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] prettyClouds commented on pull request #5036: GEODE-8058: Update implementation of EXPIRE, PEXPIRE, EXPIREAT, and PEXPIREAT to be HA
this is the same as the one above except for the extra. Can we combine them, or have mutually exclusive asserts? [ Full content available at: https://github.com/apache/geode/pull/5036 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] alb3rtobr commented on pull request #4978: GEODE-8004: Fix for regression introduced by GEODE-7565
done [ Full content available at: https://github.com/apache/geode/pull/4978 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jujoramos commented on pull request #4978: GEODE-8004: Fix for regression introduced by GEODE-7565
Not a new method but significantly changed, it should be, at leat, unit tested. You can make it package private, annotate it with `@VisibleForTesting` and access it directly from `LocatorLoadSnapshotJUnitTest` and/or `LocatorLoadSnapshotIntegrationTest`. [ Full content available at: https://github.com/apache/geode/pull/4978 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund opened pull request #5051: DRAFT: GEODE-7739: Prevent skipped JMX federation and notifications
[ Full content available at: https://github.com/apache/geode/pull/5051 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #5018: GEODE-8039: update incorrect versions in LICENSE
The only reference to polyfill, which I tracked down from the email thread you shared, is in https://github.com/apache/geode-site/blob/master/website/content/js/respond.min.js Since we don't distribute geode-site in source form as part of Geode releases, do we still need it in the Geode LICENSE? [ Full content available at: https://github.com/apache/geode/pull/5018 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] gesterzhou commented on pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.
I don't know what the code change here caused the test PartitionedRegionClearWithExpirationDUnitTest to take 72 minutes to finish, while it took 17 minutes(still quite long) in GEODE-7665 branch [ Full content available at: https://github.com/apache/geode/pull/4987 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] metatype commented on pull request #5018: GEODE-8039: update incorrect versions in LICENSE
This should stay, see above. [ Full content available at: https://github.com/apache/geode/pull/5018 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] metatype commented on pull request #5018: GEODE-8039: update incorrect versions in LICENSE
Something seems wrong that we are bundling both activation and Java.activation. Can you file a JIRA for followup? [ Full content available at: https://github.com/apache/geode/pull/5018 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jdeppe-pivotal opened pull request #5042: GEODE-8036: Do not block Netty threads when publishing
- Now delegate PUBLISH responses to a background executor in order to free up the Netty worker thread. This prevents possible deadlocks. Co-authored-by: Murtuza Boxwala Co-authored-by: Ray Ingles Co-authored-by: Jens Deppe Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. [ Full content available at: https://github.com/apache/geode/pull/5042 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] DonalEvans commented on pull request #4987: GEODE-7678: Support for cache-listener and client-notification for Partitioned Region Clear operation.
@agingade I see. So this timeout is kind of unique to this step in the clear operation and so isn't needed/tracked anywhere else. [ Full content available at: https://github.com/apache/geode/pull/4987 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode-native] pivotal-jbarrett opened pull request #598: GEODE-8062: Disables flaky and omitted tests.
Use test DISABLED property to avoid accidental execution. [ Full content available at: https://github.com/apache/geode-native/pull/598 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jujoramos commented on pull request #5037: GEODE-8029: Delete orphaned drf files
Sounds good. [ Full content available at: https://github.com/apache/geode/pull/5037 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jujoramos commented on pull request #5037: GEODE-8029: Delete orphaned drf files
[ Full content available at: https://github.com/apache/geode/pull/5037 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jujoramos commented on pull request #5037: GEODE-8029: Delete orphaned drf files
It's irrelevant for this scenario, we're interested only in the `disk-stores` locally used by the servers. [ Full content available at: https://github.com/apache/geode/pull/5037 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jchen21 commented on pull request #5014: GEODE-8035: Parallel Disk Store Recovery when Cluster Restarts
I am not sure which exception you are talking about. I don't see `parallelStream()` and `forEach()` introduce new exception, based on the Javadoc. For test coverage, there are quite a few existing tests that already cover the single thread or multiple disk stores cases. We don't have to add new tests for that. For multi-thread test, it is a very tricky one. The purpose of this pull request is to introduce parallel disk recovery and improve the performance. We can assert that the stream should be parallel using `isParallel()`. Or we can scan the logs and make sure there are multiple thread IDs that recover the disk stores. But it doesn't serve the purpose of testing performance improvement. It doesn't guarantee that disk recovery is parallel, even if we can assert that the stream is parallel or there are multiple threads that recover the disk store. For example, if we keep the synchronized block in `DiskStoreFactoryImple` line 147, the disk stores recovery will be sequential, even though there are multiple threads recovering the disk stores. [ Full content available at: https://github.com/apache/geode/pull/5014 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
