[jira] [Created] (GROOVY-8847) TryCatchStatement - adding constructor with List parameter
Anton Pryamostanov created GROOVY-8847:
--
Summary: TryCatchStatement - adding constructor with
List parameter
Key: GROOVY-8847
URL: https://issues.apache.org/jira/browse/GROOVY-8847
Project: Groovy
Issue Type: Improvement
Affects Versions: 2.5.2
Reporter: Anton Pryamostanov
Currently TryCatchStatement only has 1 constructor:
{code}
public TryCatchStatement(Statement tryStatement, Statement
finallyStatement) {
this.tryStatement = tryStatement;
this.finallyStatement = finallyStatement;
}
{code}
As per existing practice for other Statements and Expressions, suggest to add
the missing constructor:
{code}
public TryCatchStatement(Statement tryStatement, Statement
finallyStatement, List catchStatements) {
this.tryStatement = tryStatement;
this.finallyStatement = finallyStatement;
this.catchStatements = catchStatements;
}
{code}
This will make initialization easier.
Note: GeneralUtils does not have helper method for TryCatchStatement.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GROOVY-8842) Implement a smart highlighter for groovy console editor
[
https://issues.apache.org/jira/browse/GROOVY-8842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Sun updated GROOVY-8842:
---
Description:
Implement a source code highlighter based on Parrot's lexer, the new
highlighter should be smarter. e.g.
It can show different colors in GString `"abc${'123' + 123}def${a + b}"`
The new highlighter is enabled by default.
Check the checkbox "Enable smart highlighter" in "View" menu to enable/disable
the new highlighter.
was:
Implement a source code highlighter based on Parrot's lexer, the new
highlighter should be smarter. e.g.
It can show different colors in GString `"abc${'123' + 123}def${a + b}"`
P.S. Currently the new highlighter will render almost all source code for each
editing(lexer's scanning is very fast, but rendering is very slow, i.e.
{{styledDocument.setCharacterAttributes}} has performance issue), so it is NOT
recommended to be enable for large source code for the time being.
The new highlighter is NOT enabled by default. Check the checkbox "Enable
smart highlighter" in "View" menu to enable the new highlighter
> Implement a smart highlighter for groovy console editor
> ---
>
> Key: GROOVY-8842
> URL: https://issues.apache.org/jira/browse/GROOVY-8842
> Project: Groovy
> Issue Type: New Feature
>Reporter: Daniel Sun
>Assignee: Daniel Sun
>Priority: Major
> Fix For: 3.0.0-alpha-4
>
>
> Implement a source code highlighter based on Parrot's lexer, the new
> highlighter should be smarter. e.g.
> It can show different colors in GString `"abc${'123' + 123}def${a + b}"`
> The new highlighter is enabled by default.
> Check the checkbox "Enable smart highlighter" in "View" menu to
> enable/disable the new highlighter.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (GROOVY-8848) Named parameters documentation missing explanation for mixing multiple parameters use case
Szymon Stępniak created GROOVY-8848: --- Summary: Named parameters documentation missing explanation for mixing multiple parameters use case Key: GROOVY-8848 URL: https://issues.apache.org/jira/browse/GROOVY-8848 Project: Groovy Issue Type: Documentation Components: Documentation Affects Versions: 2.5.3, 3.0.0-alpha-3 Reporter: Szymon Stępniak It looks like current documentation page that explains named parameters is missing information about what happens when we start mixing named parameters with additional parameters. Current documentation - http://docs.groovy-lang.org/latest/html/documentation/#_named_arguments This problem was reported on Stack Overflow - https://stackoverflow.com/questions/52832382/omiting-brackets-for-named-arguments-inverts-order/52834346#52834346 Please assign this task to me - I will prepare a pull request with documentation update in a few hours. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] groovy pull request #812: GROOVY-8848: Named parameters documentation missin...
GitHub user wololock opened a pull request: https://github.com/apache/groovy/pull/812 GROOVY-8848: Named parameters documentation missing explanation for mixing multiple parameters use case This pull request fixes https://issues.apache.org/jira/browse/GROOVY-8848 The problem explained in updated documentation "Named arguments" section was reported on Stack Overflow today - https://stackoverflow.com/q/52832382/2194470 You can merge this pull request into a Git repository by running: $ git pull https://github.com/wololock/groovy GROOVY-8848 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/812.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #812 commit 322275d5b1db27cfae59d6b1c4744c5e33432753 Author: Szymon Stepniak Date: 2018-10-16T22:03:48Z GROOVY-8848: added mixing named arguments with other arguments use case explanation to the documentation ---
[jira] [Commented] (GROOVY-8848) Named parameters documentation missing explanation for mixing multiple parameters use case
[ https://issues.apache.org/jira/browse/GROOVY-8848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652525#comment-16652525 ] ASF GitHub Bot commented on GROOVY-8848: GitHub user wololock opened a pull request: https://github.com/apache/groovy/pull/812 GROOVY-8848: Named parameters documentation missing explanation for mixing multiple parameters use case This pull request fixes https://issues.apache.org/jira/browse/GROOVY-8848 The problem explained in updated documentation "Named arguments" section was reported on Stack Overflow today - https://stackoverflow.com/q/52832382/2194470 You can merge this pull request into a Git repository by running: $ git pull https://github.com/wololock/groovy GROOVY-8848 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/812.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #812 commit 322275d5b1db27cfae59d6b1c4744c5e33432753 Author: Szymon Stepniak Date: 2018-10-16T22:03:48Z GROOVY-8848: added mixing named arguments with other arguments use case explanation to the documentation > Named parameters documentation missing explanation for mixing multiple > parameters use case > -- > > Key: GROOVY-8848 > URL: https://issues.apache.org/jira/browse/GROOVY-8848 > Project: Groovy > Issue Type: Documentation > Components: Documentation >Affects Versions: 3.0.0-alpha-3, 2.5.3 >Reporter: Szymon Stępniak >Priority: Minor > > It looks like current documentation page that explains named parameters is > missing information about what happens when we start mixing named parameters > with additional parameters. > Current documentation - > http://docs.groovy-lang.org/latest/html/documentation/#_named_arguments > This problem was reported on Stack Overflow - > https://stackoverflow.com/questions/52832382/omiting-brackets-for-named-arguments-inverts-order/52834346#52834346 > Please assign this task to me - I will prepare a pull request with > documentation update in a few hours. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GROOVY-8848) Named parameters documentation missing explanation for mixing multiple parameters use case
[ https://issues.apache.org/jira/browse/GROOVY-8848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652526#comment-16652526 ] Szymon Stępniak commented on GROOVY-8848: - Pull request ready to review - https://github.com/apache/groovy/pull/812 > Named parameters documentation missing explanation for mixing multiple > parameters use case > -- > > Key: GROOVY-8848 > URL: https://issues.apache.org/jira/browse/GROOVY-8848 > Project: Groovy > Issue Type: Documentation > Components: Documentation >Affects Versions: 3.0.0-alpha-3, 2.5.3 >Reporter: Szymon Stępniak >Priority: Minor > > It looks like current documentation page that explains named parameters is > missing information about what happens when we start mixing named parameters > with additional parameters. > Current documentation - > http://docs.groovy-lang.org/latest/html/documentation/#_named_arguments > This problem was reported on Stack Overflow - > https://stackoverflow.com/questions/52832382/omiting-brackets-for-named-arguments-inverts-order/52834346#52834346 > Please assign this task to me - I will prepare a pull request with > documentation update in a few hours. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (GROOVY-8848) Named parameters documentation missing explanation for mixing multiple parameters use case
[ https://issues.apache.org/jira/browse/GROOVY-8848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King reassigned GROOVY-8848: - Assignee: Paul King > Named parameters documentation missing explanation for mixing multiple > parameters use case > -- > > Key: GROOVY-8848 > URL: https://issues.apache.org/jira/browse/GROOVY-8848 > Project: Groovy > Issue Type: Documentation > Components: Documentation >Affects Versions: 3.0.0-alpha-3, 2.5.3 >Reporter: Szymon Stępniak >Assignee: Paul King >Priority: Minor > > It looks like current documentation page that explains named parameters is > missing information about what happens when we start mixing named parameters > with additional parameters. > Current documentation - > http://docs.groovy-lang.org/latest/html/documentation/#_named_arguments > This problem was reported on Stack Overflow - > https://stackoverflow.com/questions/52832382/omiting-brackets-for-named-arguments-inverts-order/52834346#52834346 > Please assign this task to me - I will prepare a pull request with > documentation update in a few hours. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GROOVY-8848) Named parameters documentation missing explanation for mixing multiple parameters use case
[ https://issues.apache.org/jira/browse/GROOVY-8848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652898#comment-16652898 ] ASF GitHub Bot commented on GROOVY-8848: Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/812 > Named parameters documentation missing explanation for mixing multiple > parameters use case > -- > > Key: GROOVY-8848 > URL: https://issues.apache.org/jira/browse/GROOVY-8848 > Project: Groovy > Issue Type: Documentation > Components: Documentation >Affects Versions: 3.0.0-alpha-3, 2.5.3 >Reporter: Szymon Stępniak >Assignee: Paul King >Priority: Minor > > It looks like current documentation page that explains named parameters is > missing information about what happens when we start mixing named parameters > with additional parameters. > Current documentation - > http://docs.groovy-lang.org/latest/html/documentation/#_named_arguments > This problem was reported on Stack Overflow - > https://stackoverflow.com/questions/52832382/omiting-brackets-for-named-arguments-inverts-order/52834346#52834346 > Please assign this task to me - I will prepare a pull request with > documentation update in a few hours. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] groovy pull request #812: GROOVY-8848: Named parameters documentation missin...
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/812 ---
[jira] [Resolved] (GROOVY-8848) Named parameters documentation missing explanation for mixing multiple parameters use case
[ https://issues.apache.org/jira/browse/GROOVY-8848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-8848. --- Resolution: Fixed Fix Version/s: 2.5.4 3.0.0-alpha-4 Proposed PR merged, thanks! > Named parameters documentation missing explanation for mixing multiple > parameters use case > -- > > Key: GROOVY-8848 > URL: https://issues.apache.org/jira/browse/GROOVY-8848 > Project: Groovy > Issue Type: Documentation > Components: Documentation >Affects Versions: 3.0.0-alpha-3, 2.5.3 >Reporter: Szymon Stępniak >Assignee: Paul King >Priority: Minor > Fix For: 3.0.0-alpha-4, 2.5.4 > > > It looks like current documentation page that explains named parameters is > missing information about what happens when we start mixing named parameters > with additional parameters. > Current documentation - > http://docs.groovy-lang.org/latest/html/documentation/#_named_arguments > This problem was reported on Stack Overflow - > https://stackoverflow.com/questions/52832382/omiting-brackets-for-named-arguments-inverts-order/52834346#52834346 > Please assign this task to me - I will prepare a pull request with > documentation update in a few hours. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
