[jira] [Created] (GROOVY-9033) Bad code green: empty list literal with each method

2019-03-13 Thread Daniil Ovchinnikov (JIRA)
Daniil Ovchinnikov created GROOVY-9033:
--

 Summary: Bad code green: empty list literal with each method
 Key: GROOVY-9033
 URL: https://issues.apache.org/jira/browse/GROOVY-9033
 Project: Groovy
  Issue Type: Bug
  Components: Static Type Checker
Reporter: Daniil Ovchinnikov


{code:java}
@groovy.transform.CompileStatic
List usage() {
  def l = [].each {}
  return l // expected error: Incompatible generic argument types. Cannot 
assign java.util.List  to: java.util.List  
}

println usage(){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GROOVY-9033) Bad code green: empty list literal with each method

2019-03-13 Thread Daniil Ovchinnikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-9033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniil Ovchinnikov updated GROOVY-9033:
---
Description: 
{code:groovy}
@groovy.transform.CompileStatic
List usage() {
  def l = [].each {}
  return l // expected error: Incompatible generic argument types. Cannot 
assign java.util.List  to: java.util.List  
}{code}

  was:
{code:java}
@groovy.transform.CompileStatic
List usage() {
  def l = [].each {}
  return l // expected error: Incompatible generic argument types. Cannot 
assign java.util.List  to: java.util.List  
}

println usage(){code}


> Bad code green: empty list literal with each method
> ---
>
> Key: GROOVY-9033
> URL: https://issues.apache.org/jira/browse/GROOVY-9033
> Project: Groovy
>  Issue Type: Bug
>  Components: Static Type Checker
>Affects Versions: 2.5.6
>Reporter: Daniil Ovchinnikov
>Priority: Major
>
> {code:groovy}
> @groovy.transform.CompileStatic
> List usage() {
>   def l = [].each {}
>   return l // expected error: Incompatible generic argument types. Cannot 
> assign java.util.List  to: java.util.List  
> }{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GROOVY-9033) Bad code green: empty list literal with each method

2019-03-13 Thread Daniil Ovchinnikov (JIRA)


 [ 
https://issues.apache.org/jira/browse/GROOVY-9033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniil Ovchinnikov updated GROOVY-9033:
---
Affects Version/s: 2.5.6

> Bad code green: empty list literal with each method
> ---
>
> Key: GROOVY-9033
> URL: https://issues.apache.org/jira/browse/GROOVY-9033
> Project: Groovy
>  Issue Type: Bug
>  Components: Static Type Checker
>Affects Versions: 2.5.6
>Reporter: Daniil Ovchinnikov
>Priority: Major
>
> {code:java}
> @groovy.transform.CompileStatic
> List usage() {
>   def l = [].each {}
>   return l // expected error: Incompatible generic argument types. Cannot 
> assign java.util.List  to: java.util.List  
> }
> println usage(){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [groovy] asfgit closed pull request #897: Update the link to bronze sponsor picture

2019-03-13 Thread GitBox
asfgit closed pull request #897: Update the link to bronze sponsor picture
URL: https://github.com/apache/groovy/pull/897
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [groovy] calid commented on issue #896: GROOVY-9018: fix shellcheck warnings for bin scripts

2019-03-13 Thread GitBox
calid commented on issue #896: GROOVY-9018: fix shellcheck warnings for bin 
scripts
URL: https://github.com/apache/groovy/pull/896#issuecomment-472418334
 
 
   ok sounds good, updated the PR accordingly


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [groovy] paulk-asert edited a comment on issue #891: GROOVY-9022: Added option under View menu of whether or not to have v…

2019-03-13 Thread GitBox
paulk-asert edited a comment on issue #891: GROOVY-9022: Added option under 
View menu of whether or not to have v…
URL: https://github.com/apache/groovy/pull/891#issuecomment-472398819
 
 
   Here is what I get when switching vert/horiz while detached (but not always):
   
   ![2019-03-13 
22_16_44-GroovyConsoleGlitch2](https://user-images.githubusercontent.com/280016/54278394-f4e13680-45dd-11e9-9e67-20735732a160.png)
   ![2019-03-13 
22_14_01-GroovyConsoleGlitch1](https://user-images.githubusercontent.com/280016/54278400-f90d5400-45dd-11e9-83d5-2bd1bea8cc0a.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [groovy] paulk-asert commented on issue #891: GROOVY-9022: Added option under View menu of whether or not to have v…

2019-03-13 Thread GitBox
paulk-asert commented on issue #891: GROOVY-9022: Added option under View menu 
of whether or not to have v…
URL: https://github.com/apache/groovy/pull/891#issuecomment-472398819
 
 
   ![2019-03-13 
22_16_44-GroovyConsoleGlitch2](https://user-images.githubusercontent.com/280016/54278394-f4e13680-45dd-11e9-9e67-20735732a160.png)
   ![2019-03-13 
22_14_01-GroovyConsoleGlitch1](https://user-images.githubusercontent.com/280016/54278400-f90d5400-45dd-11e9-83d5-2bd1bea8cc0a.png)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [groovy] paulk-asert commented on a change in pull request #891: GROOVY-9022: Added option under View menu of whether or not to have v…

2019-03-13 Thread GitBox
paulk-asert commented on a change in pull request #891: GROOVY-9022: Added 
option under View menu of whether or not to have v…
URL: https://github.com/apache/groovy/pull/891#discussion_r265098216
 
 

 ##
 File path: subprojects/groovy-console/src/main/groovy/groovy/ui/Console.groovy
 ##
 @@ -638,11 +638,10 @@ class Console implements CaretListener, 
HyperlinkListener, ComponentListener, Fo
 if (oldValue != orientationVertical) {
 if (orientationVertical) {
 splitPane.setOrientation(JSplitPane.VERTICAL_SPLIT)
-splitPane.resizeWeight = 0.5
 } else {
 splitPane.setOrientation(JSplitPane.HORIZONTAL_SPLIT)
-splitPane.resizeWeight = 0.5
 }
+splitPane.resizeWeight = detachedOutput ? 1.0 : 0.5
 
 Review comment:
   still didn't seem to work for me
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [groovy] adamldavis commented on issue #891: GROOVY-9022: Added option under View menu of whether or not to have v…

2019-03-13 Thread GitBox
adamldavis commented on issue #891: GROOVY-9022: Added option under View menu 
of whether or not to have v…
URL: https://github.com/apache/groovy/pull/891#issuecomment-472384119
 
 
   Sure I can fix that


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services