[GitHub] [groovy] danielsun1106 commented on issue #906: GROOVY-9073: added compiler option to enable preview features (JEP 12)
danielsun1106 commented on issue #906: GROOVY-9073: added compiler option to enable preview features (JEP 12) URL: https://github.com/apache/groovy/pull/906#issuecomment-482778104 Make some changes and push, which will trigger the CI build, at last we can see the build result. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [groovy] keeganwitt commented on issue #906: GROOVY-9073: added compiler option to enable preview features (JEP 12)
keeganwitt commented on issue #906: GROOVY-9073: added compiler option to enable preview features (JEP 12) URL: https://github.com/apache/groovy/pull/906#issuecomment-482777613 I'm not sure why checks were failing. It'd be kinda nice to have some tests for it too, but I'm not sure how best to do that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (GROOVY-9080) MarkupTemplateEngine uses invalid XML entity for escaping double quotes
[
https://issues.apache.org/jira/browse/GROOVY-9080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816660#comment-16816660
]
Dan Ziemba commented on GROOVY-9080:
Looks like all that is needed is to fix the
'groovy.text.markup.BaseTemplate#escapeQuotes' method.
> MarkupTemplateEngine uses invalid XML entity for escaping double quotes
> ---
>
> Key: GROOVY-9080
> URL: https://issues.apache.org/jira/browse/GROOVY-9080
> Project: Groovy
> Issue Type: Bug
> Components: Templating
>Affects Versions: 3.0.0-alpha-4, 2.5.6
>Reporter: Dan Ziemba
>Priority: Major
>
> When MarkupTemplateEngine is used with 'useDoubleQuotes' config enabled,
> incorrect output is produced.
> Given this example code:
> {code:java}
> import groovy.text.markup.*
> def out = new MarkupTemplateEngine(new TemplateConfiguration(useDoubleQuotes:
> true))
> .createTemplate('''tag(attr: 'contains " quote')''')
> .make()
> println out
> {code}
> Result is:
> {{}}
> But expected result is:
> {{}}
> The wrong XML entity is used - is not valid.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (GROOVY-9080) MarkupTemplateEngine uses invalid XML entity for escaping double quotes
Dan Ziemba created GROOVY-9080:
--
Summary: MarkupTemplateEngine uses invalid XML entity for escaping
double quotes
Key: GROOVY-9080
URL: https://issues.apache.org/jira/browse/GROOVY-9080
Project: Groovy
Issue Type: Bug
Components: Templating
Affects Versions: 2.5.6, 3.0.0-alpha-4
Reporter: Dan Ziemba
When MarkupTemplateEngine is used with 'useDoubleQuotes' config enabled,
incorrect output is produced.
Given this example code:
{code:java}
import groovy.text.markup.*
def out = new MarkupTemplateEngine(new TemplateConfiguration(useDoubleQuotes:
true))
.createTemplate('''tag(attr: 'contains " quote')''')
.make()
println out
{code}
Result is:
{{}}
But expected result is:
{{}}
The wrong XML entity is used - is not valid.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [groovy] danielsun1106 opened a new pull request #909: Add the missing delegate methods to `InnerLoader`
danielsun1106 opened a new pull request #909: Add the missing delegate methods to `InnerLoader` URL: https://github.com/apache/groovy/pull/909 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [groovy] danielsun1106 commented on issue #906: GROOVY-9073: added compiler option to enable preview features (JEP 12)
danielsun1106 commented on issue #906: GROOVY-9073: added compiler option to enable preview features (JEP 12) URL: https://github.com/apache/groovy/pull/906#issuecomment-482651668 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API
danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482642708 @blackdrag As far as I know, `javax.tools.JavaCompiler` is a normal official API and will not stop working suddenly, isn't it? :wink: https://docs.oracle.com/javase/7/docs/api/javax/tools/JavaCompiler.html This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [groovy] danielsun1106 edited a comment on issue #904: GROOVY-9067: Compile Java stubs with standard API
danielsun1106 edited a comment on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482640324 @blackdrag Jochen, in-memory compilation is still supported, but in-file compilation is changed to rely on the same normal official API, e.g. `javax.tools.JavaCompiler`. As a result, we can compile all source code in the same way and it will be easier for us to maintain. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API
danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482640324 @blackdrag Jochen, in-memory compilation is still supported, but in-file compilation is changed to rely on the same API, e.g. `javax.tools.JavaCompiler`. As a result, we can compile all source code in the same way and it will be easier for us to maintain. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [groovy] blackdrag commented on issue #904: GROOVY-9067: Compile Java stubs with standard API
blackdrag commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482637564 you are doing more than undoing the change for the in-memory compilation? In general I am partial to in-memory compilation, but it must be done using the normal official API or else it will stop working at one point. Is that not possible? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API
danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482633625 @paulk-asert @blackdrag Please set aside some time to review the PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (GROOVY-9076) Debugger Step Into doesn't work in Groovy-compiled classes
[
https://issues.apache.org/jira/browse/GROOVY-9076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniil Ovchinnikov updated GROOVY-9076:
---
Description:
Please see https://github.com/dovchinnikov/debug-groovy-bug
{code:title=GC.groovy}
package foo.bar
class GC {
GC() {
int i = 42
}
int getStuff() {
return 70
}
}
{code}
{code:title=GMain.groovy}
package foo.bar
class GMain {
static void main(String[] args) {
new GC().stuff // set breakpoint here
}
}
{code}
was:
Please see https://github.com/dovchinnikov/debug-groovy-bug
> Debugger Step Into doesn't work in Groovy-compiled classes
> --
>
> Key: GROOVY-9076
> URL: https://issues.apache.org/jira/browse/GROOVY-9076
> Project: Groovy
> Issue Type: Bug
>Affects Versions: 2.5.6
>Reporter: Daniil Ovchinnikov
>Priority: Blocker
>
> Please see https://github.com/dovchinnikov/debug-groovy-bug
> {code:title=GC.groovy}
> package foo.bar
> class GC {
> GC() {
> int i = 42
> }
> int getStuff() {
> return 70
> }
> }
> {code}
> {code:title=GMain.groovy}
> package foo.bar
> class GMain {
> static void main(String[] args) {
> new GC().stuff // set breakpoint here
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
