[GitHub] [groovy] xsj24 closed pull request #1845: Tweak StringGroovyMethods
xsj24 closed pull request #1845: Tweak StringGroovyMethods URL: https://github.com/apache/groovy/pull/1845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1846: GROOVY-10905: Improve matching no-arg closures to SAM types
paulk-asert merged PR #1846: URL: https://github.com/apache/groovy/pull/1846 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1845: Tweak StringGroovyMethods
codecov-commenter commented on PR #1845: URL: https://github.com/apache/groovy/pull/1845#issuecomment-1383135076 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1845?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1845](https://codecov.io/gh/apache/groovy/pull/1845?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cadc5a4) into [master](https://codecov.io/gh/apache/groovy/commit/1334242e2ecc1fe4b9b4a3821a1324805c0112ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1334242) will **increase** coverage by `0.0036%`. > The diff coverage is `100.%`. [](https://codecov.io/gh/apache/groovy/pull/1845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1845+/- ## == + Coverage 67.9942% 67.9978% +0.0036% - Complexity 28535 28537 +2 == Files1427 1427 Lines 112889 112889 Branches19284 19284 == + Hits76758 76762 +4 + Misses 29637 29635 -2 + Partials 6494 6492 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...g/codehaus/groovy/runtime/StringGroovyMethods.java](https://codecov.io/gh/apache/groovy/pull/1845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvU3RyaW5nR3Jvb3Z5TWV0aG9kcy5qYXZh) | `84.5528% <100.%> (ø)` | | | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1845?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `45.6522% <0.%> (+0.7905%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] xsj24 opened a new pull request, #1845: Tweak StringGroovyMethods
xsj24 opened a new pull request, #1845: URL: https://github.com/apache/groovy/pull/1845 Group zero is not included in the result of the groupCount method. Set the correct initial capacity -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1844: Replace usages of `path.toFile().exists()` in `NioExtensions` with `Files#exists`
paulk-asert commented on PR #1844: URL: https://github.com/apache/groovy/pull/1844#issuecomment-1382702376 I don't know whether the original code was chosen to avoid the exception being thrown when using the NIO method (for the not exists case) but it shouldn't be too much of a drama. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun commented on pull request #1844: Replace usages of `path.toFile().exists()` in `NioExtensions` with `Files#exists`
daniellansun commented on PR #1844: URL: https://github.com/apache/groovy/pull/1844#issuecomment-1382693991 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1844: Replace usages of `path.toFile().exists()` in `NioExtensions` with `Files#exists`
daniellansun merged PR #1844: URL: https://github.com/apache/groovy/pull/1844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1844: Replace usages of `path.toFile().exists()` in `NioExtensions` with `Files#exists`
codecov-commenter commented on PR #1844: URL: https://github.com/apache/groovy/pull/1844#issuecomment-1382677553 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1844?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1844](https://codecov.io/gh/apache/groovy/pull/1844?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f5f49f) into [master](https://codecov.io/gh/apache/groovy/commit/0961a6981700e7a366d400819b340c8f8920309e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0961a69) will **increase** coverage by `0.0009%`. > The diff coverage is `0.%`. [](https://codecov.io/gh/apache/groovy/pull/1844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1844+/- ## == + Coverage 67.9978% 67.9986% +0.0009% + Complexity 28537 28534 -3 == Files1427 1427 Lines 112889 112889 Branches19284 19284 == + Hits76762 76763 +1 + Misses 29635 29634 -1 Partials 6492 6492 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rg/apache/groovy/nio/extensions/NioExtensions.java](https://codecov.io/gh/apache/groovy/pull/1844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LW5pby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ3Jvb3Z5L25pby9leHRlbnNpb25zL05pb0V4dGVuc2lvbnMuamF2YQ==) | `36.9186% <0.%> (ø)` | | | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `44.8617% <0.%> (-0.7905%)` | :arrow_down: | | [...vy/util/concurrent/ConcurrentReferenceHashMap.java](https://codecov.io/gh/apache/groovy/pull/1844?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvQ29uY3VycmVudFJlZmVyZW5jZUhhc2hNYXAuamF2YQ==) | `36.0738% <0.%> (+0.8389%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] Matyrobbrt opened a new pull request, #1844: Replace usages of `path.toFile().exists()` in `NioExtensions` with `Files#exists`
Matyrobbrt opened a new pull request, #1844: URL: https://github.com/apache/groovy/pull/1844 This PR replaces the different usages of `Path#toFile` in `NioExtensions` with the equivalent methods in the NIO API (`Files`). This change is done because there is no guarantee a `Path` can always be converted to a `File`, even if you can open a stream to it: > Throws: UnsupportedOperationException – if this Path is not associated with the default provider -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] Matyrobbrt opened a new pull request, #1843: Add `asBoolean` extension methods to `File` and `Path`
Matyrobbrt opened a new pull request, #1843: URL: https://github.com/apache/groovy/pull/1843 This PR adds `asBoolean` extension methods to `Path` and `File` in order to allow Groovy Truth usage. I have also added an `exists(LinkOption...)` extension method in `NioExtensions` but I can remove it if it is too out-of-scope for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun commented on pull request #1841: Fix JMH Benchmarks
daniellansun commented on PR #1841: URL: https://github.com/apache/groovy/pull/1841#issuecomment-1380855302 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1841: Fix JMH Benchmarks
daniellansun merged PR #1841: URL: https://github.com/apache/groovy/pull/1841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun commented on pull request #1837: Add source dependency on task to fix task cacheability
daniellansun commented on PR #1837: URL: https://github.com/apache/groovy/pull/1837#issuecomment-1380800056 The build is still failing: https://github.com/apache/groovy/actions/runs/3886703609/jobs/6634225416#step:6:569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1842: GROOVY-10898: Provide tail/init for primitive arrays
paulk-asert merged PR #1842: URL: https://github.com/apache/groovy/pull/1842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] runningcode commented on pull request #1837: Add source dependency on task to fix task cacheability
runningcode commented on PR #1837: URL: https://github.com/apache/groovy/pull/1837#issuecomment-1377762884 Thanks, do you mean that the build in general is failing? Or that this PR caused this failure? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1842: GROOVY-10898: Provide tail/init for primitive arrays
codecov-commenter commented on PR #1842: URL: https://github.com/apache/groovy/pull/1842#issuecomment-1374828179 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1842?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1842](https://codecov.io/gh/apache/groovy/pull/1842?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (81ed389) into [master](https://codecov.io/gh/apache/groovy/commit/8f80995b4a116ca65ca1536df8f7f65abc08dac6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f80995) will **decrease** coverage by `0.0173%`. > The diff coverage is `33.%`. [](https://codecov.io/gh/apache/groovy/pull/1842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1842+/- ## == - Coverage 67.7474% 67.7300% -0.0173% - Complexity 28300 28316+16 == Files1427 1427 Lines 112611 112659+48 Branches19302 19302 == + Hits76291 76304+13 - Misses 29795 29812+17 - Partials 6525 6543+18 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...rg/codehaus/groovy/runtime/ArrayGroovyMethods.java](https://codecov.io/gh/apache/groovy/pull/1842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvQXJyYXlHcm9vdnlNZXRob2RzLmphdmE=) | `51.8625% <33.%> (-2.9548%)` | :arrow_down: | | [...vy/util/concurrent/ConcurrentReferenceHashMap.java](https://codecov.io/gh/apache/groovy/pull/1842?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvQ29uY3VycmVudFJlZmVyZW5jZUhhc2hNYXAuamF2YQ==) | `35.2349% <0.%> (-0.5034%)` | :arrow_down: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun commented on pull request #1837: Add source dependency on task to fix task cacheability
daniellansun commented on PR #1837: URL: https://github.com/apache/groovy/pull/1837#issuecomment-1374790998 ``` > Task :groovy-xml:asciidoctor Dependency verification has been disabled for configuration detachedConfiguration2 Dependency verification has been disabled for configuration detachedConfiguration3 error: Illegal package name: "/home/runner/work/groovy/groovy/build/generated/sources/antlr4/org/apache/groovy/parser/antlr4/GroovyLexer.tokens" ``` The distribution build is failing because of the above error, so the PR can not be merged for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun commented on pull request #1841: Fix JMH Benchmarks
daniellansun commented on PR #1841: URL: https://github.com/apache/groovy/pull/1841#issuecomment-1374789309 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1841: Fix JMH Benchmarks
codecov-commenter commented on PR #1841: URL: https://github.com/apache/groovy/pull/1841#issuecomment-1374701185 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1841](https://codecov.io/gh/apache/groovy/pull/1841?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e084c37) into [master](https://codecov.io/gh/apache/groovy/commit/8f80995b4a116ca65ca1536df8f7f65abc08dac6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f80995) will **increase** coverage by `0.0009%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1841+/- ## == + Coverage 67.7474% 67.7483% +0.0009% - Complexity 28300 28302 +2 == Files1427 1427 Lines 112611 112611 Branches19302 19302 == + Hits76291 76292 +1 Misses 29795 29795 + Partials 6525 6524 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1841?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `45.0593% <0.%> (+0.1976%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] PaintNinja opened a new pull request, #1841: Fix JMH Benchmarks
PaintNinja opened a new pull request, #1841: URL: https://github.com/apache/groovy/pull/1841 This small PR fixes the following error when trying to run the Groovy runtime benchmarks (`./gradlew -PbenchInclude=CallsiteBench :perf:jmh`): ``` Execution failed for task ':performance:jmh'. > A failure occurred while executing me.champeau.gradle.IsolatedRunner > Error while instantiating tests: unable to set 'list' on Runner. This plugin version doesn't seem to be compatible with JMH 1.35. Please report to the plugin authors at https://github.com/melix/jmh-gradle-plugin/. ``` I did look into fixing `./gradlew :perf:performanceTests` as well but unfortunately couldn't figure that one out, sorry about that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1840: Bump com.gradle.enterprise from 3.12.1 to 3.12.2
daniellansun merged PR #1840: URL: https://github.com/apache/groovy/pull/1840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1840: Bump com.gradle.enterprise from 3.12.1 to 3.12.2
codecov-commenter commented on PR #1840: URL: https://github.com/apache/groovy/pull/1840#issuecomment-1371638430 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1840?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1840](https://codecov.io/gh/apache/groovy/pull/1840?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d56b106) into [master](https://codecov.io/gh/apache/groovy/commit/3a5569172b2d4b48e8a9ceb0e404075672014247?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3a55691) will **increase** coverage by `0.0018%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1840?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1840+/- ## == + Coverage 67.7447% 67.7465% +0.0018% + Complexity 28301 28300 -1 == Files1427 1427 Lines 112611 112611 Branches19302 19302 == + Hits76288 76290 +2 + Misses 29796 29795 -1 + Partials 6527 6526 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1840?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1840?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `85.2459% <0.%> (-0.8197%)` | :arrow_down: | | [...vy/util/concurrent/ConcurrentReferenceHashMap.java](https://codecov.io/gh/apache/groovy/pull/1840?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvQ29uY3VycmVudFJlZmVyZW5jZUhhc2hNYXAuamF2YQ==) | `35.7383% <0.%> (+0.5034%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1840: Bump com.gradle.enterprise from 3.12.1 to 3.12.2
dependabot[bot] opened a new pull request, #1840: URL: https://github.com/apache/groovy/pull/1840 Bumps com.gradle.enterprise from 3.12.1 to 3.12.2. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…
paulk-asert merged PR #1839: URL: https://github.com/apache/groovy/pull/1839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] royteeuwen commented on pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment
royteeuwen commented on PR #1836: URL: https://github.com/apache/groovy/pull/1836#issuecomment-1371305256 > Will this cause many passes of class scanning and `DefaultFastStringService` instances? How are `loadService()` and `getService()` used? INSTANCE s a static field, meaning that at the class loading of FastStringUtils it will be initialized by calling loadService(). This will only be done once getService() will just return that same static instance all the time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment
eric-milles commented on PR #1836: URL: https://github.com/apache/groovy/pull/1836#issuecomment-1371268084 Will this cause many passes of class scanning and `DefaultFastStringService` instances? How are `loadService()` and `getService()` used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment
eric-milles commented on PR #1836: URL: https://github.com/apache/groovy/pull/1836#issuecomment-1371265481 Can you please make the test class `final` and JUnit4-based by using `@Test` instead of `GroovyTestCase`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…
paulk-asert commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1370224768 My thinking was since this is missing functionality it makes sense for 4.0.8. We have the find/findAll variants (Groovy truth) in 4.0.7 why not the missing findResult/s variants (null-based) also? We just never got around to it before. The `ArrayGroovyMethods` are just for primitive arrays. There is no need for primitive variations for these since they couldn't have null and moreover the Object variant picks up those anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…
eric-milles commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1369834434 Not sure why the new methods are listed as "since 4.0.8". Are these such a must have that they should be available immediately. If kept for 5+, the array-based overloads can start off in `ArrayGroovyMethods` with no deprecated artifact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…
paulk-asert commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1369681830 Is the "further clarification request" on your -1 veto satisfied? Perhaps you can formally remove it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…
paulk-asert commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368542797 We picked the name `findResult` many years ago. Naming is hard. I wasn't going to open the naming can of worms myself. Just plugging that hole in the existing named functions. But on naming, I think the idea was that if you got a result (being "non-null") that was a match whereas what was regarded as more common case of wanting Groovy truth was find/findAll. If we hadn't already locked in the find/findAll naming many years earlier again, we might not have chosen findResult/findResults for the non-null case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…
eric-milles commented on PR #1839:
URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368491569
Okay, just picked up on the difference. `find` and `findAll` apply groovy
truth and `findResult` and `findResults` check `null` only. Is that too subtle
a difference?
If this is what I am looking for:
```groovy
def list = [null, '', 'A', null, 'B', false]
assert list.find() == 'A'
assert list.findAll() == ['A', 'B']
assert list.xxx == ''
assert list.yyy == ['','A', 'B',false]
```
For myself, I'd look to sub "xxx" with `find{it != null}` or
`find(Objects::nonNull)` and "yyy" with `findAll{it != null}` or
`findAll(Objects::nonNull)`. Nice and clear IMO.
I'm just really stuck on "result" in `findResult` meaning something other
than the input value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…
eric-milles commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368484663 And since `find` and `findAll` are based on groovy truth, to get a default value, you can just pepper in elvis: ```groovy def list = [null,false,'',[]] def result = list.find() ?: 'defaultValue' assert result == 'defaultValue' ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…
eric-milles commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368483874 I don't think it is hole in existing functionality though. I'm missing the clear and obvious part of all this. Leaving the default value stuff aside, ```groovy def list = [null, '', 'A', null, 'B', false, []] assert list.find() == 'A' assert list.findAll() == ['A', 'B'] // Is this what you are suggesting? assert list.findResult() == 'A' assert list.findResults() == ['A', 'B'] ``` Why do I need the no-arg variants of `findResult` and `findResults` then? If not transforming, I justuse `find` or `findAll`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…
paulk-asert commented on PR #1839:
URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368316519
It is filling a hole in existing functionality. Take `find` and `findAll`
for instance, they have the no Closure variants:
```
var list = [null, '', 'A', null, 'B']
assert list.findAll() == ['A', 'B']
assert list.find() == 'A'
```
These return all (or the first) element that satisfies Groovy truth. It is
common in Groovy to provide these shortcuts even though `findAll { it }` and
`find { it }` would do in the above examples. The same applies for `groupBy`,
`collect`, `collectEntries`, and others. We have never gotten around to
providing the findResult/s variants which is what this PR does. It improves
Groovy's consistency in the API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…
eric-milles commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368284125 -1 for me unless some description is provided. What is the specific purpose of this and what does to replace that is currently available? More discussion from Feb 2019: https://www.mail-archive.com/dev@groovy.apache.org/msg04292.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…
codecov-commenter commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368212345 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1839](https://codecov.io/gh/apache/groovy/pull/1839?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a738705) into [master](https://codecov.io/gh/apache/groovy/commit/a4da7b66b621071d794f17c28f64250ba95e46f4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4da7b6) will **decrease** coverage by `0.0029%`. > The diff coverage is `56.2500%`. [](https://codecov.io/gh/apache/groovy/pull/1839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1839+/- ## == - Coverage 67.7495% 67.7466% -0.0029% - Complexity 28298 28307 +9 == Files1427 1427 Lines 112606 112627+21 Branches19307 19311 +4 == + Hits76290 76301+11 - Misses 29786 29796+10 Partials 6530 6530 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1839?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [.../codehaus/groovy/runtime/DefaultGroovyMethods.java](https://codecov.io/gh/apache/groovy/pull/1839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3J1bnRpbWUvRGVmYXVsdEdyb292eU1ldGhvZHMuamF2YQ==) | `76.6410% <56.2500%> (-0.1010%)` | :arrow_down: | | [.../apache/groovy/groovysh/commands/DocCommand.groovy](https://codecov.io/gh/apache/groovy/pull/1839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWdyb292eXNoL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL2dyb292eS9ncm9vdnlzaC9jb21tYW5kcy9Eb2NDb21tYW5kLmdyb292eQ==) | `50.% <0.%> (-1.3158%)` | :arrow_down: | | [.../codehaus/groovy/classgen/asm/AssertionWriter.java](https://codecov.io/gh/apache/groovy/pull/1839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L2NsYXNzZ2VuL2FzbS9Bc3NlcnRpb25Xcml0ZXIuamF2YQ==) | `94.2857% <0.%> (-0.0405%)` | :arrow_down: | | [...org/codehaus/groovy/vmplugin/v8/IndyInterface.java](https://codecov.io/gh/apache/groovy/pull/1839/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3ZtcGx1Z2luL3Y4L0luZHlJbnRlcmZhY2UuamF2YQ==) | `86.0656% <0.%> (+0.8197%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert opened a new pull request, #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…
paulk-asert opened a new pull request, #1839: URL: https://github.com/apache/groovy/pull/1839 … which use Closure.IDENTITY in that case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1838: Bump build-info-extractor-gradle from 4.30.1 to 4.31.0
daniellansun merged PR #1838: URL: https://github.com/apache/groovy/pull/1838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1838: Bump build-info-extractor-gradle from 4.30.1 to 4.31.0
codecov-commenter commented on PR #1838: URL: https://github.com/apache/groovy/pull/1838#issuecomment-1367678028 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1838](https://codecov.io/gh/apache/groovy/pull/1838?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c166610) into [master](https://codecov.io/gh/apache/groovy/commit/381610a5e1fc91cb617dcab2071c5499af34b631?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (381610a) will **increase** coverage by `0.0009%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1838+/- ## == + Coverage 67.7519% 67.7528% +0.0009% - Complexity 28298 28299 +1 == Files1427 1427 Lines 112605 112605 Branches19307 19307 == + Hits76292 76293 +1 Misses 29784 29784 + Partials 6529 6528 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1838?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1838/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `45.0593% <0.%> (+0.1976%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1838: Bump build-info-extractor-gradle from 4.30.1 to 4.31.0
dependabot[bot] opened a new pull request, #1838: URL: https://github.com/apache/groovy/pull/1838 Bumps build-info-extractor-gradle from 4.30.1 to 4.31.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1837: Add source dependency on task to fix task cacheability
codecov-commenter commented on PR #1837: URL: https://github.com/apache/groovy/pull/1837#issuecomment-1366848283 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1837?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1837](https://codecov.io/gh/apache/groovy/pull/1837?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1f6663) into [master](https://codecov.io/gh/apache/groovy/commit/381610a5e1fc91cb617dcab2071c5499af34b631?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (381610a) will **decrease** coverage by `0.0027%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1837?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1837+/- ## == - Coverage 67.7519% 67.7492% -0.0027% + Complexity 28298 28297 -1 == Files1427 1427 Lines 112605 112605 Branches19307 19307 == - Hits76292 76289 -3 - Misses 29784 29786 +2 - Partials 6529 6530 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1837?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...vy/util/concurrent/ConcurrentReferenceHashMap.java](https://codecov.io/gh/apache/groovy/pull/1837/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvQ29uY3VycmVudFJlZmVyZW5jZUhhc2hNYXAuamF2YQ==) | `35.2349% <0.%> (-0.5034%)` | :arrow_down: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] runningcode opened a new pull request, #1837: Add source dependency on task to fix task cacheability
runningcode opened a new pull request, #1837: URL: https://github.com/apache/groovy/pull/1837 The deprecation warning that this PR fixes can be seen [in this build scan](https://scans.gradle.com/s/njuvm77j3jark/deprecations?expanded=WyI1OSJd#60) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun commented on pull request #1834: GROOVY-10879: Additional DGM collectEntries variants
daniellansun commented on PR #1834: URL: https://github.com/apache/groovy/pull/1834#issuecomment-1362284825 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1834: GROOVY-10879: Additional DGM collectEntries variants
daniellansun merged PR #1834: URL: https://github.com/apache/groovy/pull/1834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment
codecov-commenter commented on PR #1836: URL: https://github.com/apache/groovy/pull/1836#issuecomment-1361193224 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1836?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1836](https://codecov.io/gh/apache/groovy/pull/1836?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (59d3a32) into [master](https://codecov.io/gh/apache/groovy/commit/27275071bfcad2225b6ddc0d7dcf54528d3ac29e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2727507) will **decrease** coverage by `0.0003%`. > The diff coverage is `33.%`. [](https://codecov.io/gh/apache/groovy/pull/1836?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1836+/- ## == - Coverage 67.7583% 67.7580% -0.0003% Complexity 28281 28281 == Files1427 1427 Lines 112556 112558 +2 Branches19302 19303 +1 == + Hits76266 76267 +1 - Misses 29759 29761 +2 + Partials 6531 6530 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1836?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...g/apache/groovy/json/internal/FastStringUtils.java](https://codecov.io/gh/apache/groovy/pull/1836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LWpzb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS9qc29uL2ludGVybmFsL0Zhc3RTdHJpbmdVdGlscy5qYXZh) | `55.% <33.%> (-6.%)` | :arrow_down: | | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `45.0593% <0.%> (ø)` | | | [...odehaus/groovy/reflection/GeneratedMetaMethod.java](https://codecov.io/gh/apache/groovy/pull/1836/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvY29kZWhhdXMvZ3Jvb3Z5L3JlZmxlY3Rpb24vR2VuZXJhdGVkTWV0YU1ldGhvZC5qYXZh) | `57.6923% <0.%> (+0.9615%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1835: Bump com.gradle.enterprise from 3.12 to 3.12.1
daniellansun merged PR #1835: URL: https://github.com/apache/groovy/pull/1835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] codecov-commenter commented on pull request #1835: Bump com.gradle.enterprise from 3.12 to 3.12.1
codecov-commenter commented on PR #1835: URL: https://github.com/apache/groovy/pull/1835#issuecomment-1360651016 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1835?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#1835](https://codecov.io/gh/apache/groovy/pull/1835?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (88b2619) into [master](https://codecov.io/gh/apache/groovy/commit/e9c4abc6f115a21006192969f6a0a73476e07367?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e9c4abc) will **increase** coverage by `0.0009%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/groovy/pull/1835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #1835+/- ## == + Coverage 67.7592% 67.7600% +0.0009% - Complexity 28282 28283 +1 == Files1427 1427 Lines 112556 112556 Branches19302 19302 == + Hits76267 76268 +1 Misses 29760 29760 + Partials 6529 6528 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/groovy/pull/1835?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java](https://codecov.io/gh/apache/groovy/pull/1835/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dyb292eS91dGlsL2NvbmN1cnJlbnQvY29uY3VycmVudGxpbmtlZGhhc2htYXAvQ29uY3VycmVudExpbmtlZEhhc2hNYXAuamF2YQ==) | `45.0593% <0.%> (+0.1976%)` | :arrow_up: | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1835: Bump com.gradle.enterprise from 3.12 to 3.12.1
dependabot[bot] opened a new pull request, #1835: URL: https://github.com/apache/groovy/pull/1835 Bumps com.gradle.enterprise from 3.12 to 3.12.1. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1834: GROOVY-10879: Additional DGM collectEntries variants
paulk-asert commented on PR #1834: URL: https://github.com/apache/groovy/pull/1834#issuecomment-1360225048 There are 24 methods but it is basically: 4 types: Iterators, Iterables, arrays and Maps BY 2 options: supplied collector or new map BY 3 scenarios: change key and value, change key, change value ``` collectEntries(Iterator self, Map collector, Function keyTransform, Function valueTransform) collectEntries(Iterator self, Function keyTransform, Function valueTransform) collectEntries(Iterable self, Map collector, Function keyTransform, Function valueTransform) collectEntries(Iterable self, Function keyTransform, Function valueTransform) collectEntries(E[] self, Map collector, Function keyTransform, Function valueTransform) collectEntries(E[] self, Function keyTransform, Function valueTransform) collectEntries(Map self, Map collector, Function keyTransform, Function valueTransform) collectEntries(Map self, Function keyTransform, Function valueTransform) withCollectedValues(Iterator keys, Map collector, Function valueTransform) withCollectedValues(Iterator keys, Function valueTransform) withCollectedValues(Iterable keys, Map collector, Function valueTransform) withCollectedValues(Iterable keys, Function valueTransform) withCollectedValues(K[] keys, Map collector, Function valueTransform) withCollectedValues(K[] keys, Function valueTransform) collectValues(Map keys, Map collector, Function valueTransform) collectValues(Map keys, Function valueTransform) withCollectedKeys(Iterator values, Map collector, Function keyTransform) withCollectedKeys(Iterator values, Function keyTransform) withCollectedKeys(Iterable values, Map collector, Function keyTransform) withCollectedKeys(Iterable values, Function keyTransform) withCollectedKeys(V[] values, Map collector, Function keyTransform) withCollectedKeys(V[] values, Function keyTransform) collectKeys(Map keys, Map collector, Function keyTransform) collectKeys(Map keys, Function keyTransform) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1834: GROOVY-10879: Additional DGM collectEntries variants
eric-milles commented on PR #1834: URL: https://github.com/apache/groovy/pull/1834#issuecomment-1359449154 That's a lot of new methods. Any chance of splitting it up into separate PRs for each name so they can be reviewed separately? new `collectEntries` variant seemed reasonable-ish. But there are a lot more there to try and understand. For me, producing a map always meant "collectEntries". Not sure I agree with adding new names for making maps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun commented on pull request #1834: GROOVY-10879: Additional DGM collectEntries variants
daniellansun commented on PR #1834: URL: https://github.com/apache/groovy/pull/1834#issuecomment-1359128768 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1834: GROOVY-10879: Additional DGM collectEntries variants
sonatype-lift[bot] commented on code in PR #1834:
URL: https://github.com/apache/groovy/pull/1834#discussion_r1053074864
##
src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java:
##
@@ -4005,6 +3998,405 @@ public static Map
collectEntries(Iterator self, Map col
return collector;
}
+/**
+ * A variant of collectEntries for Iterators with separate functions for
transforming the keys and values.
+ * The supplied collector map is used as the destination for transformed
entries.
+ *
+ * @param self an Iterator
+ * @param collector the Map into which the transformed entries are put
+ * @param keyTransform a function for transforming Iterator elements
into keys
+ * @param valueTransform a function for transforming Iterator elements
into values
+ * @return the collector with all transformed values added to it
+ * @since 5.0.0
+ */
+public static Map collectEntries(Iterator self, Map collector, Function keyTransform, Function
valueTransform) {
+while (self.hasNext()) {
+E element = self.next();
+addEntry(collector, Tuple2.tuple(keyTransform.apply(element),
valueTransform.apply(element)));
+}
+return collector;
+}
+
+/**
+ * A variant of collectEntries for Iterators with separate functions for
transforming the keys and values.
+ *
+ * @param self an Iterator
+ * @param keyTransform a function for transforming Iterator elements
into keys
+ * @param valueTransform a function for transforming Iterator elements
into values
+ * @return a Map of the transformed entries
+ * @since 5.0.0
+ */
+public static Map collectEntries(Iterator self,
Function keyTransform, Function valueTransform) {
+return collectEntries(self, new LinkedHashMap<>(), keyTransform,
valueTransform);
+}
+
+/**
+ * A variant of collectEntries for Iterables with separate functions for
transforming the keys and values.
+ * The supplied collector map is used as the destination for transformed
entries.
+ *
+ * def languages = ['Groovy', 'Java', 'Kotlin', 'Scala']
+ * assert languages.collectEntries([clojure:7], String::toLowerCase,
String::size) ==
+ * [clojure:7, groovy:6, java:4, kotlin:6, scala:5]
+ *
+ *
+ * @param self an Iterable
+ * @param collector the Map into which the transformed entries are put
+ * @param keyTransform a function for transforming Iterable elements
into keys
+ * @param valueTransform a function for transforming Iterable elements
into values
+ * @return the collector with all transformed values added to it
+ * @since 5.0.0
+ */
+public static Map collectEntries(Iterable self, Map collector, Function keyTransform, Function
valueTransform) {
+return collectEntries(self.iterator(), collector, keyTransform,
valueTransform);
+}
+
+/**
+ * A variant of collectEntries for Iterables with separate functions for
transforming the keys and values.
+ *
+ * def languages = ['Groovy', 'Java', 'Kotlin', 'Scala']
+ * assert languages.collectEntries(String::toLowerCase, String::size) ==
+ * [groovy:6, java:4, kotlin:6, scala:5]
+ *
+ *
+ * @param self an Iterable
+ * @param keyTransform a function for transforming Iterable elements
into keys
+ * @param valueTransform a function for transforming Iterable elements
into values
+ * @return a Map of the transformed entries
+ * @since 5.0.0
+ */
+public static Map collectEntries(Iterable self,
Function keyTransform, Function valueTransform) {
+return collectEntries(self.iterator(), new LinkedHashMap<>(),
keyTransform, valueTransform);
+}
+
+/**
+ * A variant of collectEntries for arrays with separate functions for
transforming the keys and values.
+ * The supplied collector map is used as the destination for transformed
entries.
+ *
+ * @param self an array
+ * @param collector the Map into which the transformed entries are put
+ * @param keyTransform a function for transforming array elements into
keys
+ * @param valueTransform a function for transforming array elements into
values
+ * @return the collector with all transformed values added to it
+ * @since 5.0.0
+ */
+public static Map collectEntries(E[] self, Map
collector, Function keyTransform, Function
valueTransform) {
+return collectEntries(new ArrayIterator<>(self), collector,
keyTransform, valueTransform);
+}
+
+/**
+ * A variant of collectEntries for arrays with separate functions for
transforming the keys and values.
+ *
+ * String[] languages = ['Groovy', 'Java', 'Kotlin', 'Scala']
+ * def firstLetter = s -> s[0]
+ * assert languages.collectEntries(firstLetter, String::size) == [G:6,
J:4, K
[GitHub] [groovy] daniellansun commented on pull request #1832: GROOVY-10871: Bump Gradle version (build dependency)
daniellansun commented on PR #1832: URL: https://github.com/apache/groovy/pull/1832#issuecomment-1358708115 Asciidoctor Gradle Plugin is not that active any more... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1832: GROOVY-10871: Bump Gradle version (build dependency)
paulk-asert commented on PR #1832: URL: https://github.com/apache/groovy/pull/1832#issuecomment-1356167530 > The issue of Asciidoctor Gradle Plugin had been filed at [asciidoctor/asciidoctor-gradle-plugin#655](https://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/655). Thanks, yes I saw your issue (Thanks!) and already have the link in the Jira issue: https://issues.apache.org/jira/browse/GROOVY-10871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] Goooler commented on pull request #1832: GROOVY-10871: Bump Gradle version (build dependency)
Goooler commented on PR #1832: URL: https://github.com/apache/groovy/pull/1832#issuecomment-1356157190 The issue of Asciidoctor Gradle Plugin had been filed at https://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/655. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1833: Bump build-info-extractor-gradle from 4.30.0 to 4.30.1
daniellansun merged PR #1833: URL: https://github.com/apache/groovy/pull/1833 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1833: Bump build-info-extractor-gradle from 4.30.0 to 4.30.1
dependabot[bot] opened a new pull request, #1833: URL: https://github.com/apache/groovy/pull/1833 Bumps build-info-extractor-gradle from 4.30.0 to 4.30.1. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1831: Bump build-info-extractor-gradle from 4.29.4 to 4.30.0
daniellansun merged PR #1831: URL: https://github.com/apache/groovy/pull/1831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1831: Bump build-info-extractor-gradle from 4.29.4 to 4.30.0
dependabot[bot] opened a new pull request, #1831: URL: https://github.com/apache/groovy/pull/1831 Bumps build-info-extractor-gradle from 4.29.4 to 4.30.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1830: Bump com.gradle.enterprise from 3.11.4 to 3.12
daniellansun merged PR #1830: URL: https://github.com/apache/groovy/pull/1830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1830: Bump com.gradle.enterprise from 3.11.4 to 3.12
dependabot[bot] opened a new pull request, #1830: URL: https://github.com/apache/groovy/pull/1830 Bumps com.gradle.enterprise from 3.11.4 to 3.12. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1829: Bump build-info-extractor-gradle from 4.29.3 to 4.29.4
daniellansun merged PR #1829: URL: https://github.com/apache/groovy/pull/1829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1829: Bump build-info-extractor-gradle from 4.29.3 to 4.29.4
dependabot[bot] opened a new pull request, #1829: URL: https://github.com/apache/groovy/pull/1829 Bumps build-info-extractor-gradle from 4.29.3 to 4.29.4. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types
eric-milles commented on PR #1824: URL: https://github.com/apache/groovy/pull/1824#issuecomment-1320201876 I relocated the lambda tests and reworked the generics tests to ensure the placeholders are not returned. https://github.com/apache/groovy/commit/ef9b58463e83f842b56f24dff0ac4df0e02f112f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles closed pull request #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types
eric-milles closed pull request #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types URL: https://github.com/apache/groovy/pull/1824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert closed pull request #1719: GROOVY-10615: Bump Codenarc to 3.0.1 (build dependency)
paulk-asert closed pull request #1719: GROOVY-10615: Bump Codenarc to 3.0.1 (build dependency) URL: https://github.com/apache/groovy/pull/1719 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1719: GROOVY-10615: Bump Codenarc to 3.0.1 (build dependency)
paulk-asert commented on PR #1719: URL: https://github.com/apache/groovy/pull/1719#issuecomment-1314679995 We'll wait for the next release -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1826: GROOVY-10822: Groovysh DocCommand improvements
paulk-asert merged PR #1826: URL: https://github.com/apache/groovy/pull/1826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1827: Bump com.github.ben-manes.versions from 0.43.0 to 0.44.0
daniellansun merged PR #1827: URL: https://github.com/apache/groovy/pull/1827 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1827: Bump com.github.ben-manes.versions from 0.43.0 to 0.44.0
dependabot[bot] opened a new pull request, #1827: URL: https://github.com/apache/groovy/pull/1827 Bumps com.github.ben-manes.versions from 0.43.0 to 0.44.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] Shadow-Devil commented on a diff in pull request #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020890479
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -855,10 +855,16 @@ private static Map
doMakeDeclaringAndActualGenericsT
GenericsType[] targetGenericsTypes =
parameterizedType.redirect().getGenericsTypes();
if (targetGenericsTypes != null) {
GenericsType[] sourceGenericsTypes =
parameterizedType.getGenericsTypes();
-if (sourceGenericsTypes == null) sourceGenericsTypes =
EMPTY_GENERICS_ARRAY;
map = new LinkedHashMap<>();
-for (int i = 0, m = sourceGenericsTypes.length, n =
targetGenericsTypes.length; i < n; i += 1) {
-map.put(targetGenericsTypes[i], i < m ?
sourceGenericsTypes[i] : targetGenericsTypes[i]);
+if (sourceGenericsTypes == null) {
+//We have no sourceGenerics, so we need to return the
erasures for the raw types (Groovy-10813)
+for (GenericsType targetGenericsType :
targetGenericsTypes) {
+map.put(targetGenericsType,
ClassHelper.OBJECT_TYPE.asGenericsType());
Review Comment:
I've added some tests that have an upper bound. I was a bit suprised that `T
extends String & Object` just selects the first one when you use raw types, so
the result is different from `T extends Object & String`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1822: GROOVY-8668: add property groovysh.disableDocCommand
paulk-asert commented on PR #1822: URL: https://github.com/apache/groovy/pull/1822#issuecomment-1312638940 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert merged pull request #1822: GROOVY-8668: add property groovysh.disableDocCommand
paulk-asert merged PR #1822: URL: https://github.com/apache/groovy/pull/1822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] Shadow-Devil commented on a diff in pull request #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020470376
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -855,10 +855,16 @@ private static Map
doMakeDeclaringAndActualGenericsT
GenericsType[] targetGenericsTypes =
parameterizedType.redirect().getGenericsTypes();
if (targetGenericsTypes != null) {
GenericsType[] sourceGenericsTypes =
parameterizedType.getGenericsTypes();
-if (sourceGenericsTypes == null) sourceGenericsTypes =
EMPTY_GENERICS_ARRAY;
map = new LinkedHashMap<>();
-for (int i = 0, m = sourceGenericsTypes.length, n =
targetGenericsTypes.length; i < n; i += 1) {
-map.put(targetGenericsTypes[i], i < m ?
sourceGenericsTypes[i] : targetGenericsTypes[i]);
+if (sourceGenericsTypes == null) {
+//We have no sourceGenerics, so we need to return the
erasures for the raw types (Groovy-10813)
+for (GenericsType targetGenericsType :
targetGenericsTypes) {
+map.put(targetGenericsType,
ClassHelper.OBJECT_TYPE.asGenericsType());
Review Comment:
Uh, now I got an example, that has not Object as its type:
```java
interface A {
T apply(T input);
}
class B implements A{
@Override
String apply(String input) {
return null
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] Shadow-Devil commented on a diff in pull request #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020468865
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -855,10 +855,16 @@ private static Map
doMakeDeclaringAndActualGenericsT
GenericsType[] targetGenericsTypes =
parameterizedType.redirect().getGenericsTypes();
if (targetGenericsTypes != null) {
GenericsType[] sourceGenericsTypes =
parameterizedType.getGenericsTypes();
-if (sourceGenericsTypes == null) sourceGenericsTypes =
EMPTY_GENERICS_ARRAY;
map = new LinkedHashMap<>();
-for (int i = 0, m = sourceGenericsTypes.length, n =
targetGenericsTypes.length; i < n; i += 1) {
-map.put(targetGenericsTypes[i], i < m ?
sourceGenericsTypes[i] : targetGenericsTypes[i]);
+if (sourceGenericsTypes == null) {
+//We have no sourceGenerics, so we need to return the
erasures for the raw types (Groovy-10813)
+for (GenericsType targetGenericsType :
targetGenericsTypes) {
+map.put(targetGenericsType,
ClassHelper.OBJECT_TYPE.asGenericsType());
Review Comment:
Another example where the type parameter has an upper bound:
```java
interface A extends Function {}
class B implements A{
@Override
Object apply(Object input) {
return null
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] Shadow-Devil commented on a diff in pull request #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020468865
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -855,10 +855,16 @@ private static Map
doMakeDeclaringAndActualGenericsT
GenericsType[] targetGenericsTypes =
parameterizedType.redirect().getGenericsTypes();
if (targetGenericsTypes != null) {
GenericsType[] sourceGenericsTypes =
parameterizedType.getGenericsTypes();
-if (sourceGenericsTypes == null) sourceGenericsTypes =
EMPTY_GENERICS_ARRAY;
map = new LinkedHashMap<>();
-for (int i = 0, m = sourceGenericsTypes.length, n =
targetGenericsTypes.length; i < n; i += 1) {
-map.put(targetGenericsTypes[i], i < m ?
sourceGenericsTypes[i] : targetGenericsTypes[i]);
+if (sourceGenericsTypes == null) {
+//We have no sourceGenerics, so we need to return the
erasures for the raw types (Groovy-10813)
+for (GenericsType targetGenericsType :
targetGenericsTypes) {
+map.put(targetGenericsType,
ClassHelper.OBJECT_TYPE.asGenericsType());
Review Comment:
Another example where the type parameter has an upper bound:
´´´java
interface A extends Function {}
class B implements A{
@Override
Object apply(Object input) {
return null
}
}
´´´
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] Shadow-Devil commented on a diff in pull request #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020417769
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -855,10 +855,16 @@ private static Map
doMakeDeclaringAndActualGenericsT
GenericsType[] targetGenericsTypes =
parameterizedType.redirect().getGenericsTypes();
if (targetGenericsTypes != null) {
GenericsType[] sourceGenericsTypes =
parameterizedType.getGenericsTypes();
-if (sourceGenericsTypes == null) sourceGenericsTypes =
EMPTY_GENERICS_ARRAY;
map = new LinkedHashMap<>();
-for (int i = 0, m = sourceGenericsTypes.length, n =
targetGenericsTypes.length; i < n; i += 1) {
-map.put(targetGenericsTypes[i], i < m ?
sourceGenericsTypes[i] : targetGenericsTypes[i]);
+if (sourceGenericsTypes == null) {
+//We have no sourceGenerics, so we need to return the
erasures for the raw types (Groovy-10813)
+for (GenericsType targetGenericsType :
targetGenericsTypes) {
+map.put(targetGenericsType,
ClassHelper.OBJECT_TYPE.asGenericsType());
Review Comment:
I've played around with generics in java, but couldn't find an example where
the erasure isn't of type Object.
I've also tried something like this:
```java
import java.util.function.*
interface T extends Function{}
class TT implements T{
@Override
Object apply(Object o) {
return null
}
}
```
and it still loses all type information. Maybe I'm just not advanced enough
into generics and how they work. Could you perhaps help me here or give me a
resource where to learn more about this? I've found some information about the
topic
[here](https://docs.oracle.com/javase/tutorial/java/generics/rawTypes.html) and
[here](https://docs.oracle.com/javase/tutorial/java/generics/erasure.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] Shadow-Devil commented on a diff in pull request #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020266114
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -855,10 +855,16 @@ private static Map
doMakeDeclaringAndActualGenericsT
GenericsType[] targetGenericsTypes =
parameterizedType.redirect().getGenericsTypes();
if (targetGenericsTypes != null) {
GenericsType[] sourceGenericsTypes =
parameterizedType.getGenericsTypes();
-if (sourceGenericsTypes == null) sourceGenericsTypes =
EMPTY_GENERICS_ARRAY;
map = new LinkedHashMap<>();
-for (int i = 0, m = sourceGenericsTypes.length, n =
targetGenericsTypes.length; i < n; i += 1) {
-map.put(targetGenericsTypes[i], i < m ?
sourceGenericsTypes[i] : targetGenericsTypes[i]);
+if (sourceGenericsTypes == null) {
+//We have no sourceGenerics, so we need to return the
erasures for the raw types (Groovy-10813)
+for (GenericsType targetGenericsType :
targetGenericsTypes) {
+map.put(targetGenericsType,
ClassHelper.OBJECT_TYPE.asGenericsType());
Review Comment:
I will try to find an example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] Shadow-Devil commented on a diff in pull request #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020265603
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -950,7 +956,7 @@ public static boolean hasUnresolvedGenerics(final ClassNode
type) {
public static Tuple2 parameterizeSAM(final
ClassNode samType) {
MethodNode abstractMethod = ClassHelper.findSAM(samType);
-Map generics =
makeDeclaringAndActualGenericsTypeMapOfExactType(abstractMethod.getDeclaringClass(),
samType);
+Map generics =
makeDeclaringAndActualGenericsTypeMap(abstractMethod.getDeclaringClass(),
samType);
Review Comment:
> Is this the stuff that sits under parametwrizeSAM? That was the key method
for fixing lambda param types.
parameterizeSAM uses this makeDeclaringAndActualGenericsTypeMapOfExactType
method to map declaring generics to actual generics. I thought that I needed to
adjust this mapping so for unresolved generics it will output Object, but I'm
still unsure if that's the right solution (as you mentioned in the other
comment).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] Shadow-Devil commented on a diff in pull request #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types
Shadow-Devil commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020046859
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -950,7 +956,7 @@ public static boolean hasUnresolvedGenerics(final ClassNode
type) {
public static Tuple2 parameterizeSAM(final
ClassNode samType) {
MethodNode abstractMethod = ClassHelper.findSAM(samType);
-Map generics =
makeDeclaringAndActualGenericsTypeMapOfExactType(abstractMethod.getDeclaringClass(),
samType);
+Map generics =
makeDeclaringAndActualGenericsTypeMap(abstractMethod.getDeclaringClass(),
samType);
Review Comment:
I'm sorry, this change was not intended to be commited, it was just for
testing.
I will revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] FelixSchnabel commented on a diff in pull request #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types
FelixSchnabel commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1020045088
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -950,7 +956,7 @@ public static boolean hasUnresolvedGenerics(final ClassNode
type) {
public static Tuple2 parameterizeSAM(final
ClassNode samType) {
MethodNode abstractMethod = ClassHelper.findSAM(samType);
-Map generics =
makeDeclaringAndActualGenericsTypeMapOfExactType(abstractMethod.getDeclaringClass(),
samType);
+Map generics =
makeDeclaringAndActualGenericsTypeMap(abstractMethod.getDeclaringClass(),
samType);
Review Comment:
I'm sorry, this was a mistake.
I will revert this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1825: Bump build-info-extractor-gradle from 4.29.2 to 4.29.3
daniellansun merged PR #1825: URL: https://github.com/apache/groovy/pull/1825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1820: Fix doc typos
paulk-asert commented on PR #1820: URL: https://github.com/apache/groovy/pull/1820#issuecomment-1311122050 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] asfgit closed pull request #1820: Fix doc typos
asfgit closed pull request #1820: Fix doc typos URL: https://github.com/apache/groovy/pull/1820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1825: Bump build-info-extractor-gradle from 4.29.2 to 4.29.3
dependabot[bot] opened a new pull request, #1825: URL: https://github.com/apache/groovy/pull/1825 Bumps [build-info-extractor-gradle](https://github.com/jfrog/build-info) from 4.29.2 to 4.29.3. Changelog Sourced from https://github.com/jfrog/build-info/blob/master/RELEASE.md";>build-info-extractor-gradle's changelog. build-info-extractor 2.37.3 / gradle-artifactory-plugin 4.29.3 (November 10, 2022) Bug fix - Remove custom exception for unknown violation types (https://github-redirect.dependabot.com/jfrog/build-info/pull/675";>675) Bug fix - Sha256 hashes being set to literal "SHA-256" in build-info json (https://github-redirect.dependabot.com/jfrog/build-info/pull/669";>669) Commits https://github.com/jfrog/build-info/commit/ebb661993e15624b4b3813eb989fa88a300a4c5f";>ebb6619 [artifactory-release] Release version 2.37.3 [skipRun] https://github.com/jfrog/build-info/commit/30b0900cd9c86c6734a42ee51fa2751454223a01";>30b0900 Temporarily remove audit commands from release pipelines https://github.com/jfrog/build-info/commit/9d4dccd193e7ab9054bf2cd9ec0afce18c8c2c7d";>9d4dccd Fix build scan table tests (https://github-redirect.dependabot.com/jfrog/build-info/issues/676";>#676) https://github.com/jfrog/build-info/commit/1863811a29da1d50c7f91b10c02d4490165804d4";>1863811 Remove custom exception for unknown violation types (https://github-redirect.dependabot.com/jfrog/build-info/issues/675";>#675) https://github.com/jfrog/build-info/commit/df2bdd383b7257724ad7b3816829dba63675ccd3";>df2bdd3 Update dependencies (https://github-redirect.dependabot.com/jfrog/build-info/issues/673";>#673) https://github.com/jfrog/build-info/commit/789f3e70a80522f9c521cb80c72c1adff8b39b66";>789f3e7 Fix sha256 hashes being set to literal "SHA-256" in build-info json (https://github-redirect.dependabot.com/jfrog/build-info/issues/669";>#669) https://github.com/jfrog/build-info/commit/9bd00bde6a0161f2301986355ea8592a7cf86ffa";>9bd00bd [artifactory-release] Next development version [skipRun] See full diff in https://github.com/jfrog/build-info/compare/build-info-gradle-extractor-4.29.2...build-info-gradle-extractor-4.29.3";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles commented on a diff in pull request #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types
eric-milles commented on code in PR #1824:
URL: https://github.com/apache/groovy/pull/1824#discussion_r1019717220
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -950,7 +956,7 @@ public static boolean hasUnresolvedGenerics(final ClassNode
type) {
public static Tuple2 parameterizeSAM(final
ClassNode samType) {
MethodNode abstractMethod = ClassHelper.findSAM(samType);
-Map generics =
makeDeclaringAndActualGenericsTypeMapOfExactType(abstractMethod.getDeclaringClass(),
samType);
+Map generics =
makeDeclaringAndActualGenericsTypeMap(abstractMethod.getDeclaringClass(),
samType);
Review Comment:
We have been moving away from `makeDeclaringAndActualGenericsTypeMap`
towards `makeDeclaringAndActualGenericsTypeMapOfExactType`. Can you explain
this change?
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -950,7 +956,7 @@ public static boolean hasUnresolvedGenerics(final ClassNode
type) {
public static Tuple2 parameterizeSAM(final
ClassNode samType) {
MethodNode abstractMethod = ClassHelper.findSAM(samType);
-Map generics =
makeDeclaringAndActualGenericsTypeMapOfExactType(abstractMethod.getDeclaringClass(),
samType);
+Map generics =
makeDeclaringAndActualGenericsTypeMap(abstractMethod.getDeclaringClass(),
samType);
Review Comment:
Is this the stuff that sits under parametwrizeSAM? That was the key method
for fixing lambda param types.
##
src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
##
@@ -855,10 +855,16 @@ private static Map
doMakeDeclaringAndActualGenericsT
GenericsType[] targetGenericsTypes =
parameterizedType.redirect().getGenericsTypes();
if (targetGenericsTypes != null) {
GenericsType[] sourceGenericsTypes =
parameterizedType.getGenericsTypes();
-if (sourceGenericsTypes == null) sourceGenericsTypes =
EMPTY_GENERICS_ARRAY;
map = new LinkedHashMap<>();
-for (int i = 0, m = sourceGenericsTypes.length, n =
targetGenericsTypes.length; i < n; i += 1) {
-map.put(targetGenericsTypes[i], i < m ?
sourceGenericsTypes[i] : targetGenericsTypes[i]);
+if (sourceGenericsTypes == null) {
+//We have no sourceGenerics, so we need to return the
erasures for the raw types (Groovy-10813)
+for (GenericsType targetGenericsType :
targetGenericsTypes) {
+map.put(targetGenericsType,
ClassHelper.OBJECT_TYPE.asGenericsType());
Review Comment:
The erasure type is not always Object. Can you create an example where it
is another type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] Shadow-Devil opened a new pull request, #1824: GROOVY-10813: Fix NullPointerException for lambdas with raw types
Shadow-Devil opened a new pull request, #1824: URL: https://github.com/apache/groovy/pull/1824 I've added a test case and a fix for the bug reported in GROOVY-10813. I'm not sure if there are any other edge cases that will now break because of this change, but one [test](https://github.com/apache/groovy/blob/9210cfab6aac681a865c57dd97e96aac73f38fd4/src/test/groovy/transform/stc/GenericsSTCTest.groovy#L740), that failed with another solution that I tried, passes with this solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] tisonkun closed pull request #1821: Replace gradlew command with relative path
tisonkun closed pull request #1821: Replace gradlew command with relative path URL: https://github.com/apache/groovy/pull/1821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] tisonkun commented on pull request #1821: Replace gradlew command with relative path
tisonkun commented on PR #1821: URL: https://github.com/apache/groovy/pull/1821#issuecomment-1309832274 @paulk-asert Thanks! I read it. Closed as invalid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1821: Replace gradlew command with relative path
paulk-asert commented on PR #1821: URL: https://github.com/apache/groovy/pull/1821#issuecomment-1309829154 We already have the relative path for unix systems as a comment the first time the command appears. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] daniellansun merged pull request #1823: Bump com.gradle.enterprise from 3.11.3 to 3.11.4
daniellansun merged PR #1823: URL: https://github.com/apache/groovy/pull/1823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] dependabot[bot] opened a new pull request, #1823: Bump com.gradle.enterprise from 3.11.3 to 3.11.4
dependabot[bot] opened a new pull request, #1823: URL: https://github.com/apache/groovy/pull/1823 Bumps com.gradle.enterprise from 3.11.3 to 3.11.4. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] tisonkun opened a new pull request, #1822: GROOVY-8668: add property groovysh.disableDocCommand
tisonkun opened a new pull request, #1822: URL: https://github.com/apache/groovy/pull/1822 The AWT window is launched by DocCommand. I want to exclude this functionality to avoid opening a new window so I suggest to add an option to disable it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1816: Bugfix/groovy 9541 stc take classloader param
eric-milles commented on PR #1816: URL: https://github.com/apache/groovy/pull/1816#issuecomment-1307353408 I merged the main changes that should fix GROOVY-9541 and will cherry-pick them back as well. The `ExtendedVerifier` spot has some history -- `getTypeClass()` -- I'm reworking it to unify the resolved and unresolved handling. Thanks again for your submission. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles closed pull request #1816: Bugfix/groovy 9541 stc take classloader param
eric-milles closed pull request #1816: Bugfix/groovy 9541 stc take classloader param URL: https://github.com/apache/groovy/pull/1816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1816: Bugfix/groovy 9541 stc take classloader param
eric-milles commented on PR #1816: URL: https://github.com/apache/groovy/pull/1816#issuecomment-1307253615 Thanks. I should be able to look at it today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] tisonkun opened a new pull request, #1821: Replace gradlew command with relative path
tisonkun opened a new pull request, #1821: URL: https://github.com/apache/groovy/pull/1821 Current working directory is not always in PATH -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] jonnybot0 commented on a diff in pull request #1816: Bugfix/groovy 9541 stc take classloader param
jonnybot0 commented on code in PR #1816:
URL: https://github.com/apache/groovy/pull/1816#discussion_r1015853496
##
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java:
##
@@ -2181,6 +2182,14 @@ public static boolean missesGenericsTypes(ClassNode cn) {
return cnGenerics == null || cnGenerics.length == 0 ? rnGenerics !=
null : GenericsUtils.hasUnresolvedGenerics(cn);
}
+/**
+ * @deprecated Use {@link #evaluateExpression(Expression,
CompilerConfiguration, GroovyClassLoader)} instead
+ */
+@Deprecated
+public static Object evaluateExpression(final Expression expr, final
CompilerConfiguration config) {
Review Comment:
I'm not sure this recommendation is one to follow. I don't see other
deprecated methods in this class or anywhere else in the codebase using this
annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1816: Bugfix/groovy 9541 stc take classloader param
sonatype-lift[bot] commented on code in PR #1816:
URL: https://github.com/apache/groovy/pull/1816#discussion_r1014858643
##
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java:
##
@@ -2181,6 +2182,14 @@ public static boolean missesGenericsTypes(ClassNode cn) {
return cnGenerics == null || cnGenerics.length == 0 ? rnGenerics !=
null : GenericsUtils.hasUnresolvedGenerics(cn);
}
+/**
+ * @deprecated Use {@link #evaluateExpression(Expression,
CompilerConfiguration, GroovyClassLoader)} instead
+ */
+@Deprecated
+public static Object evaluateExpression(final Expression expr, final
CompilerConfiguration config) {
Review Comment:
*[InlineMeSuggester](https://errorprone.info/bugpattern/InlineMeSuggester):*
This deprecated API looks inlineable. If you'd like the body of the API to be
inlined to its callers, please annotate it with @InlineMe.
---
```suggestion
@InlineMe(replacement =
"StaticTypeCheckingSupport.evaluateExpression(expr, config, null)", imports =
"org.codehaus.groovy.transform.stc.StaticTypeCheckingSupport")
```
---
ℹ️ Learn about @sonatype-lift commands
You can reply with the following commands. For example, reply with
***@sonatype-lift ignoreall*** to leave out all findings.
| **Command** | **Usage** |
| - | - |
| `@sonatype-lift ignore` | Leave out the above finding from this PR |
| `@sonatype-lift ignoreall` | Leave out all the existing findings from this
PR |
| `@sonatype-lift exclude ` | Exclude specified
`file\|issue\|path\|tool` from Lift findings by updating your config.toml file |
**Note:** When talking to LiftBot, you need to **refresh** the page to see
its response.
[Click here](https://github.com/apps/sonatype-lift/installations/new)
to add LiftBot to another repo.
---
Was this a good recommendation?
[ [🙁 Not
relevant](https://www.sonatype.com/lift-comment-rating?comment=351125067&lift_comment_rating=1)
] - [ [😕 Won't
fix](https://www.sonatype.com/lift-comment-rating?comment=351125067&lift_comment_rating=2)
] - [ [😑 Not critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=351125067&lift_comment_rating=3)
] - [ [🙂 Critical, will
fix](https://www.sonatype.com/lift-comment-rating?comment=351125067&lift_comment_rating=4)
] - [ [😊 Critical, fixing
now](https://www.sonatype.com/lift-comment-rating?comment=351125067&lift_comment_rating=5)
]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
