[GitHub] groovy pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/a7ebe87b8cb4ff7ce220a13af96788118d316006#commitcomment-30426446 In subprojects/groovy-test-junit5/build.gradle: In subprojects/groovy-test-junit5/build.gradle on line 28: Platform dependencies should be updated to `1.3.0` (to match jupiter dependencies `5.3.0`). ---
[GitHub] groovy pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/a7ebe87b8cb4ff7ce220a13af96788118d316006#commitcomment-30427718 In subprojects/groovy-test-junit5/build.gradle: In subprojects/groovy-test-junit5/build.gradle on line 28: Great! Thanks! ---
[GitHub] groovy pull request #808: Documentation for @TailRecursive
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/groovy/pull/808#discussion_r224093386 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -1985,7 +1985,19 @@ _protectedCacheSize>0_ would create an unlimited cache with some results protect [[xform-TailRecursive]] = `@groovy.transform.TailRecursive` -TBD +The `@TailRecursive` annotation can be used to automatically transform a recursive call in the end of a method to an +iterative version of the same code, to avoid stack overflow due to to many recursive calls. Below is an example of --- End diff -- `to to many` should be `to too many` I guess. ---
[GitHub] groovy pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/e21d6226b9a4cc411fb0e7d24cf7b6023edc9002#commitcomment-18124607 Nice :+1: I thought nobody would ever fix these tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request #442: GROOVY-7953: property expressions for extension me...
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/groovy/pull/442#discussion_r82509499 --- Diff: src/spec/test-resources/META-INF/services/org.codehaus.groovy.runtime.ExtensionModule --- @@ -17,5 +17,5 @@ # IT IS A WORKAROUND FOR 2 DESCRIPTORS ON CLASSPATH! moduleName=Test module moduleVersion=1.0-test -extensionClasses=support.MaxRetriesExtension,org.codehaus.groovy.runtime.m12n.TestStringExtension,org.codehaus.groovy.runtime.m12n.Groovy6496Extension +extensionClasses=support.MaxRetriesExtension,org.codehaus.groovy.runtime.m12n.TestStringExtension,org.codehaus.groovy.runtime.m12n.Groovy6496Extension,,org.codehaus.groovy.runtime.m12n.TestPrimitiveWrapperExtension --- End diff -- superfluous comma --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request #132: GROOVY-7502: Add IOGroovyMethods.getText(ByteArray...
Github user PascalSchumacher closed the pull request at: https://github.com/apache/groovy/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request #526: cleanup now that jdk7 is baseline
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/groovy/pull/526 cleanup now that jdk7 is baseline for master and the GROOVY_2_5_X branch You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/incubator-groovy jdk7_clean_up Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/526.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #526 commit 5c66ccd5bda414aac634b02d5977d3b122d765e3 Author: PascalSchumacher Date: 2017-04-21T18:27:22Z cleanup now that jdk7 is baseline --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request #527: remove skipping of tests for builds.apache.org as ...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/groovy/pull/527 remove skipping of tests for builds.apache.org as we no longer use it even groovy decides to use builds.apache.org again, these workarounds may not be necessary today You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/incubator-groovy remove_builds_apache_org_workarounds Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/527.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #527 commit 6455da24690981b6166de6b134526e437fdacbc4 Author: PascalSchumacher Date: 2017-04-23T09:04:00Z remove skipping of tests for builds.apache.org as we no longer use it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21962912 test fails on travis, see: https://travis-ci.org/apache/groovy/builds/227402483?utm_source=github_status&utm_medium=notification --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21966439 @danielsun1106 So is it a bug in the new groovy parser? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219131 In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java: In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java on line 62: Shouldn't this be final? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request #:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219191 In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java: In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java on line 62: Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request: GROOVY-7074: DelegatingScript does not work w...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/groovy/pull/216 GROOVY-7074: DelegatingScript does not work with Builder as delegate Patch supplied by Jochen Kemnade You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/incubator-groovy GROOVY-7074 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/216.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #216 commit d2b9a05a4db922dfefcd9c1b04593758cdc02ad1 Author: PascalSchumacher Date: 2015-12-20T12:47:22Z GROOVY-7074: DelegatingScript does not work with Builder as delegate Patch supplied by Jochen Kemnade --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/606891d85bedbda8139882f41eef531f5752d99f#commitcomment-15434092 I guess this could/should also be merged into 2.4.x What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/2e7c69dc4d185dc790b7d15857235458ef3eb7a6#commitcomment-15660685 Thanks! Sorry for not checking before merging the pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/f7be98a084cf3d6b8a82cae05fa1ec32f7ed7029#commitcomment-15849840 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/efee13bd34862dbcbdebf79254043664861eb2df#commitcomment-15849844 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/53ac431f807f629ad49bfb91a511ff95b42828ca#commitcomment-15849845 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request: GROOVY-7640:AST Builder should include superc...
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/groovy/pull/284 GROOVY-7640:AST Builder should include superclass properties The code is really ugly, but this is caused by a method with is in `BuilderASTTransformation` but should have been in `ExternalStrategy`. No it can not be moved/modified without breaking binary compatibility. The pull request is still missing documentation. I will add that if it is accepted. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/incubator-groovy 7640_superclass_prop Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/284.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #284 commit 18710b9b155646b9de00d821b12db933311503b7 Author: Marc Bogaerts Date: 2015-10-20T15:14:43Z GROOVY-7640:AST Builder should include superclass properties commit fee48bd65d8bf72b440dd66ee5c9735526f060ea Author: PascalSchumacher Date: 2016-03-06T17:30:12Z GROOVY-7640:AST Builder should include superclass properties (closes #152) make it configurable and make it clear that SimpleStrategy does not support this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request: Add jaxb marshalling support
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/groovy/pull/255#discussion_r55146104
--- Diff:
subprojects/groovy-xml/src/main/groovy/groovy/xml/jaxb/JaxbGroovyMethods.groovy
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package groovy.xml.jaxb
+
+import groovy.transform.CompileStatic
+
+import javax.xml.bind.JAXBContext
+import javax.xml.bind.Marshaller
+import javax.xml.bind.Unmarshaller
+
+/**
+ * This class defines methods which simplifies marshalling object to
+ * {@link String} containing xml and unmarshalling xml in {@link String}
to object.
+ *
+ * @author Dominik Przybysz
+ */
+@CompileStatic
+class JaxbGroovyMethods {
--- End diff --
Hi Dominik,
can you please add some javadoc to the methods?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request: Add jaxb marshalling support
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/groovy/pull/255#discussion_r55146131
--- Diff:
subprojects/groovy-xml/src/test/groovy/groovy/xml/jaxb/JaxbGroovyMethodsTest.groovy
---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package groovy.xml.jaxb
+
+import javax.xml.bind.JAXBContext
+
+/**
+ * Test cases for {@link JaxbGroovyMethods}
+ *
+ * @author Dominik Przybysz
+ */
+class JaxbGroovyMethodsTest extends GroovyTestCase {
+JAXBContext jaxbContext = JAXBContext.newInstance(Person)
+Person p = new Person(name: 'JT', age: 20)
+
+void
testMarshallAndUnmarshallObjectUsingCategoryOnMarshallerAndUnmarshaller() {
+String xml = jaxbContext.createMarshaller().marshal(p)
+assert jaxbContext.createUnmarshaller().unmarshal(xml, Person) == p
+}
+
+void testMarshallAndUnmarshallObjectUsingCategoryOnJaxbContext() {
--- End diff --
These test should be renamed, because there is no `Category` anymore.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] groovy pull request:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/a0aed6c6e523d176ebd480075d54aa9a3e19b472#commitcomment-16545493 In src/main/org/codehaus/groovy/ast/PropertyNode.java: In src/main/org/codehaus/groovy/ast/PropertyNode.java on line 125: @oreissig I guess this was a mistake? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/a0aed6c6e523d176ebd480075d54aa9a3e19b472#commitcomment-16545765 In src/main/org/codehaus/groovy/ast/PropertyNode.java: In src/main/org/codehaus/groovy/ast/PropertyNode.java on line 125: o.k. thanks for the explanation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/a0aed6c6e523d176ebd480075d54aa9a3e19b472#commitcomment-16545920 In src/main/org/codehaus/groovy/ast/PropertyNode.java: In src/main/org/codehaus/groovy/ast/PropertyNode.java on line 125: If you take a look at the history: https://github.com/apache/groovy/blame/a0aed6c6e523d176ebd480075d54aa9a3e19b472/src/main/org/codehaus/groovy/ast/PropertyNode.java you can see that it was added ten years ago. It probably was used years ago. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request:
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/a0aed6c6e523d176ebd480075d54aa9a3e19b472#commitcomment-16546079 In src/main/org/codehaus/groovy/ast/PropertyNode.java: In src/main/org/codehaus/groovy/ast/PropertyNode.java on line 125: Already done: https://github.com/apache/groovy/commit/83891b6dc09be0a40ce1ce7cb2a48f2524ac43e1 but thanks for the offer. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] groovy pull request: GROOVY-7793: Compiler compiles class with pri...
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/groovy/pull/328#discussion_r62416234 --- Diff: src/test/org/codehaus/groovy/classgen/ClassCompletionVerifierTest.java --- @@ -73,13 +73,22 @@ "Method 'prom' is protected but should be public in interface 'zzz'."; private static final String EXPECTED_PRIVATE_METHOD_ERROR_MESSAGE = "Method 'prim' is private but should be public in interface 'zzz'."; +private static final String EXPECTED_ABSTRACT_PRIVATE_METHOD_ERROR_MESSAGE = +"Method 'y' from class 'X' must not be private as it is declared as abstract method."; --- End diff -- Should this be "... as an abstract method"? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
