[GitHub] [groovy] paulk-asert commented on a diff in pull request #1915: GROOVY-11127: Set operator extension methods
paulk-asert commented on code in PR #1915: URL: https://github.com/apache/groovy/pull/1915#discussion_r1271788471 ## src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java: ## @@ -10734,6 +10734,258 @@ public static boolean disjoint(Iterable left, Iterable right) { return true; } +/** + * Create a Collection composed of the union of both collections. Any + * elements that exist in either collections are added to the resultant collection, such + * that no elements are duplicated in the resultant collection. + * For collections of custom objects; the objects should implement java.lang.Comparable + * assert [1,2,3,4,5,6.7,8] == [1,2,3,4,5].union([4,5,6,7,8]) Review Comment: I added a commit to fix this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [groovy] paulk-asert commented on a diff in pull request #1915: GROOVY-11127: Set operator extension methods
paulk-asert commented on code in PR #1915: URL: https://github.com/apache/groovy/pull/1915#discussion_r1271691328 ## src/main/java/org/codehaus/groovy/runtime/DefaultGroovyMethods.java: ## @@ -10734,6 +10734,258 @@ public static boolean disjoint(Iterable left, Iterable right) { return true; } +/** + * Create a Collection composed of the union of both collections. Any + * elements that exist in either collections are added to the resultant collection, such + * that no elements are duplicated in the resultant collection. + * For collections of custom objects; the objects should implement java.lang.Comparable + * assert [1,2,3,4,5,6.7,8] == [1,2,3,4,5].union([4,5,6,7,8]) Review Comment: typo? "6.7" instead of "6,7" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@groovy.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org