[GitHub] groovy pull request #432: GROOVY-7909 Calling parents method from trait usin...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/432


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request #432: GROOVY-7909 Calling parents method from trait usin...

[blindpirate]

Github user blindpirate commented on a diff in the pull request:

https://github.com/apache/groovy/pull/432#discussion_r83548596
  
--- Diff: 
src/main/org/codehaus/groovy/transform/trait/SuperCallTraitTransformer.java ---
@@ -36,13 +38,19 @@
 
 import java.util.List;
 
+import static org.objectweb.asm.Opcodes.ACC_ABSTRACT;
+import static org.objectweb.asm.Opcodes.ACC_PUBLIC;
+import static org.objectweb.asm.Opcodes.ACC_STATIC;
+import static org.objectweb.asm.Opcodes.ACC_SYNTHETIC;
+
 /**
  * This transformer is used to transform calls to 
SomeTrait.super.foo() into the appropriate trait call.
  *
  * @author Cédric Champeau
  * @since 2.3.0
  */
 class SuperCallTraitTransformer extends ClassCodeExpressionTransformer {
+public static final String UNRESOLVED_HELPER_CLASS = 
"UNRESOLVED_HELPER_CLASS";
--- End diff --

Yes, I haven't realize it. Done as you say.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request #432: GROOVY-7909 Calling parents method from trait usin...

[jwagenleitner]

Github user jwagenleitner commented on a diff in the pull request:

https://github.com/apache/groovy/pull/432#discussion_r83546094
  
--- Diff: 
src/main/org/codehaus/groovy/transform/trait/SuperCallTraitTransformer.java ---
@@ -36,13 +38,19 @@
 
 import java.util.List;
 
+import static org.objectweb.asm.Opcodes.ACC_ABSTRACT;
+import static org.objectweb.asm.Opcodes.ACC_PUBLIC;
+import static org.objectweb.asm.Opcodes.ACC_STATIC;
+import static org.objectweb.asm.Opcodes.ACC_SYNTHETIC;
+
 /**
  * This transformer is used to transform calls to 
SomeTrait.super.foo() into the appropriate trait call.
  *
  * @author Cédric Champeau
  * @since 2.3.0
  */
 class SuperCallTraitTransformer extends ClassCodeExpressionTransformer {
+public static final String UNRESOLVED_HELPER_CLASS = 
"UNRESOLVED_HELPER_CLASS";
--- End diff --

This is only used in the same package, I think package-private would be 
better than public.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request #432: GROOVY-7909 Calling parents method from trait usin...

[jwagenleitner]

Github user jwagenleitner commented on a diff in the pull request:

https://github.com/apache/groovy/pull/432#discussion_r82406821
  
--- Diff: src/test/groovy/bugs/Groovy7909Bug.groovy ---
@@ -0,0 +1,57 @@
+package groovy.bugs
--- End diff --

Could you add the license header to this file, should be able to grab it 
from another file in the same package.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request #432: GROOVY-7909 Calling parents method from trait usin...

[blindpirate]

GitHub user blindpirate opened a pull request:

https://github.com/apache/groovy/pull/432

GROOVY-7909 Calling parents method from trait using Parent.super.method() 
fail depending on trait declaration order 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/blindpirate/groovy groovy7909

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/432.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #432


commit 546dd0dcbf4c340624a5ec5a23bc92500e729a54
Author: zhangbo 
Date:   2016-09-26T02:29:16Z

groovy 7909 bug




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---