[GitHub] incubator-groovy pull request: GROOVY-7680: Bump gradle to version...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/192 GROOVY-7680: Bump gradle to version 2.9 (closes #192) You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7680 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/192.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #192 commit 3db427faef89a0fb9bab95d4e5a6a3560b4e67b4 Author: paulk Date: 2015-11-19T06:06:20Z GROOVY-7680: Bump gradle to version 2.9 (closes #192) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7672: TupleConstructor shoul...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/187 GROOVY-7672: TupleConstructor should have only SOURCE retention policy You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7672 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/187.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #187 commit 36d7a58f2b6ad84a6b6b8ac2bcb4bd8cc335bd0b Author: paulk Date: 2015-11-12T04:18:48Z GROOVY-7672: TupleConstructor should have only SOURCE retention policy --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7645: Stub generator unescap...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/168 GROOVY-7645: Stub generator unescapes escaped backslashes in String a⦠â¦nnotation values (closes #168) You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7645 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/168.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7650: CLONE - collectEntries...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/166 GROOVY-7650: CLONE - collectEntries throws cryptic error when used wi⦠â¦th split(delimiter, limit) (closes #166) You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7650 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/166.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #166 commit 7be5f9eb1b9cbe07188a96616bc5a3988765dab3 Author: paulk Date: 2015-10-29T00:47:11Z GROOVY-7650: CLONE - collectEntries throws cryptic error when used with split(delimiter, limit) (closes #166) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request:
Github user paulk-asert commented on the pull request: https://github.com/apache/incubator-groovy/commit/643815aa1deec53cf0f775d0eb2e317c85da2526#commitcomment-13937078 Darn, Intellij showed the file as changed after doing 'gradlew wrapper' so I didn't check the contents. I'll fix after work today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request:
Github user paulk-asert commented on the pull request: https://github.com/apache/incubator-groovy/commit/636595690824b7567d5aa8ce2c34419fe0b4d50b#commitcomment-13828633 Nice work Bertrand. I liked the approach of having some kind of structure to organize thoughts on whether everything was covered or not and the particular structure seemed pretty close to what is needed too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request:
Github user paulk-asert commented on the pull request: https://github.com/apache/incubator-groovy/commit/8ed5d29ed6cd7384cc34a1e9f3f28e7262b3e3ad#commitcomment-13713804 All good. Love your work! :-) On Mon, Oct 12, 2015 at 4:55 PM, Pascal Schumacher wrote: > Thanks :) > > Sorry that I 'stole' your work. > > I removed most of the Java'isms with 5ad8393 > <https://github.com/apache/incubator-groovy/commit/5ad8393451648ea560b972cce066f9d7fa2e8530> > > â > Reply to this email directly or view it on GitHub > <https://github.com/apache/incubator-groovy/commit/8ed5d29ed6cd7384cc34a1e9f3f28e7262b3e3ad#commitcomment-13710203> > . > --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request:
Github user paulk-asert commented on the pull request: https://github.com/apache/incubator-groovy/commit/8ed5d29ed6cd7384cc34a1e9f3f28e7262b3e3ad#commitcomment-13707371 Nice work. I started working on this on the train this morning on my way into my customer client work before I noticed you had already done it! :-) There are still a couple of costmetic Java'isms we could get rid of at some point: no need for '.class' on Parameterized, semicolons, unneeded returns etc. but low prioirity. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request:
Github user paulk-asert commented on the pull request: https://github.com/apache/incubator-groovy/commit/57719291957e34c409552412304f4c6268ff1735#commitcomment-13707349 Yes, this was removed as part of the MacroGroovy PR (which isn't part of GROOVY_2_4_X). I had to put it back in for master to make the LineColumnChecks work. We'll have to keep an eye out as to whether it affects MacroGroovy or was just removed because it didn't seem to be necessary during MacroGroovy rejigging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7548: @Grab should provide a...
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/83 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7551: groovy-all has a depen...
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7551: groovy-all has a depen...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/91 GROOVY-7551: groovy-all has a dependency on com.googlecode:openbeans ⦠â¦that is not available on Maven Central You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7551 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/91.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #91 commit d414f0c3dc912e81f018fbb7c85e1c56c6f8f3d3 Author: paulk Date: 2015-08-20T03:58:03Z GROOVY-7551: groovy-all has a dependency on com.googlecode:openbeans that is not available on Maven Central --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7548: @Grab should provide a...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/83 GROOVY-7548: @Grab should provide a way to set system properties You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7548 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/83.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #83 commit 4c0d2d2bf4a701ea7d2c12f82f763fe5be50e02c Author: paulk Date: 2015-08-15T06:53:19Z GROOVY-7548: @Grab should provide a way to set system properties --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7540: Add a method to String...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/80 GROOVY-7540: Add a method to StringGroovyMethods for replacing String⦠⦠pairs supplied as a Map You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7540 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/80.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #80 commit 96db0005e8774bc45c4111ad057ece7d09e161c3 Author: Paul King Date: 2015-08-07T10:06:12Z GROOVY-7540: Add a method to StringGroovyMethods for replacing String pairs supplied as a Map --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7529: Fix up transforms (apa...
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7522: TupleConstructor overw...
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request:
Github user paulk-asert commented on the pull request: https://github.com/apache/incubator-groovy/commit/971cee027b34b9e5d92ed6c8cce3c541af0974f6#commitcomment-12485046 In src/test/groovy/bugs/Groovy7520Bug.groovy: In src/test/groovy/bugs/Groovy7520Bug.groovy on line 1: test file needs an Apache header? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7529: Fix up transforms (apa...
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/77#discussion_r36029568
--- Diff: src/spec/doc/core-metaprogramming.adoc ---
@@ -966,6 +966,25 @@
include::{projectdir}/src/spec/test/CodeGenerationASTTransformsTest.groovy[tags=
|===
+[[xform-MapConstructor]]
+= @groovy.transform.MapConstructor
+
+The `@MapConstructor` annotation aims at eliminating boilerplate code by
generating a map constructor for you. A map
--- End diff --
Yes, MapConstructor was missing from the documentation altogether. I added
at least a placeholder but I'll probably try to add the doco in a separate
commit and then rework this PR accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-groovy pull request: GROOVY-7529: Fix up transforms (apa...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/77 GROOVY-7529: Fix up transforms (apart from TupleConstructor) which ar⦠â¦e affected by empty includes default You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7529 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/77.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #77 commit d6f398b344a6cda38f319e061d0ab1257361c1c7 Author: paulk Date: 2015-07-30T12:44:57Z GROOVY-7529: Fix up transforms (apart from TupleConstructor) which are affected by empty includes default --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7522: TupleConstructor overw...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/75 GROOVY-7522: TupleConstructor overwrites empty default constructors You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7522 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/75.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #75 commit 891aaa2f7f11afc4a62f0501ccae550f23c4ff05 Author: Paul King Date: 2015-07-28T13:45:14Z GROOVY-7522: TupleConstructor overwrites empty default constructors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7523: TupleConstructor with ...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/72 GROOVY-7523: TupleConstructor with empty includes includes all You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7523 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/72.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #72 commit 03c99e456245c5d1866cae8c8b7b89b2d20a6d4a Author: paulk Date: 2015-07-26T08:37:19Z GROOVY-7523: TupleConstructor with empty includes includes all --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7518: hashCode() throws NPE ...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/70 GROOVY-7518: hashCode() throws NPE when using @CompileStatic with @Eq⦠â¦ualsAndHashCode You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7518 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 commit f4c2a91e81ea239303e1e7541d1a350b7fb80cff Author: paulk Date: 2015-07-23T08:41:15Z GROOVY-7518: hashCode() throws NPE when using @CompileStatic with @EqualsAndHashCode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: Groovy7488
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7486: In groovy.util.Node.de...
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7486: In groovy.util.Node.de...
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/59#discussion_r34474352
--- Diff: src/main/groovy/util/Node.java ---
@@ -537,26 +539,40 @@ private NodeList getByName(String name) {
/**
* Provides a collection of all the nodes in the tree
- * using a depth first traversal.
+ * using a depth-first preorder traversal.
*
* @return the list of (depth-first) ordered nodes
*/
public List depthFirst() {
+return depthFirst(true);
+}
+
+/**
+ * Provides a collection of all the nodes in the tree
+ * using a depth-first traversal.
+ *
+ * @param preorder if false, a postorder depth-first traversal will be
performed
--- End diff --
I am not sure I understand where you are going with the BST idea but I have
tweaked the tests a little as per your earlier comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-groovy pull request: GROOVY-7486: In groovy.util.Node.de...
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/59#discussion_r34468918
--- Diff: src/main/groovy/util/Node.java ---
@@ -537,26 +539,40 @@ private NodeList getByName(String name) {
/**
* Provides a collection of all the nodes in the tree
- * using a depth first traversal.
+ * using a depth-first preorder traversal.
*
* @return the list of (depth-first) ordered nodes
*/
public List depthFirst() {
+return depthFirst(true);
+}
+
+/**
+ * Provides a collection of all the nodes in the tree
+ * using a depth-first traversal.
+ *
+ * @param preorder if false, a postorder depth-first traversal will be
performed
--- End diff --
As mentioned in the Jira, I am not aware of any widely used inorder
traversal algorithms for non-binary trees. I have followed some of the computer
science literature/research in that area but not all. Do you have references to
such an algorithm?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-groovy pull request: GROOVY-7486: In groovy.util.Node.de...
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/59#discussion_r34463093
--- Diff: src/test/groovy/tree/NavigationTest.groovy ---
@@ -57,11 +65,25 @@ class NavigationTest extends GroovyTestCase {
}
b5()
}
-
assert root != null
-
-println(root)
-
return root
}
+
+private static createTreeFromXmlParser() {
+def xml = '''
+
+
+
+
+
+
+
--- End diff --
Good idea, I'll make that change when I get a chance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-groovy pull request:
Github user paulk-asert commented on the pull request: https://github.com/apache/incubator-groovy/commit/ad43ad456b3c9828fc538c95998d9e6509700222#commitcomment-12132192 In src/test/org/codehaus/groovy/runtime/memoize/CacheCleanupCollectedSoftReferencesTest.groovy: In src/test/org/codehaus/groovy/runtime/memoize/CacheCleanupCollectedSoftReferencesTest.groovy on line 26: perhaps the stray fails that have started showing up again on the CI server are triggered by this test - the test gobbling up all of available memory doesn't seem to make the CI server happy - it seems to take longer than the test execution itself to recover sometimes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: Groovy7488
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/61 Groovy7488 You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7488 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/61.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #61 commit 879f14e719d68600caf2ead6c64ed3b820e1b446 Author: Paul King Date: 2015-07-10T22:27:04Z GROOVY-7486: In groovy.util.Node.depthFirst please Provide a way to Specify pre-order, post-order Ordering commit 3235a17ac7ff47ec05ea60866ef10bf1a9472efe Author: paulk Date: 2015-07-13T12:28:50Z GROOVY-7488: Depth 1st and Breath 1st taking a closure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7486: In groovy.util.Node.de...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/59 GROOVY-7486: In groovy.util.Node.depthFirst please Provide a way to S⦠â¦pecify pre-order, post-order Ordering You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7486 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/59.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #59 commit 3c0e00778a0a068f2afc4fff91d665dc79bd4310 Author: Paul King Date: 2015-07-10T22:27:04Z GROOVY-7486: In groovy.util.Node.depthFirst please Provide a way to Specify pre-order, post-order Ordering --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7495: Diamond inheritance of...
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7495: Diamond inheritance of...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/58 GROOVY-7495: Diamond inheritance of interfaces makes method return ty⦠â¦pe incompatible You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7495 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit bdec939be79c133dc4e26837ad9a6b2c7ecd5dda Author: paulk Date: 2015-07-09T07:41:18Z GROOVY-7495: Diamond inheritance of interfaces makes method return type incompatible --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7492: Groovy should allow Co...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/54 GROOVY-7492: Groovy should allow CompileStatic classes to not impleme⦠â¦nt GroovyObject You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7492 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit e7dc41066fb6db3ef0e164040c0665ae50414617 Author: paulk Date: 2015-07-05T09:04:17Z GROOVY-7492: Groovy should allow CompileStatic classes to not implement GroovyObject --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7485: BUG! exception in phas...
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/50 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7416: Problem With CompileSt...
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7479: Groovy should provide ...
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7491: Upgrade Ant to 1.9.6
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7491: Upgrade Ant to 1.9.6
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/52 GROOVY-7491: Upgrade Ant to 1.9.6 You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7491 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/52.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #52 commit 143834e8052eec644886c90b3a0b1d7fdabf4bab Author: Paul King Date: 2015-07-03T07:09:27Z GROOVY-7491: Upgrade Ant to 1.9.6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7485: BUG! exception in phas...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/50 GROOVY-7485: BUG! exception in phase 'semantic analysis'... when tryi⦠â¦ng to call instance method as default for a constructor parameter You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7485 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/50.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #50 commit f53eb3411a4f9ffa574e8dd094ab5f65c3d7833e Author: paulk Date: 2015-07-02T10:35:16Z GROOVY-7485: BUG! exception in phase 'semantic analysis'... when trying to call instance method as default for a constructor parameter --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7018 GroovyClassLoader addCl...
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/43#discussion_r33632554
--- Diff: src/main/groovy/ui/GroovyMain.java ---
@@ -391,17 +391,16 @@ public String getText(String uriOrFilename) throws
IOException {
protected GroovyCodeSource getScriptSource(boolean isScriptFile,
String script) throws IOException, URISyntaxException {
//check the script is currently valid before starting a server
against the script
if (isScriptFile) {
-if (uriPattern.matcher(script).matches()) {
+// search for the file and if it exists don't try to use URIs
...
+File scriptFile = huntForTheScriptFile(script);
+if (!scriptFile.exists() &&
uriPattern.matcher(script).matches()) {
return new GroovyCodeSource(new URI(script));
-} else {
-return new GroovyCodeSource(huntForTheScriptFile(script));
}
-} else {
-return new GroovyCodeSource(script,
"script_from_command_line", GroovyShell.DEFAULT_CODE_BASE);
+return new GroovyCodeSource(huntForTheScriptFile(script));
--- End diff --
can't you just use "scriptFile" instead of the second call to
"huntForTheScriptFile"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-groovy pull request: GROOVY-7479: Groovy should provide ...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/48 GROOVY-7479: Groovy should provide "inits" and "tails" DGM methods fo⦠â¦r lists You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7479 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/48.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #48 commit ef8ebc001198059df57ec7e77128baca6511a7c7 Author: Paul King Date: 2015-06-29T12:02:25Z GROOVY-7479: Groovy should provide "inits" and "tails" DGM methods for lists --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7477: CompileStatic-related ...
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7477: CompileStatic-related ...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/47 GROOVY-7477: CompileStatic-related "BUG! exception in phase 'instruct⦠â¦ion selection'" You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7477 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/47.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #47 commit d7b8727e20acd75a2876534841075d528d991d2b Author: Paul King Date: 2015-06-27T01:01:35Z GROOVY-7477: CompileStatic-related "BUG! exception in phase 'instruction selection'" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-5185: Cast operator preceden...
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-5185: Cast operator preceden...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/42 GROOVY-5185: Cast operator precedence is incorrect I think this rolls back the prod code changes from GROOVY-2605 but we may have done other changes in the meantime since the tests for the issue seem to all still pass. You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy5185 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/42.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #42 commit 3b9f239790482931a9651cb18c4f0aeeb40ef116 Author: Paul King Date: 2015-06-23T05:26:02Z GROOVY-5185: Cast operator precedence is incorrect --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request:
Github user paulk-asert commented on the pull request: https://github.com/apache/incubator-groovy/commit/daac89dd587aadf6e21fb7b95bbab06e07976fbf#commitcomment-11779003 Please see: https://issues.apache.org/jira/browse/GROOVY-7470 It would be great if you could action. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-4811: exception while compil...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/41 GROOVY-4811: exception while compiling annotation type You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy4811 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/41.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #41 commit a7a5bc062640d66f42731761c2a59996276d47bb Author: Paul King Date: 2015-06-18T08:32:54Z GROOVY-4811: exception while compiling annotation type --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request:
Github user paulk-asert commented on the pull request: https://github.com/apache/incubator-groovy/commit/1bb5c5a92f4992bf3b5a1cf192fb295544e5415b#commitcomment-11676838 As much as the geek in me thinks it's cool to hide the binaries in source, I have to agree with Bertrand's email that it doesn't really put us in a better position, so I'd be in favor of a revert. I think it would be better to get the RAT exclusion mechanism working and exclude that way. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7377: Interpolated variable ...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/40 GROOVY-7377: Interpolated variable followed by asterisk in slashy-str⦠â¦ing causes compiler error You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7377 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/40.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #40 commit ff6917d65ec726119addca93ae8602e86039527f Author: Paul King Date: 2015-06-11T10:26:00Z GROOVY-7377: Interpolated variable followed by asterisk in slashy-string causes compiler error --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request:
Github user paulk-asert commented on the pull request: https://github.com/apache/incubator-groovy/commit/3e723c81d8abc1eab5147d19a2f90fb4745f9b07#commitcomment-11581325 I tend to run "gradlew wrapper". Then you get the latest wrapper jar as well as a fresh properties file. Granted the wrapper jar probably doesn't change too often. But both are excluded from the source zip in any case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request:
Github user paulk-asert commented on the pull request: https://github.com/apache/incubator-groovy/commit/3e723c81d8abc1eab5147d19a2f90fb4745f9b07#commitcomment-11578430 gradle-wrapper.properties is a generated file, so I would be inclined not to add the header - it will disappear next time we re-generate. If we uncomment *.properties, I'd explicitly add "wrapper" back into the exclusions since we exclude that directory from the source zip in any case --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request:
Github user paulk-asert commented on the pull request: https://github.com/apache/incubator-groovy/commit/ee779e34a42442dc75ebd0614399c443e3732af5#commitcomment-11578380 typo: Runing -> Running but let's not waste too much time hacking around with the command line integration we should use a gradle plugin, e.g.: https://github.com/apache/samza/blob/master/gradle/rat.gradle but currently only consumable by copying source? or failing that we can hook into the ant integration: http://creadur.apache.org/rat/apache-rat-tasks/ http://creadur.apache.org/rat/apidocs/org/apache/rat/anttasks/package-frame.html --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7459: leverage Ant javadoc f...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/35 GROOVY-7459: leverage Ant javadoc fix rather than have our own copy o⦠â¦f Oracle fix class You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7459 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/35.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #35 commit 7f1b4b040c3dcf7208397bbf7bda99deda5e71e2 Author: Paul King Date: 2015-06-08T05:34:32Z GROOVY-7459: leverage Ant javadoc fix rather than have our own copy of Oracle fix class --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7428: Change precedence prio...
Github user paulk-asert closed the pull request at: https://github.com/apache/incubator-groovy/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request:
Github user paulk-asert commented on the pull request: https://github.com/apache/incubator-groovy/commit/37a8cbde92d183e67b8b0a23de615576a5e47f46#commitcomment-11494315 And he's in! :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-6212: SpreadExpression BUG! ...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/30 GROOVY-6212: SpreadExpression BUG! when slicing a List You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy6212 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/30.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #30 commit 1e34509199f3b23c1ee6de7f4a6b6e1b8407cfaf Author: Paul King Date: 2015-06-01T00:43:49Z GROOVY-6212: SpreadExpression BUG! when slicing a List --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7440: Improve ClosureParam t...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/27 GROOVY-7440: Improve ClosureParam type hints for various splitEachLin⦠â¦e GroovyMethod methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7440 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/27.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #27 commit 01d4a7afd33863dbd88bbe15e2ab01345a55b502 Author: Paul King Date: 2015-05-30T01:34:10Z GROOVY-7440: Improve ClosureParam type hints for various splitEachLine GroovyMethod methods --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7434: Groovy should support ...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/24 GROOVY-7434: Groovy should support resolving ambiguous signatures whe⦠â¦n using ClosureParams You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7434 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/24.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #24 commit 343282d2faa471d79615d1af50aeba09d81cc841 Author: Paul King Date: 2015-05-25T11:49:08Z GROOVY-7434: Groovy should support resolving ambiguous signatures when using ClosureParams --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7416: Problem With CompileSt...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/23 GROOVY-7416: Problem With CompileStatic And Interface Methods In Abst⦠â¦ract Subclass You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7416 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/23.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #23 commit 2dfddc67affc26727f9f09b1f1eda8c4b4df3c09 Author: Paul King Date: 2015-05-23T04:27:44Z GROOVY-7416: Problem With CompileStatic And Interface Methods In Abstract Subclass --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7227 AST transformations rel...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/22 GROOVY-7227 AST transformations relating to properties/fields should validate their includes/excludes lists Ported (copied and reworked for recent changes) from the old repo: https://github.com/groovy/groovy-core/pull/569 You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7227 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/22.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22 commit 1a320e92682a779e06bffcb77b24a0dbc3e24771 Author: John Hurst Date: 2014-12-28T02:17:50Z Fixes and tests for getting AST transforms relating to bean properties to validate their includes/excludes lists. commit fd3ce1a625ce92aae41a8339a7a77533c883f964 Author: John Hurst Date: 2014-12-28T04:41:59Z Removed commented-out code. commit eb3d8df6a6c1fda51b6b67d146d4905fc77cb4a9 Author: Paul King Date: 2015-05-22T13:50:14Z GROOVY-7227: AST transformations relating to properties/fields should validate their includes/excludes lists --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-6319: Canonical annotation s...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/21 GROOVY-6319: Canonical annotation should allow property names in toSt⦠â¦ring You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy6319 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/21.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21 commit d2f625482b3fa78d68c02b31140bea0d24414456 Author: Paul King Date: 2015-05-20T11:52:07Z GROOVY-6319: Canonical annotation should allow property names in toString --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7353: Groovy should provide ...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/20 GROOVY-7353: Groovy should provide a MapConstructor AST transform You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7353 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/20.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #20 commit bc4be4ddea107eacdcf4915f13e52bf6b4e7feb5 Author: Paul King Date: 2015-05-20T02:10:46Z GROOVY-7353: Groovy should provide a MapConstructor AST transform --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7428: Change precedence prio...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/18 GROOVY-7428: Change precedence priority of ** compared to pre/post in⦠â¦c/dec and unary plus/minus You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7428 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit a0afb0e814bdaec656fa48e53d417b0bb7051348 Author: Paul King Date: 2015-05-18T22:04:34Z GROOVY-7428: Change precedence priority of ** compared to pre/post inc/dec and unary plus/minus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7425: Adding 'getBytes(Map p...
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/16#discussion_r30414852
--- Diff: src/test/org/codehaus/groovy/runtime/URLGetBytesTest.groovy ---
@@ -0,0 +1,114 @@
+/*
+ * Copyright 2003-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.codehaus.groovy.runtime
+
+/**
+ * Tests for {@link DefaultGroovyMethods} URL.getBytes() methods.
+ *
+ */
+class URLGetBytesTest extends GroovyTestCase {
+void testGetBytesFromURLWithParameters() {
+def url = new URL('http','groovy.codehaus.org',80, '/', new
URLStreamHandler() {
--- End diff --
I know it's a dummy URLConnection but I'd probably change
groovy.codehaus.org to groovy-lang.org.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-groovy pull request: GROOVY-7425: Adding 'getBytes(Map p...
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/16#discussion_r30414765
--- Diff: src/test/org/codehaus/groovy/runtime/URLGetBytesTest.groovy ---
@@ -0,0 +1,114 @@
+/*
+ * Copyright 2003-2015 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.codehaus.groovy.runtime
+
+/**
+ * Tests for {@link DefaultGroovyMethods} URL.getBytes() methods.
+ *
+ */
+class URLGetBytesTest extends GroovyTestCase {
+void testGetBytesFromURLWithParameters() {
+def url = new URL('http','groovy.codehaus.org',80, '/', new
URLStreamHandler() {
+@Override
+protected URLConnection openConnection(URL u) {
+new DummyURLConnection(new
URL('http://groovy.codehaus.org'))
+}
+
+})
+
+assert url.bytes == 'Groovy'.bytes
+
+shouldFail(SocketTimeoutException) {
+url.getBytes(readTimeout:5)
+}
+
+shouldFail(SocketTimeoutException) {
+url.getText(connectTimeout:5)
+}
+
+shouldFail(RuntimeException) {
+url.getBytes(allowUserInteraction:true)
+}
+
+assert url.getBytes(useCaches:true) == 'Groovy cached'.bytes
+
+assert url.getBytes(requestProperties:[a:'b']) == 'Groovy
a:b'.bytes
+
+assert url.getBytes(useCaches:true, requestProperties:[a:'b']) ==
'Groovy cached a:b'.bytes
+
+assert url.getBytes() == url.getBytes()
--- End diff --
What are you trying to test with this line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-groovy pull request: GROOVY-7425: Adding 'getBytes(Map p...
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/incubator-groovy/pull/16#discussion_r30414741 --- Diff: src/main/org/codehaus/groovy/runtime/ResourceGroovyMethods.java --- @@ -694,6 +694,29 @@ public static String getText(URL url, Map parameters, String charset) throws IOE } /** + * Read the content of this URL and returns it as a byte[]. + * The default connection parameters can be modified by adding keys to the + * parameters map: + * + * connectTimeout : the connection timeout + * readTimeout : the read timeout + * useCaches : set the use cache property for the URL connection + * allowUserInteraction : set the user interaction flag for the URL connection + * requestProperties : a map of properties to be passed to the URL connection + * + * + * @param urlURL to read content from + * @param parameters connection parameters + * @return the byte[] from that URL + * @throws IOException if an IOException occurs. + * @since 2.4.1 --- End diff -- 2.4.4 is our next planned release for the 2_4_X stream, so that would be the since version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: Access to Method parameter names at...
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/15#discussion_r30281069
--- Diff: src/main/groovy/ui/GroovyMain.java ---
@@ -305,6 +310,7 @@ private static boolean process(CommandLine line) throws
ParseException, IOExcept
main.isScriptFile = !line.hasOption('e');
main.debug = line.hasOption('d');
main.conf.setDebug(main.debug);
+main.conf.setParameters(line.hasOption("pa") ||
System.getProperty("parameters") != null);
--- End diff --
We wouldn't normally check system properties here but rather in
CompilerConfiguration#configure. We'd also normally prefix properties e.g. like
"groovy.parameters" unless Java is already using something without a java
prefix in which case we might use directly what Java uses.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-groovy pull request: GROOVY-7422: @AnnotationCollector s...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/14 GROOVY-7422: @AnnotationCollector should provide more control over wh⦠â¦ere collected annotations are placed You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7422 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/14.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #14 commit cd1c452f71ff816da0b88dbad410160ed5e059cc Author: Paul King Date: 2015-05-12T12:26:44Z GROOVY-7422: @AnnotationCollector should provide more control over where collected annotations are placed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-groovy pull request: GROOVY-7394: @ToString could suppor...
GitHub user paulk-asert opened a pull request: https://github.com/apache/incubator-groovy/pull/2 GROOVY-7394: @ToString could support non-field properties You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/incubator-groovy groovy7394 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-groovy/pull/2.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2 commit 9c70fd45857e563e5fd9fc77bcaac2a8f46dc16a Author: Paul King Date: 2015-04-20T10:52:34Z GROOVY-7394: @ToString could support non-field properties --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
