[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10393: IGNITE-18236 Cache objects transformation

2023-01-20 Thread GitBox


NSAmelchev commented on code in PR #10393:
URL: https://github.com/apache/ignite/pull/10393#discussion_r1082732858


##
modules/core/src/main/java/org/apache/ignite/events/EventType.java:
##
@@ -526,6 +526,17 @@ public interface EventType {
  */
 public static final int EVT_CACHE_OBJECT_UNLOCKED = 67;
 
+/**
+ * Built-in event type: cache object was transformed.
+ * 
+ * NOTE: all types in range from 1 to 1000 are reserved for
+ * internal Ignite events and should not be used by user-defined events.
+ *
+ * @see CacheEvent
+ */
+

Review Comment:
   Unnecessary line break



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10393: IGNITE-18236 Cache objects transformation

2023-01-20 Thread GitBox


NSAmelchev commented on code in PR #10393:
URL: https://github.com/apache/ignite/pull/10393#discussion_r1082732023


##
modules/core/src/main/java/org/apache/ignite/events/CacheObjectTransformedEvent.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.events;
+
+import org.apache.ignite.cluster.ClusterNode;
+import org.apache.ignite.lang.IgniteExperimental;
+
+/**
+ *
+ */
+@IgniteExperimental
+public class CacheObjectTransformedEvent extends EventAdapter {
+/** */
+private static final long serialVersionUID = 0L;
+
+/** Original cache object bytes. */
+private final byte[] original;
+
+/** Transformed cache object bytes. */
+private final byte[] transformed;
+
+/** Restore operation. */
+private final boolean restore;
+
+/**
+ * @param nodeNode.
+ * @param msg Message.
+ * @param typeType.
+ * @param originalOriginal cache object bytes.
+ * @param transformed Transformed cache object bytes.
+ * @param restore Restore operation flag.
+ */
+public CacheObjectTransformedEvent(
+ClusterNode node,
+String msg,
+int type,
+byte[] original,

Review Comment:
   Are these bytes actual without offset?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [ignite] NSAmelchev commented on a diff in pull request #10393: IGNITE-18236 Cache objects transformation

2023-01-20 Thread GitBox


NSAmelchev commented on code in PR #10393:
URL: https://github.com/apache/ignite/pull/10393#discussion_r1082728668


##
modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java:
##
@@ -416,6 +417,9 @@ public class IgniteConfiguration {
 /** Failover SPI. */
 private FailoverSpi[] failSpi;
 
+/** Cache object transform spi. */

Review Comment:
   not an SPI anymore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org