[GitHub] [ignite] xtern commented on a change in pull request #6929: IGNITE-12181 Fixed assertion for non-persisted group in PDS enabled cluster.
xtern commented on a change in pull request #6929: IGNITE-12181 Fixed assertion
for non-persisted group in PDS enabled cluster.
URL: https://github.com/apache/ignite/pull/6929#discussion_r330926644
##
File path:
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/IgnitePdsAtomicCacheHistoricalRebalancingTest.java
##
@@ -61,4 +63,11 @@
if (!walRebalanceInvoked)
throw new AssertionError("WAL rebalance hasn't been invoked.");
}
+
+/** {@inheritDoc} */
+@Test
+@Ignore
+@Override public void testTopologyChangesWithConstantLoadOnInMemoryCache()
{
+// No-op.
+}
Review comment:
I've updated PR, added a new test for mixed configurations of the data
regions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] xtern commented on a change in pull request #6929: IGNITE-12181 Fixed assertion for non-persisted group in PDS enabled cluster.
xtern commented on a change in pull request #6929: IGNITE-12181 Fixed assertion
for non-persisted group in PDS enabled cluster.
URL: https://github.com/apache/ignite/pull/6929#discussion_r330606896
##
File path:
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/IgnitePdsAtomicCacheHistoricalRebalancingTest.java
##
@@ -61,4 +63,11 @@
if (!walRebalanceInvoked)
throw new AssertionError("WAL rebalance hasn't been invoked.");
}
+
+/** {@inheritDoc} */
+@Test
+@Ignore
+@Override public void testTopologyChangesWithConstantLoadOnInMemoryCache()
{
+// No-op.
+}
Review comment:
Because testTopologyChangesWithConstantLoad is the best that I found to
check rebalancing with indexing, but as you may know, historical (WAL)
rebalancing doesn't support for in-memory caches, so test case with in-memory
cache should be ignored somehow.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] xtern commented on a change in pull request #6929: IGNITE-12181 Fixed assertion for non-persisted group in PDS enabled cluster.
xtern commented on a change in pull request #6929: IGNITE-12181 Fixed assertion
for non-persisted group in PDS enabled cluster.
URL: https://github.com/apache/ignite/pull/6929#discussion_r330606896
##
File path:
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/IgnitePdsAtomicCacheHistoricalRebalancingTest.java
##
@@ -61,4 +63,11 @@
if (!walRebalanceInvoked)
throw new AssertionError("WAL rebalance hasn't been invoked.");
}
+
+/** {@inheritDoc} */
+@Test
+@Ignore
+@Override public void testTopologyChangesWithConstantLoadOnInMemoryCache()
{
+// No-op.
+}
Review comment:
Because testTopologyChangesWithConstantLoad is the best that I found to
check complex rebalancing with indexing, but as you may know, historical (WAL)
rebalancing doesn't support for in-memory caches, so test case with in-memory
cache should be ignored somehow.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
