Re: [PR] IGNITE-22735 Sql. Avoid double parsing of sql queries [ignite-3]
korlov42 merged PR #4085: URL: https://github.com/apache/ignite-3/pull/4085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IGNITE-22735 Sql. Avoid double parsing of sql queries [ignite-3]
korlov42 commented on code in PR #4085: URL: https://github.com/apache/ignite-3/pull/4085#discussion_r1679570967 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlToRelConvertor.java: ## @@ -322,4 +324,44 @@ private RelNode convertMerge(SqlMerge call) { relBuilder.build(), LogicalTableModify.Operation.MERGE, targetColumnNameList, null, false); } + +// = Review Comment: done https://issues.apache.org/jira/browse/IGNITE-22755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IGNITE-22735 Sql. Avoid double parsing of sql queries [ignite-3]
ygerzhedovich commented on code in PR #4085: URL: https://github.com/apache/ignite-3/pull/4085#discussion_r1677991630 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlToRelConvertor.java: ## @@ -322,4 +324,44 @@ private RelNode convertMerge(SqlMerge call) { relBuilder.build(), LogicalTableModify.Operation.MERGE, targetColumnNameList, null, false); } + +// = Review Comment: I suggest create a ticket with a patch for Calcite and add mention the ticket here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] IGNITE-22735 Sql. Avoid double parsing of sql queries [ignite-3]
ygerzhedovich commented on code in PR #4085: URL: https://github.com/apache/ignite-3/pull/4085#discussion_r1677985512 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/ParserServiceImpl.java: ## @@ -55,12 +56,23 @@ public ParsedResult parse(String query) { assert queryType != null : normalizedQuery; +AtomicReference holder = new AtomicReference<>(parsedTree); + +@SuppressWarnings("UnnecessaryLocalVariable") ParsedResult result = new ParsedResultImpl( queryType, query, normalizedQuery, parsedStatement.dynamicParamsCount(), -() -> IgniteSqlParser.parse(query, StatementParseResult.MODE).statement() +() -> { +SqlNode ast = holder.getAndSet(null); Review Comment: hacker ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] IGNITE-22735 Sql. Avoid double parsing of sql queries [ignite-3]
korlov42 opened a new pull request, #4085: URL: https://github.com/apache/ignite-3/pull/4085 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ### The Review Checklist - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following: \- There is a single JIRA ticket related to the pull request. \- The web-link to the pull request is attached to the JIRA ticket. \- The JIRA ticket has the Patch Available state. \- The description of the JIRA ticket explains WHAT was made, WHY and HOW. \- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE- Change summary where - number of JIRA issue. - [ ] **Design:** new code conforms with the design principles of the components it is added to. - [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable. - [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed. - [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources. ### Notes - [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org