[jira] [Created] (IOTDB-1274) ./sbin/start-cli.sh -e 'select last * from root.*' Parser error : Msg: 401

2021-03-31 Thread Jira
刘珍 created IOTDB-1274:
-

 Summary: ./sbin/start-cli.sh -e 'select last * from root.*'  
Parser error  : Msg: 401
 Key: IOTDB-1274
 URL: https://issues.apache.org/jira/browse/IOTDB-1274
 Project: Apache IoTDB
  Issue Type: Bug
  Components: Client/CLI
Reporter: 刘珍


0.11.3  9e371454b05f9a0e24fabb2c84f7ce690f14a882

{color:#FF}start-cli.sh -e   SQL contains *   parser error{color}

{color:#FF}Msg: 401: line 1:18 mismatched input 'conf' expecting \{FROM, 
',', '.'}{color}

 

set storage group root.db1;

CREATE TIMESERIES root.db1.tab1.id WITH DATATYPE=INT32, ENCODING=PLAIN

CREATE TIMESERIES root.db1.tab1.name WITH DATATYPE=text, ENCODING=PLAIN

CREATE TIMESERIES root.db1.tab1.age WITH DATATYPE=INT32, ENCODING=PLAIN

CREATE TIMESERIES root.db1.tab1.country WITH DATATYPE=text, ENCODING=PLAIN

CREATE TIMESERIES root.db1.tab1.salary WITH DATATYPE=float, ENCODING=PLAIN

CREATE TIMESERIES root.db1.tab1.other WITH DATATYPE=double, ENCODING=PLAIN

CREATE TIMESERIES root.db1.tab1.student WITH DATATYPE=boolean, ENCODING=PLAIN

 

insert into root.db1.tab1(time,id,name,age,country,salary,other ,student ) 
values(now(),1,'lily',25,'usa',5678.34,7.77,false);

insert into root.db1.tab1(time,id,name,age,country,salary,other ,student ) 
values(now(),2,'lily2',25,'usa',5678.34,7.77,false);

 

./sbin/start-cli.sh{color:#FF} -e{color} 'select last * from root.*'
Msg: 401: line 1:18 mismatched input 'conf' expecting \{FROM, ',', '.'}

 

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IOTDB-1273) Supports Pandas (Python)

2021-03-31 Thread Xiangdong Huang (Jira)


 [ 
https://issues.apache.org/jira/browse/IOTDB-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiangdong Huang reassigned IOTDB-1273:
--

Assignee: Julian Feinauer

> Supports Pandas  (Python)
> -
>
> Key: IOTDB-1273
> URL: https://issues.apache.org/jira/browse/IOTDB-1273
> Project: Apache IoTDB
>  Issue Type: New Feature
>  Components: Client/Python
>Reporter: Xiangdong Huang
>Assignee: Julian Feinauer
>Priority: Major
>
> To easily transform a query result to a [Pandas 
> Dataframe](https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.html)
> the SessionDataSet has a method `.todf()` which consumes the dataset and 
> transforms it to a pandas dataframe.
> Example:
> ```python
> from iotdb.Session import Session
> ip = "127.0.0.1"
> port_ = "6667"
> username_ = 'root'
> password_ = 'root'
> session = Session(ip, port_, username_, password_)
> session.open(False)
> result = session.execute_query_statement("SELECT * FROM root.*")
> # Transform to Pandas Dataset
> df = result.todf()
> session.close()
> # Now you can work with the dataframe
> df = ...
> ```



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IOTDB-1273) Supports Pandas (Python)

2021-03-31 Thread Xiangdong Huang (Jira)
Xiangdong Huang created IOTDB-1273:
--

 Summary: Supports Pandas  (Python)
 Key: IOTDB-1273
 URL: https://issues.apache.org/jira/browse/IOTDB-1273
 Project: Apache IoTDB
  Issue Type: New Feature
  Components: Client/Python
Reporter: Xiangdong Huang


To easily transform a query result to a [Pandas 
Dataframe](https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.html)
the SessionDataSet has a method `.todf()` which consumes the dataset and 
transforms it to a pandas dataframe.

Example:

```python
from iotdb.Session import Session
ip = "127.0.0.1"
port_ = "6667"
username_ = 'root'
password_ = 'root'
session = Session(ip, port_, username_, password_)
session.open(False)
result = session.execute_query_statement("SELECT * FROM root.*")
# Transform to Pandas Dataset
df = result.todf()
session.close()
# Now you can work with the dataframe
df = ...
```



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IOTDB-1272) [Python] the session api does not infer the data as correct type

2021-03-31 Thread Xiangdong Huang (Jira)


 [ 
https://issues.apache.org/jira/browse/IOTDB-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xiangdong Huang reassigned IOTDB-1272:
--

Assignee: Xiangdong Huang

> [Python] the session api does not infer the data as correct type
> 
>
> Key: IOTDB-1272
> URL: https://issues.apache.org/jira/browse/IOTDB-1272
> Project: Apache IoTDB
>  Issue Type: Bug
>  Components: Client/Python
>Affects Versions: 0.11.2
>Reporter: Xiangdong Huang
>Assignee: Xiangdong Huang
>Priority: Major
>
> IoTDB Java session API supports inferring data type, by using 
> `InsertStringRecord`.
> Python API also has a similar API, called `insert_str_record`. 
> However, it does not infer the data type. Instead, it considers all values as 
> strings.
> Reason: 
> the API should generate `gen_insert_str_record_req`, but it generates 
> `gen_insert_record_req` now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IOTDB-1272) [Python] the session api does not infer the data as correct type

2021-03-31 Thread Xiangdong Huang (Jira)
Xiangdong Huang created IOTDB-1272:
--

 Summary: [Python] the session api does not infer the data as 
correct type
 Key: IOTDB-1272
 URL: https://issues.apache.org/jira/browse/IOTDB-1272
 Project: Apache IoTDB
  Issue Type: Bug
  Components: Client/Python
Affects Versions: 0.11.2
Reporter: Xiangdong Huang


IoTDB Java session API supports inferring data type, by using 
`InsertStringRecord`.

Python API also has a similar API, called `insert_str_record`. 

However, it does not infer the data type. Instead, it considers all values as 
strings.

Reason: 

the API should generate `gen_insert_str_record_req`, but it generates 
`gen_insert_record_req` now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IOTDB-1271) Delete the timeseries, the information is wrong,about report 304

2021-03-31 Thread xiaozhihong (Jira)
xiaozhihong created IOTDB-1271:
--

 Summary: Delete the timeseries, the  information is wrong,about 
report 304
 Key: IOTDB-1271
 URL: https://issues.apache.org/jira/browse/IOTDB-1271
 Project: Apache IoTDB
  Issue Type: Bug
  Components: Server
Affects Versions: 0.11.3
 Environment: 192.168.31.50
Reporter: xiaozhihong
 Fix For: 0.11.3


The operation is as follows:(for example)

IoTDB> show timeseries
+--+-+-+++---++--+
| timeseries|alias|storage group|dataType|encoding|compression|tags|attributes|
+--+-+-+++---++--+
| root.ln.wf.double| null| root.ln| INT32| RLE| SNAPPY|null| null|
| root.ln.wf.double.double| null| root.ln| INT32| RLE| SNAPPY|null| null|
| root.ln.wf.double.double1| null| root.ln| INT32| RLE| SNAPPY|null| null|
|root.test.wf02.wt02.status| null| root.test| BOOLEAN| PLAIN| SNAPPY|null| null|
+--+-+-+++---++--+
Total line number = 4
It costs 0.011s
IoTDB> delete timeseries root.ln.*
Msg: 304: org.apache.iotdb.db.exception.metadata.PathNotExistException: Path 
[root.ln.wf.double.double] does not exist
IoTDB> show timeseries root.ln.wf.double
+--+-+-+++---++--+
|timeseries|alias|storage group|dataType|encoding|compression|tags|attributes|
+--+-+-+++---++--+
+--+-+-+++---++--+
Empty set.
It costs 0.006s



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IOTDB-1270) Forbid loading tsfile with conflict measurement schemas

2021-03-31 Thread Eric Pai (Jira)


 [ 
https://issues.apache.org/jira/browse/IOTDB-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Pai reassigned IOTDB-1270:
---

Assignee: Eric Pai

> Forbid loading tsfile with conflict measurement schemas
> ---
>
> Key: IOTDB-1270
> URL: https://issues.apache.org/jira/browse/IOTDB-1270
> Project: Apache IoTDB
>  Issue Type: Improvement
>  Components: Tools/Others
>Reporter: Eric Pai
>Assignee: Eric Pai
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IOTDB-1270) Forbid loading tsfile with conflict measurement schemas

2021-03-31 Thread Eric Pai (Jira)
Eric Pai created IOTDB-1270:
---

 Summary: Forbid loading tsfile with conflict measurement schemas
 Key: IOTDB-1270
 URL: https://issues.apache.org/jira/browse/IOTDB-1270
 Project: Apache IoTDB
  Issue Type: Improvement
  Components: Tools/Others
Reporter: Eric Pai






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IOTDB-1194) Load multiple tsfile in a directory report "cross time partition" error

2021-03-31 Thread Zesong Sun (Jira)


 [ 
https://issues.apache.org/jira/browse/IOTDB-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zesong Sun reassigned IOTDB-1194:
-

Assignee: Yuyuan KANG

> Load multiple tsfile in a directory report "cross time partition" error
> ---
>
> Key: IOTDB-1194
> URL: https://issues.apache.org/jira/browse/IOTDB-1194
> Project: Apache IoTDB
>  Issue Type: Bug
>Reporter: Yuyuan KANG
>Assignee: Yuyuan KANG
>Priority: Major
>  Labels: pull-request-available
> Fix For: 0.12.0, 0.11.3
>
> Attachments: WriteTsFile.java
>
>
> I generated several tsfiles. Generally, one device, one measurement. The 
> total time range is from 0 to 100,000s. I set the partition interval to 
> 3600s. So the tsfiles covers time from 0s to 3599s, 3600s to  7199s, ...
>  
> I tried to use "load " command to load all tsfiles to IoTDB, but the 
> server reported the following error:
> 12:28:16.208 [pool-7-IoTDB-RPC-Client-thread-1] WARN 
> org.apache.iotdb.db.service.TSServiceImpl - meet error while processing 
> non-query. 12:28:16.208 [pool-7-IoTDB-RPC-Client-thread-1] WARN 
> org.apache.iotdb.db.service.TSServiceImpl - meet error while processing 
> non-query. org.apache.iotdb.db.exception.query.QueryProcessException: Cannot 
> load file /home/yuyuankang/Downloads/data3/1615345483026-1-0.tsfile because 
> The data of file /home/yuyuankang/Downloads/data3/1615345483026-1-0.tsfile 
> cross partitions at 
> org.apache.iotdb.db.qp.executor.PlanExecutor.loadFile(PlanExecutor.java:754) 
> at 
> org.apache.iotdb.db.qp.executor.PlanExecutor.operateLoadFiles(PlanExecutor.java:695)
>  at 
> org.apache.iotdb.db.qp.executor.PlanExecutor.processNonQuery(PlanExecutor.java:241)
>  at 
> org.apache.iotdb.db.service.TSServiceImpl.executeNonQuery(TSServiceImpl.java:1161)
>  at 
> org.apache.iotdb.db.service.TSServiceImpl.executeNonQueryPlan(TSServiceImpl.java:1795)
>  at 
> org.apache.iotdb.db.service.TSServiceImpl.executeUpdateStatement(TSServiceImpl.java:1148)
>  at 
> org.apache.iotdb.db.service.TSServiceImpl.executeStatement(TSServiceImpl.java:527)
>  at 
> org.apache.iotdb.service.rpc.thrift.TSIService$Processor$executeStatement.getResult(TSIService.java:2253)
>  at 
> org.apache.iotdb.service.rpc.thrift.TSIService$Processor$executeStatement.getResult(TSIService.java:2233)
>  at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:38) at 
> org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:38) at 
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:313)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run(Thread.java:748)
>  
> The attachment is how I generate tsfiles.
>  
> ps: The time range interval setting in the server and WriteTsFile.java are 
> consistent, 3600 seconds. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IOTDB-1266) SHOW TIMESERIES will only display 2000 timeseries

2021-03-31 Thread Tian Jiang (Jira)


[ 
https://issues.apache.org/jira/browse/IOTDB-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312206#comment-17312206
 ] 

Tian Jiang commented on IOTDB-1266:
---

The case where offset equals zero is simple enough and you can see we did not 
change limit or offset when the offset is 0. But when it is not 0, things 
become rather complicated. If the user wants to skip the first 10 results, how 
does a coordinator know where the first 10 results are? So it cannot let any 
queried node do the skip, since it may skip the desired records. 

> SHOW TIMESERIES will only display 2000 timeseries
> -
>
> Key: IOTDB-1266
> URL: https://issues.apache.org/jira/browse/IOTDB-1266
> Project: Apache IoTDB
>  Issue Type: Improvement
>  Components: Cluster
>Reporter: Yifu Zhou
>Assignee: Yifu Zhou
>Priority: Major
> Fix For: 0.12.0
>
>
> The BUG is in the applyShowTimeseriesLimitOffset method. If there are 1 
> timeseries data, when first time go in this method, and the default limit is 
> 1000, offset is 0, showTimeSeriesResults will only return 1000 timeseries. 
> For the reason that 1 > 1000(limit+offset), so it will do the second 
> iteration. And now offset is set to 1000. Once the offset != 0, it will do 
> plan.setOffset(0) and plan.setLimit(0). So for the second iteration, after 
> return 1000 timeseries from showTimeSeriesResults, it will end. 
> In my opinion, it is useless for the applyShowTimeseriesLimitOffset method... 
> If the default limit is 1000, it means that if we have 1 timeseries, we 
> have to do 10 times iterations, and each iteration we need to fetch the 
> timeseries data from all the servers.
> I think there are two ways, one is to keep this 
> applyShowTimeseriesLimitOffset method and fix the plan.setOffset(0)(I am 
> confused what why we have to set it 0), the other is remove 
> applyShowTimeseriesLimitOffset because I think it is useless...
> Any idea here?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IOTDB-1266) SHOW TIMESERIES will only display 2000 timeseries

2021-03-31 Thread Tian Jiang (Jira)


[ 
https://issues.apache.org/jira/browse/IOTDB-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312191#comment-17312191
 ] 

Tian Jiang commented on IOTDB-1266:
---

Actually, it is also because that limit is also used for fetch size.

Let us look at how show timeseries works first:
When a client executes "SHOW TIMESERIES" without providing any offset and 
limit, to return the results in a paged manner (you cannot simply fetch all 
results and print them all at once, or the display will be extremely 
unfriendly), according to the fetch size (default at 1000), the plan will be 
executed several times with different limits and offsets.
For example, to return the first 1000 results (the first page), the offset and 
limit are set to 0 and 1000 respectively;  to return the second 1000 results 
(the second page), the offset and limit are set to 1000 and 1000... the process 
will keep on until all results are returned (the offset has moved beyond the 
last record).

This multi-pass approach works just fine in the stand-alone version, as all 
timeseries are memory-resident, skipping already-fetched timeseries is not that 
time-consuming (it is still not a good choice though). But in the distributed 
environment, because the coordinator has to gather all results every time 
before applying offset and limit, incurring high performance overhead.

As for the field `limit` and offset, they are designed to support random access 
of the results. For example, "SHOW TIMESERIES LIMIT 10" returns the first 10 
timeseries, while "SHOW TIMESERIES OFFSET 50 LIMIT 100" returns from the 50th 
timeseries to the 149th timeseries.

> SHOW TIMESERIES will only display 2000 timeseries
> -
>
> Key: IOTDB-1266
> URL: https://issues.apache.org/jira/browse/IOTDB-1266
> Project: Apache IoTDB
>  Issue Type: Improvement
>  Components: Cluster
>Reporter: Yifu Zhou
>Assignee: Yifu Zhou
>Priority: Major
> Fix For: 0.12.0
>
>
> The BUG is in the applyShowTimeseriesLimitOffset method. If there are 1 
> timeseries data, when first time go in this method, and the default limit is 
> 1000, offset is 0, showTimeSeriesResults will only return 1000 timeseries. 
> For the reason that 1 > 1000(limit+offset), so it will do the second 
> iteration. And now offset is set to 1000. Once the offset != 0, it will do 
> plan.setOffset(0) and plan.setLimit(0). So for the second iteration, after 
> return 1000 timeseries from showTimeSeriesResults, it will end. 
> In my opinion, it is useless for the applyShowTimeseriesLimitOffset method... 
> If the default limit is 1000, it means that if we have 1 timeseries, we 
> have to do 10 times iterations, and each iteration we need to fetch the 
> timeseries data from all the servers.
> I think there are two ways, one is to keep this 
> applyShowTimeseriesLimitOffset method and fix the plan.setOffset(0)(I am 
> confused what why we have to set it 0), the other is remove 
> applyShowTimeseriesLimitOffset because I think it is useless...
> Any idea here?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IOTDB-1269) print-tsfile-sketch tool throw exception when prase one tsfile

2021-03-31 Thread Eric Pai (Jira)


 [ 
https://issues.apache.org/jira/browse/IOTDB-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Pai reassigned IOTDB-1269:
---

Assignee: Eric Pai

>  print-tsfile-sketch tool throw exception when prase one tsfile
> ---
>
> Key: IOTDB-1269
> URL: https://issues.apache.org/jira/browse/IOTDB-1269
> Project: Apache IoTDB
>  Issue Type: Bug
>Reporter: Houliang Qi
>Assignee: Eric Pai
>Priority: Major
> Attachments: image-2021-03-31-16-35-33-396.png
>
>
> version 0.12-snapshot(master)
> commid id : 2e7a32ed9cc761b2f497397638297dfba46cda6b
>  
> use benchmark insert some records and execute the flush command, then use 
> print-tsfile-sketch.sh tool to prase the tsfile, it will produce the 
> following error.
> !image-2021-03-31-16-35-33-396.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IOTDB-1269) print-tsfile-sketch tool throw exception when prase one tsfile

2021-03-31 Thread Houliang Qi (Jira)
Houliang Qi created IOTDB-1269:
--

 Summary:  print-tsfile-sketch tool throw exception when prase one 
tsfile
 Key: IOTDB-1269
 URL: https://issues.apache.org/jira/browse/IOTDB-1269
 Project: Apache IoTDB
  Issue Type: Bug
Reporter: Houliang Qi
 Attachments: image-2021-03-31-16-35-33-396.png

version 0.12-snapshot(master)

commid id : 2e7a32ed9cc761b2f497397638297dfba46cda6b

 

use benchmark insert some records and execute the flush command, then use 
print-tsfile-sketch.sh tool to prase the tsfile, it will produce the following 
error.

!image-2021-03-31-16-35-33-396.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IOTDB-1266) SHOW TIMESERIES will only display 2000 timeseries

2021-03-31 Thread Yifu Zhou (Jira)


[ 
https://issues.apache.org/jira/browse/IOTDB-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312185#comment-17312185
 ] 

Yifu Zhou commented on IOTDB-1266:
--

So in my opinion, the default plan.getLimit() should be 0. It means that for 
the first iteration, we can fetch all the timeseries from all the servers. So 
we do not need to do the second iteration. If user want to set this plan' 
limit, for example he want to set plan.setLimit() == 1000, so for each server, 
it will return 1000 timeseries, if we have three servers, it will only return 
3000 timeseries and end. Actually it means that we do not need plan.setLimit(0) 
and plan.setOffset(0) and the applyShowTimeseriesLimitOffset() method.. 
Please correct me if my understanding is incorrect..

> SHOW TIMESERIES will only display 2000 timeseries
> -
>
> Key: IOTDB-1266
> URL: https://issues.apache.org/jira/browse/IOTDB-1266
> Project: Apache IoTDB
>  Issue Type: Improvement
>  Components: Cluster
>Reporter: Yifu Zhou
>Assignee: Yifu Zhou
>Priority: Major
> Fix For: 0.12.0
>
>
> The BUG is in the applyShowTimeseriesLimitOffset method. If there are 1 
> timeseries data, when first time go in this method, and the default limit is 
> 1000, offset is 0, showTimeSeriesResults will only return 1000 timeseries. 
> For the reason that 1 > 1000(limit+offset), so it will do the second 
> iteration. And now offset is set to 1000. Once the offset != 0, it will do 
> plan.setOffset(0) and plan.setLimit(0). So for the second iteration, after 
> return 1000 timeseries from showTimeSeriesResults, it will end. 
> In my opinion, it is useless for the applyShowTimeseriesLimitOffset method... 
> If the default limit is 1000, it means that if we have 1 timeseries, we 
> have to do 10 times iterations, and each iteration we need to fetch the 
> timeseries data from all the servers.
> I think there are two ways, one is to keep this 
> applyShowTimeseriesLimitOffset method and fix the plan.setOffset(0)(I am 
> confused what why we have to set it 0), the other is remove 
> applyShowTimeseriesLimitOffset because I think it is useless...
> Any idea here?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IOTDB-1268) correct cluster to iotdb-cluster when pacakging zip files

2021-03-31 Thread Houliang Qi (Jira)
Houliang Qi created IOTDB-1268:
--

 Summary: correct cluster to iotdb-cluster when pacakging zip files
 Key: IOTDB-1268
 URL: https://issues.apache.org/jira/browse/IOTDB-1268
 Project: Apache IoTDB
  Issue Type: Bug
Reporter: Houliang Qi
 Attachments: image-2021-03-31-16-14-10-290.png

The apache-iotdb-0.12.0-SNAPSHOT-all-bin package forget packaging the 
iotdb-cluster.properties confiration file.

 

commit id : 2e7a32ed9cc761b2f497397638297dfba46cda6b

!image-2021-03-31-16-14-10-290.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (IOTDB-1267) optimize ServerTimeGenerator IExpression parameter

2021-03-31 Thread Chao Wang (Jira)
Chao Wang created IOTDB-1267:


 Summary: optimize ServerTimeGenerator IExpression  parameter
 Key: IOTDB-1267
 URL: https://issues.apache.org/jira/browse/IOTDB-1267
 Project: Apache IoTDB
  Issue Type: Improvement
  Components: Core/Engine
Reporter: Chao Wang
Assignee: Chao Wang
 Fix For: 0.12.0


More, in {{public ServerTimeGenerator(IExpression expression, QueryContext 
context, RawDataQueryPlan queryPlan)}} , we should remove {{IExpression 
expression}}, and use {{queryPlan.getExpression}} instead.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IOTDB-1266) SHOW TIMESERIES will only display 2000 timeseries

2021-03-31 Thread Yifu Zhou (Jira)


[ 
https://issues.apache.org/jira/browse/IOTDB-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312158#comment-17312158
 ] 

Yifu Zhou commented on IOTDB-1266:
--

I think the weird logic is at the beginning... Let me explain it clearly:
For example, we have three servers and 10,000 timeseries. In the first 
iteration, plan.getLimit() is 1000(default), so the resultSet will only fetch 
3,000 timeseries, and the showTimeSeriesResults will get 1st to 1,000th 
timeseries(because the limit is 1,000). Then we go to second iteration, now the 
offset != 0 and so plan.setLimit(0) and plan.setOffset(0). So the resultSet 
will fetch all 10,000 timeseries, and return these 10,000 timeseries' 1001th 
and 2000th timeseries and then end.. 
I think the solution is at the beginning, the default plan.getLimit() shoud be 
set to 0 so the first iteration will fetch all the timeseries. But now, I don't 
think why should we have the 'limit' porperty.. 


> SHOW TIMESERIES will only display 2000 timeseries
> -
>
> Key: IOTDB-1266
> URL: https://issues.apache.org/jira/browse/IOTDB-1266
> Project: Apache IoTDB
>  Issue Type: Improvement
>  Components: Cluster
>Reporter: Yifu Zhou
>Assignee: Yifu Zhou
>Priority: Major
> Fix For: 0.12.0
>
>
> The BUG is in the applyShowTimeseriesLimitOffset method. If there are 1 
> timeseries data, when first time go in this method, and the default limit is 
> 1000, offset is 0, showTimeSeriesResults will only return 1000 timeseries. 
> For the reason that 1 > 1000(limit+offset), so it will do the second 
> iteration. And now offset is set to 1000. Once the offset != 0, it will do 
> plan.setOffset(0) and plan.setLimit(0). So for the second iteration, after 
> return 1000 timeseries from showTimeSeriesResults, it will end. 
> In my opinion, it is useless for the applyShowTimeseriesLimitOffset method... 
> If the default limit is 1000, it means that if we have 1 timeseries, we 
> have to do 10 times iterations, and each iteration we need to fetch the 
> timeseries data from all the servers.
> I think there are two ways, one is to keep this 
> applyShowTimeseriesLimitOffset method and fix the plan.setOffset(0)(I am 
> confused what why we have to set it 0), the other is remove 
> applyShowTimeseriesLimitOffset because I think it is useless...
> Any idea here?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)