[jira] [Commented] (IOTDB-1179) spotless check confilcts with the checkstyle of sonar
[ https://issues.apache.org/jira/browse/IOTDB-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294222#comment-17294222 ] sunjincheng commented on IOTDB-1179: Thanks for your feedback, I will close this JIRA. Thank you! > spotless check confilcts with the checkstyle of sonar > - > > Key: IOTDB-1179 > URL: https://issues.apache.org/jira/browse/IOTDB-1179 > Project: Apache IoTDB > Issue Type: Improvement > Components: Core/Others >Reporter: Houliang Qi >Assignee: sunjincheng >Priority: Major > Labels: pull-request-available > Fix For: 0.12.0 > > Attachments: image-2021-03-01-14-38-00-577.png, > image-2021-03-01-14-38-13-642.png, image-2021-03-01-14-38-24-089.png > > > When we submit one pr, the sonar check produces the following error, it's may > due to the spotless check's import order is _org.apache.iotdb,,javax,java,#_ > , while the check style is sortImportsInGroupAlphabetically, they're in > conflict > !image-2021-03-01-14-38-00-577.png! > !image-2021-03-01-14-38-13-642.png! > > !image-2021-03-01-14-38-24-089.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IOTDB-1179) spotless check confilcts with the checkstyle of sonar
[ https://issues.apache.org/jira/browse/IOTDB-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294220#comment-17294220 ] Houliang Qi commented on IOTDB-1179: Thanks, [~sunjincheng121]， I have merged the newest codes and rerun my PR, the import conflicts errors are disappeared. > spotless check confilcts with the checkstyle of sonar > - > > Key: IOTDB-1179 > URL: https://issues.apache.org/jira/browse/IOTDB-1179 > Project: Apache IoTDB > Issue Type: Improvement > Components: Core/Others >Reporter: Houliang Qi >Assignee: sunjincheng >Priority: Major > Labels: pull-request-available > Attachments: image-2021-03-01-14-38-00-577.png, > image-2021-03-01-14-38-13-642.png, image-2021-03-01-14-38-24-089.png > > > When we submit one pr, the sonar check produces the following error, it's may > due to the spotless check's import order is _org.apache.iotdb,,javax,java,#_ > , while the check style is sortImportsInGroupAlphabetically, they're in > conflict > !image-2021-03-01-14-38-00-577.png! > !image-2021-03-01-14-38-13-642.png! > > !image-2021-03-01-14-38-24-089.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IOTDB-1179) spotless check confilcts with the checkstyle of sonar
[ https://issues.apache.org/jira/browse/IOTDB-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294071#comment-17294071 ] sunjincheng commented on IOTDB-1179: Would be great if you can double check that whether your PR can pass the inspection of sonar. :) > spotless check confilcts with the checkstyle of sonar > - > > Key: IOTDB-1179 > URL: https://issues.apache.org/jira/browse/IOTDB-1179 > Project: Apache IoTDB > Issue Type: Improvement > Components: Core/Others >Reporter: Houliang Qi >Assignee: sunjincheng >Priority: Major > Labels: pull-request-available > Attachments: image-2021-03-01-14-38-00-577.png, > image-2021-03-01-14-38-13-642.png, image-2021-03-01-14-38-24-089.png > > > When we submit one pr, the sonar check produces the following error, it's may > due to the spotless check's import order is _org.apache.iotdb,,javax,java,#_ > , while the check style is sortImportsInGroupAlphabetically, they're in > conflict > !image-2021-03-01-14-38-00-577.png! > !image-2021-03-01-14-38-13-642.png! > > !image-2021-03-01-14-38-24-089.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IOTDB-1179) spotless check confilcts with the checkstyle of sonar
[ https://issues.apache.org/jira/browse/IOTDB-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294070#comment-17294070 ] sunjincheng commented on IOTDB-1179: fixed by PR#2762, detail can be find here: https://sonarcloud.io/code?id=apache_incubator-iotdb&selected=apache_incubator-iotdb%3Acluster%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fcluster%2Flog%2FHardState.java > spotless check confilcts with the checkstyle of sonar > - > > Key: IOTDB-1179 > URL: https://issues.apache.org/jira/browse/IOTDB-1179 > Project: Apache IoTDB > Issue Type: Improvement > Components: Core/Others >Reporter: Houliang Qi >Assignee: sunjincheng >Priority: Major > Labels: pull-request-available > Attachments: image-2021-03-01-14-38-00-577.png, > image-2021-03-01-14-38-13-642.png, image-2021-03-01-14-38-24-089.png > > > When we submit one pr, the sonar check produces the following error, it's may > due to the spotless check's import order is _org.apache.iotdb,,javax,java,#_ > , while the check style is sortImportsInGroupAlphabetically, they're in > conflict > !image-2021-03-01-14-38-00-577.png! > !image-2021-03-01-14-38-13-642.png! > > !image-2021-03-01-14-38-24-089.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IOTDB-1179) spotless check confilcts with the checkstyle of sonar
[ https://issues.apache.org/jira/browse/IOTDB-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293538#comment-17293538 ] sunjincheng commented on IOTDB-1179: Thanks for reporting this issue [~houliang], would be great if you can put the sonar check link here :) Import order is our choice. We prefer to import iotdb itself to the front. we may need to change the check rule of sonar. > spotless check confilcts with the checkstyle of sonar > - > > Key: IOTDB-1179 > URL: https://issues.apache.org/jira/browse/IOTDB-1179 > Project: Apache IoTDB > Issue Type: Improvement > Components: Core/Others >Reporter: Houliang Qi >Priority: Major > Attachments: image-2021-03-01-14-38-00-577.png, > image-2021-03-01-14-38-13-642.png, image-2021-03-01-14-38-24-089.png > > > When we submit one pr, the sonar check produces the following error, it's may > due to the spotless check's import order is _org.apache.iotdb,,javax,java,#_ > , while the check style is sortImportsInGroupAlphabetically, they're in > conflict > !image-2021-03-01-14-38-00-577.png! > !image-2021-03-01-14-38-13-642.png! > > !image-2021-03-01-14-38-24-089.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (IOTDB-1179) spotless check confilcts with the checkstyle of sonar
[ https://issues.apache.org/jira/browse/IOTDB-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17292675#comment-17292675 ] Xiangdong Huang commented on IOTDB-1179: [~jincheng] > spotless check confilcts with the checkstyle of sonar > - > > Key: IOTDB-1179 > URL: https://issues.apache.org/jira/browse/IOTDB-1179 > Project: Apache IoTDB > Issue Type: Improvement > Components: Core/Others >Reporter: Houliang Qi >Priority: Major > Attachments: image-2021-03-01-14-38-00-577.png, > image-2021-03-01-14-38-13-642.png, image-2021-03-01-14-38-24-089.png > > > When we submit one pr, the sonar check produces the following error, it's may > due to the spotless check's import order is _org.apache.iotdb,,javax,java,#_ > , while the check style is sortImportsInGroupAlphabetically, they're in > conflict > !image-2021-03-01-14-38-00-577.png! > !image-2021-03-01-14-38-13-642.png! > > !image-2021-03-01-14-38-24-089.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
