Re: [PR] JAMES-2586 Update Guide binding Postgres [james-project]
Arsnael merged PR #2154: URL: https://github.com/apache/james-project/pull/2154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org
Re: [PR] JAMES-2586 Update Guide binding Postgres [james-project]
Arsnael commented on code in PR #2154:
URL: https://github.com/apache/james-project/pull/2154#discussion_r1538522791
##
server/container/guice/mailbox-postgres/src/main/java/org/apache/james/modules/mailbox/PostgresMailboxModule.java:
##
@@ -133,6 +135,7 @@ protected void configure() {
bind(AttachmentMapperFactory.class).to(PostgresMailboxSessionMapperFactory.class);
bind(ReIndexer.class).to(ReIndexerImpl.class);
+bind(MessageIdReIndexer.class).to(MessageIdReIndexerImpl.class);
Review Comment:
As postgres can use Opensearch fo idexing, yes I think we need the task for
reindexing :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
Re: [PR] JAMES-2586 Update Guide binding Postgres [james-project]
quantranhong1999 commented on code in PR #2154:
URL: https://github.com/apache/james-project/pull/2154#discussion_r1538521562
##
server/container/guice/mailbox-postgres/src/main/java/org/apache/james/modules/mailbox/PostgresMailboxModule.java:
##
@@ -133,6 +135,7 @@ protected void configure() {
bind(AttachmentMapperFactory.class).to(PostgresMailboxSessionMapperFactory.class);
bind(ReIndexer.class).to(ReIndexerImpl.class);
+bind(MessageIdReIndexer.class).to(MessageIdReIndexerImpl.class);
Review Comment:
likely we need e.g. reindex messages in OpenSearch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
Re: [PR] JAMES-2586 Update Guide binding Postgres [james-project]
vttranlina commented on code in PR #2154:
URL: https://github.com/apache/james-project/pull/2154#discussion_r1538519882
##
server/container/guice/mailbox-postgres/src/main/java/org/apache/james/modules/mailbox/PostgresMailboxModule.java:
##
@@ -133,6 +135,7 @@ protected void configure() {
bind(AttachmentMapperFactory.class).to(PostgresMailboxSessionMapperFactory.class);
bind(ReIndexer.class).to(ReIndexerImpl.class);
+bind(MessageIdReIndexer.class).to(MessageIdReIndexerImpl.class);
Review Comment:
Wait wait
Do we need MessasgeRoute for postgres?
https://james.apache.org/server/manage-webadmin.html#Administrating_Messages
```
This task is only available on top of Guice Cassandra products or Guice JPA
products. It is not part of Memory Guice product.
```
This is an old document, not sure it still correct or not with Postgres
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
Re: [PR] JAMES-2586 Update Guide binding Postgres [james-project]
vttranlina commented on code in PR #2154:
URL: https://github.com/apache/james-project/pull/2154#discussion_r1538507738
##
server/container/guice/mailbox-postgres/src/main/java/org/apache/james/modules/mailbox/PostgresMailboxModule.java:
##
@@ -133,6 +135,7 @@ protected void configure() {
bind(AttachmentMapperFactory.class).to(PostgresMailboxSessionMapperFactory.class);
bind(ReIndexer.class).to(ReIndexerImpl.class);
+bind(MessageIdReIndexer.class).to(MessageIdReIndexerImpl.class);
Review Comment:
It is required for web admin MessageRoute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
Re: [PR] JAMES-2586 Update Guide binding Postgres [james-project]
Arsnael commented on code in PR #2154:
URL: https://github.com/apache/james-project/pull/2154#discussion_r1538502507
##
server/container/guice/mailbox-postgres/src/main/java/org/apache/james/modules/mailbox/PostgresMailboxModule.java:
##
@@ -133,6 +135,7 @@ protected void configure() {
bind(AttachmentMapperFactory.class).to(PostgresMailboxSessionMapperFactory.class);
bind(ReIndexer.class).to(ReIndexerImpl.class);
+bind(MessageIdReIndexer.class).to(MessageIdReIndexerImpl.class);
Review Comment:
What was the issue when we were missing this? Just curious :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org
For additional commands, e-mail: notifications-h...@james.apache.org
[PR] JAMES-2586 Update Guide binding Postgres [james-project]
vttranlina opened a new pull request, #2154: URL: https://github.com/apache/james-project/pull/2154 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: notifications-unsubscr...@james.apache.org For additional commands, e-mail: notifications-h...@james.apache.org
