[jira] [Created] (JCLOUDS-520) Azureblob live-test fails when the system username contain uppercase letter.

[Bhathiya Supun (JIRA)]

Bhathiya Supun created JCLOUDS-520:
--

 Summary: Azureblob live-test fails when the system username 
contain uppercase letter.
 Key: JCLOUDS-520
 URL: https://issues.apache.org/jira/browse/JCLOUDS-520
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-core
Affects Versions: 1.7.1
Reporter: Bhathiya Supun
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

[Shri Javadekar]

> @@ -87,7 +87,9 @@ public void testListContainers() throws Exception {
> public void testCreateContainer() throws Exception {
>boolean created = false;
>while (!created) {
> - privateContainer = prefix + new SecureRandom().nextInt();
> +
> + privateContainer = (CONTAINER_PREFIX + new 
> SecureRandom().nextInt());

Can you explain how this change fixes the bug? If I read the code correctly, 
CONTAINER_PREFIX is defined as follows:


public static final String CONTAINER_PREFIX = (System.getProperty("user.name") 
+ "-blobstore").toLowerCase();


Therefore even this result in a container name starting with upper case letter.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336/files#r11105342

[jira] [Updated] (JCLOUDS-520) Azureblob live-test fails when the system username contain uppercase letters.

[Bhathiya Supun (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bhathiya Supun updated JCLOUDS-520:
---

   Description: This can be simulated by running live test with 
-Duser.name=BhathiyaHS (Any name with upper case letters). 
   Environment:  
Remaining Estimate: 1h
 Original Estimate: 1h
   Summary: Azureblob live-test fails when the system username 
contain uppercase letters.  (was: Azureblob live-test fails when the system 
username contain uppercase letter.)

> Azureblob live-test fails when the system username contain uppercase letters.
> -
>
> Key: JCLOUDS-520
> URL: https://issues.apache.org/jira/browse/JCLOUDS-520
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-core
>Affects Versions: 1.7.1
> Environment:  
>Reporter: Bhathiya Supun
>Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This can be simulated by running live test with -Duser.name=BhathiyaHS (Any 
> name with upper case letters). 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (JCLOUDS-520) Azureblob live-test fails when the system username contain uppercase letters.

[Bhathiya Supun (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954993#comment-13954993
 ] 

Bhathiya Supun commented on JCLOUDS-520:


https://github.com/jclouds/jclouds/pull/336

> Azureblob live-test fails when the system username contain uppercase letters.
> -
>
> Key: JCLOUDS-520
> URL: https://issues.apache.org/jira/browse/JCLOUDS-520
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-core
>Affects Versions: 1.7.1
> Environment:  
>Reporter: Bhathiya Supun
>Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This can be simulated by running live test with -Duser.name=BhathiyaHS (Any 
> name with upper case letters). 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

[Bhathiya]

When I replace 'prefix' with ' CONTAINER_PREFIX ' all the test cases 
succeded.Before that there was a 
error in ' testCreateContainer ' and build failed.

testCreateContainer
 "java.lang.IllegalArgumentException: Validation on '[java.lang.String arg0, 
[Lorg.jclouds.azureblob.options.CreateContainerOptions; arg1]' didn't pass:
Reason: Object 'Bhathiya-1255138650' doesn't match Azure container naming 
convention. Reason: Should be only lowercase.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39060131

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

[BuildHive]

[jclouds » jclouds 
#979](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/979/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39061358

Jenkins build is back to stable : jclouds » jclouds #979

[BuildHive]

See 

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

[CloudBees pull request builder plugin]

[jclouds-pull-requests 
#721](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/721/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39061489

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

[CloudBees pull request builder plugin]

[jclouds-java-7-pull-requests 
#1191](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1191/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39061836

Jenkins build is still unstable: jclouds » jclouds-karaf #843

[BuildHive]

See 

[jira] [Commented] (JCLOUDS-511) Incorrect feature definition: jclouds-rackspace-cloudblockstorage-uk/us

[Grzegorz Grzybek (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955095#comment-13955095
 ] 

Grzegorz Grzybek commented on JCLOUDS-511:
--

Could we backport it to {{1.7.x}} branch?

> Incorrect feature definition: jclouds-rackspace-cloudblockstorage-uk/us
> ---
>
> Key: JCLOUDS-511
> URL: https://issues.apache.org/jira/browse/JCLOUDS-511
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-karaf
>Affects Versions: 1.7.1
>Reporter: Grzegorz Grzybek
>Assignee: Andrew Phillips
> Fix For: 1.8.0
>
> Attachments: JCLOUDS-511.patch
>
>
> For example, uk feature has the following definition:
> {code:xml}
> 
>   jclouds-api-openstack-cinder
>version='${project.version}'>jclouds-api-rackspace-cloudidentity
>   
> mvn:org.apache.jclouds.provider/rackspace-cloudblockstorage-uk/${jclouds.version}
> 
> {code}
> and {{jclouds-api-rackspace-cloudidentity}}:
> {code:xml}
> 
>   jclouds-compute
>version='${project.version}'>jclouds-api-openstack-keystone
>dependency='true'>mvn:org.apache.jclouds.api/rackspace-cloudidentity/${jclouds.version}
> 
> {code}
> However, with current Karaf there's no way the bundle 
> "mvn:org.apache.jclouds.api/rackspace-cloudidentity/${jclouds.version}" will 
> get installed. Bundles with {dependency="true"} are taken into account only 
> during resolution of other bundles from the same feature - not of the _upper_ 
> feature which uses other features. In other words - {{ dependency="true" />}} doesn't _bubble up_.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (JCLOUDS-511) Incorrect feature definition: jclouds-rackspace-cloudblockstorage-uk/us

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955201#comment-13955201
 ] 

ASF subversion and git services commented on JCLOUDS-511:
-

Commit a7422966616abcad3c72cc78b521b07ee10d828b in jclouds-karaf's branch 
refs/heads/JCLOUDS-511-1.7.x from [~gzres]
[ https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;h=a742296 ]

JCLOUDS-511: Correcting features with dependency-only bundles


> Incorrect feature definition: jclouds-rackspace-cloudblockstorage-uk/us
> ---
>
> Key: JCLOUDS-511
> URL: https://issues.apache.org/jira/browse/JCLOUDS-511
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-karaf
>Affects Versions: 1.7.1
>Reporter: Grzegorz Grzybek
>Assignee: Andrew Phillips
> Fix For: 1.8.0
>
> Attachments: JCLOUDS-511.patch
>
>
> For example, uk feature has the following definition:
> {code:xml}
> 
>   jclouds-api-openstack-cinder
>version='${project.version}'>jclouds-api-rackspace-cloudidentity
>   
> mvn:org.apache.jclouds.provider/rackspace-cloudblockstorage-uk/${jclouds.version}
> 
> {code}
> and {{jclouds-api-rackspace-cloudidentity}}:
> {code:xml}
> 
>   jclouds-compute
>version='${project.version}'>jclouds-api-openstack-keystone
>dependency='true'>mvn:org.apache.jclouds.api/rackspace-cloudidentity/${jclouds.version}
> 
> {code}
> However, with current Karaf there's no way the bundle 
> "mvn:org.apache.jclouds.api/rackspace-cloudidentity/${jclouds.version}" will 
> get installed. Bundles with {dependency="true"} are taken into account only 
> during resolution of other bundles from the same feature - not of the _upper_ 
> feature which uses other features. In other words - {{ dependency="true" />}} doesn't _bubble up_.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jclouds-karaf] JCLOUDS-511: Correcting features with dependency-only bundles (#41)

[Andrew Phillips]

Backport of https://github.com/jclouds/jclouds-karaf/pull/40 to 1.7.x
You can merge this Pull Request by running:

  git pull https://github.com/jclouds/jclouds-karaf JCLOUDS-511-1.7.x

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-karaf/pull/41

-- Commit Summary --

  * JCLOUDS-511: Correcting features with dependency-only bundles

-- File Changes --

M feature/src/main/resources/feature.xml (5)

-- Patch Links --

https://github.com/jclouds/jclouds-karaf/pull/41.patch
https://github.com/jclouds/jclouds-karaf/pull/41.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/41

[jira] [Commented] (JCLOUDS-511) Incorrect feature definition: jclouds-rackspace-cloudblockstorage-uk/us

[Andrew Phillips (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955230#comment-13955230
 ] 

Andrew Phillips commented on JCLOUDS-511:
-

1.7.x backport PR: https://github.com/jclouds/jclouds-karaf/pull/41

> Incorrect feature definition: jclouds-rackspace-cloudblockstorage-uk/us
> ---
>
> Key: JCLOUDS-511
> URL: https://issues.apache.org/jira/browse/JCLOUDS-511
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-karaf
>Affects Versions: 1.7.1
>Reporter: Grzegorz Grzybek
>Assignee: Andrew Phillips
> Fix For: 1.8.0
>
> Attachments: JCLOUDS-511.patch
>
>
> For example, uk feature has the following definition:
> {code:xml}
> 
>   jclouds-api-openstack-cinder
>version='${project.version}'>jclouds-api-rackspace-cloudidentity
>   
> mvn:org.apache.jclouds.provider/rackspace-cloudblockstorage-uk/${jclouds.version}
> 
> {code}
> and {{jclouds-api-rackspace-cloudidentity}}:
> {code:xml}
> 
>   jclouds-compute
>version='${project.version}'>jclouds-api-openstack-keystone
>dependency='true'>mvn:org.apache.jclouds.api/rackspace-cloudidentity/${jclouds.version}
> 
> {code}
> However, with current Karaf there's no way the bundle 
> "mvn:org.apache.jclouds.api/rackspace-cloudidentity/${jclouds.version}" will 
> get installed. Bundles with {dependency="true"} are taken into account only 
> during resolution of other bundles from the same feature - not of the _upper_ 
> feature which uses other features. In other words - {{ dependency="true" />}} doesn't _bubble up_.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: [jclouds-karaf] JCLOUDS-511: Correcting features with dependency-only bundles (#41)

[Andrew Phillips]

Waiting for the PR builders...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/41#issuecomment-39098191

Jenkins build is still unstable: jclouds » jclouds-karaf #844

[BuildHive]

See 

Re: [jclouds-karaf] JCLOUDS-511: Correcting features with dependency-only bundles (#41)

[BuildHive]

[jclouds » jclouds-karaf 
#844](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/844/) 
UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/41#issuecomment-39102558

Re: [jclouds-karaf] JCLOUDS-511: Correcting features with dependency-only bundles (#41)

[CloudBees pull request builder plugin]

[jclouds-karaf-pull-requests 
#53](https://jclouds.ci.cloudbees.com/job/jclouds-karaf-pull-requests/53/) 
UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/41#issuecomment-39104028

Re: [jclouds-karaf] JCLOUDS-511: Correcting features with dependency-only bundles (#41)

[Andrew Phillips]

> jclouds » jclouds-karaf #844 UNSTABLE
> jclouds-karaf-pull-requests #53 UNSTABLE

Oh oh...looks like https://github.com/jclouds/jclouds/pull/330 [broke 
stuff](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/org.apache.jclouds.karaf$itests/844/testReport/org.jclouds.karaf.itests/MiscFeaturesInstallationTest/testBasicFeaturesInstallation_MiscFeaturesInstallationTest_testBasicFeaturesInstallation_KarafTestContainer_mvn_org_apache_karaf__apache_karaf__2_2_7__tar_gz_/)
 :-(

I don't think this change is causing any failures, but we need to address this.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/41#issuecomment-39106665

Re: [jclouds] Add ssh-agent support via jsch agentproxy (#312)

[Andrew Phillips]

Oh oh...looks like this [broke 
Karaf](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-karaf/org.apache.jclouds.karaf$itests/844/testReport/org.jclouds.karaf.itests/MiscFeaturesInstallationTest/testBasicFeaturesInstallation_MiscFeaturesInstallationTest_testBasicFeaturesInstallation_KarafTestContainer_mvn_org_apache_karaf__apache_karaf__2_2_7__tar_gz_/):
```
Caused by: org.osgi.framework.BundleException: Unresolved constraint in bundle 
jclouds-sshj [84]: Unable to resolve 84.0: missing requirement [84.0] package; 
(&(package=com.jcraft.jsch.agentproxy)(version>=0.0.0)(!(version>=1.0.0)))
at org.apache.felix.framework.Felix.resolveBundle(Felix.java:3446)
at org.apache.felix.framework.Felix.startBundle(Felix.java:1734)
at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:918)
at org.apache.felix.framework.BundleImpl.start(BundleImpl.java:905)
at 
org.apache.karaf.features.internal.FeaturesServiceImpl.installFeatures(FeaturesServiceImpl.java:353)
... 61 more
```
@iocanal: Any obvious quick fix here..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/312#issuecomment-39106796

[jira] [Commented] (JCLOUDS-516) Support ssh-agent authentication to access created nodes

[Andrew Phillips (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955334#comment-13955334
 ] 

Andrew Phillips commented on JCLOUDS-516:
-

It looks like this change broke Karaf - Karaf can't seem to find the two new 
dependencies :-( See 
https://github.com/jclouds/jclouds/pull/312#issuecomment-39106796

> Support ssh-agent authentication to access created nodes
> 
>
> Key: JCLOUDS-516
> URL: https://issues.apache.org/jira/browse/JCLOUDS-516
> Project: jclouds
>  Issue Type: Improvement
>  Components: jclouds-drivers
>Affects Versions: 1.8.0
>Reporter: Andrew Phillips
>Assignee: Andrew Phillips
> Fix For: 1.8.0, 1.7.2
>
> Attachments: JCLOUDS-516.patch
>
>
> See https://github.com/jclouds/jclouds/pull/312



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jclouds-site] Link to how to write a guest blog post (#67)

[Everett Toews]

You can merge this Pull Request by running:

  git pull https://github.com/rackerlabs/jclouds-site guest-post

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-site/pull/67

-- Commit Summary --

  * Link to how to write a guest blog post

-- File Changes --

M blog/index.html (2)

-- Patch Links --

https://github.com/jclouds/jclouds-site/pull/67.patch
https://github.com/jclouds/jclouds-site/pull/67.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/67

Re: [jclouds-site] Link to how to write a guest blog post (#67)

[CloudBees pull request builder plugin]

[jclouds-site-pull-requests 
#222](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/222/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39111665

[jira] [Commented] (JCLOUDS-516) Support ssh-agent authentication to access created nodes

[Andrew Phillips (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955380#comment-13955380
 ] 

Andrew Phillips commented on JCLOUDS-516:
-

It appears there are at least *some* packages out there that provide OSGi 
bundles:

http://rpm.pbone.net/index.php3/stat/4/idpl/25776964/dir/rawhide/com/jsch-agent-proxy-core-0.0.7-5.fc21.noarch.rpm.html

Wonder what we need to do to ensure we can resolve this dependency? [~iocanel]: 
any ideas?

> Support ssh-agent authentication to access created nodes
> 
>
> Key: JCLOUDS-516
> URL: https://issues.apache.org/jira/browse/JCLOUDS-516
> Project: jclouds
>  Issue Type: Improvement
>  Components: jclouds-drivers
>Affects Versions: 1.8.0
>Reporter: Andrew Phillips
>Assignee: Andrew Phillips
> Fix For: 1.8.0, 1.7.2
>
> Attachments: JCLOUDS-516.patch
>
>
> See https://github.com/jclouds/jclouds/pull/312



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: [jclouds-site] Link to how to write a guest blog post (#67)

[Andrew Phillips]

> @@ -3,6 +3,8 @@
>  title: Blog & News
>  ---
>  
> + href="https://wiki.apache.org/jclouds/How%20to%20Contribute%20Documentation";>Write
>  a guest post for this blog!

[minor] Perhaps just "Write a guest post!"? I guess it's obvious that it's "for 
this blog"?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/67/files#r11125635

Re: [jclouds-site] Link to how to write a guest blog post (#67)

[Andrew Phillips]

One minor text comment, otherwise +1 - looks good to me!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39114344

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

[Shri Javadekar]

> @@ -87,7 +87,9 @@ public void testListContainers() throws Exception {
> public void testCreateContainer() throws Exception {
>boolean created = false;
>while (!created) {
> - privateContainer = prefix + new SecureRandom().nextInt();
> +
> + privateContainer = (CONTAINER_PREFIX + new 
> SecureRandom().nextInt());

Aah.. I missed the ".toLowerCase()" in the declaration of CONTAINER_PREFIX. 
That explains it.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336/files#r11126006

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

[Shri Javadekar]

> @@ -87,7 +87,9 @@ public void testListContainers() throws Exception {
> public void testCreateContainer() throws Exception {
>boolean created = false;
>while (!created) {
> - privateContainer = prefix + new SecureRandom().nextInt();
> +
> + privateContainer = (CONTAINER_PREFIX + new 
> SecureRandom().nextInt());

You don't need the parenthesis.

(CONTAINER_PREFIX + new SecureRandom().nextInt());
could simply be
CONTAINER_PREFIX + new SecureRandom().nextInt();

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336/files#r11126993

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

[Andrew Phillips]

Thanks, @hsbhathiya! As @shrinandj pointed out, you can remove the parentheses 
around `(CONTAINER_PREFIX + new SecureRandom().nextInt())`. If you could update 
the PR, we can get this merged.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39118254

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

[Jeremy Daggett]

>return this;
> }
>  
> public static class Builder {
> -  /** @see UpdateCDNContainerOptions#ttl */
> +  /**
> +   * @see UpdateCDNContainerOptions#ttl

That comment about the @see tag was in some of the model classes. If you look 
through the code base, most of the Options classes have the @see tags. Is the 
thinking that we should remove these?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/85/files#r11127984

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

[Jeremy Daggett]

> @@ -86,6 +117,45 @@ public void testGet() throws Exception {
>}
> }
>  
> +   /**
> +* By default, this method is disabled due to daily purge limitations of 
> 25 objects per day.
> +*/
> +   @Test(enabled = false)

Because you can only purge 25 objects per day, I felt that this test should be 
disabled. As long as you don't run the live tests more than 25 times a day, 
enabling this should be fine.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/85/files#r11129835

Re: [jclouds-site] Link to how to write a guest blog post (#67)

[CloudBees pull request builder plugin]

[jclouds-site-pull-requests 
#223](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/223/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39124551

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

[Jeremy Daggett]

> @@ -43,6 +56,24 @@ public CloudFilesCDNApiLiveTest() {
>super();
> }
>  
> +   public void testEnable() throws Exception {
> +  for (String regionId : regions) {
> + assertNotNull(api.cdnApiInRegion(regionId).enable(name));
> +  }
> +   }
> +
> +   public void testEnableWithTTL() throws Exception {
> +  for (String regionId : regions) {
> + assertNotNull(api.cdnApiInRegion(regionId).enable(name, 77));
> +  }
> +   }
> +
> +   public void testDisable() throws Exception {
> +  for (String regionId : regions) {
> + assertNotNull(api.cdnApiInRegion(regionId).disable(name));

Always!? ;)  Added an assert method to the class that checks all of the CDN 
Container fields.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/85/files#r11129912

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

[Jeremy Daggett]

> @@ -86,6 +117,45 @@ public void testGet() throws Exception {
>}
> }
>  
> +   /**
> +* By default, this method is disabled due to daily purge limitations of 
> 25 objects per day.
> +*/
> +   @Test(enabled = false)
> +   public void testPurgeObject() throws Exception {
> +  for (String regionId : regions) {
> + String objectName = "testPurge";
> + Payload payload = Payloads.newByteSourcePayload(ByteSource.wrap(new 
> byte[]{1,2,3}));

Fixed.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/85/files#r11129916

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

[Jeremy Daggett]

> +  MockWebServer server = mockOpenStackServer();
> +  server.enqueue(addCommonHeaders(new 
> MockResponse().setBody(stringFromResource("/access.json";
> +  server.enqueue(addCommonHeaders(new 
> MockResponse().setResponseCode(404).setBody(stringFromResource("/cdn_container_list.json";
> +
> +  try {
> + CloudFilesApi api = api(server.getUrl("/").toString(), 
> "rackspace-cloudfiles");
> + CDNApi cdnApi = api.cdnApiInRegion("DFW");
> +
> + FluentIterable cdnContainers = cdnApi.list();
> +
> + assertEquals(server.getRequestCount(), 2);
> + assertAuthentication(server);
> + assertRequest(server.takeRequest(), "GET", 
> "/v1/MossoCloudFS_5bcf396e-39dd-45ff-93a1-712b9aba90a9/?format=json&enabled_only=true");
> +
> + assertNotNull(cdnContainers);
> + assertEquals(cdnContainers.size(), 0);

Fixed.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/85/files#r11129922

Re: [jclouds-site] Link to how to write a guest blog post (#67)

[jclouds-commentator]

  Go to 
http://6a21acc6345d125ffce2-18de16e2feac29e299a226ea14cb6219.r45.cf1.rackcdn.com/
 to review your changes.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39124791

Re: [jclouds-site] Link to how to write a guest blog post (#67)

[CloudBees pull request builder plugin]

[jclouds-site-pull-requests 
#224](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/224/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39126125

Re: [jclouds-site] Link to how to write a guest blog post (#67)

[jclouds-commentator]

  Go to 
http://ddd5ff4496aa02ab1791-50dfd0f8239b5549d8cdb74ee270c5e8.r76.cf1.rackcdn.com/
 to review your changes.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39126371

Re: [jclouds-site] Link to how to write a guest blog post (#67)

[Everett Toews]

Closed #67.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/67

Re: [jclouds-site] Link to how to write a guest blog post (#67)

[Everett Toews]

Merged and deployed.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39126998

Re: [jclouds-site] Link to how to write a guest blog post (#67)

[Andrew Phillips]

> Merged and deployed.

Thanks, @everett-toews! +1 - looks good to me.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/67#issuecomment-39127080

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

[Everett Toews]

+1

I'm okay with this. I suspect the value is set that way because of a driver in 
Cinder. I could see this being the case for other Cinder driver's as well.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-39128245

[jira] [Commented] (JCLOUDS-515) Cinder volume create does not require availability zone

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1395#comment-1395
 ] 

ASF subversion and git services commented on JCLOUDS-515:
-

Commit a45a24d4a16b6758dbccae8da73bc6dfce3387bd in jclouds's branch 
refs/heads/1.7.x from jasdeep-hundal
[ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=a45a24d ]

JCLOUDS-515: Don't require availability zone when creating volumes in cinder


> Cinder volume create does not require availability zone
> ---
>
> Key: JCLOUDS-515
> URL: https://issues.apache.org/jira/browse/JCLOUDS-515
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-core
>Affects Versions: 1.7.1
>Reporter: Jasdeep Hundal
>Assignee: Jasdeep Hundal
> Fix For: 1.8.0
>
>
> Openstack Cinder does not require specifying an availability zone for volume 
> creation, but the Cinder API as implemented in JClouds does. We should change 
> the check in the constructor of org.jclouds.openstack.cinder.v1.domain to 
> allow a null value for availability zone.
> The docs on the v1 API are not readily available but tracing through the 
> Cinder source code, we find this line that gets executed if we specify no 
> availability zone in either the v1 or v2 block storage APIs:
> https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L247
> It can also be noted the the Block Storage v2 request here does not require 
> an availability zone:
> http://docs.openstack.org/api/openstack-block-storage/2.0/content/POST_createVolume_v2__tenant_id__volumes_Volumes.html



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

[Everett Toews]

Merged to master and 1.7.x.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-39129202

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

[Everett Toews]

Closed #327.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327

[jira] [Updated] (JCLOUDS-515) Cinder volume create does not require availability zone

[Everett Toews (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Everett Toews updated JCLOUDS-515:
--

Fix Version/s: 1.7.2

> Cinder volume create does not require availability zone
> ---
>
> Key: JCLOUDS-515
> URL: https://issues.apache.org/jira/browse/JCLOUDS-515
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-core
>Affects Versions: 1.7.1
>Reporter: Jasdeep Hundal
>Assignee: Jasdeep Hundal
> Fix For: 1.8.0, 1.7.2
>
>
> Openstack Cinder does not require specifying an availability zone for volume 
> creation, but the Cinder API as implemented in JClouds does. We should change 
> the check in the constructor of org.jclouds.openstack.cinder.v1.domain to 
> allow a null value for availability zone.
> The docs on the v1 API are not readily available but tracing through the 
> Cinder source code, we find this line that gets executed if we specify no 
> availability zone in either the v1 or v2 block storage APIs:
> https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L247
> It can also be noted the the Block Storage v2 request here does not require 
> an availability zone:
> http://docs.openstack.org/api/openstack-block-storage/2.0/content/POST_createVolume_v2__tenant_id__volumes_Volumes.html



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Resolved] (JCLOUDS-515) Cinder volume create does not require availability zone

[Everett Toews (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Everett Toews resolved JCLOUDS-515.
---

Resolution: Fixed

> Cinder volume create does not require availability zone
> ---
>
> Key: JCLOUDS-515
> URL: https://issues.apache.org/jira/browse/JCLOUDS-515
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-core
>Affects Versions: 1.7.1
>Reporter: Jasdeep Hundal
>Assignee: Jasdeep Hundal
> Fix For: 1.8.0, 1.7.2
>
>
> Openstack Cinder does not require specifying an availability zone for volume 
> creation, but the Cinder API as implemented in JClouds does. We should change 
> the check in the constructor of org.jclouds.openstack.cinder.v1.domain to 
> allow a null value for availability zone.
> The docs on the v1 API are not readily available but tracing through the 
> Cinder source code, we find this line that gets executed if we specify no 
> availability zone in either the v1 or v2 block storage APIs:
> https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L247
> It can also be noted the the Block Storage v2 request here does not require 
> an availability zone:
> http://docs.openstack.org/api/openstack-block-storage/2.0/content/POST_createVolume_v2__tenant_id__volumes_Volumes.html



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

[BuildHive]

[jclouds » jclouds 
#980](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/980/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39128971

[jira] [Commented] (JCLOUDS-515) Cinder volume create does not require availability zone

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955547#comment-13955547
 ] 

ASF subversion and git services commented on JCLOUDS-515:
-

Commit b92892094b0d4c30cf4c767e9759c0f350b7dd46 in jclouds's branch 
refs/heads/master from jasdeep-hundal
[ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=b928920 ]

JCLOUDS-515: Don't require availability zone when creating volumes in cinder


> Cinder volume create does not require availability zone
> ---
>
> Key: JCLOUDS-515
> URL: https://issues.apache.org/jira/browse/JCLOUDS-515
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-core
>Affects Versions: 1.7.1
>Reporter: Jasdeep Hundal
>Assignee: Jasdeep Hundal
> Fix For: 1.8.0
>
>
> Openstack Cinder does not require specifying an availability zone for volume 
> creation, but the Cinder API as implemented in JClouds does. We should change 
> the check in the constructor of org.jclouds.openstack.cinder.v1.domain to 
> allow a null value for availability zone.
> The docs on the v1 API are not readily available but tracing through the 
> Cinder source code, we find this line that gets executed if we specify no 
> availability zone in either the v1 or v2 block storage APIs:
> https://github.com/openstack/cinder/blob/master/cinder/volume/flows/api/create_volume.py#L247
> It can also be noted the the Block Storage v2 request here does not require 
> an availability zone:
> http://docs.openstack.org/api/openstack-block-storage/2.0/content/POST_createVolume_v2__tenant_id__volumes_Volumes.html



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

[CloudBees pull request builder plugin]

[jclouds-pull-requests 
#722](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/722/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39129949

[jira] [Commented] (JCLOUDS-329) Missing Open stack functionality nova

[Everett Toews (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955562#comment-13955562
 ] 

Everett Toews commented on JCLOUDS-329:
---

These fixes are in 1.7.x.

> Missing Open stack functionality nova 
> --
>
> Key: JCLOUDS-329
> URL: https://issues.apache.org/jira/browse/JCLOUDS-329
> Project: jclouds
>  Issue Type: New Feature
>Affects Versions: 1.6.2, 1.6.3
>Reporter: Sina Molazem
> Fix For: 1.7.0
>
>
> There are some missing functionalities with open stack nova which are fixed 
> in a pull request in github (https://github.com/jclouds/jclouds/pull/161).
> I need to know when this commits will merge and is it possible to merge in 
> 1.6.x ?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Resolved] (JCLOUDS-329) Missing Open stack functionality nova

[Everett Toews (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Everett Toews resolved JCLOUDS-329.
---

   Resolution: Not a Problem
Fix Version/s: 1.7.0

> Missing Open stack functionality nova 
> --
>
> Key: JCLOUDS-329
> URL: https://issues.apache.org/jira/browse/JCLOUDS-329
> Project: jclouds
>  Issue Type: New Feature
>Affects Versions: 1.6.2, 1.6.3
>Reporter: Sina Molazem
> Fix For: 1.7.0
>
>
> There are some missing functionalities with open stack nova which are fixed 
> in a pull request in github (https://github.com/jclouds/jclouds/pull/161).
> I need to know when this commits will merge and is it possible to merge in 
> 1.6.x ?



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

[CloudBees pull request builder plugin]

[jclouds-java-7-pull-requests 
#1192](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1192/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39130256

[jira] [Commented] (JCLOUDS-154) key [openstack-nova] not in the list of providers or apis: {}"

[Everett Toews (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955567#comment-13955567
 ] 

Everett Toews commented on JCLOUDS-154:
---

Is this still a problem Shankar?

If I don't hear anything in a few days, I'll go ahead and close it.

> key [openstack-nova] not in the list of providers or apis: {}"
> --
>
> Key: JCLOUDS-154
> URL: https://issues.apache.org/jira/browse/JCLOUDS-154
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-compute
>Affects Versions: 1.6.0
> Environment: jclouds sdk version 1.6 
> Openstack - Folsom
> maven 
>Reporter: Shankar
>  Labels: compute, openstack
>
> I get the an exception when I try to create a new context as below :
>   ComputeServiceContext context = 
> ContextBuilder.newBuilder(provider)
>   .credentials(, )
>   .endpoint().modules(modules)
>   .buildView(ComputeServiceContext.class);
> Not sure what is wrong - the parameter provider is correct & all other 
> parameters are correct as well. 
> I'm using maven with the following dependencies: 
>   
>   org.jclouds.api
>   openstack-nova
>   1.6.0
>   
>   
>   org.jclouds.driver
>   jclouds-slf4j
>   1.6.0
>   



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (JCLOUDS-374) Exception while creating the server in OpenStack Nova API

[Everett Toews (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955571#comment-13955571
 ] 

Everett Toews commented on JCLOUDS-374:
---

Is this still a problem Nadeem?

If I don't hear anything in a few days, I'll go ahead and close it.

> Exception while creating the server in OpenStack Nova API
> -
>
> Key: JCLOUDS-374
> URL: https://issues.apache.org/jira/browse/JCLOUDS-374
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-compute, jclouds-core, jclouds-examples, 
> jclouds-labs-openstack
>Affects Versions: 1.5.10
> Environment: jclouds Version: 
> jclouds-compute-1.5.1,jclouds-core-1.5.1,
> Cloud and API Version: OpenStack Essex
> Operating system:  Windows7
> Java Version: 1.7.0_05
>Reporter: Nadeem
>Assignee: Everett Toews
>  Labels: easyfix, features, test
> Fix For: 1.5.11
>
>
> Code:
> CreateServerOptions options = 
> CreateServerOptions.Builder.adminPass("password");
> ServerCreated serverCreated = serverApi.create(computeData.getServerName(), 
> computeData.getImageId(), flavourId, options);
> eg: ServerCreated serverCreated = serverApi.create("ServerTest", 
> "f414c2a5-fb5b-49d2-a9e0-7c055703e4d2", "1",options);
> The code above throws the following error:
> Error Log:
> "com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: 
> Expected BEGIN_OBJECT but was STRING at line 1 column 5".
> The server is created, but the error restricts me from proceeding further. 
> Kindly help.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (JCLOUDS-493) Extend TemplateOptions and CreateServerOptions to support fixed private IPs and more

[Everett Toews (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955580#comment-13955580
 ] 

Everett Toews commented on JCLOUDS-493:
---

Should this issue be closed?

> Extend TemplateOptions and CreateServerOptions to support fixed private IPs 
> and more
> 
>
> Key: JCLOUDS-493
> URL: https://issues.apache.org/jira/browse/JCLOUDS-493
> Project: jclouds
>  Issue Type: Improvement
>  Components: jclouds-compute
>Affects Versions: 1.7.1
> Environment: jClouds 1.7.1
>Reporter: Jeffrey Nguyen
>Assignee: Jeffrey Nguyen
>  Labels: features
>
> Hi jClouds Devs,
> I'm currently working an enhancement related to recent enhancements to 
> support networks in jClouds compute layer [1] and OpenStack nova [2].  In 
> jClouds 1.7.1, both of these are invoked via the method 
> "networks(Iterable networks)".   I believe the intention is to set a 
> list of network UUIDs.
> For each network UUID, I want to be able to assign a fixed private IP 
> address, and possibly MAC address and port number.  [3] Below is an example 
> of how I assign (network UUID, fixed private IP) tuples for the 3 network 
> interfaces when creating a server in OpenStack. 
> Ideally, we need a more generic API like "TemplateOptions 
> networks(Iterable> networks)".   This will support all of 
> the network attributes instead of just the network UUID.
> Obviously Java does not allow the above overloaded method because we already 
> have a "networks(Iterable networks)" in the existing implementation.
> I'd like to propose we create a new method 
> "networkConfig(Iterable> networkConfig)" and deprecate  
> "networks(Iterable networks)".   This will allow each individual Iaas 
> to take time to migrate to the new API.
> What I like about the new API is that since it's a Map, it'll take any 
> network attributes supported by the underlined Iaas.  All we need to do is 
> specify the attribute names in the JSON payload (not hard-coded in the code). 
>  For example, when I apply this new API against OpenStack nova, I can specify 
> network UUID, fix_ip, and port UUID for each interface.   Also, if any new 
> attribute is introduced under networks, we'll get it for free with this new 
> enhancement.
> Please let me know what you think.
> Regards,
> -Jeffrey
> [1] https://issues.apache.org/jira/browse/JCLOUDS-416
> [2] https://issues.apache.org/jira/browse/JCLOUDS-202
> [3] OpenStack JSON payload for creating server with network uuid and fixed 
> private IP:
> "{"server":{"name":"testp-e12","imageRef":"66dac7ce-992c-43a4-b765-029c0b6fc1fe","flavorRef":"1d89ff82-5981-4a14-91e5-fc769f82a2f9","metadata":{"jclouds-group":"testp"},"key_name":"test","security_groups":[{"name":"default"}],"user_data":"U0VSVk...VAx","networks":[{"uuid":"fb9c21f4-0672-48b2-8279-77334bb63a53","fixed_ip":"172.16.0.10"},{"uuid":"aa1809a2-c32d-4eb8-a5c5-e46f692416e0","fixed_ip":"172.16.1.11"},{"uuid":"1e43f86f-4165-4f2e-8017-dd4cfb5548b0","fixed_ip":"172.16.2.12"}]}}"



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (JCLOUDS-493) Extend TemplateOptions and CreateServerOptions to support fixed private IPs and more

[Jeffrey Nguyen (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955591#comment-13955591
 ] 

Jeffrey Nguyen commented on JCLOUDS-493:


Hi Everett,

As per my comments on this JIRA (dated March 12th), we're deferring
enhancement at the jClouds abstract layer.  You can close this and re-open
it when it's the right time to do the enhancement or just leave it open.
I'm okay either way.

-Jeffrey





> Extend TemplateOptions and CreateServerOptions to support fixed private IPs 
> and more
> 
>
> Key: JCLOUDS-493
> URL: https://issues.apache.org/jira/browse/JCLOUDS-493
> Project: jclouds
>  Issue Type: Improvement
>  Components: jclouds-compute
>Affects Versions: 1.7.1
> Environment: jClouds 1.7.1
>Reporter: Jeffrey Nguyen
>Assignee: Jeffrey Nguyen
>  Labels: features
>
> Hi jClouds Devs,
> I'm currently working an enhancement related to recent enhancements to 
> support networks in jClouds compute layer [1] and OpenStack nova [2].  In 
> jClouds 1.7.1, both of these are invoked via the method 
> "networks(Iterable networks)".   I believe the intention is to set a 
> list of network UUIDs.
> For each network UUID, I want to be able to assign a fixed private IP 
> address, and possibly MAC address and port number.  [3] Below is an example 
> of how I assign (network UUID, fixed private IP) tuples for the 3 network 
> interfaces when creating a server in OpenStack. 
> Ideally, we need a more generic API like "TemplateOptions 
> networks(Iterable> networks)".   This will support all of 
> the network attributes instead of just the network UUID.
> Obviously Java does not allow the above overloaded method because we already 
> have a "networks(Iterable networks)" in the existing implementation.
> I'd like to propose we create a new method 
> "networkConfig(Iterable> networkConfig)" and deprecate  
> "networks(Iterable networks)".   This will allow each individual Iaas 
> to take time to migrate to the new API.
> What I like about the new API is that since it's a Map, it'll take any 
> network attributes supported by the underlined Iaas.  All we need to do is 
> specify the attribute names in the JSON payload (not hard-coded in the code). 
>  For example, when I apply this new API against OpenStack nova, I can specify 
> network UUID, fix_ip, and port UUID for each interface.   Also, if any new 
> attribute is introduced under networks, we'll get it for free with this new 
> enhancement.
> Please let me know what you think.
> Regards,
> -Jeffrey
> [1] https://issues.apache.org/jira/browse/JCLOUDS-416
> [2] https://issues.apache.org/jira/browse/JCLOUDS-202
> [3] OpenStack JSON payload for creating server with network uuid and fixed 
> private IP:
> "{"server":{"name":"testp-e12","imageRef":"66dac7ce-992c-43a4-b765-029c0b6fc1fe","flavorRef":"1d89ff82-5981-4a14-91e5-fc769f82a2f9","metadata":{"jclouds-group":"testp"},"key_name":"test","security_groups":[{"name":"default"}],"user_data":"U0VSVk...VAx","networks":[{"uuid":"fb9c21f4-0672-48b2-8279-77334bb63a53","fixed_ip":"172.16.0.10"},{"uuid":"aa1809a2-c32d-4eb8-a5c5-e46f692416e0","fixed_ip":"172.16.1.11"},{"uuid":"1e43f86f-4165-4f2e-8017-dd4cfb5548b0","fixed_ip":"172.16.2.12"}]}}"



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: [jclouds] Azureblobs live-test Bug Fix (#336)

[Shri Javadekar]

Looks good to me. Thanks @hsbhathiya.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/336#issuecomment-39133714

[jira] [Updated] (JCLOUDS-494) Glance version negotiation is not performed

[Everett Toews (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Everett Toews updated JCLOUDS-494:
--

Assignee: Jasdeep Hundal

> Glance version negotiation is not performed
> ---
>
> Key: JCLOUDS-494
> URL: https://issues.apache.org/jira/browse/JCLOUDS-494
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-core, jclouds-labs-openstack
>Affects Versions: 1.8.0
>Reporter: Jasdeep Hundal
>Assignee: Jasdeep Hundal
>
> Glance is currently broken in jclouds-labs-openstack because it attempts to 
> performs operations at the base URL returned in the Keystone catalog. Glance 
> is built to run multiple versions of its API at different endpoints, which 
> can be discovered by querying the base URL returned by Keystone. JClouds 
> needs to perform this version negotiation in order to make Glance work.
> In 99% of cases, this last part of the url will be either "/v1" for versions 
> 1.0 and 1.1 of the API or "/v2" for version 2.0, so one possible fix could be 
> to simply apply a Path annotation on top of the 
> org.jclouds.openstack.glance.v1_0.features.ImageApi specification. However, 
> according to Mark Washenberger, the current Glance PTL, the most correct 
> operation is to actually query for the appropriate URL for the requested 
> version. (I'll try to pull up docs that confirm this and link them when I can 
> to avoid this "documentation by dictator").



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Jenkins build is back to stable : jclouds-1.7.x-branch #57

[jenkins-no-reply]

See 

Jenkins build is back to stable : jclouds-1.7.x-branch » jclouds compute core #57

[jenkins-no-reply]

See 

Jenkins build is back to normal : jclouds-labs-google-1.7.x-branch #76

[jenkins-no-reply]

See 

Jenkins build is back to normal : jclouds-labs-aws-1.7.x-branch » jcloud rds api #32

[jenkins-no-reply]

See 

Jenkins build is back to normal : jclouds-labs-aws-1.7.x-branch » jcloud iam api #32

[jenkins-no-reply]

See 

Jenkins build is back to normal : jclouds-labs-aws-1.7.x-branch » jclouds Amazon Elastic Load Balancer provider #32

[jenkins-no-reply]

See 

Jenkins build is back to normal : jclouds-labs-1.7.x-branch » jclouds virtualbox api #36

[jenkins-no-reply]

See 

Jenkins build is back to normal : jclouds-labs-openstack-1.7.x-branch » jclouds rackspace-autoscale api #42

[jenkins-no-reply]

See 

Build failed in Jenkins: jclouds-labs-openstack » jclouds openstack-glance api #317

[jenkins-no-reply]

See 


--
[...truncated 2230 lines...]
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/reporting/maven-reporting/2.2.1/maven-reporting-2.2.1.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/reporting/maven-reporting/2.2.1/maven-reporting-2.2.1.pom
 (2 KB at 100.7 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-sink-api/1.1/doxia-sink-api-1.1.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-sink-api/1.1/doxia-sink-api-1.1.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-sink-api/1.1/doxia-sink-api-1.1.pom
 (2 KB at 153.2 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia/1.1/doxia-1.1.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia/1.1/doxia-1.1.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia/1.1/doxia-1.1.pom
 (15 KB at 988.2 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-logging-api/1.1/doxia-logging-api-1.1.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-logging-api/1.1/doxia-logging-api-1.1.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-logging-api/1.1/doxia-logging-api-1.1.pom
 (2 KB at 96.1 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/maven-toolchain/2.2.1/maven-toolchain-2.2.1.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven-toolchain/2.2.1/maven-toolchain-2.2.1.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven-toolchain/2.2.1/maven-toolchain-2.2.1.pom
 (4 KB at 251.2 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/shared/maven-invoker/2.0.9/maven-invoker-2.0.9.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/shared/maven-invoker/2.0.9/maven-invoker-2.0.9.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/shared/maven-invoker/2.0.9/maven-invoker-2.0.9.pom
 (6 KB at 470.1 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/1.5.6/plexus-utils-1.5.6.pom
 (6 KB at 398.3 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus/1.0.12/plexus-1.0.12.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus/1.0.12/plexus-1.0.12.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus/1.0.12/plexus-1.0.12.pom
 (10 KB at 598.1 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-site-renderer/1.0/doxia-site-renderer-1.0.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-site-renderer/1.0/doxia-site-renderer-1.0.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-site-renderer/1.0/doxia-site-renderer-1.0.pom
 (5 KB at 308.8 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-sitetools/1.0/doxia-sitetools-1.0.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-sitetools/1.0/doxia-sitetools-1.0.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-sitetools/1.0/doxia-sitetools-1.0.pom
 (10 KB at 550.7 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-core/1.0/doxia-core-1.0.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-core/1.0/doxia-core-1.0.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-core/1.0/doxia-core-1.0.pom
 (3 KB at 155.9 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus-utils/1.5.7/plexus-utils-1.5.7.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/1.5.7/plexus-utils-1.5.7.pom
Downloaded: 
http://repo.cloudbees.com/content/repo

Build failed in Jenkins: jclouds-labs-openstack #317

[jenkins-no-reply]

See 

--
[...truncated 2378 lines...]
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-module-fml/1.0/doxia-module-fml-1.0.jar
 (19 KB at 696.6 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-module-xdoc/1.0/doxia-module-xdoc-1.0.jar
 (28 KB at 1085.8 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/commons-codec/commons-codec/1.2/commons-codec-1.2.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-module-apt/1.0/doxia-module-apt-1.0.jar
 (46 KB at 919.5 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/log4j/log4j/1.2.14/log4j-1.2.14.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-module-xhtml/1.0/doxia-module-xhtml-1.0.jar
 (22 KB at 1183.0 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/com/thoughtworks/qdox/qdox/1.12/qdox-1.12.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/commons-collections/commons-collections/3.2/commons-collections-3.2.jar
 (558 KB at 8997.9 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-archiver/2.1.2/plexus-archiver-2.1.2.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/commons-httpclient/commons-httpclient/3.1/commons-httpclient-3.1.jar
 (298 KB at 8510.1 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-io/2.0.4/plexus-io-2.0.4.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/commons-codec/commons-codec/1.2/commons-codec-1.2.jar
 (30 KB at 947.7 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/3.0.5/plexus-utils-3.0.5.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/log4j/log4j/1.2.14/log4j-1.2.14.jar
 (359 KB at 10553.9 KB/sec)
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-io/2.0.4/plexus-io-2.0.4.jar
 (57 KB at 2474.5 KB/sec)
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-archiver/2.1.2/plexus-archiver-2.1.2.jar
 (181 KB at 5823.3 KB/sec)
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/3.0.5/plexus-utils-3.0.5.jar
 (226 KB at 7501.5 KB/sec)
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/com/thoughtworks/qdox/qdox/1.12/qdox-1.12.jar
 (176 KB at 2700.1 KB/sec)
[INFO] 
4 warnings
[WARNING] Javadoc Warnings
[WARNING] 
:41:
 warning - Tag @link: reference not found: ApiMetadata
[WARNING] 
:41:
 warning - Tag @link: reference not found: ApiMetadata
[WARNING] 
:41:
 warning - Tag @link: reference not found: ApiMetadata
[WARNING] 
:41:
 warning - Tag @link: reference not found: ApiMetadata
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-source-plugin:2.2:jar-no-fork (attach-sources) @ 
openstack-glance ---
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus-utils/3.0.1/plexus-utils-3.0.1.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/3.0.1/plexus-utils-3.0.1.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/3.0.1/plexus-utils-3.0.1.pom
 (3 KB at 144.3 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus-utils/3.0.1/plexus-utils-3.0.1.jar
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/3.0.1/plexus-utils-3.0.1.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/3.0.1/plexus-utils-3.0.1.jar
 (222 KB at 8851.1 KB/sec)
[INFO] Building jar: 

Build failed in Jenkins: jclouds-labs-1.7.x-branch #36

[jenkins-no-reply]

See 

--
[...truncated 7834 lines...]
[WARNING] 
:40:
 warning - Tag @link: reference not found: Group
[WARNING] 
:54:
 warning - Tag @link: reference not found: Org
[WARNING] 
:68:
 warning - Tag @link: reference not found: Right
[WARNING] 
:82:
 warning - Tag @link: reference not found: Role
[WARNING] 
:107:
 warning - Tag @link: reference not found: User
[WARNING] 
:121:
 warning - Tag @link: reference not found: User
[WARNING] 
:135:
 warning - Tag @link: reference not found: Vdc
[WARNING] 
:41:
 warning - Tag @link: reference not found: Link
[WARNING] 
:41:
 warning - Tag @link: reference not found: ApiMetadata
[WARNING] 
:47:
 warning - Tag @link: reference not found: 
ResourceEntityType.Status#WAITING_FOR_INPUT
[WARNING] 
:47:
 warning - Tag @link: reference not found: 
ResourceEntityType.Status#WAITING_FOR_INPUT
[WARNING] 
:37:
 warning - Tag @link: reference not found: Org
[WARNING] 
:29:
 warning - Tag @link: reference not found: AdminQuery
[WARNING] 
:41:
 warning - Tag @link: reference not found: AdminQuery
[WARNING] 
:37:
 warning - Tag @link: reference not found: Org
[WARNING] 
:29:
 warning - Tag @link: reference not found: AdminQuery
[WARNING] 
:41:
 warning - Tag @link: reference not found: AdminQuery
[WARNING] 
:93:
 warning - Tag @link: reference not found: CatalogReference
[WARNING] 
:75:
 warning - Tag @link: reference not found: Catalog
[WARNING] 
:77:
 warning - Tag @link: reference not found: Catalog
[WARNING] 
:33:
 warning - Tag @link: referenc

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

[Everett Toews]

> +/*
> + * Copyright 2014 The Apache Software Foundation.
> + *
> + * Licensed under the Apache License, Version 2.0 (the "License");
> + * you may not use this file except in compliance with the License.
> + * You may obtain a copy of the License at
> + *
> + *  http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.jclouds.location.functions;

This is definitely not the right package for this. This is going to be common 
to all Glance versions so I think it belongs in 
`org.jclouds.openstack.glance.functions`.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/82/files#r11136161

Re: [jclouds-labs-openstack] JCLOUDS-494: Change EndpointParam parser to negotiate version for Glance API (#82)

[Everett Toews]

I ran the live tests with 100% success.

mvn clean integration-test -Plive 
-Dtest.openstack-glance.endpoint=http://162.242.246.90:5000/v2.0/ 
-Dtest.openstack-glance.identity=admin:admin 
-Dtest.openstack-glance.credential=devstack


---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/82#issuecomment-39140274

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> +   }
> +
> +   /**
> +* Builds a Json string suitable for sending to the softlayer api
> +*
> +* @param virtualGuest
> +* @return String
> +*/
> +   String buildJson(VirtualGuest virtualGuest) {
> +  TemplateObject templateObject = null;
> +  String hostname = checkNotNull(virtualGuest.getHostname(), "hostname");
> +  String domain = checkNotNull(virtualGuest.getDomain(), "domain");
> +  int startCpus = checkNotNull(virtualGuest.getStartCpus(), "startCpus");
> +  int maxMemory = checkNotNull(virtualGuest.getMaxMemory(), "maxMemory");
> +  boolean localDiskFlag = checkNotNull(virtualGuest.isLocalDiskFlag(), 
> "localDiskFlag");
> +  String datacenterName = 
> checkNotNull(virtualGuest.getDatacenter().getName(), "datacenterName");

Can the `virtualGuest.getDatacenter()` be null?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11136382

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> +   /**
> +* Builds a Json string suitable for sending to the softlayer api
> +*
> +* @param virtualGuest
> +* @return String
> +*/
> +   String buildJson(VirtualGuest virtualGuest) {
> +  TemplateObject templateObject = null;
> +  String hostname = checkNotNull(virtualGuest.getHostname(), "hostname");
> +  String domain = checkNotNull(virtualGuest.getDomain(), "domain");
> +  int startCpus = checkNotNull(virtualGuest.getStartCpus(), "startCpus");
> +  int maxMemory = checkNotNull(virtualGuest.getMaxMemory(), "maxMemory");
> +  boolean localDiskFlag = checkNotNull(virtualGuest.isLocalDiskFlag(), 
> "localDiskFlag");
> +  String datacenterName = 
> checkNotNull(virtualGuest.getDatacenter().getName(), "datacenterName");
> +  Set networkComponents = 
> getNetworkComponents(virtualGuest);
> +  if(virtualGuest.getOperatingSystem() != null) {

[minor] space after `if`.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11136395

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> +   String buildJson(VirtualGuest virtualGuest) {
> +  TemplateObject templateObject = null;
> +  String hostname = checkNotNull(virtualGuest.getHostname(), "hostname");
> +  String domain = checkNotNull(virtualGuest.getDomain(), "domain");
> +  int startCpus = checkNotNull(virtualGuest.getStartCpus(), "startCpus");
> +  int maxMemory = checkNotNull(virtualGuest.getMaxMemory(), "maxMemory");
> +  boolean localDiskFlag = checkNotNull(virtualGuest.isLocalDiskFlag(), 
> "localDiskFlag");
> +  String datacenterName = 
> checkNotNull(virtualGuest.getDatacenter().getName(), "datacenterName");
> +  Set networkComponents = 
> getNetworkComponents(virtualGuest);
> +  if(virtualGuest.getOperatingSystem() != null) {
> + String operatingSystemReferenceCode = 
> checkNotNull(virtualGuest.getOperatingSystem()
> + .getOperatingSystemReferenceCode(), 
> "operatingSystemReferenceCode");
> + templateObject = new TemplateObject(hostname, domain, startCpus, 
> maxMemory, true,
> + operatingSystemReferenceCode, null, localDiskFlag, new 
> Datacenter(datacenterName), networkComponents,
> + getBlockDevices(virtualGuest));
> +  } else if(virtualGuest.getVirtualGuestBlockDeviceTemplateGroup() != 
> null) {

[minor] space after `if`.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11136416

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> +  .transform(new Function BlockDevice>() {
> + @Override
> + public BlockDevice apply(VirtualGuestBlockDevice input) {
> +return new BlockDevice(input.getDevice(), 
> input.getVirtualDiskImage().getCapacity());
> + }
> +  })
> +  .toSortedSet(new Comparator() {
> + @Override
> + public int compare(BlockDevice b1, BlockDevice b2) {
> +return 
> Integer.valueOf(b1.getDevice()).compareTo(Integer.valueOf(b2.getDevice()));
> + }
> +  });
> +  return set;
> +   }
> +
> +   private HashSet getNetworkComponents(VirtualGuest 
> virtualGuest) {

Even if it is a private method, return the `Set` interface instead of a 
concrete implementation.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11136489

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

>  .build();
> }
>  
> private Iterable createIso3166Codes(Address address) {
> -  if (address == null) return ImmutableSet. of();
> +  if (address== null) return ImmutableSet. of();

[minor] Add the space back again

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11136645

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

[Jeremy Daggett]

> +   }
> +
> +   public void testUpdate() throws Exception {
> +  for (String regionId : regions) {
> + UpdateCDNContainerOptions opts = new UpdateCDNContainerOptions();
> + opts.ttl(1234567);
> + opts.logRetention(true);
> + opts.enabled(false);
> + 
> + // update the container
> + assertTrue(api.cdnApiInRegion(regionId).update(name, opts));
> + 
> + CDNContainer container = api.cdnApiInRegion(regionId).get(name);
> + assertEquals(container.getTtl(), 1234567);
> + assertTrue(container.isLogRetentionEnabled());
> + assertFalse(container.isEnabled());

I rewrote the test!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/85/files#r11136735

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> +return input.getMountType().equals("Disk");
> + }
> +  })
> +  .transform(new Function Volume>() {
> + @Override
> + public Volume apply(VirtualGuestBlockDevice item) {
> +float volumeSize = 
> item.getVirtualDiskImage().getCapacity();
> +return new VolumeImpl(
> +item.getId() + "",
> +from.isLocalDiskFlag() ? 
> Volume.Type.LOCAL : Volume.Type.SAN,
> +volumeSize, null, item.getBootableFlag() 
> == 1, false);
> + }
> +  }).toSet());
> +  }
> +  return builder.build();
> +   }

Reformat this class to 3 space indentation and 120 line length.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11136807

Re: [jclouds-examples] Fixes broken README links (#36)

[Everett Toews]

Closed #36.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/36

Re: [jclouds-examples] Fixes broken README links (#36)

[Everett Toews]

Merged.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/36#issuecomment-39141829

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> +@Singleton
> +public class VirtualGuestToImage implements Function {
> +
> +   private static final String CENTOS = "CENTOS";
> +   private static final String DEBIAN = "DEBIAN";
> +   private static final String RHEL = "REDHAT";
> +   private static final String UBUNTU = "UBUNTU";
> +   private static final String WINDOWS = "WIN_";
> +   private static final String CLOUD_LINUX = "CLOUDLINUX";
> +   private static final String VYATTACE = "VYATTACE";
> +
> +   @Resource
> +   @Named(ComputeServiceConstants.COMPUTE_LOGGER)
> +   protected Logger logger = Logger.NULL;
> +
> +   public static Function osFamily() {

Can we remove this function and reuse the one in the `OperatingSystemToImage` 
class?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11136853

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

[Jeremy Daggett]

> @@ -105,34 +123,64 @@ public void testListWithOptions() throws Exception {
>}
> }
>  
> -   public void testEnableAndDisable() throws Exception {
> +   public void testListWithOptionsFail() throws Exception {

Updating test method to **testListWithOptionsIsEmpty()**

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/85/files#r11136852

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

[Jeremy Daggett]

> @@ -81,6 +77,28 @@ public void testList() throws Exception {
>}
> }
>  
> +   public void testListFail() throws Exception {

Updating test method to **testListIsEmpty()**

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/85/files#r11136851

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> +   else if (description.startsWith(VYATTACE)) return 
> OsFamily.LINUX;
> +}
> +return OsFamily.UNRECOGNIZED;
> + }
> +  };
> +   }
> +
> +   @Override
> +   public Image apply(VirtualGuest from) {
> +
> +  checkNotNull(from, "from");
> +  ImageBuilder builder = new ImageBuilder().ids(from.getId() + "")
> +  .name(from.getHostname())
> +  .status(Image.Status.AVAILABLE);
> +
> +  if(from.getOperatingSystem() == null) {

[minor] space after `if`.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11136923

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> +import com.google.common.base.Splitter;
> +import com.google.common.collect.Iterables;
> +
> +import static com.google.common.collect.Iterables.getLast;
> +
> +/**
> + * @author Andrea Turli
> + */
> +public class OperatingSystems {
> +
> +   public static Function bits() {
> +  return new Function() {
> + @Override
> + public Integer apply(String operatingSystemReferenceCode) {
> +if (operatingSystemReferenceCode != null) {
> +   return 
> Integer.parseInt(getLast(Splitter.on("_").split(operatingSystemReferenceCode)));

If the function is allowed to return null, perhaps it is better to use 
`Ints.tryParse` instead of `parseInt` to avoid throwing an exception and return 
null instead.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11137001

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> + }
> +  };
> +   }
> +
> +   private static String parseVersion(String version) {
> +  if(version.contains("-")) {
> + String rawVersion = version.substring(0,
> + version.lastIndexOf("-"));
> + if(Iterables.size(Splitter.on(".").split(rawVersion)) == 3) {
> +return rawVersion.substring(0, rawVersion.lastIndexOf("."));
> + } else {
> +return rawVersion;
> + }
> +  } else if(version.contains(" ")) {
> + return version.substring(0,
> + version.indexOf(" "));

[minor] Spaces after each `if` and don't break lines here (also in the above 
call to substring).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11137092

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> @@ -49,6 +53,7 @@
>  public class SoftLayerTemplateOptions extends TemplateOptions implements 
> Cloneable {
>  
> protected String domainName = "jclouds.org";
> +   protected Optional> blockDevices = Optional.absent();

Add this variable to the `copyTo` method too, so the object is properly cloned.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11137207

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

[BuildHive]

[jclouds » jclouds-labs-openstack 
#985](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/985/)
 SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/85#issuecomment-39143262

Re: [jclouds-labs-openstack] Updates to Rackspace Cloud Files CDN (#85)

[CloudBees pull request builder plugin]

[jclouds-labs-openstack-pull-requests 
#191](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/191/)
 SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/85#issuecomment-39143472

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

>Password pw = get(result.getOperatingSystem().getPasswords(), 0);
>return new NodeAndInitialCredentials(result, 
> result.getId() + "", 
> LoginCredentials.builder().user(pw.getUsername()).password(
>  pw.getPassword()).build());
> }
>  
> -   private Iterable getPrices(Template template) {
> -  Builder result = ImmutableSet.builder();
> +   private Set getBlockDevices(List 
> blockDeviceCapacities) {
> +  Set blockDevices = Sets.newHashSet();
> +  int devicePosition = 0;
> +  for (int i = 0; i < blockDeviceCapacities.size(); i++) {
> + if (i > 0) { devicePosition = i + 1; }

This will lead to `devicePosition` being `0, 2, 3, 4...`. Is there a reason why 
1 can't be used?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11137608

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> +  for (int i = 0; i < blockDeviceCapacities.size(); i++) {
> + if (i > 0) { devicePosition = i + 1; }
> + blockDevices.add(VirtualGuestBlockDevice.builder()
> +.device(devicePosition + "")
> +.diskImage(VirtualDiskImage.builder()
> +.capacity(blockDeviceCapacities.get(i))
> +.typeId(Type.valueOf(diskType).ordinal())
> +.build())
> +.build());
> +  }
> +  return blockDevices;
> +   }
> +
> +   private Optional tryGetOperatingSystemFrom(final String 
> imageId) {
> +  Set operatingSystemsAvailable = 
> createObjectOptionsSupplier.get().getVirtualGuestOperatingSystems();
> +  return tryFind(from(operatingSystemsAvailable)

I'm in favor of static imports, but when they improve readability. In the case 
of `from`, when statically imported it's harder to understand what's happening: 
From `operatingSystemsAvailable ` to what? In this cases I tend to avoid using 
static imports in favor of a more readable code.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11137710

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> +List volumes2 = h2.getVolumes();
> +ComparisonChain comparisonChain = 
> ComparisonChain.start().compare(getCores(h1), getCores(h2))
> +.compare(h1.getRam(), h2.getRam())
> +.compare(getSpace(h1), getSpace(h2))
> +.compare(getBootableDeviceType(h1), 
> getBootableDeviceType(h2));
> +if(!volumes1.isEmpty() && !volumes2.isEmpty() && volumes1.size() 
> == volumes2.size()) {
> +   for (int i = 0; i < volumes1.size(); i++) {
> +  comparisonChain.compare(volumes1.get(i).getType(), 
> volumes2.get(i).getType());
> +   }
> +}
> +return comparisonChain.result();
> + }
> +  });
> +  for (Integer cpus : virtualGuestConfiguration.getCpusOfProcessors()) {
> + for (Integer memory : virtualGuestConfiguration.getMemories()) {
> +for (VirtualGuestBlockDevice blockDevice : 
> virtualGuestConfiguration.getVirtualGuestBlockDevices()) {

As this is only considering bootable devices, can this loop be the outer one? 
This way we can save some cpu and memory unnecessary iterations.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11137860

Re: [jclouds] JCLOUDS-317: Add missing states to Nova v2 Server (#334)

[Everett Toews]

Can you please put the STOPPED state back?

I realize the OpenStack doesn't return this but that state has been in jclouds 
for a long time and some code is bound to depend on it. @Deprecated STOPPED and 
add a comment telling users to change it to SHUTOFF. 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/334#issuecomment-39144844

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> +
> +  // list private images and transform them to OperatingSystem
> +  Set privateImages = 
> api.getAccountApi().getBlockDeviceTemplateGroups();
> +  Map privateImagesSoftwareDescriptions = 
> extractSoftwareDescriptions(privateImages);
> +  for (Map.Entry entry : 
> privateImagesSoftwareDescriptions.entrySet()) {
> + OperatingSystem os = getOperatingSystem(entry);
> + if (os != null) {
> +result.add(os);
> + }
> +  }
> +  // list public images and transform them to OperatingSystem
> +  if(includePublicImages) {
> + Set publicImages = 
> api.getVirtualGuestBlockDeviceTemplateGroupApi().getPublicImages();
> + Map publicImagesSoftwareDescriptions = 
> extractSoftwareDescriptions(publicImages);
> + for (Map.Entry entry :
> + publicImagesSoftwareDescriptions.entrySet()) {

[minor] Remove the line break and add spaces after all `if` statements.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11138078

[jclouds-site] Update stale BlobStore docs (#68)

[Jeremy Daggett]

This PR is to clean up the BlobStore Start Guide with current information and 
fix some minor typos.

jekyll was run locally to verify these changes.
You can merge this Pull Request by running:

  git pull https://github.com/rackerlabs/jclouds-site update-stale-docs

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-site/pull/68

-- Commit Summary --

  * Cleaned up BlobStore Start Guide and fixed minor typos
  * Formatting/typo fixes

-- File Changes --

M guides/azure-storage.md (2)
M reference/configuration.md (7)
M start/blobstore.md (494)

-- Patch Links --

https://github.com/jclouds/jclouds-site/pull/68.patch
https://github.com/jclouds/jclouds-site/pull/68.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/68

Re: [jclouds-site] Update stale BlobStore docs (#68)

[CloudBees pull request builder plugin]

[jclouds-site-pull-requests 
#225](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/225/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/68#issuecomment-39145122

Re: [jclouds-site] Update stale BlobStore docs (#68)

[jclouds-commentator]

  Go to 
http://82cb4d27028b5f2da720-a5885cc8c368884850298f986087b419.r37.cf1.rackcdn.com/
 to review your changes.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/68#issuecomment-39145294

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

> @@ -236,28 +414,34 @@ public void destroyNode(String id) {
>VirtualGuest guest = getNode(id);
>if (guest == null)
>   return;
> -
> -  if (guest.getBillingItemId() == -1)
> - throw new IllegalStateException(String.format("no billing item for 
> guest(%s) so we cannot cancel the order",
> -   id));
> -
> -  logger.debug(">> canceling service for guest(%s) billingItem(%s)", id, 
> guest.getBillingItemId());
> -  client.getVirtualGuestApi().cancelService(guest.getBillingItemId());
> +  logger.debug(">> awaiting virtualGuest(%s) without active 
> transactions", guest.getId());
> +  checkState(retry(new Predicate() {
> + public boolean apply(VirtualGuest guest) {
> +   guest = getNode(guest.getId() + "");

Can you do the same without re-assigning the variable passed as a parameter?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11138223

Re: [jclouds] Refactor SoftLayer CCI support (#296)

[Ignasi Barrera]

>  public class SoftLayerHttpApiModule extends HttpApiModule {
>  
> +   public SoftLayerHttpApiModule() {
> +   }

This constructor isn't needed.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/296/files#r11138265