Re: [jclouds] fix support for private images in SoftLayer (#568)
@demobox, I've cherry-picked the commit onto master, shall I close the PR manually? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/568#issuecomment-59170282
Build failed in Jenkins: jclouds » jclouds #1797
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1797/ -- GitHub pull request #433 to jclouds/jclouds Building remotely on s-3517c7f6 in workspace https://buildhive.cloudbees.com/job/jclouds/job/jclouds/ws/ Fetching changes from the remote Git repository Fetching upstream changes from git://github.com/jclouds/jclouds.git FATAL: Could not checkout master with start point origin/master hudson.plugins.git.GitException: Could not checkout master with start point origin/master at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.checkoutBranch(CliGitAPIImpl.java:1037) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at hudson.remoting.RemoteInvocationHandler$RPCRequest.perform(RemoteInvocationHandler.java:299) at hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:280) at hudson.remoting.RemoteInvocationHandler$RPCRequest.call(RemoteInvocationHandler.java:239) at hudson.remoting.UserRequest.perform(UserRequest.java:118) at hudson.remoting.UserRequest.perform(UserRequest.java:48) at hudson.remoting.Request$2.run(Request.java:328) at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72) at java.util.concurrent.FutureTask.run(FutureTask.java:262) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:744) Caused by: hudson.plugins.git.GitException: Command checkout -b master origin/master returned status code 1: stdout: apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/domain/FloatingIPPool.java: needs merge apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/extensions/FloatingIPPoolApi.java: needs merge apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/extensions/FloatingIPPoolApiLiveTest.java: needs merge apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseFloatingIPPoolListTest.java: needs merge stderr: error: you need to resolve your current index first at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:928) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:909) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:853) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommand(CliGitAPIImpl.java:863) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.checkout(CliGitAPIImpl.java:1018) at hudson.plugins.git.GitAPI.checkout(GitAPI.java:181) at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.checkoutBranch(CliGitAPIImpl.java:1034) ... 15 more
Re: [jclouds] Token based authentication in openstack-keystone (#433)
[jclouds » jclouds #1797](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1797/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/433#issuecomment-59181676
Re: [jclouds] Token based authentication in openstack-keystone (#433)
[jclouds » jclouds #1798](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1798/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/433#issuecomment-59182963
Re: [jclouds] Token based authentication in openstack-keystone (#433)
[jclouds-pull-requests-java-6 #204](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/204/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/433#issuecomment-59183246
Re: [jclouds] Token based authentication in openstack-keystone (#433)
[jclouds-pull-requests #1292](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1292/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/433#issuecomment-59184906
Re: [jclouds] Token based authentication in openstack-keystone (#433)
Did a rebase because it has been a long time and there were merge conflicts. Also @jdaggett you had a comment about ParseAccessTest that I had a question --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/433#issuecomment-59185690
Re: [jclouds] Token based authentication in openstack-keystone (#433)
[jclouds-pull-requests #1293](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1293/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/433#issuecomment-59185925
[jclouds-labs] Cleanup round 1 of azurecompute Deployment class and imports. (#92)
did a global import order fix so that all following changes don#39;t have this. Main change was to consolidate the Deployment value type. A follow-up PR will take out the private fields, equals, etc. with auto-value. You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds-labs adrian.azurecompute-Deployment-cleanup1 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pull/92 -- Commit Summary -- * Cleanup round 1 of azurecompute Deployment class and imports. -- File Changes -- M azurecompute/src/main/java/org/jclouds/azurecompute/AzureComputeApi.java (2) M azurecompute/src/main/java/org/jclouds/azurecompute/AzureComputeProviderMetadata.java (5) M azurecompute/src/main/java/org/jclouds/azurecompute/AzureManagementApiMetadata.java (8) M azurecompute/src/main/java/org/jclouds/azurecompute/binders/BindCreateHostedServiceToXmlPayload.java (15) M azurecompute/src/main/java/org/jclouds/azurecompute/binders/BindDeploymentParamsToXmlPayload.java (6) M azurecompute/src/main/java/org/jclouds/azurecompute/binders/BindOSImageParamsToXmlPayload.java (6) M azurecompute/src/main/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapter.java (1) M azurecompute/src/main/java/org/jclouds/azurecompute/compute/config/AzureComputeServiceContextModule.java (5) M azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/AzureImageToImage.java (3) M azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/DeploymentToNodeMetadata.java (3) M azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/RoleSizeToHardware.java (3) M azurecompute/src/main/java/org/jclouds/azurecompute/config/AzureComputeHttpApiModule.java (7) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Deployment.java (363) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/DeploymentParams.java (3) D azurecompute/src/main/java/org/jclouds/azurecompute/domain/DeploymentSlot.java (42) D azurecompute/src/main/java/org/jclouds/azurecompute/domain/DeploymentStatus.java (43) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/DetailedHostedServiceProperties.java (10) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Disk.java (7) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Error.java (4) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/HostedService.java (7) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/HostedServiceProperties.java (4) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Image.java (9) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/ImageParams.java (7) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/InstanceStatus.java (4) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Location.java (7) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSType.java (4) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Operation.java (4) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleSize.java (4) M azurecompute/src/main/java/org/jclouds/azurecompute/features/DeploymentApi.java (5) M azurecompute/src/main/java/org/jclouds/azurecompute/features/DiskApi.java (8) M azurecompute/src/main/java/org/jclouds/azurecompute/features/HostedServiceApi.java (8) M azurecompute/src/main/java/org/jclouds/azurecompute/features/ImageApi.java (8) M azurecompute/src/main/java/org/jclouds/azurecompute/features/LocationApi.java (6) M azurecompute/src/main/java/org/jclouds/azurecompute/features/OperationApi.java (5) M azurecompute/src/main/java/org/jclouds/azurecompute/features/VirtualMachineApi.java (1) M azurecompute/src/main/java/org/jclouds/azurecompute/functions/ImageParamsName.java (8) M azurecompute/src/main/java/org/jclouds/azurecompute/functions/ParseRequestIdHeader.java (6) M azurecompute/src/main/java/org/jclouds/azurecompute/options/CreateHostedServiceOptions.java (3) M azurecompute/src/main/java/org/jclouds/azurecompute/suppliers/KeyStoreSupplier.java (13) M azurecompute/src/main/java/org/jclouds/azurecompute/suppliers/SSLContextWithKeysSupplier.java (9) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DeploymentHandler.java (24) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DetailedHostedServicePropertiesHandler.java (7) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DiskHandler.java (8) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/HostedServiceHandler.java (8) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/HostedServicePropertiesHandler.java (8) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/HostedServiceWithDetailedPropertiesHandler.java (1) M
Re: [jclouds-labs] Cleanup round 1 of azurecompute Deployment class and imports. (#92)
cc @abayer --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/92#issuecomment-59222099
Re: [jclouds-labs] Cleanup round 1 of azurecompute Deployment class and imports. (#92)
}
- public String getPrivateIpAddress() {
- return privateIpAddress;
+ private Deployment(Builder builder) {
Using constructor pattern like this leads to far less chance of mistake when
builders are used.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/92/files#r1884
Re: [jclouds-labs] Cleanup round 1 of azurecompute Deployment class and imports. (#92)
}
- public String getPrivateIpAddress() {
- return privateIpAddress;
+ private Deployment(Builder builder) {
Also, intentionally didn't do a nullable sweep. This is just reorganizing the
fields however good or bad they are.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/92/files#r18900034
Re: [jclouds-labs] Cleanup round 1 of azurecompute Deployment class and imports. (#92)
+ instanceStatus + , instanceStateDetails= +
instanceStateDetails + , instanceErrorCode=
+ instanceErrorCode + , instanceSize= + instanceSize + ,
privateIpAddress= + privateIpAddress
+ , publicIpAddress= + publicIpAddress + ];
}
+
+ public static Builder builder() {
+ return new Builder();
+ }
+
+ public static class Builder {
Likely going to kill this or move it to the XML parser. There's no reason for a
user to create this object.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/92/files#r18900072
Re: [jclouds-labs] Cleanup round 1 of azurecompute Deployment class and imports. (#92)
[jclouds-labs-pull-requests #315](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/315/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/92#issuecomment-59223175
Re: [jclouds-labs] Cleanup round 1 of azurecompute Deployment class and imports. (#92)
[jclouds » jclouds-labs #1696](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1696/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/92#issuecomment-59225000
Re: [jclouds] add availability zone to server (#574)
For this particular extension, it just adds a field to the response, so the field needs to be added to the `Server` domain class : @Named(OS-EXT-AZ:availability_zone) private final OptionalString availabilityZones; For the tests, since this is _technically_ an extension, I suggest that you create both a `ExtendedAvailabilityZoneExpectTest` and `ExtendedAvailabilityZoneLiveTest` in the `org.jclouds.openstack.nova.v2_0.extensions` package. There are examples of how to write the tests in that package. HTH! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/574#issuecomment-59249079
[jira] [Created] (JCLOUDS-753) HttpCommandExecutorService(s) vulnerable to POODLE
Diwaker Gupta created JCLOUDS-753:
-
Summary: HttpCommandExecutorService(s) vulnerable to POODLE
Key: JCLOUDS-753
URL: https://issues.apache.org/jira/browse/JCLOUDS-753
Project: jclouds
Issue Type: Bug
Components: jclouds-core
Affects Versions: 1.8.0
Reporter: Diwaker Gupta
SSLModule configures the SSLContext thus:
{noformat}
sc = SSLContext.getInstance(SSL);
sc.init(null, new TrustManager[] { trustAllCerts }, new
SecureRandom());
{noformat}
This makes the client end of the SSL connection vulnerable to POODLE
(http://googleonlinesecurity.blogspot.com/2014/10/this-poodle-bites-exploiting-ssl-30.html)
jclouds should enforce TLS on all client connections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jclouds] fix support for private images in SoftLayer (#568)
Closed #568. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/568#event-179079167
[jira] [Commented] (JCLOUDS-753) HttpCommandExecutorService(s) vulnerable to POODLE
[
https://issues.apache.org/jira/browse/JCLOUDS-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172901#comment-14172901
]
Diwaker Gupta commented on JCLOUDS-753:
---
I should note that `getInstance(TLS)` or even `getInstance(TLSv1.2)` is
*not* sufficient. The set of supported protocols must be explicitly restricted
to TLS+ (e.g. via SSLEngine.setEnabledProtocols)
HttpCommandExecutorService(s) vulnerable to POODLE
--
Key: JCLOUDS-753
URL: https://issues.apache.org/jira/browse/JCLOUDS-753
Project: jclouds
Issue Type: Bug
Components: jclouds-core
Affects Versions: 1.8.0
Reporter: Diwaker Gupta
SSLModule configures the SSLContext thus:
{noformat}
sc = SSLContext.getInstance(SSL);
sc.init(null, new TrustManager[] { trustAllCerts }, new
SecureRandom());
{noformat}
This makes the client end of the SSL connection vulnerable to POODLE
(http://googleonlinesecurity.blogspot.com/2014/10/this-poodle-bites-exploiting-ssl-30.html)
jclouds should enforce TLS on all client connections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jclouds-labs-google] JCLOUDS-649: Added image creation from pd, changed rawDisk to OptionalT (#59)
Users can now create images from persistent disks. When images are made from PD the rawDisk attribute is not present. This changes Image.java to treat it as an Optionallt;RawDiskgt; instead. You can merge this Pull Request by running: git pull https://github.com/GoogleCloudPlatform/jclouds-labs-google imagecreation Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pull/59 -- Commit Summary -- * JCLOUDS-649: added image creation from pd and made Image rawDisk Optionallt;Tgt; -- File Changes -- M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Image.java (10) M google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/features/ImageApi.java (23) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/DiskApiLiveTest.java (2) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ImageApiExpectTest.java (42) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/features/ImageApiLiveTest.java (47) M google-compute-engine/src/test/java/org/jclouds/googlecomputeengine/internal/BaseGoogleComputeEngineApiLiveTest.java (6) A google-compute-engine/src/test/resources/image_insert_from_pd.json (1) -- Patch Links -- https://github.com/jclouds/jclouds-labs-google/pull/59.patch https://github.com/jclouds/jclouds-labs-google/pull/59.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/59
Re: [jclouds-labs-google] JCLOUDS-649: Added image creation from pd, changed rawDisk to OptionalT (#59)
[jclouds-labs-google-pull-requests #159](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/159/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/59#issuecomment-59274346
[jira] [Commented] (JCLOUDS-649) Creating an image from a root persistent disk causes NullPointerException on GCE
[
https://issues.apache.org/jira/browse/JCLOUDS-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172924#comment-14172924
]
Daniel Broudy commented on JCLOUDS-649:
---
After talking to Chris I made the following PR to address this issue.
https://github.com/jclouds/jclouds-labs-google/pull/59
Creating an image from a root persistent disk causes NullPointerException on
GCE
Key: JCLOUDS-649
URL: https://issues.apache.org/jira/browse/JCLOUDS-649
Project: jclouds
Issue Type: Bug
Components: jclouds-labs-google
Affects Versions: 1.7.3
Environment: Debian Wheezy
Reporter: Sunil Shah
Assignee: Chris Custine
When we create an image using the instructions at
https://developers.google.com/compute/docs/images#creating_an_image_from_a_root_persistent_disk
and add it to our project, using JClouds to list images fails with a
NullPointerException:
context.getComputeService.listImages()
Full stack trace is here: https://gist.github.com/ssk2/5ee56af7f0976b4b1e9d
This appears to be because adding an image this way (using gcutil addimage
but with source_disk specified) doesn't set the rawDisk attribute for the
image, whereas other images have this set (whether official or added by using
gcutil addimage without source_disk specified).
A working image added using gcutil addimage without source_disk specified:
{code:javascript}
{
kind: compute#image,
selfLink:
https://www.googleapis.com/compute/v1/projects/snipped/global/images/em2,
id: 16640109463810346568,
creationTimestamp: 2014-08-01T14:16:33.255-07:00,
name: em2,
description: ,
sourceType: RAW,
rawDisk: {
source: ,
containerType: TAR
},
status: READY,
archiveSizeBytes: 2105823816,
diskSizeGb: 10
}
{code}
A non-working image added using gcutil addimage with source_disk specified:
{code:javascript}
{
kind: compute#image,
selfLink:
https://www.googleapis.com/compute/v1/projects/snipped/global/images/em2-201407311619,
id: 5684027672297600099,
creationTimestamp: 2014-07-31T16:25:31.255-07:00,
name: em2-201407311619,
description: ,
sourceType: RAW,
status: READY,
archiveSizeBytes: 2195392264,
diskSizeGb: 10,
sourceDisk:
https://www.googleapis.com/compute/v1/projects/snipped/zones/us-central1-a/disks/em2,
sourceDiskId: 1777248800849859015
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (JCLOUDS-753) HttpCommandExecutorService(s) vulnerable to POODLE
[
https://issues.apache.org/jira/browse/JCLOUDS-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173013#comment-14173013
]
Andrew Phillips commented on JCLOUDS-753:
-
Thanks for raising this, [~diwaker]! Care to open a PR with the suggested
change to see what happens?
Also, have you been able to look at the alternative HTTP drivers (apachehc and
okhttp)? If they are not vulnerable, this could provide a workaround for the
time being.
HttpCommandExecutorService(s) vulnerable to POODLE
--
Key: JCLOUDS-753
URL: https://issues.apache.org/jira/browse/JCLOUDS-753
Project: jclouds
Issue Type: Bug
Components: jclouds-core
Affects Versions: 1.8.0
Reporter: Diwaker Gupta
SSLModule configures the SSLContext thus:
{noformat}
sc = SSLContext.getInstance(SSL);
sc.init(null, new TrustManager[] { trustAllCerts }, new
SecureRandom());
{noformat}
This makes the client end of the SSL connection vulnerable to POODLE
(http://googleonlinesecurity.blogspot.com/2014/10/this-poodle-bites-exploiting-ssl-30.html)
jclouds should enforce TLS on all client connections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jclouds-labs-google] JCLOUDS-649: Added image creation from pd, changed rawDisk to OptionalT (#59)
+ /** +* Creates an image resource in the specified project from the provided persistent disk. +* +* @param imageName the name of the created image +* @param sourceDisk fully qualified URL for the persistent disk to create the image from +* @return an Operation resource. To check on the status of an operation, poll the Operations resource returned to +* you, and look for the status field. +*/ + @Named(Images:insert) + @POST + @Consumes(MediaType.APPLICATION_JSON) + @Produces(MediaType.APPLICATION_JSON) + @Path(/global/images) + @OAuthScopes(COMPUTE_SCOPE) + @MapBinder(BindToJsonPayload.class) + @Fallback(NullOnNotFoundOr404.class) This kind of fallbacks shouldn't be used in PUT or POST operations, as the returned type won't be clear (see https://github.com/jclouds/jclouds-labs-google/pull/40). *Write* operations on a resource should assume that the resource already exists or fail otherwise. Using this fallback would silently return `null`, which has no clear meaning to the user: did the operation fail? Did it complete and the response had no body? Others? Just remove the fallback, and a `ResourceNotFoundException` will be automatically thrown by jclouds if a 404 response is returned. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/59/files#r18926849
Re: [jclouds-labs-google] JCLOUDS-649: Added image creation from pd, changed rawDisk to OptionalT (#59)
@@ -70,5 +86,36 @@ private void assertImageEquals(Image result, Image
expected) {
assertEquals(result.getName(), expected.getName());
}
+ @Test(groups = live)
+ public void testInsertDisk() {
+ assertZoneOperationDoneSucessfully(diskApi().createInZone(DISK_NAME,
sizeGb, DEFAULT_ZONE_NAME), TIME_WAIT);
+ Disk disk = diskApi().getInZone(DEFAULT_ZONE_NAME, DISK_NAME);
+ diskURI = disk.getSelfLink();
+ System.out.println(diskURI: + diskURI.toString());
Can this be removed?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/59/files#r18926936
Re: [jclouds-labs-google] JCLOUDS-649: Added image creation from pd, changed rawDisk to OptionalT (#59)
Thanks @danbroudy! Just a couple comments. Apart from that, lgtm! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/59#issuecomment-59285602
[jclouds-site] add softlayer getting started (#134)
You can merge this Pull Request by running: git pull https://github.com/andreaturli/jclouds-site feature/softlayer Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-site/pull/134 -- Commit Summary -- * add softlayer getting started -- File Changes -- M guides/index.md (1) A guides/softlayer.md (150) M reference/providers.md (4) -- Patch Links -- https://github.com/jclouds/jclouds-site/pull/134.patch https://github.com/jclouds/jclouds-site/pull/134.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/134
Re: [jclouds-site] add softlayer getting started (#134)
[jclouds-site-pull-requests #409](https://jclouds.ci.cloudbees.com/job/jclouds-site-pull-requests/409/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/134#issuecomment-59287417
Re: [jclouds-site] add softlayer getting started (#134)
Go to http://38a1978b0178d686f80d-7e234dfdb2a13218b9e9179aca636b27.r31.cf5.rackcdn.com/ to review your changes. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/134#issuecomment-59287587
Re: [jclouds-labs-google] JCLOUDS-649: Added image creation from pd, changed rawDisk to OptionalT (#59)
@@ -70,5 +86,36 @@ private void assertImageEquals(Image result, Image
expected) {
assertEquals(result.getName(), expected.getName());
}
+ @Test(groups = live)
+ public void testInsertDisk() {
+ assertZoneOperationDoneSucessfully(diskApi().createInZone(DISK_NAME,
sizeGb, DEFAULT_ZONE_NAME), TIME_WAIT);
+ Disk disk = diskApi().getInZone(DEFAULT_ZONE_NAME, DISK_NAME);
+ diskURI = disk.getSelfLink();
+ System.out.println(diskURI: + diskURI.toString());
I don't think we can get rid of it because in the tests below I need the disk
to create an image from.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/59/files#r18929352
Re: [jclouds-labs-google] JCLOUDS-649: Added image creation from pd, changed rawDisk to OptionalT (#59)
+ /** +* Creates an image resource in the specified project from the provided persistent disk. +* +* @param imageName the name of the created image +* @param sourceDisk fully qualified URL for the persistent disk to create the image from +* @return an Operation resource. To check on the status of an operation, poll the Operations resource returned to +* you, and look for the status field. +*/ + @Named(Images:insert) + @POST + @Consumes(MediaType.APPLICATION_JSON) + @Produces(MediaType.APPLICATION_JSON) + @Path(/global/images) + @OAuthScopes(COMPUTE_SCOPE) + @MapBinder(BindToJsonPayload.class) + @Fallback(NullOnNotFoundOr404.class) Sounds good to me. I was wondering how to handle these responses, I noticed that some similar methods did not have a fallback such as Disk:insert but then others did such as Disks:createSnapshot. I see that is addressed in PR#40. I will remove the @Fallback(NullOnNotFoundOr404.class) line and the corresponding expect test testCreateImageFromPdResponseIs4xx(). --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/59/files#r18929730
Re: [jclouds-labs-google] JCLOUDS-649: Added image creation from pd, changed rawDisk to OptionalT (#59)
I did have a question about how to handle backwards compatibility with Image.getRawDisk(). Is it ok that I have changed the return value from a RawDisk to an OptionalRawDisk? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/59#issuecomment-59291700
Re: [jclouds-labs-google] JCLOUDS-649: Added image creation from pd, changed rawDisk to OptionalT (#59)
[jclouds-labs-google-pull-requests #160](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/160/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/59#issuecomment-59293469
Re: [jclouds-labs-google] JCLOUDS-649: Added image creation from pd, changed rawDisk to OptionalT (#59)
[jclouds » jclouds-labs-google #1475](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1475/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/59#issuecomment-59293730
Re: [jclouds-labs-google] JCLOUDS-649: Added image creation from pd, changed rawDisk to OptionalT (#59)
@danbroudy Yeah it is perfectly fine to change the return type here in a labs project. If we had released this before the PR, then we would have to wait until 2.0, so this worked out nicely. I don't have time to review this in detail but I'll be back with a review in a couple of hours. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/59#issuecomment-59300182
Re: [jclouds-site] add softlayer getting started (#134)
tdsoftlayer/td -td/td +tdSG,US-CA,US-TX,US-VA,US-WA,NL,HK,NSFTW-IL,AU,CA-ON,GB/td Wow, now there is a list of ISO codes! I wonder if you can add an `p/` tag right after `US-WA` to split it into two lines. ? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/134/files#r18934692
Re: [jclouds-site] add softlayer getting started (#134)
+
+{% highlight java %}
+// Get a context with softlayer that offers the portable BlobStore API
+BlobStoreContext context = ContextBuilder.newBuilder(swift)
+ .credentials(tenantName:accessKey, apiKey)
+
.endpoint(https://ams01.objectstorage.softlayer.net/auth/v1.0;)
+ .buildView(BlobStoreContext.class);
+
+// Create a container in the default location
+context.getBlobStore().createContainerInLocation(null, container);
+
+// Use the map interface for easy access to put/get things, keySet, etc.
+context.createInputStreamMap(container).put(blob.txt, inputStream);
+
+// When you need access to hpcloud specific features, use the
provider-specific context
+HPCloudObjectStorageClient hpcloudClient =
Is this correct? I would think that `SwiftClient` should be here instead.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/134/files#r18934749
Re: [jclouds-labs] CloudSigma2 ComputeService and SecurityGroupExtension (#70)
[jclouds-labs-pull-requests #316](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/316/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/70#issuecomment-59307882
Re: [jclouds-labs] CloudSigma2 ComputeService and SecurityGroupExtension (#70)
[jclouds » jclouds-labs #1697](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1697/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/70#issuecomment-59308124
Build failed in Jenkins: jclouds » jclouds-labs #1697
See https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1697/changes Changes: [kulakov.ilya] CloudSigma2 ComputeService. -- [...truncated 2545 lines...] [INFO] Exclude: **/*.iml [INFO] Exclude: **/*.eml [INFO] Exclude: **/*.ipr [INFO] Exclude: **/*.iws [INFO] Exclude: **/*.DS_STORE [INFO] Exclude: **/TAGS [INFO] Exclude: **/.metadata/** [INFO] Exclude: **/atlassian-ide-plugin.xml [INFO] Exclude: **/.DS_Store [INFO] Exclude: .mailmap [INFO] Exclude: .git/** [INFO] Exclude: **/.gitignore [INFO] Exclude: **/.gitattributes [INFO] Exclude: .repository/** [INFO] Exclude: .java-version [INFO] Exclude: .repository/** [INFO] Exclude: gc.log [INFO] 127 resources included (use -debug for more details) Warning: org.apache.xerces.jaxp.SAXParserImpl$JAXPSAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. Compiler warnings: WARNING: 'org.apache.xerces.jaxp.SAXParserImpl: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized.' Warning: org.apache.xerces.parsers.SAXParser: Feature 'http://javax.xml.XMLConstants/feature/secure-processing' is not recognized. Warning: org.apache.xerces.parsers.SAXParser: Property 'http://javax.xml.XMLConstants/property/accessExternalDTD' is not recognized. Warning: org.apache.xerces.parsers.SAXParser: Property 'http://www.oracle.com/xml/jaxp/properties/entityExpansionLimit' is not recognized. [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 127 licence. [INFO] [INFO] --- maven-jar-plugin:2.4:test-jar (default) @ cloudsigma2 --- [INFO] Building jar: https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/ws/cloudsigma2/target/cloudsigma2-2.0.0-SNAPSHOT-tests.jar [INFO] [INFO] --- maven-surefire-plugin:2.17:test (integration) @ cloudsigma2 --- [JENKINS] Recording test results[INFO] [INFO] --- maven-duplicate-finder-plugin:1.0.5:check (default) @ cloudsigma2 --- [INFO] Checking compile classpath [INFO] Checking runtime classpath [INFO] Checking test classpath [INFO] [INFO] --- maven-checkstyle-plugin:2.13:check (default) @ cloudsigma2 --- [INFO] [INFO] [INFO] modernizer-maven-plugin:1.1.0:modernizer (modernizer) @ cloudsigma2 [INFO] [INFO] --- maven-enforcer-plugin:1.1.1:enforce (enforce-banned-dependencies) @ cloudsigma2 --- [INFO] [INFO] --- maven-enforcer-plugin:1.1.1:enforce (enforce-java) @ cloudsigma2 --- [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ cloudsigma2 --- [INFO] artifact net.schmizz:sshj: checking for updates from central [INFO] artifact net.schmizz:sshj: checking for updates from jclouds-sona-snapshots-nexus [INFO] artifact com.google.guava:guava: checking for updates from central [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ cloudsigma2 --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/ws/cloudsigma2/src/main/clojure [INFO] Copying 1 resource [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ cloudsigma2 --- [INFO] Nothing to compile - all classes are up to date [INFO] [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ cloudsigma2 --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/ws/cloudsigma2/src/test/clojure [INFO] Copying 70 resources [INFO] Copying 3 resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ cloudsigma2 --- [INFO] Nothing to compile - all classes are up to date [WARNING] Failed to getClass for org.gaul.modernizer_maven_plugin.ModernizerMojo [INFO] [INFO] modernizer-maven-plugin:1.1.0:modernizer (modernizer) @ cloudsigma2 [INFO] [INFO] --- modernizer-maven-plugin:1.1.0:modernizer (modernizer) @ cloudsigma2 --- [INFO] [INFO] [INFO] Building jclouds CloudSigma v2 Honolulu Provider 2.0.0-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ cloudsigma2-hnl --- [INFO] [INFO] --- maven-enforcer-plugin:1.1.1:enforce (enforce-banned-dependencies) @ cloudsigma2-hnl --- [INFO] [INFO] --- maven-enforcer-plugin:1.1.1:enforce (enforce-java) @ cloudsigma2-hnl --- [INFO] [INFO] --- maven-remote-resources-plugin:1.5:process (default) @ cloudsigma2-hnl --- [INFO] artifact net.schmizz:sshj: checking for updates from central [INFO] artifact net.schmizz:sshj: checking for updates from jclouds-sona-snapshots-nexus [INFO] artifact com.google.guava:guava: checking for
