Re: [jclouds-labs-google] Add setDiskAutoDelete to InstanceApi (#89)

[Chris Custine]

> @@ -196,7 +229,7 @@ public void testResetInstance() {
>assertOperationDoneSuccessfully(api().reset(INSTANCE_NAME));
> }
>  
> -   @Test(groups = "live", dependsOnMethods = "testResetInstance")
> +   @Test(groups = "live", dependsOnMethods = {"testSetDiskAutoDelete", 
> "testResetInstance"}, alwaysRun = true)

> I'd just wonder if this is also run if the methods the test depends on are 
> skipped rather than fail.
FWIW, the docs for alwaysRun on the @Before and @After annotations implies that 
it works for both failed and skipped.  I was thinking about doing something 
like this for live tests as well.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/89/files#r20344740

Re: [jclouds-labs-google] Add setDiskAutoDelete to InstanceApi (#89)

[Andrew Phillips]

> @@ -196,7 +229,7 @@ public void testResetInstance() {
>assertOperationDoneSuccessfully(api().reset(INSTANCE_NAME));
> }
>  
> -   @Test(groups = "live", dependsOnMethods = "testResetInstance")
> +   @Test(groups = "live", dependsOnMethods = {"testSetDiskAutoDelete", 
> "testResetInstance"}, alwaysRun = true)

> I just got tired of having to delete things if the tests failed partway 
> through.

Seems like a good plan to me. From the documentation of `alwaysRun` ("If set to 
true, this test method will always be run even if it depends on a method that 
failed."), I'd just wonder if this is also run if the methods the test depends 
on are **skipped** rather than fail.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/89/files#r20344173

Build failed in Jenkins: jclouds-labs-google » Apache jclouds labs google #321

[jenkins-no-reply]

See 


--
[...truncated 2085 lines...]
Downloading: 
https://repository-jclouds.forge.cloudbees.com/snapshot/net/schmizz/sshj/0.10.1-SNAPSHOT/sshj-0.10.1-20140702.063459-1.pom
Downloading: 
https://repository.apache.org/content/repositories/snapshots/net/schmizz/sshj/0.10.1-SNAPSHOT/sshj-0.10.1-20140702.063459-1.pom
Downloading: 
http://repository.apache.org/snapshots/net/schmizz/sshj/0.10.1-SNAPSHOT/sshj-0.10.1-20140702.063459-1.pom
Downloading: 
https://oss.sonatype.org/content/repositories/snapshots/net/schmizz/sshj/0.10.1-SNAPSHOT/sshj-0.10.1-20140702.063459-1.pom
Downloaded: 
https://oss.sonatype.org/content/repositories/snapshots/net/schmizz/sshj/0.10.1-SNAPSHOT/sshj-0.10.1-20140702.063459-1.pom
 (13 KB at 103.0 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/com/jcraft/jsch.agentproxy.core/0.0.8/jsch.agentproxy.core-0.0.8.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/com/jcraft/jsch.agentproxy.core/0.0.8/jsch.agentproxy.core-0.0.8.pom
 (804 B at 14.0 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/com/jcraft/jsch.agentproxy.connector-factory/0.0.8/jsch.agentproxy.connector-factory-0.0.8.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/com/jcraft/jsch.agentproxy.connector-factory/0.0.8/jsch.agentproxy.connector-factory-0.0.8.pom
 (2 KB at 20.8 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/com/jcraft/jsch.agentproxy.usocket-jna/0.0.8/jsch.agentproxy.usocket-jna-0.0.8.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/com/jcraft/jsch.agentproxy.usocket-jna/0.0.8/jsch.agentproxy.usocket-jna-0.0.8.pom
 (2 KB at 14.3 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/net/java/dev/jna/jna/4.1.0/jna-4.1.0.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/net/java/dev/jna/jna/4.1.0/jna-4.1.0.pom
 (2 KB at 83.1 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/net/java/dev/jna/jna-platform/4.1.0/jna-platform-4.1.0.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/net/java/dev/jna/jna-platform/4.1.0/jna-platform-4.1.0.pom
 (2 KB at 26.1 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/com/jcraft/jsch.agentproxy.usocket-nc/0.0.8/jsch.agentproxy.usocket-nc-0.0.8.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/com/jcraft/jsch.agentproxy.usocket-nc/0.0.8/jsch.agentproxy.usocket-nc-0.0.8.pom
 (996 B at 22.6 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/com/jcraft/jsch.agentproxy.sshagent/0.0.8/jsch.agentproxy.sshagent-0.0.8.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/com/jcraft/jsch.agentproxy.sshagent/0.0.8/jsch.agentproxy.sshagent-0.0.8.pom
 (971 B at 8.4 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/com/jcraft/jsch.agentproxy.pageant/0.0.8/jsch.agentproxy.pageant-0.0.8.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/com/jcraft/jsch.agentproxy.pageant/0.0.8/jsch.agentproxy.pageant-0.0.8.pom
 (2 KB at 26.3 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/snapshot/org/apache/jclouds/labs/googlecloud/2.0.0-SNAPSHOT/googlecloud-2.0.0-SNAPSHOT.jar
Downloading: 
https://repository.apache.org/content/repositories/snapshots/org/apache/jclouds/labs/googlecloud/2.0.0-SNAPSHOT/googlecloud-2.0.0-SNAPSHOT.jar
Downloading: 
https://repository.apache.org/content/repositories/snapshots/org/apache/jclouds/jclouds-compute/2.0.0-SNAPSHOT/jclouds-compute-2.0.0-20141113.105233-110.jar
Downloading: 
https://repository.apache.org/content/repositories/snapshots/org/apache/jclouds/jclouds-scriptbuilder/2.0.0-SNAPSHOT/jclouds-scriptbuilder-2.0.0-20141113.105145-111.jar
Downloaded: 
https://repository.apache.org/content/repositories/snapshots/org/apache/jclouds/jclouds-scriptbuilder/2.0.0-SNAPSHOT/jclouds-scriptbuilder-2.0.0-20141113.105145-111.jar
 (170 KB at 174.8 KB/sec)
Downloaded: 
https://repository.apache.org/content/repositories/snapshots/org/apache/jclouds/jclouds-compute/2.0.0-SNAPSHOT/jclouds-compute-2.0.0-20141113.105233-110.jar
 (501 KB at 245.6 KB/sec)
Downloading: 
http://repository.apache.org/snapshots/org/apache/jclouds/labs/googlecloud/2.0.0-SNAPSHOT/googlecloud-2.0.0-SNAPSHOT.jar
[WARNING] The following dependencies could not be resolved at this point of the 
build but seem to be part of the reactor:
[WARNING] o org.apache.jclouds.labs:googlecloud:jar:2.0.0-SNAPSHOT (compile)
[WARNING] Try running the build up to the lifecycle phase "package"
Downloading: 
https://repository.apache.org/content/repositories/snapshots/org/apache/jclouds/jclouds-blobstore/2.0.0-SNAPSHOT/maven-metadata.xml
Downloading: 
http://repository.apache.org/snapshots/org/a

Build failed in Jenkins: jclouds-labs-google #321

[jenkins-no-reply]

See 

Changes:

[Adrian Cole] Dedupe code between google cloud products.

--
[...truncated 2403 lines...]
[ERROR] 
[ERROR] --
[ERROR] 2 required artifacts are missing.
[ERROR] 
[ERROR] for artifact:
[ERROR] org.apache.jclouds.labs:google-compute-engine:jar:2.0.0-SNAPSHOT
[ERROR] 
[ERROR] from the specified remote repositories:
[ERROR] central (http://repo.cloudbees.com/content/repositories/central, 
releases=true, snapshots=false),
[ERROR] cloudbees-private-snapshot-repository 
(https://repository-jclouds.forge.cloudbees.com/snapshot, releases=false, 
snapshots=true),
[ERROR] cloudbees-private-release-repository 
(https://repository-jclouds.forge.cloudbees.com/release, releases=true, 
snapshots=false),
[ERROR] apache-snapshots 
(https://repository.apache.org/content/repositories/snapshots, releases=false, 
snapshots=true),
[ERROR] apache.snapshots (http://repository.apache.org/snapshots, 
releases=false, snapshots=true)
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-javadoc-plugin:2.9:aggregate-jar (javadoc) on 
project jclouds-labs-google: MavenReportException: Error while creating 
archive: Missing:
--
1) org.apache.jclouds.labs:googlecloud:test-jar:tests:2.0.0-SNAPSHOT

  Try downloading the file manually from the project website.

  Then, install it using the command: 
  mvn install:install-file -DgroupId=org.apache.jclouds.labs 
-DartifactId=googlecloud -Dversion=2.0.0-SNAPSHOT -Dclassifier=tests 
-Dpackaging=test-jar -Dfile=/path/to/file

  Alternatively, if you host your own repository you can deploy the file there: 
  mvn deploy:deploy-file -DgroupId=org.apache.jclouds.labs 
-DartifactId=googlecloud -Dversion=2.0.0-SNAPSHOT -Dclassifier=tests 
-Dpackaging=test-jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]

  Path to dependency: 
1) org.apache.jclouds.labs:google-compute-engine:jar:2.0.0-SNAPSHOT
2) org.apache.jclouds.labs:googlecloud:test-jar:tests:2.0.0-SNAPSHOT

2) org.apache.jclouds.labs:googlecloud:jar:2.0.0-SNAPSHOT

  Try downloading the file manually from the project website.

  Then, install it using the command: 
  mvn install:install-file -DgroupId=org.apache.jclouds.labs 
-DartifactId=googlecloud -Dversion=2.0.0-SNAPSHOT -Dpackaging=jar 
-Dfile=/path/to/file

  Alternatively, if you host your own repository you can deploy the file there: 
  mvn deploy:deploy-file -DgroupId=org.apache.jclouds.labs 
-DartifactId=googlecloud -Dversion=2.0.0-SNAPSHOT -Dpackaging=jar 
-Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]

  Path to dependency: 
1) org.apache.jclouds.labs:google-compute-engine:jar:2.0.0-SNAPSHOT
2) org.apache.jclouds.labs:googlecloud:jar:2.0.0-SNAPSHOT

--
2 required artifacts are missing.

for artifact: 
  org.apache.jclouds.labs:google-compute-engine:jar:2.0.0-SNAPSHOT

from the specified remote repositories:
  central (http://repo.cloudbees.com/content/repositories/central, 
releases=true, snapshots=false),
  cloudbees-private-snapshot-repository 
(https://repository-jclouds.forge.cloudbees.com/snapshot, releases=false, 
snapshots=true),
  cloudbees-private-release-repository 
(https://repository-jclouds.forge.cloudbees.com/release, releases=true, 
snapshots=false),
  apache-snapshots 
(https://repository.apache.org/content/repositories/snapshots, releases=false, 
snapshots=true),
  apache.snapshots (http://repository.apache.org/snapshots, releases=false, 
snapshots=true)

at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at 
org.jvnet.hudson.maven3.launcher.Maven3Launcher.main(Maven3Launcher.java:117)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchStandard(Laun

Re: [jclouds-labs-google] Dedupe code between google cloud products. (#93)

[Adrian Cole]

thx for the look, @ccustine.

OK, I think I can work on cloud storage without disrupting GCE now.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/93#issuecomment-62947554

Re: [jclouds-labs-google] Dedupe code between google cloud products. (#93)

[Adrian Cole]

same live tests results in GCE as before:

```
Results :

Failed tests: 
  
GoogleComputeEngineServiceLiveTest>BaseComputeServiceLiveTest.testCreateAndRunAService:706->BaseComputeServiceLiveTest.createAndRunAServiceInGroup:723
 » RunNodes
  
GoogleComputeEngineServiceLiveTest>BaseComputeServiceLiveTest.testAScriptExecutionAfterBootWithBasicTemplate:223
 » RunNodes
  
GoogleComputeEngineServiceLiveTest>BaseComputeServiceLiveTest.testConcurrentUseOfComputeServiceToCreateNodes:475
 » Execution

Tests run: 115, Failures: 3, Errors: 0, Skipped: 13
```

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/93#issuecomment-62942815

Re: [jclouds-labs-google] Add setDiskAutoDelete to InstanceApi (#89)

[Adrian Cole]

> @@ -196,7 +229,7 @@ public void testResetInstance() {
>assertOperationDoneSuccessfully(api().reset(INSTANCE_NAME));
> }
>  
> -   @Test(groups = "live", dependsOnMethods = "testResetInstance")
> +   @Test(groups = "live", dependsOnMethods = {"testSetDiskAutoDelete", 
> "testResetInstance"}, alwaysRun = true)

FWIW I prefer this. Otherwise, we duplicate this, one to test the delete
and one for cleanup method.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/89/files#r20310976

Re: [jclouds-labs-google] Dedupe code between google cloud products. (#93)

[Adrian Cole]

new lines are largely due to another pom.xml and logback file, and license 
header from an extracted class. Logic-wise, there's less.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/93#issuecomment-62940199

Re: [jclouds-labs-google] Add setDiskAutoDelete to InstanceApi (#89)

[danbroudy]

> @@ -196,7 +229,7 @@ public void testResetInstance() {
>assertOperationDoneSuccessfully(api().reset(INSTANCE_NAME));
> }
>  
> -   @Test(groups = "live", dependsOnMethods = "testResetInstance")
> +   @Test(groups = "live", dependsOnMethods = {"testSetDiskAutoDelete", 
> "testResetInstance"}, alwaysRun = true)

That is what I was thinking. I don't feel strongly about it, I just got tired 
of having to delete things if the tests failed partway through. 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/89/files#r20310503

Re: [jclouds-labs-google] Dedupe code between google cloud products. (#93)

[Adrian Cole]

GCS has a similar amount of live test errors as before. As soon as this is in, 
I'll get to the bottom of them.

{code}
Results :

Failed tests: 
  
GCSBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutIncorrectContentMD5:271
 null
  BucketAccessControlsApiLiveTest.testCreateBucketAcl:49->createBucket:43 » 
NullPointer
  BucketApiLiveTest.testCreateBucket:69 » NullPointer param{project} for 
invocat...
  BucketApiLiveTest.testCreateBucketWithOptions:119 » NullPointer 
param{project}...
  
DefaultObjectAccessControlsApiLiveTest.testCreateDefaultObjectAcl:49->createBucket:43
 » NullPointer
  ObjectApiLiveTest.createBucket:94 » NullPointer param{project} for invocation 
...
  
GCSContainerIntegrationLiveTest>BaseContainerIntegrationTest.deleteContainerWithoutContents:292->BaseBlobStoreIntegrationTest.recycleContainerAndAddToPool:494->BaseBlobStoreIntegrationTest.recycleContainer:500->BaseBlobStoreIntegrationTest.createContainerAndEnsureEmpty:260->BaseBlobStoreIntegrationTest.createContainerAndEnsureEmpty:253
 » HttpResponse
  
GCSContainerIntegrationLiveTest>BaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:315
 » ResourceNotFound

Tests run: 101, Failures: 8, Errors: 0, Skipped: 55
{code}

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/93#issuecomment-62939266

Re: [jclouds-labs-google] Dedupe code between google cloud products. (#93)

[BuildHive]

[jclouds » jclouds-labs-google 
#1712](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1712/)
 SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/93#issuecomment-62939055

Re: [jclouds-labs-google] Dedupe code between google cloud products. (#93)

[BuildHive]

[jclouds » jclouds-labs-google 
#1711](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1711/)
 SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/93#issuecomment-62938148

Re: [jclouds-labs-google] Dedupe code between google cloud products. (#93)

[CloudBees pull request builder plugin]

[jclouds-labs-google-pull-requests 
#287](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/287/)
 SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/93#issuecomment-62938141

Re: [jclouds-labs-google] Dedupe code between google cloud products. (#93)

[Adrian Cole]

> @@ -61,25 +52,12 @@ protected void bindErrorHandlers() {
> }
>  
> @Provides
> -   @Singleton
> -   @UserProject
> -   public Supplier supplyProject(@Provider final 
> Supplier creds, final GoogleCloudStorageApi api,
> -AtomicReference authException, 
> @Named(PROPERTY_SESSION_INTERVAL) long seconds) {
> -  return 
> MemoizedRetryOnTimeOutButNotOnAuthorizationExceptionSupplier.create(authException,

this was absolutely senseless. we don't need to guard authorization errors when 
only parsing a string!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/93/files#r20309718

Re: [jclouds-labs-google] Dedupe code between google cloud products. (#93)

[CloudBees pull request builder plugin]

[jclouds-labs-google-pull-requests 
#286](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/286/)
 SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/93#issuecomment-62937553

Re: [jclouds-labs-google] Dedupe code between google cloud products. (#93)

[Adrian Cole]

@nacx @ccustine @danbroudy heads up; I need this to finish up google storage 
without wanting to fork my eyes

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/93#issuecomment-62937116

[jclouds-labs-google] Dedupe code between google cloud products. (#93)

[Adrian Cole]

There were a lot of copy/paste errors between google cloud storage and google 
compute engine. This change extracts the items common between the apis, 
particularly aspects such as how to specify the default project, and how list 
page works.
You can merge this Pull Request by running:

  git pull https://github.com/adriancole/jclouds-labs-google adrian.one-google

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-google/pull/93

-- Commit Summary --

  * Dedupe code between google cloud products.

-- File Changes --

M google-cloud-storage/README.md (38)
M google-cloud-storage/pom.xml (253)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageApiMetadata.java
 (35)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageFallbacks.java
 (18)
A 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageProviderMetadata.java
 (72)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GCSBlobStore.java
 (13)
R 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/config/GoogleCloudStorageBlobStoreContextModule.java
 (7)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/ObjectListToStorageMetadata.java
 (9)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/strategy/internal/MultipartUploadSlicingAlgorithm.java
 (9)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/GoogleCloudStorageHttpApiModule.java
 (40)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/GoogleCloudStorageParserModule.java
 (9)
D 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/UserProject.java
 (33)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/Bucket.java
 (4)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/GCSObject.java
 (2)
R 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/ListPageWithPrefixes.java
 (13)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/BucketApi.java
 (5)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/ObjectApi.java
 (13)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/handlers/GoogleCloudStorageRedirectRetryHandler.java
 (1)
D 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/internal/NullSafeCopies.java
 (39)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/options/ListOptions.java
 (8)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/parser/ParseToPayloadEnclosing.java
 (1)
M 
google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/reference/GoogleCloudStorageConstants.java
 (2)
R 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/GoogleCloudStorageProviderMetadataTest.java
 (24)
M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GCSBlobIntegrationLiveTest.java
 (16)
M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GCSBlobLiveTest.java
 (6)
M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GCSContainerIntegrationLiveTest.java
 (7)
M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GCSContainerLiveTest.java
 (7)
M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketApiExpectTest.java
 (5)
M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketApiLiveTest.java
 (3)
M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ObjectApiLiveTest.java
 (6)
M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/internal/BaseGoogleCloudStorageApiExpectTest.java
 (3)
M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/internal/BaseGoogleCloudStorageApiLiveTest.java
 (17)
M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/internal/BaseGoogleCloudStorageExpectTest.java
 (21)
M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/internal/BaseGoogleCloudStorageParseTest.java
 (3)
M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/FullBucketGetTest.java
 (2)
M 
google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/parse/NoAclBucketListTest.java
 (5)
A google-cloud-storage/src/test/resources/logback.xml (83)
M google-compute-engine/pom.xml (8)
M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/GoogleComputeEngineApi.java
 (2)
M 
google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/GoogleComputeEngineApiMetadata.java
 (6)
M 
google-compu

Re: [jclouds-labs-google] Add setDiskAutoDelete to InstanceApi (#89)

[Andrew Phillips]

> @@ -196,7 +229,7 @@ public void testResetInstance() {
>assertOperationDoneSuccessfully(api().reset(INSTANCE_NAME));
> }
>  
> -   @Test(groups = "live", dependsOnMethods = "testResetInstance")
> +   @Test(groups = "live", dependsOnMethods = {"testSetDiskAutoDelete", 
> "testResetInstance"}, alwaysRun = true)

Just to clarify: we're setting `alwaysRun = true` as we also consider this to 
be the cleanup method for this test?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/89/files#r20294965

[jira] [Commented] (JCLOUDS-172) "Graduate" GCE to core

[Eric Johnson (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209723#comment-14209723
 ] 

Eric Johnson commented on JCLOUDS-172:
--

This is really great to hear [~adriancole].  Thank you very much for help 
getting us into a much better state!

> "Graduate" GCE to core
> --
>
> Key: JCLOUDS-172
> URL: https://issues.apache.org/jira/browse/JCLOUDS-172
> Project: jclouds
>  Issue Type: Task
>  Components: jclouds-labs-google
>Affects Versions: 1.8.0
>Reporter: Andrew Bayer
>Assignee: Adrian Cole
>Priority: Critical
>
> We should really get GCE to a "finished" state and include it in 1.7.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build is back to stable : jclouds » jclouds-labs #1869

[BuildHive]

See 

Jenkins build became unstable: jclouds » jclouds-labs #1868

[BuildHive]

See 

Jenkins build is back to normal : jclouds-karaf #770

[jenkins-no-reply]

See 

Jenkins build is back to stable : jclouds » jclouds-labs-google #1709

[BuildHive]

See 

Jenkins build is back to normal : jclouds-labs-openstack #536

[jenkins-no-reply]

See 

Jenkins build is back to normal : jclouds-labs-openstack » jclouds openstack-glance api #536

[jenkins-no-reply]

See 

Re: [jclouds] Small cleanup of how RegionToEndpoint checks arguments. (#599)

[BuildHive]

[jclouds » jclouds 
#1902](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1902/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/599#issuecomment-62877911

Re: [jclouds] Small cleanup of how RegionToEndpoint checks arguments. (#599)

[CloudBees pull request builder plugin]

[jclouds-pull-requests 
#1375](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1375/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/599#issuecomment-62874932

Re: [jclouds] Small cleanup of how RegionToEndpoint checks arguments. (#599)

[CloudBees pull request builder plugin]

[jclouds-pull-requests-java-7 
#286](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/286/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/599#issuecomment-62873978

Re: [jclouds] Small cleanup of how RegionToEndpoint checks arguments. (#599)

[Zack Shoylev]

merged

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/599#issuecomment-62871915

Re: [jclouds] Small cleanup of how RegionToEndpoint checks arguments. (#599)

[Zack Shoylev]

Closed #599.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/599#event-192598739

Re: [jclouds] Small cleanup of how RegionToEndpoint checks arguments. (#599)

[Zack Shoylev]

No backport planned
About to squash/merge

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/599#issuecomment-62869270