Re: [jclouds-labs-google] Make deleteObject() return false on 404 response (#122)
@@ -199,7 +198,7 @@ GoogleCloudStorageObject simpleUpload(@PathParam(bucket) String bucketName, @H @Named(Object:delete) @DELETE @Path(storage/v1/b/{bucket}/o/{object}) - @Fallback(TrueOnNotFoundOr404.class) + @Fallback(FalseOnNotFoundOr404.class) Definitely, can you either modify an existing test or add a new test? We need not check at all call sites, but at least the basic delete test should do this. Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/122/files#r23021488
[jira] [Created] (JCLOUDS-804) Cannot run jclouds-cli
Andrea Turli created JCLOUDS-804: Summary: Cannot run jclouds-cli Key: JCLOUDS-804 URL: https://issues.apache.org/jira/browse/JCLOUDS-804 Project: jclouds Issue Type: Bug Components: jclouds-cli Affects Versions: 2.0.0 Reporter: Andrea Turli Assignee: Ioannis Canellos Fix For: 1.9.0 after building from source, ./bin/jclouds return `Error: Could not find or load main class org.jclouds.cli.runner.Main` -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jclouds-cli] [JCLOUDS-804] Align assembly descriptors and scripts with the new artifa... (#25)
...ctId of jclouds-cli-runner. Ensure guava is in the classpath. You can merge this Pull Request by running: git pull https://github.com/iocanel/jclouds-cli 804 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-cli/pull/25 -- Commit Summary -- * [JCLOUDS-804] Align assembly descriptors and scripts with the new artifactId of jclouds-cli-runner. Ensure guava is in the classpath. -- File Changes -- M assembly/pom.xml (7) M assembly/src/main/assembly/unix.xml (11) M assembly/src/main/assembly/win.xml (11) M assembly/src/main/filtered-resources/unix/bin/shell (3) M assembly/src/main/filtered-resources/win/bin/shell.bat (3) -- Patch Links -- https://github.com/jclouds/jclouds-cli/pull/25.patch https://github.com/jclouds/jclouds-cli/pull/25.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/25
[jira] [Closed] (JCLOUDS-804) Cannot run jclouds-cli
[ https://issues.apache.org/jira/browse/JCLOUDS-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrea Turli closed JCLOUDS-804. Resolution: Fixed Cannot run jclouds-cli -- Key: JCLOUDS-804 URL: https://issues.apache.org/jira/browse/JCLOUDS-804 Project: jclouds Issue Type: Bug Components: jclouds-cli Affects Versions: 2.0.0 Reporter: Andrea Turli Assignee: Ioannis Canellos Fix For: 1.9.0 after building from source, ./bin/jclouds return `Error: Could not find or load main class org.jclouds.cli.runner.Main` -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jclouds-cli] [JCLOUDS-804] Align assembly descriptors and scripts with the new artifa... (#25)
@iocanel lgtm! I've tested and it works great! thanks! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/25#issuecomment-70151677
[jira] [Commented] (JCLOUDS-804) Cannot run jclouds-cli
[ https://issues.apache.org/jira/browse/JCLOUDS-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279279#comment-14279279 ] Andrea Turli commented on JCLOUDS-804: -- This https://github.com/jclouds/jclouds-cli/pull/25 closes the issue. Thanks [~iocanel] Cannot run jclouds-cli -- Key: JCLOUDS-804 URL: https://issues.apache.org/jira/browse/JCLOUDS-804 Project: jclouds Issue Type: Bug Components: jclouds-cli Affects Versions: 2.0.0 Reporter: Andrea Turli Assignee: Ioannis Canellos Fix For: 1.9.0 after building from source, ./bin/jclouds return `Error: Could not find or load main class org.jclouds.cli.runner.Main` -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jclouds-cli] [JCLOUDS-804] Align assembly descriptors and scripts with the new artifa... (#25)
Could you please squash those 3 commits into 1, so that I can merge it? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/25#issuecomment-70152193
Re: [jclouds-cli] [JCLOUDS-804] Align assembly descriptors and scripts with the new artifa... (#25)
Merged #25. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-cli/pull/25#event-219672059
[jira] [Commented] (JCLOUDS-805) Google Cloud Storage integration test failures
[ https://issues.apache.org/jira/browse/JCLOUDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279499#comment-14279499 ] ASF subversion and git services commented on JCLOUDS-805: - Commit 2a4ed3c89e9f13a13f592896e6a1a36c389239eb in jclouds-labs-google's branch refs/heads/master from [~gaul] [ https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;h=2a4ed3c ] JCLOUDS-805: fix GCS MD5 checks Regression from b8670b16e3793fb17255381faee6608d694c387a. Google Cloud Storage integration test failures -- Key: JCLOUDS-805 URL: https://issues.apache.org/jira/browse/JCLOUDS-805 Project: jclouds Issue Type: Bug Components: jclouds-blobstore Affects Versions: 2.0.0 Reporter: Andrew Gaul Labels: google-cloud-storage Attachments: testresults.txt {noformat} Failed tests: GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutByteSource:531-BaseBlobIntegrationTest.testPut:574 » HttpResponse GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutIncorrectContentMD5:277 null GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutInputStream:539-BaseBlobIntegrationTest.testPut:574 » HttpResponse GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:372 » ResourceNotFound GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.testListContainerGetBlobSize:409 expected [42] but found [null] GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.testListMarkerAfterLastKey:88 » HttpResponse ResumableUploadApiLiveTest.testResumableChunkedUpload:120 expected object to not be null ResumableUploadApiLiveTest.testResumableJpegUpload:83 expected object to not be null BucketApiLiveTest.testPatchBucket:192 » Authorization { error: { errors... BucketApiLiveTest.testUpdateBucket:133 » Authorization { error: { errors... BucketApiLiveTest.testUpdateBucketWithOptions:146 » Authorization { error: ... ObjectApiLiveTest.testSimpleJpegUpload:157-checkHashCodes:399 expected [8FdApr35Ql5P3B1cOAavYg==] but found [f05740a6bdf9425e4fdc1d5c3806af62] ObjectApiLiveTest.testUpdateObject:293 » Authorization { error: { errors... ObjectApiLiveTest.deleteBucket:425 » IllegalState { error: { errors: [ ... Tests run: 100, Failures: 14, Errors: 0, Skipped: 17 {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-805) Google Cloud Storage integration test failures
[ https://issues.apache.org/jira/browse/JCLOUDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Gaul updated JCLOUDS-805: Attachment: testresults.txt Google Cloud Storage integration test failures -- Key: JCLOUDS-805 URL: https://issues.apache.org/jira/browse/JCLOUDS-805 Project: jclouds Issue Type: Bug Components: jclouds-blobstore Affects Versions: 2.0.0 Reporter: Andrew Gaul Labels: google-cloud-storage Attachments: testresults.txt {noformat} Failed tests: GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutByteSource:531-BaseBlobIntegrationTest.testPut:574 » HttpResponse GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutIncorrectContentMD5:277 null GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutInputStream:539-BaseBlobIntegrationTest.testPut:574 » HttpResponse GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:372 » ResourceNotFound GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.testListContainerGetBlobSize:409 expected [42] but found [null] GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.testListMarkerAfterLastKey:88 » HttpResponse ResumableUploadApiLiveTest.testResumableChunkedUpload:120 expected object to not be null ResumableUploadApiLiveTest.testResumableJpegUpload:83 expected object to not be null BucketApiLiveTest.testPatchBucket:192 » Authorization { error: { errors... BucketApiLiveTest.testUpdateBucket:133 » Authorization { error: { errors... BucketApiLiveTest.testUpdateBucketWithOptions:146 » Authorization { error: ... ObjectApiLiveTest.testSimpleJpegUpload:157-checkHashCodes:399 expected [8FdApr35Ql5P3B1cOAavYg==] but found [f05740a6bdf9425e4fdc1d5c3806af62] ObjectApiLiveTest.testUpdateObject:293 » Authorization { error: { errors... ObjectApiLiveTest.deleteBucket:425 » IllegalState { error: { errors: [ ... Tests run: 100, Failures: 14, Errors: 0, Skipped: 17 {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JCLOUDS-805) Google Cloud Storage integration test failures
[ https://issues.apache.org/jira/browse/JCLOUDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279367#comment-14279367 ] Andrew Gaul commented on JCLOUDS-805: - [~Bhash90] Could you take a look at these errors? Google Cloud Storage integration test failures -- Key: JCLOUDS-805 URL: https://issues.apache.org/jira/browse/JCLOUDS-805 Project: jclouds Issue Type: Bug Components: jclouds-blobstore Affects Versions: 2.0.0 Reporter: Andrew Gaul Labels: google-cloud-storage Attachments: testresults.txt {noformat} Failed tests: GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutByteSource:531-BaseBlobIntegrationTest.testPut:574 » HttpResponse GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutIncorrectContentMD5:277 null GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutInputStream:539-BaseBlobIntegrationTest.testPut:574 » HttpResponse GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:372 » ResourceNotFound GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.testListContainerGetBlobSize:409 expected [42] but found [null] GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.testListMarkerAfterLastKey:88 » HttpResponse ResumableUploadApiLiveTest.testResumableChunkedUpload:120 expected object to not be null ResumableUploadApiLiveTest.testResumableJpegUpload:83 expected object to not be null BucketApiLiveTest.testPatchBucket:192 » Authorization { error: { errors... BucketApiLiveTest.testUpdateBucket:133 » Authorization { error: { errors... BucketApiLiveTest.testUpdateBucketWithOptions:146 » Authorization { error: ... ObjectApiLiveTest.testSimpleJpegUpload:157-checkHashCodes:399 expected [8FdApr35Ql5P3B1cOAavYg==] but found [f05740a6bdf9425e4fdc1d5c3806af62] ObjectApiLiveTest.testUpdateObject:293 » Authorization { error: { errors... ObjectApiLiveTest.deleteBucket:425 » IllegalState { error: { errors: [ ... Tests run: 100, Failures: 14, Errors: 0, Skipped: 17 {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JCLOUDS-805) Google Cloud Storage integration test failures
[ https://issues.apache.org/jira/browse/JCLOUDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279514#comment-14279514 ] ASF subversion and git services commented on JCLOUDS-805: - Commit 0111e8f88d4a099552ae841c3ff74abbeb6db935 in jclouds-labs-google's branch refs/heads/master from [~gaul] [ https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;h=0111e8f ] JCLOUDS-805: Populate StorageMetadata size for GCS Google Cloud Storage integration test failures -- Key: JCLOUDS-805 URL: https://issues.apache.org/jira/browse/JCLOUDS-805 Project: jclouds Issue Type: Bug Components: jclouds-blobstore Affects Versions: 2.0.0 Reporter: Andrew Gaul Labels: google-cloud-storage Attachments: testresults.txt {noformat} Failed tests: GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutByteSource:531-BaseBlobIntegrationTest.testPut:574 » HttpResponse GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutIncorrectContentMD5:277 null GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutInputStream:539-BaseBlobIntegrationTest.testPut:574 » HttpResponse GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:372 » ResourceNotFound GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.testListContainerGetBlobSize:409 expected [42] but found [null] GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.testListMarkerAfterLastKey:88 » HttpResponse ResumableUploadApiLiveTest.testResumableChunkedUpload:120 expected object to not be null ResumableUploadApiLiveTest.testResumableJpegUpload:83 expected object to not be null BucketApiLiveTest.testPatchBucket:192 » Authorization { error: { errors... BucketApiLiveTest.testUpdateBucket:133 » Authorization { error: { errors... BucketApiLiveTest.testUpdateBucketWithOptions:146 » Authorization { error: ... ObjectApiLiveTest.testSimpleJpegUpload:157-checkHashCodes:399 expected [8FdApr35Ql5P3B1cOAavYg==] but found [f05740a6bdf9425e4fdc1d5c3806af62] ObjectApiLiveTest.testUpdateObject:293 » Authorization { error: { errors... ObjectApiLiveTest.deleteBucket:425 » IllegalState { error: { errors: [ ... Tests run: 100, Failures: 14, Errors: 0, Skipped: 17 {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jclouds] [JCLOUDS-609] Adding vCloud API 1.5 support (#418)
@melanj I am closing this PR since vcloud and vcloud-director have been removed from both the [jclouds](https://github.com/jclouds/jclouds/pull/604) and [jclouds-labs](https://github.com/jclouds/jclouds-labs/pull/111) repos. cc @demobox @nacx --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/418#issuecomment-70178078
Re: [jclouds] [JCLOUDS-609] Adding vCloud API 1.5 support (#418)
Closed #418. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/418#event-219765488
[jira] [Created] (JCLOUDS-805) Google Cloud Storage integration test failures
Andrew Gaul created JCLOUDS-805: --- Summary: Google Cloud Storage integration test failures Key: JCLOUDS-805 URL: https://issues.apache.org/jira/browse/JCLOUDS-805 Project: jclouds Issue Type: Bug Components: jclouds-blobstore Affects Versions: 2.0.0 Reporter: Andrew Gaul {noformat} Failed tests: GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutByteSource:531-BaseBlobIntegrationTest.testPut:574 » HttpResponse GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutIncorrectContentMD5:277 null GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutInputStream:539-BaseBlobIntegrationTest.testPut:574 » HttpResponse GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:372 » ResourceNotFound GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.testListContainerGetBlobSize:409 expected [42] but found [null] GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.testListMarkerAfterLastKey:88 » HttpResponse ResumableUploadApiLiveTest.testResumableChunkedUpload:120 expected object to not be null ResumableUploadApiLiveTest.testResumableJpegUpload:83 expected object to not be null BucketApiLiveTest.testPatchBucket:192 » Authorization { error: { errors... BucketApiLiveTest.testUpdateBucket:133 » Authorization { error: { errors... BucketApiLiveTest.testUpdateBucketWithOptions:146 » Authorization { error: ... ObjectApiLiveTest.testSimpleJpegUpload:157-checkHashCodes:399 expected [8FdApr35Ql5P3B1cOAavYg==] but found [f05740a6bdf9425e4fdc1d5c3806af62] ObjectApiLiveTest.testUpdateObject:293 » Authorization { error: { errors... ObjectApiLiveTest.deleteBucket:425 » IllegalState { error: { errors: [ ... Tests run: 100, Failures: 14, Errors: 0, Skipped: 17 {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is back to normal : jclouds-labs-google » Apache jclouds labs google #386
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-google/org.apache.jclouds.labs$jclouds-labs-google/386/
Jenkins build is back to normal : jclouds-labs-google #386
See https://jclouds.ci.cloudbees.com/job/jclouds-labs-google/386/changes
Re: [jclouds-labs-google] Make deleteObject() return false on 404 response (#122)
@@ -199,7 +198,7 @@ GoogleCloudStorageObject simpleUpload(@PathParam(bucket) String bucketName, @H @Named(Object:delete) @DELETE @Path(storage/v1/b/{bucket}/o/{object}) - @Fallback(TrueOnNotFoundOr404.class) + @Fallback(FalseOnNotFoundOr404.class) @snotling I opened [JCLOUDS-805](https://issues.apache.org/jira/browse/JCLOUDS-805) to track this issue. I will take a quick look and asked @hsbhathiya, the original developer, to do the same. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/122/files#r23048033
[jira] [Commented] (JCLOUDS-805) Google Cloud Storage integration test failures
[ https://issues.apache.org/jira/browse/JCLOUDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279597#comment-14279597 ] ASF subversion and git services commented on JCLOUDS-805: - Commit ea22fa2526e58f71b22b096f44a29733a2dd5d57 in jclouds-labs-google's branch refs/heads/master from [~gaul] [ https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-google.git;h=ea22fa2 ] JCLOUDS-805: transposed length and upload id Google Cloud Storage integration test failures -- Key: JCLOUDS-805 URL: https://issues.apache.org/jira/browse/JCLOUDS-805 Project: jclouds Issue Type: Bug Components: jclouds-blobstore Affects Versions: 2.0.0 Reporter: Andrew Gaul Labels: google-cloud-storage Attachments: testresults.txt {noformat} Failed tests: GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutByteSource:531-BaseBlobIntegrationTest.testPut:574 » HttpResponse GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutIncorrectContentMD5:277 null GoogleCloudStorageBlobIntegrationLiveTestBaseBlobIntegrationTest.testPutInputStream:539-BaseBlobIntegrationTest.testPut:574 » HttpResponse GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:372 » ResourceNotFound GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.testListContainerGetBlobSize:409 expected [42] but found [null] GoogleCloudStorageContainerIntegrationLiveTestBaseContainerIntegrationTest.testListMarkerAfterLastKey:88 » HttpResponse ResumableUploadApiLiveTest.testResumableChunkedUpload:120 expected object to not be null ResumableUploadApiLiveTest.testResumableJpegUpload:83 expected object to not be null BucketApiLiveTest.testPatchBucket:192 » Authorization { error: { errors... BucketApiLiveTest.testUpdateBucket:133 » Authorization { error: { errors... BucketApiLiveTest.testUpdateBucketWithOptions:146 » Authorization { error: ... ObjectApiLiveTest.testSimpleJpegUpload:157-checkHashCodes:399 expected [8FdApr35Ql5P3B1cOAavYg==] but found [f05740a6bdf9425e4fdc1d5c3806af62] ObjectApiLiveTest.testUpdateObject:293 » Authorization { error: { errors... ObjectApiLiveTest.deleteBucket:425 » IllegalState { error: { errors: [ ... Tests run: 100, Failures: 14, Errors: 0, Skipped: 17 {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JCLOUDS-654) Provide blob size during container listing
[ https://issues.apache.org/jira/browse/JCLOUDS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14279691#comment-14279691 ] ASF subversion and git services commented on JCLOUDS-654: - Commit e170f1e6323facb45a84b741acb1a30bba09c4f6 in jclouds's branch refs/heads/master from [~gaul] [ https://git-wip-us.apache.org/repos/asf?p=jclouds.git;h=e170f1e ] JCLOUDS-654: Add size to Swift StorageMetadata This allows callers to read the content length during container listing. Follow-on to fae097e144c0b9adf00f88ded1d614e2aec963f8. Provide blob size during container listing -- Key: JCLOUDS-654 URL: https://issues.apache.org/jira/browse/JCLOUDS-654 Project: jclouds Issue Type: New Feature Components: jclouds-blobstore Affects Versions: 1.8.0 Reporter: Andrew Gaul Assignee: Andrew Gaul Fix For: 2.0.0, 1.9.0 All blobstore providers return the content length during a blob list but jclouds does not expose this through the portable abstraction. S3Proxy needs this functionality to more accurately model the S3 API. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jclouds-labs-google] Make deleteObject() return false on 404 response (#122)
@@ -199,7 +198,7 @@ GoogleCloudStorageObject simpleUpload(@PathParam(bucket) String bucketName, @H @Named(Object:delete) @DELETE @Path(storage/v1/b/{bucket}/o/{object}) - @Fallback(TrueOnNotFoundOr404.class) + @Fallback(FalseOnNotFoundOr404.class) In all the tests for GCS, the return value of ``deleteObject()`` calls is not checked. So I think the tests should be improved in that regard. Is that what you meant? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/122/files#r22996584
Re: [jclouds-labs-google] Make deleteObject() return false on 404 response (#122)
@@ -199,7 +198,7 @@ GoogleCloudStorageObject simpleUpload(@PathParam(bucket) String bucketName, @H @Named(Object:delete) @DELETE @Path(storage/v1/b/{bucket}/o/{object}) - @Fallback(TrueOnNotFoundOr404.class) + @Fallback(FalseOnNotFoundOr404.class) Is the current ``master`` GCS test suite supposed to pass? I'm having a few errors, in particular in ``ObjectApiLiveTest`` (the class I'm working on). --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/122/files#r23041040