Jenkins build is back to normal : jclouds-labs-openstack #597

[jenkins-no-reply]

See 

Build failed in Jenkins: jclouds-labs-openstack #596

[jenkins-no-reply]

See 

--
[...truncated 159 lines...]
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/classworlds/classworlds/1.1/classworlds-1.1.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/classworlds/classworlds/1.1/classworlds-1.1.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/classworlds/classworlds/1.1/classworlds-1.1.pom
 (4 KB at 162.3 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/maven-archiver/2.4.1/maven-archiver-2.4.1.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven-archiver/2.4.1/maven-archiver-2.4.1.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven-archiver/2.4.1/maven-archiver-2.4.1.pom
 (4 KB at 83.9 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/shared/maven-shared-components/15/maven-shared-components-15.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/shared/maven-shared-components/15/maven-shared-components-15.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/shared/maven-shared-components/15/maven-shared-components-15.pom
 (10 KB at 506.6 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/maven-parent/16/maven-parent-16.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven-parent/16/maven-parent-16.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven-parent/16/maven-parent-16.pom
 (23 KB at 946.9 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/apache/7/apache-7.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/apache/7/apache-7.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/apache/7/apache-7.pom
 (15 KB at 299.8 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/maven-artifact/2.0.6/maven-artifact-2.0.6.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven-artifact/2.0.6/maven-artifact-2.0.6.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven-artifact/2.0.6/maven-artifact-2.0.6.pom
 (2 KB at 67.0 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/maven/2.0.6/maven-2.0.6.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven/2.0.6/maven-2.0.6.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven/2.0.6/maven-2.0.6.pom
 (9 KB at 490.8 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/maven-model/2.0.6/maven-model-2.0.6.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven-model/2.0.6/maven-model-2.0.6.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven-model/2.0.6/maven-model-2.0.6.pom
 (3 KB at 135.3 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus-archiver/1.0/plexus-archiver-1.0.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-archiver/1.0/plexus-archiver-1.0.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-archiver/1.0/plexus-archiver-1.0.pom
 (2 KB at 82.8 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus-components/1.1.17/plexus-components-1.1.17.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-components/1.1.17/plexus-components-1.1.17.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-components/1.1.17/plexus-components-1.1.17.pom
 (6 KB at 92.5 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus/2.0.5/plexus-2.0.5.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus/2.0.5/plexus-2.0.5.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus/2.0.5/plexus-2.0.5.pom
 (17 KB at 941.2 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus-utils/2.0.5/plexus-utils-2.0.5.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/2.0.5/plexus-utils-2.0.5.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/2.0.5/plexus-utils-2.0.5.pom
 (4 KB at 148.0 KB/sec)
Downloading: 

Jenkins build is back to normal : jclouds-labs-openstack » jclouds openstack-glance api #595

[jenkins-no-reply]

See 

Jenkins build is back to normal : jclouds-guava-17-18 » 18.0,OpenJDK 7 (latest) #48

[jenkins-no-reply]

See 

Jenkins build is back to normal : jclouds-labs-openstack #595

[jenkins-no-reply]

See 

[jclouds] JCLOUDS-794: Use bogus URL for generic S3 endpoint (#649)

[Andrew Gaul]

This prevents users from accidentally connecting to AWS.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/649

-- Commit Summary --

  * JCLOUDS-794: Use bogus URL for generic S3 endpoint

-- File Changes --

M apis/s3/src/main/java/org/jclouds/s3/S3ApiMetadata.java (2)
M apis/s3/src/test/java/org/jclouds/s3/PathBasedS3ClientExpectTest.java (6)
M apis/s3/src/test/java/org/jclouds/s3/S3ClientExpectTest.java (2)
M 
apis/s3/src/test/java/org/jclouds/s3/binders/BindAsHostPrefixIfConfiguredNoPathTest.java
 (2)
M 
apis/s3/src/test/java/org/jclouds/s3/blobstore/S3BlobSignerExpectTest.java (12)
M 
apis/s3/src/test/java/org/jclouds/s3/filters/RequestAuthorizeSignatureTest.java 
(2)
M providers/aws-s3/src/main/java/org/jclouds/aws/s3/AWSS3ApiMetadata.java 
(1)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/649.patch
https://github.com/jclouds/jclouds/pull/649.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/649

Re: [jclouds] fix usermetadata check on OS X (#648)

[Andrew Gaul]

Closed #648.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#event-222046415

[jira] [Updated] (JCLOUDS-193) getBlob does not throw ContainerNotFoundException on non-existent bucket in S3 and Rackspace

[Andrew Gaul (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul updated JCLOUDS-193:

Description: 
getBlob method of BlobStore is assumed to throw ContainerNotFoundException 
exception if the underlying container does not exist. However, for S3 and 
Rackspace providers (only these two were tested) it does not - it simply 
returns null. This severely breaks the API, as it differs from the 
documentation. Moreover, FileSystem provider correctly throws the exception.

Test code that shows the incorrect behaviour is here:
https://gist.github.com/anonymous/5984101

Some (IMHO) relevant output is here:
{noformat}
[main][]   ContainerExistTest:getBlob - Getting blob 'uploadedImage' from 
'wrongtest-container-1'
[main][] keSyncToAsyncHttpMethod:logTrace - >> converting GetObject
[main][] RestAnnotationProcessor:logTrace - using endpoint 
Optional.of(https://s3.amazonaws.com) for public abstract 
com.google.common.util.concurrent.ListenableFuture 
org.jclouds.s3.S3AsyncClient.getObject(java.lang.String,java.lang.String,org.jclouds.http.options.GetOptions[])[wrongtest-container-1,
 uploadedImage, [Lorg.jclouds.http.options.GetOptions;@707b11cf]
[main][] RestAnnotationProcessor:logTrace - adding filter 
org.jclouds.s3.filters.RequestAuthorizeSignature@46f50ae2 from annotation on 
org.jclouds.s3.S3AsyncClient
[main][] keSyncToAsyncHttpMethod:logTrace - << converted GetObject to GET 
https://wrongtest-container-1.s3.amazonaws.com/uploadedImage HTTP/1.1
[main][] keSyncToAsyncHttpMethod:logTrace - << response from GetObject is 
parsed by ParseObjectFromHeadersAndHttpContent
[main][] keSyncToAsyncHttpMethod:logTrace - << exceptions from GetObject are 
parsed by NullOnKeyNotFound
[main][] keSyncToAsyncHttpMethod:logDebug - >> invoking GetObject
[main][]   signature:logDebug - >> GET 
https://wrongtest-container-1.s3.amazonaws.com/uploadedImage HTTP/1.1
[main][]   signature:logDebug - >> Host: 
wrongtest-container-1.s3.amazonaws.com
[main][]   signature:logDebug - >> Date: Fri, 12 Jul 2013 12:25:11 
GMT
[main][]   signature:logDebug - >> "GET[\n]"
[main][]   signature:logDebug - >> "[\n]"
[main][]   signature:logDebug - >> "[\n]"
[main][]   signature:logDebug - >> "Fri, 12 Jul 2013 12:25:11 
GMT[\n]"
[main][]   signature:logDebug - >> 
"/wrongtest-container-1/uploadedImage"
[main][]   signature:logDebug - << GET 
https://wrongtest-container-1.s3.amazonaws.com/uploadedImage HTTP/1.1
[main][]   signature:logDebug - << Host: 
wrongtest-container-1.s3.amazonaws.com
[main][]   signature:logDebug - << Date: Fri, 12 Jul 2013 12:25:11 
GMT
[main][] pCommandExecutorService:logDebug - Sending request 2132681414: GET 
https://wrongtest-container-1.s3.amazonaws.com/uploadedImage HTTP/1.1
[main][] headers:logDebug - >> GET 
https://wrongtest-container-1.s3.amazonaws.com/uploadedImage HTTP/1.1
[main][] headers:logDebug - >> Host: 
wrongtest-container-1.s3.amazonaws.com
[main][] headers:logDebug - >> Date: Fri, 12 Jul 2013 12:25:11 
GMT
[main][] pCommandExecutorService:logDebug - Receiving response 2132681414: 
HTTP/1.1 404 Not Found
[main][] headers:logDebug - << HTTP/1.1 404 Not Found
[main][] headers:logDebug - << x-amz-request-id: 
3EE5AFE13C3ACE57
[main][] headers:logDebug - << Date: Fri, 12 Jul 2013 12:25:14 
GMT
[main][] headers:logDebug - << Transfer-Encoding: chunked
[main][] headers:logDebug - << x-amz-id-2: 
[main][] headers:logDebug - << Server: AmazonS3
[main][] headers:logDebug - << Content-Type: application/xml
[main][]wire:logDebug - << "[\n]"
[main][]wire:logDebug - << 
"NoSuchBucketThe specified bucket does not 
existwrongtest-container-13EE5AFE13C3ACE57snip"
[main][]   ContainerExistTest:getBlob - Got blob 'null'
[main][] tainerExistTest:verifyOperations - Got this blob!? null
{noformat}

  was:
getBlob method of BlobStore is assumed to throw ContainerNotFoundException 
exception if the underlying container does not exist. However, for S3 and 
Rackspace providers (only these two were tested) it does not - it simply 
returns null. This severely breaks the API, as it differs from the 
documentation. Moreover, FileSystem provider correctly throws the exception.

Test code that shows the incorrect behaviour is here:
https://gist.github.com/anonymous/5984101

Some (IMHO) relevant output is here:
[main][]   ContainerExistTest:getBlob - Getting blob 'uploadedImage' from 
'wrongtest-container-1'
[main][] keSyncToAsyncHttpMethod:logTrace - >> converting GetObject
[main][] RestAnnotationProcessor:logTrace - using endpoint 
Optional.of(https://s3.amazonaws.com) for public abstract 

[jira] [Updated] (JCLOUDS-206) Add flag to list blob metadata to list blob command

[Andrew Gaul (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul updated JCLOUDS-206:

Assignee: (was: Andrew Gaul)

> Add flag to list blob metadata to list blob command
> ---
>
> Key: JCLOUDS-206
> URL: https://issues.apache.org/jira/browse/JCLOUDS-206
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-karaf
>Affects Versions: 1.6.1
>Reporter: Andrew Gaul
>Priority: Minor
>
> Presently this command only lists blob names.  It should also offer a 
> --details flag, which ideally would be machine-parsable.  Current output for 
> BlobStore.blobMetadata().toString():
> [type=BLOB, id=null, name=0008a570cc5fb0fcc0aa05bf37436ddb, 
> location={scope=REGION, id=us-standard, description=us-standard, 
> parent=aws-s3, iso3166Codes=[US]}, 
> uri=https://cloud-testing.s3.amazonaws.com/0008a570cc5fb0fcc0aa05bf37436ddb, 
> userMetadata={}]
> and for BlobStore.blobMetadata().getContentMetadata().toString():
> [contentDisposition=null, contentEncoding=null, contentLanguage=null, 
> contentLength=1, contentMD5=[-43, 39, -54, 7, 77, 65, 45, -99, 15, -4, -124, 
> 72, 114, -60, 96, 60], contentType=application/unknown, expires=null]
> This output is hard to parse and injurious to the human spirit.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (JCLOUDS-271) Support supplying a list of blobs to retrieve from the blobstore

[Andrew Gaul (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul updated JCLOUDS-271:

Assignee: (was: Andrew Gaul)

> Support supplying a list of blobs to retrieve from the blobstore
> 
>
> Key: JCLOUDS-271
> URL: https://issues.apache.org/jira/browse/JCLOUDS-271
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-cli
>Affects Versions: 1.6.2
>Reporter: Timur Alperovich
>
> It would be really useful to be able to retrieve multiple blobs from the 
> blobstore. Currently, jclouds-cli only allows to retrieve one blob at a time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (JCLOUDS-533) Add support for S3 server-side encryption

[Andrew Gaul (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul updated JCLOUDS-533:

Assignee: (was: Andrew Gaul)

> Add support for S3 server-side encryption
> -
>
> Key: JCLOUDS-533
> URL: https://issues.apache.org/jira/browse/JCLOUDS-533
> Project: jclouds
>  Issue Type: Improvement
>  Components: jclouds-blobstore
>Affects Versions: 1.7.1
>Reporter: Andrew Gaul
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (JCLOUDS-799) new Swift provider should support multipart upload in portable abstraction

[Andrew Gaul (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul resolved JCLOUDS-799.
-
Resolution: Duplicate

Duplicate of JCLOUDS-760.

> new Swift provider should support multipart upload in portable abstraction
> --
>
> Key: JCLOUDS-799
> URL: https://issues.apache.org/jira/browse/JCLOUDS-799
> Project: jclouds
>  Issue Type: New Feature
>  Components: jclouds-blobstore
>Affects Versions: 1.8.1
>Reporter: Andrew Gaul
>Assignee: Jeremy Daggett
>  Labels: openstack-swift
>
> Presently {{RegionScopedSwiftBlobStore.putBlob}} throws 
> {{UnsupportedOperationException}} when {{options.isMultipart}} is true.  This 
> represents a regression in functionality for any user migrating from the old 
> Swift provider.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (JCLOUDS-631) Slowdown of putBlob operation for the FileSystem provider

[Andrew Gaul (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul resolved JCLOUDS-631.
-
Resolution: Cannot Reproduce
  Assignee: Andrew Gaul

> Slowdown of putBlob operation for the FileSystem provider
> -
>
> Key: JCLOUDS-631
> URL: https://issues.apache.org/jira/browse/JCLOUDS-631
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-blobstore
>Affects Versions: 1.8.0
>Reporter: Nikola Knezevic
>Assignee: Andrew Gaul
>
> The following (incomplete) piece of code when run for the filesystem provider 
> and swift, for uploading a 1GB file shows 2-3x slowdown for the filesystem 
> provider.
> Note that the code only _writes_ through jclouds, there is no reading 
> involved.
> {code}
>  public void sendLargeFilesOnlyJclouds() throws Exception
> {
> LOG.info("Working with {}", p);
> Environment env = 
> Environment.builder().setName("SomeName").addProperties(p).build();
> String providerName = env.getConnectionModules().get(0).getName();
> String provider = checkNotNull(env.getProperty(providerName + 
> ".provider"), new ICStoreException("No provider specified"));
> Iterable modules =
> ImmutableSet.of(
> new SLF4JLoggingModule()
> );
> if(provider.equals("s3"))
> {
> provider = "aws-s3";
> modules =
> ImmutableSet.builder()
> .addAll(modules)
> .add(new ICStoreMultipartUploadModule())
> .build();
> }
> Properties properties = new Properties();
> // store provider credentials in properties
> properties.setProperty(provider + ".identity", env.getProperty( 
> providerName + ".identity", ""));
> properties.setProperty(provider + ".credential", 
> env.getProperty(providerName + ".credential", ""));
> properties.putAll(env.getPropertiesForModule(providerName));
> final BlobStoreContext blobStoreContext = 
> ContextBuilder.newBuilder(provider)
> .overrides(properties)
> .modules(modules)
> .buildView(BlobStoreContext.class);
> final BlobStore bs = blobStoreContext.getBlobStore();
> bs.createContainerInLocation(null, "mycontainer");
> for (int i = 0; i < num_invocations; i++)
> {
> InputStream fis = new FakeInputStream(FAKE_IS_SEED, blobSize);
> Blob blob = bs.blobBuilder("myblob").payload(fis).build();
> LOG.info("Invocation number {}", i);
> long startTime = System.currentTimeMillis();
> bs.putBlob("mycontainer", blob);
> long stopTime = System.currentTimeMillis();
> LOG.info("Running time for one blob is {}", stopTime - startTime);
> }
> }
> {code}
> Where {{FakeInputStream}} is an input stream that produces a deterministic 
> output (though method {{read()}}, of a given size, and {{Environment}} is 
> just a smarter container for {{Properties}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (JCLOUDS-749) Files of 961450810 bytes are corupted in swift when using multipart

[Andrew Gaul (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul updated JCLOUDS-749:

Environment: (was: storage: swift  )

> Files of 961450810 bytes are corupted in swift when using multipart 
> 
>
> Key: JCLOUDS-749
> URL: https://issues.apache.org/jira/browse/JCLOUDS-749
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-blobstore
>Affects Versions: 1.8.0
>Reporter: Spiros Koulouzis
>  Labels: swift
>
> Uploading any file of 961450810 bytes (tested 3 random files using  dd 
> if=/dev/urandom of=file bs=961450810 count=1)  to swift using multipart is 
> currupted if downloaded back. 
> This is the code used for uploading: 
> {noformat}
> props.setProperty("jclouds.mpu.parts.size", "103554431");
> BlobStoreContext blobStoreContext = 
> ContextBuilder.newBuilder(provider).overrides(props).build(BlobStoreContext.class);
> blobstore = blobStoreContext.getBlobStore();
> Blob blob = blobstore.getBlob(container, name);
> File file = new File(/tmp/file);
> blob.setPayload(file);
> blobstore.putBlob(name, blob, PutOptions.Builder.multipart(true));
> {noformat}
> And downloading:
> {noformat}
> Blob blob = blobstore.getBlob(container,file);
> Payload payload = blob.getPayload();
> in =  payload.openStream();
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (JCLOUDS-749) Files of 961450810 bytes are corupted in swift when using multipart

[Andrew Gaul (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul updated JCLOUDS-749:

Labels: swift  (was: )

> Files of 961450810 bytes are corupted in swift when using multipart 
> 
>
> Key: JCLOUDS-749
> URL: https://issues.apache.org/jira/browse/JCLOUDS-749
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-blobstore
>Affects Versions: 1.8.0
>Reporter: Spiros Koulouzis
>  Labels: swift
>
> Uploading any file of 961450810 bytes (tested 3 random files using  dd 
> if=/dev/urandom of=file bs=961450810 count=1)  to swift using multipart is 
> currupted if downloaded back. 
> This is the code used for uploading: 
> {noformat}
> props.setProperty("jclouds.mpu.parts.size", "103554431");
> BlobStoreContext blobStoreContext = 
> ContextBuilder.newBuilder(provider).overrides(props).build(BlobStoreContext.class);
> blobstore = blobStoreContext.getBlobStore();
> Blob blob = blobstore.getBlob(container, name);
> File file = new File(/tmp/file);
> blob.setPayload(file);
> blobstore.putBlob(name, blob, PutOptions.Builder.multipart(true));
> {noformat}
> And downloading:
> {noformat}
> Blob blob = blobstore.getBlob(container,file);
> Payload payload = blob.getPayload();
> in =  payload.openStream();
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (JCLOUDS-249) Swift multipart upload from InputStream payload fails

[Andrew Gaul (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul resolved JCLOUDS-249.
-
   Resolution: Fixed
Fix Version/s: 1.7.0

JCLOUDS-356 resolved this issue with commit 
15a3c04fb7e488117cb1b65d13c99f4499568b3f.

> Swift multipart upload from InputStream payload fails
> -
>
> Key: JCLOUDS-249
> URL: https://issues.apache.org/jira/browse/JCLOUDS-249
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-blobstore
>Affects Versions: 1.6.0
> Environment: OS X 10.8.4, Oracle Java 1.7.0_25
>Reporter: Francis Devereux
>Assignee: Andrew Gaul
> Fix For: 1.7.0
>
>
> If I try to put a multipart blob using an InputStream payload I get the 
> following exception:
> {code}
> java.lang.RuntimeException: java.io.IOException: Stream closed
>   at com.google.common.base.Throwables.propagate(Throwables.java:160)
>   at 
> org.jclouds.io.internal.BasePayloadSlicer.doSlice(BasePayloadSlicer.java:83)
>   at 
> org.jclouds.io.internal.BasePayloadSlicer.slice(BasePayloadSlicer.java:62)
>   at 
> org.jclouds.openstack.swift.blobstore.strategy.internal.SequentialMultipartUploadStrategy.execute(SequentialMultipartUploadStrategy.java:73)
>   at 
> org.jclouds.openstack.swift.blobstore.SwiftBlobStore.putBlob(SwiftBlobStore.java:214)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at 
> com.google.inject.internal.DelegatingInvocationHandler.invoke(DelegatingInvocationHandler.java:37)
>   at com.sun.proxy.$Proxy63.putBlob(Unknown Source)
>   at 
> com.brightinteractive.jclouds.PutGetDeleteMultiPartTest.putMultiPartBlob(PutGetDeleteMultiPartTest.java:132)
>   at 
> com.brightinteractive.jclouds.PutGetDeleteMultiPartTest.putGetDelete(PutGetDeleteMultiPartTest.java:65)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
>   at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
>   at 
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:77)
>   at 
> com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:195)
>   at 
> com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:63)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)
> Caused by: java.io.IOException: Stream closed
>   at 
> java.io.BufferedInputStream.getBufIfOpen(BufferedInputStream.java:162)
>   at java.io.BufferedInputStream.skip(BufferedInputStream.java:357)
>   at com.google.common.io.ByteStreams.skipFully(ByteStreams.java:755)
>   at 
> org.jclouds.io.internal.BasePayloadSlicer.doSlice(BasePayloadSlicer.java:81)
>   ... 39 more
> {code}
> Code to reproduce here: 
> https://github.com/brightinteractive/jclouds-prototype/blob/825f704266191bb35413838260681775efa90cb9/src/test/java/com/brightinteractive/jclouds/PutGetDeleteMultiPartTest.java
> With similar code that uses a File p

[jira] [Assigned] (JCLOUDS-249) Swift multipart upload from InputStream payload fails

[Andrew Gaul (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul reassigned JCLOUDS-249:
---

Assignee: Andrew Gaul

> Swift multipart upload from InputStream payload fails
> -
>
> Key: JCLOUDS-249
> URL: https://issues.apache.org/jira/browse/JCLOUDS-249
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-blobstore
>Affects Versions: 1.6.0
> Environment: OS X 10.8.4, Oracle Java 1.7.0_25
>Reporter: Francis Devereux
>Assignee: Andrew Gaul
>
> If I try to put a multipart blob using an InputStream payload I get the 
> following exception:
> {code}
> java.lang.RuntimeException: java.io.IOException: Stream closed
>   at com.google.common.base.Throwables.propagate(Throwables.java:160)
>   at 
> org.jclouds.io.internal.BasePayloadSlicer.doSlice(BasePayloadSlicer.java:83)
>   at 
> org.jclouds.io.internal.BasePayloadSlicer.slice(BasePayloadSlicer.java:62)
>   at 
> org.jclouds.openstack.swift.blobstore.strategy.internal.SequentialMultipartUploadStrategy.execute(SequentialMultipartUploadStrategy.java:73)
>   at 
> org.jclouds.openstack.swift.blobstore.SwiftBlobStore.putBlob(SwiftBlobStore.java:214)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at 
> com.google.inject.internal.DelegatingInvocationHandler.invoke(DelegatingInvocationHandler.java:37)
>   at com.sun.proxy.$Proxy63.putBlob(Unknown Source)
>   at 
> com.brightinteractive.jclouds.PutGetDeleteMultiPartTest.putMultiPartBlob(PutGetDeleteMultiPartTest.java:132)
>   at 
> com.brightinteractive.jclouds.PutGetDeleteMultiPartTest.putGetDelete(PutGetDeleteMultiPartTest.java:65)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
>   at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
>   at 
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:77)
>   at 
> com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:195)
>   at 
> com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:63)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>   at com.intellij.rt.execution.application.AppMain.main(AppMain.java:120)
> Caused by: java.io.IOException: Stream closed
>   at 
> java.io.BufferedInputStream.getBufIfOpen(BufferedInputStream.java:162)
>   at java.io.BufferedInputStream.skip(BufferedInputStream.java:357)
>   at com.google.common.io.ByteStreams.skipFully(ByteStreams.java:755)
>   at 
> org.jclouds.io.internal.BasePayloadSlicer.doSlice(BasePayloadSlicer.java:81)
>   ... 39 more
> {code}
> Code to reproduce here: 
> https://github.com/brightinteractive/jclouds-prototype/blob/825f704266191bb35413838260681775efa90cb9/src/test/java/com/brightinteractive/jclouds/PutGetDeleteMultiPartTest.java
> With similar code that uses a File payload instead of an InputStream the put 
> succeeds (although getting the blob still fails due to JCLOUDS-247): 
> https://github.com/bri

Re: [jclouds] Fixes the exponential backoff for a value of 0 (#644)

[Zack Shoylev]

@nacx How does this PR look to you now?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/644#issuecomment-70761367

Re: [jclouds] fix usermetadata check on OS X (#648)

[Jeremy Daggett]

@kahing Thanks again! Can you please address the comment from @andrewgaul 
above? Once that looks good, we should get it merged.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70753228

Re: [jclouds] fix usermetadata check on OS X (#648)

[Jeremy Daggett]

@kahing Well, that was strange... I had a git remote problem with your repo and 
now that it is sorted out, `master` is happy again on OS X! +1

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70752052

Re: [jclouds] fix usermetadata check on OS X (#648)

[Ka-Hing Cheung]

@jdaggett I just did a `mvn clean install` with xattrs disabled and 
TestUtils.isMacOSX() return true, and everything passed. 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70746966

Re: [jclouds] fix usermetadata check on OS X (#648)

[Jeremy Daggett]

@kahing I just run `mvn clean install` :smile: 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70743082

Re: [jclouds] fix usermetadata check on OS X (#648)

[Ka-Hing Cheung]

@jdaggett how did you run the test? I don't have OS X but locally I verified 
with disabling xattrs and faking TestUtils.isMacOSX() to always return true.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70741593

Re: [jclouds] Update AutoValue to version 1.0 (#646)

[Jeremy Daggett]

@zack-shoylev Glad to be of service! :grinning: 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/646#issuecomment-70730960

Re: [jclouds] fix usermetadata check on OS X (#648)

[Jeremy Daggett]

@kahing Hi! I cherry-picked this commit, built again, and have the following 2 
test failures in the `BaseBlobIntegrationTest.testPut()` method:
```
Failed tests:
  
FilesystemBlobIntegrationTest>BaseBlobIntegrationTest.testPutByteSource:531->BaseBlobIntegrationTest.testPut:584
Expecting:
 <{}>
to be equal to:
 <{"key1"="value1", "key2"="value2"}>
but was not.
  
FilesystemBlobIntegrationTest>BaseBlobIntegrationTest.testPutInputStream:539->BaseBlobIntegrationTest.testPut:584
Expecting:
 <{}>
to be equal to:
 <{"key1"="value1", "key2"="value2"}>
but was not.
```

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70729396

Re: [jclouds] fix usermetadata check on OS X (#648)

[Andrew Gaul]

> @@ -555,6 +555,14 @@ public void testPutMultipartInputStream() throws 
> Exception {
>testPut(payload, new ByteSourcePayload(byteSource), length, new 
> PutOptions().multipart(true));
> }
>  
> +   /* Java on OS X does not support extended attributes, which the 
> filesystem backend
> +* uses to implement user metadata */
> +   private void checkUserMetadata(Blob blob, Map 
> userMetadata1, Map userMetadata2) {
> +  if ("filesystem".equals(blob.getMetadata().getProviderId()) && 
> !TestUtils.isMacOSX()) {

Can you make this method protected and override it in 
`FilesystemBlobIntegrationTest`?  We follow this pattern for other attributes 
like system metadata.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648/files#r23253661

Re: [jclouds-examples] Delete all resources in all regions of an account (#70)

[Zack Shoylev]

+1

It's missing networks, but can be added later. Note: it should probably make 
you type "DELETE ALL" before proceeding, or "BOOM". Some kinda captcha maybe.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/70#issuecomment-70708232

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

[Andrea Turli]

> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.jclouds.azurecompute.domain;
> +
> +import com.google.auto.value.AutoValue;
> +import org.jclouds.javax.annotation.Nullable;
> +
> +import java.net.URI;
> +
> +/**
> + * @see http://msdn.microsoft.com/en-us/library/azure/ee460804.aspx#OSVirtualHardDisk";
>  >api

remove extra space 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/125/files#r23240207

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

[Bhathiya]

@andreaturli  Sorry, there is a mistake in the refference link. It Should be 
http://msdn.microsoft.com/en-us/library/azure/ee460804.aspx#OSVirtualHardDisk
I'll correct it.

I mapped 
http://msdn.microsoft.com/en-us/library/azure/jj157186.aspx#OSVirtualHardDisk 
to OSVirtualHardDiskParam  (not in this PR)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/125#issuecomment-70680905

Re: [jclouds] fix usermetadata check on OS X (#648)

[Jeremy Daggett]

@kahing I will pull the changes over later this morning and let you know, 
thanks! :+1: 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/648#issuecomment-70680769

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

[Andrea Turli]

@hsbhathiya thanks for splitting the PR, it is now way easier to review!

There are just some comments to get the Value class right, according to the 
online doc, at least.
Please revisit the impl, and commit the changes.

Once we'll be happy with the PR, we will squash the commits into just one 
commit and merge it.

Good job!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/125#issuecomment-70679054

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

[Andrea Turli]

> @@ -0,0 +1,11 @@
> +http://schemas.microsoft.com/windowsazure";>
> +ReadOnly
> +MyTestImage_1
> +testosimage1-testosimage1-0-20120817095145
> +
> http://blobs/disks/neotysss/MSFT__Win2K8R2SP1-ABCD-en-us-30GB.vhd
> +Ubuntu Server 12.04 LTS
> +linux
> +30
> +
> http://blobs/disks/neotysss/MSFT__Win2K8R2SP1-ABCD-en-us-30GB.vhd
> +Standard

probably this `IOType` is no more there, remove it from Value class as well

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/125/files#r23232053

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

[Andrea Turli]

> +* in Windows Azure. If you specify the path to an image with this 
> element, an associated VHD is created and
> +* you must use the MediaLink element to specify the location in storage 
> where the VHD will be located.
> +* If this element is used, SourceImageName is not used.
> +* 
> +* The RemoteSourceImageLink element is only available using version 
> 2014-05-01 or higher.
> +*/
> +   @Nullable public abstract URI remoteSourceImageLink();
> +
> +   /**
> +* This property identifies the type of the storage account for the 
> backing VHD.
> +* If the backing VHD is in an Provisioned Storage account, “Provisioned” 
> is returned otherwise “Standard”
> +* is returned.
> +* 
> +* This property is only returned with a version header of 2014-10-01 or 
> newer
> +*/
> +   @Nullable public abstract String IOType();

This property is not documented at

Instead there is a missing `ResizedSizeInGB`
When an OS Image or a RemoteSourceImage is used to create an OSVirtualHardDisk, 
this parameter can be used to resize the new OSVirtualHardDisk to a larger 
size. ResizedSizeInGB must be larger than the underlying OS Image’s 
LogicalSizeInGB. The ResizedSizeInGB element is only available using version 
2014-10-01 or higher.

Can you add it?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/125/files#r23231962

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

[Andrea Turli]

> +/**
> + * @see  href="http://msdn.microsoft.com/en-us/library/azure/jj157186.aspx#OSVirtualHardDisk";
>  >api
> + */
> +@AutoValue
> +public abstract class OSVirtualHardDisk {
> +
> +   /**
> +* Specifies the caching mode of the operating system disk.
> +* This setting impacts the consistency and performance of the disk.
> +* Possible values are:
> +* ReadOnly
> +* ReadWrite
> +* The default value is ReadWrite
> +*/
> +   @Nullable public abstract String hostCaching();
> +

Looks like also an optional `DiskLabel` Specifies the description of the disk. 
can be specified. Can you add it?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/125/files#r23231756

Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

[Andrea Turli]

> +
> +/**
> + * @see  href="http://msdn.microsoft.com/en-us/library/azure/jj157186.aspx#OSVirtualHardDisk";
>  >api
> + */
> +@AutoValue
> +public abstract class OSVirtualHardDisk {
> +
> +   /**
> +* Specifies the caching mode of the operating system disk.
> +* This setting impacts the consistency and performance of the disk.
> +* Possible values are:
> +* ReadOnly
> +* ReadWrite
> +* The default value is ReadWrite
> +*/
> +   @Nullable public abstract String hostCaching();

wouldn't be better an `enum` here?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/125/files#r23231666

Re: [jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)

[Bhathiya]

This PR wil be splited into few smaller PRs

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/124#issuecomment-70675770

Re: [jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)

[Bhathiya]

Closed #124.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/124#event-221678548

Re: [jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)

[Bhathiya]

@andreaturli  Thanks for quick response. I made 
https://github.com/jclouds/jclouds-labs/pull/125

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/124#issuecomment-70675258

[jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)

[Bhathiya]

Changes in Deployment Representation - Part 1
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/125

-- Commit Summary --

  * JCLOUDS-664: OSVirtualHardDisk Support With Tests

-- File Changes --

A 
azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDisk.java
 (98)
A 
azurecompute/src/main/java/org/jclouds/azurecompute/xml/OSVirtualHardDiskHandler.java
 (81)
A 
azurecompute/src/test/java/org/jclouds/azurecompute/xml/OSVirtualHardDisksHandlerTest.java
 (49)
A azurecompute/src/test/resources/osvirtualharddisk.xml (11)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/125.patch
https://github.com/jclouds/jclouds-labs/pull/125.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/125

Re: [jclouds] Fix for JCLOUDS-655 (#626)

[Everett Toews]

> @@ -221,6 +229,7 @@ protected Image(String id, @Nullable String name, 
> java.util.Set links, @Nu
>this.progress = progress;
>this.minDisk = minDisk;
>this.minRam = minRam;
> +  this.blockDeviceMapping = blockDeviceMapping;

Init the same as `metadata`

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626/files#r23227880

Re: [jclouds] Fix for JCLOUDS-655 (#626)

[Everett Toews]

> @@ -85,6 +86,7 @@ public static Status fromValue(String v) {
>protected int minDisk;
>protected int minRam;
>protected Resource server;
> +  protected List blockDeviceMapping;

This should be initialized with `ImmutableList.of()` (unless there's a really 
good reason not to). All of the other Collection types in the domain package 
are initialized this way. `blockDeviceMapping` should be the same.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/626/files#r23227753

Build failed in Jenkins: jclouds-guava-17-18 » 18.0,OpenJDK 7 (latest) #47

[jenkins-no-reply]

See 


--
[...truncated 11859 lines...]
Starting test 
testFileGetParallel(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testFileGetParallel(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 39ms
Test suite progress: tests succeeded: 33, failed: 1, skipped: 0.
Starting test 
testGetIfMatch(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testGetIfMatch(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 7ms
Test suite progress: tests succeeded: 34, failed: 1, skipped: 0.
Starting test 
testGetIfModifiedSince(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testGetIfModifiedSince(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 7ms
Test suite progress: tests succeeded: 35, failed: 1, skipped: 0.
Starting test 
testGetIfNoneMatch(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testGetIfNoneMatch(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 5ms
Test suite progress: tests succeeded: 36, failed: 1, skipped: 0.
Starting test 
testGetIfUnmodifiedSince(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testGetIfUnmodifiedSince(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 5006ms
Test suite progress: tests succeeded: 37, failed: 1, skipped: 0.
Starting test 
testGetRange(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testGetRange(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 6ms
Test suite progress: tests succeeded: 38, failed: 1, skipped: 0.
Starting test 
testGetTwoRanges(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testGetTwoRanges(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 4ms
Test suite progress: tests succeeded: 39, failed: 1, skipped: 0.
Starting test 
testMetadata(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testMetadata(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 5ms
Test suite progress: tests succeeded: 40, failed: 1, skipped: 0.
Starting test 
testPutByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 8ms
Test suite progress: tests succeeded: 41, failed: 1, skipped: 0.
Starting test 
testPutCorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutCorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 2ms
Test suite progress: tests succeeded: 42, failed: 1, skipped: 0.
Starting test 
testPutFileParallel(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutFileParallel(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 13ms
Test suite progress: tests succeeded: 43, failed: 1, skipped: 0.
Starting test 
testPutIncorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutIncorrectContentMD5(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 2ms
Test suite progress: tests succeeded: 44, failed: 1, skipped: 0.
Starting test 
testPutInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 succeeded: 4ms
Test suite progress: tests succeeded: 45, failed: 1, skipped: 0.
Starting test 
testPutMultipartByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutMultipartByteSource(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 45, failed: 1, skipped: 1.
Starting test 
testPutMultipartInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutMultipartInputStream(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
 skipped.
Test suite progress: tests succeeded: 45, failed: 1, skipped: 2.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 6ms
Test suite progress: tests succeeded: 46, failed: 1, skipped: 2.
Starting test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest)
[TestNG] Test 
testPutObject(org.jclouds.filesystem.integration.FilesystemBlobIntegrationTest) 
succeeded: 6ms
Test suite progress: tests succeeded: 47, failed: 1, skipped: 2.
Starting test

[jira] [Closed] (JCLOUDS-807) org.jclouds.openstack.nova.v2_0.features.ImageApi.listInDetail may fail for some Images with structured metadata

[Everett Toews (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Everett Toews closed JCLOUDS-807.
-
Resolution: Duplicate

We're getting close to a fix!

https://github.com/jclouds/jclouds/pull/626

> org.jclouds.openstack.nova.v2_0.features.ImageApi.listInDetail may fail for 
> some Images with structured metadata
> 
>
> Key: JCLOUDS-807
> URL: https://issues.apache.org/jira/browse/JCLOUDS-807
> Project: jclouds
>  Issue Type: Bug
>  Components: jclouds-labs-openstack
>Affects Versions: 1.8.0, 2.0.0
>Reporter: Pierre Souchay
>
> In our environment (Openstack Icehouse), the list of images with details may 
> return some structured data in metadata, for instance :
> {code}
> "metadata": {
> "block_device_mapping": [
> {
> "guest_format": null,
> "boot_index": 0,
> "no_device": null,
> "volume_id": null,
> "volume_size": null,
> "disk_bus": "virtio",
> "image_id": null,
> "source_type": "snapshot",
> "device_type": "disk",
> "snapshot_id": "ce746121-7829-4818-bf5b-2b86d48b5ce0",
> "destination_type": "volume",
> "delete_on_termination": null
> },
> {
> "guest_format": null,
> "boot_index": null,
> "no_device": null,
> "volume_id": null,
> "volume_size": null,
> "disk_bus": null,
> "image_id": null,
> "source_type": "snapshot",
> "device_type": null,
> "snapshot_id": "a659cb24-c84e-472b-8ec2-9e4af8211d08",
> "destination_type": "volume",
> "delete_on_termination": null
> }
> ],
> "container_format": "bare"
> [...]
> }
> {code}
> In that case, the deserialization code fails with the following message 
> "com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: 
> Expected a string but was BEGIN_ARRAY ..." since the class 
> org.jclouds.openstack.nova.v2_0.domain.Image contains metadata as a 
> Map but block_device_mapping is an array of objects instead 
> of a String.
> This issue seems present in 1.8.x and 2.0.0
> A modification of the test case 
> jclouds/apis/openstack-nova/src/test/resources/image_details.json explains 
> the problem :
> put:
> {code}
> "metadata": {
> "ImageType": "Gold",
> "ImageVersion": "1.5",
> "block_device_mapping": [{"guest_format": null, "boot_index": 0, 
> "no_device": null, "volume_id": null, "volume_size": null, "disk_bus": 
> "virtio", "image_id": null, "source_type": "snapshot", "device_type": "disk", 
> "snapshot_id": "ce746121-7829-4818-bf5b-2b86d48b5ce0", "destination_type": 
> "volume", "delete_on_termination": null}, {"guest_format": null, 
> "boot_index": null, "no_device": null, "volume_id": null, "volume_size": 
> null, "disk_bus": null, "image_id": null, "source_type": "snapshot", 
> "device_type": null, "snapshot_id": "a659cb24-c84e-472b-8ec2-9e4af8211d08", 
> "destination_type": "volume", "delete_on_termination": null}]
> },
> {code}
> instead of 
> {code}
> "metadata": {
> "ImageType": "Gold",
> "ImageVersion": "1.5"
> }
> {code}
> The message is then:
> {code}
> testGetImageWhenResponseIs2xx(org.jclouds.openstack.nova.v2_0.features.ImageApiExpectTest)
>   Time elapsed: 0.006 sec  <<< FAILURE!
> java.lang.IllegalStateException: Expected a string but was BEGIN_ARRAY at 
> line 16 column 38 path $.image.metadata.
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: jclouds-labs-openstack » jclouds openstack-glance api #594

[jenkins-no-reply]

See 


--
[...truncated 2316 lines...]
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-core/1.2/doxia-core-1.2.jar
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-decoration-model/1.2/doxia-decoration-model-1.2.jar
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-sink-api/1.2/doxia-sink-api-1.2.jar
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-site-renderer/1.2/doxia-site-renderer-1.2.jar
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-module-xhtml/1.2/doxia-module-xhtml-1.2.jar
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-module-fml/1.2/doxia-module-fml-1.2.jar
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus-utils/3.0.8/plexus-utils-3.0.8.jar
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/rat/apache-rat-core/0.10/apache-rat-core-0.10.jar
Downloading: 
http://repo.cloudbees.com/content/repositories/central/commons-lang/commons-lang/2.6/commons-lang-2.6.jar
Downloading: 
http://repo.cloudbees.com/content/repositories/central/commons-io/commons-io/2.2/commons-io-2.2.jar
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/commons/commons-compress/1.5/commons-compress-1.5.jar
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-interpolation/1.11/plexus-interpolation-1.11.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-interpolation/1.11/plexus-interpolation-1.11.jar
 (50 KB at 2487.1 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-core/1.2/doxia-core-1.2.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/commons-io/commons-io/2.2/commons-io-2.2.jar
 (170 KB at 6054.2 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-logging-api/1.2/doxia-logging-api-1.2.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/commons/commons-compress/1.5/commons-compress-1.5.jar
 (251 KB at 7359.9 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-decoration-model/1.2/doxia-decoration-model-1.2.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/rat/apache-rat-core/0.10/apache-rat-core-0.10.jar
 (115 KB at 3281.0 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-sink-api/1.2/doxia-sink-api-1.2.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/commons-lang/commons-lang/2.6/commons-lang-2.6.jar
 (278 KB at 7930.2 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-site-renderer/1.2/doxia-site-renderer-1.2.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-core/1.2/doxia-core-1.2.jar
 (151 KB at 6543.9 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-module-xhtml/1.2/doxia-module-xhtml-1.2.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-site-renderer/1.2/doxia-site-renderer-1.2.jar
 (51 KB at 1754.2 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-module-fml/1.2/doxia-module-fml-1.2.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-logging-api/1.2/doxia-logging-api-1.2.jar
 (12 KB at 299.5 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-velocity/1.1.7/plexus-velocity-1.1.7.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-sink-api/1.2/doxia-sink-api-1.2.jar
 (11 KB at 343.0 KB/sec)
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/3.0.8/plexus-utils-3.0.8.jar
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-decoration-model/1.2/doxia-decoration-model-1.2.jar
 (59 KB at 1767.7 KB/sec)
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-module-xhtml/1.2/doxia-module-xhtml-1.2.jar
 (15 KB at 460.7 KB/sec)
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/or

[jira] [Commented] (JCLOUDS-574) Support for vCloud Automation Center and the deprecation of vCloud Director for enterprise

[John Muller (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14283851#comment-14283851
 ] 

John Muller commented on JCLOUDS-574:
-

I was provided the vCAC API documents by VMWare consultants, but not the old 
vCD docs to diff them against.  Anyway, this effort is almost certainly not 
work it with the introduction of VMWare Integrated OpenStack:

http://www.vmware.com/products/openstack

Our VMWare consultants state that it will be out of beta by the end of Q1.  

Marking this request as resolved.

> Support for vCloud Automation Center and the deprecation of vCloud Director 
> for enterprise
> --
>
> Key: JCLOUDS-574
> URL: https://issues.apache.org/jira/browse/JCLOUDS-574
> Project: jclouds
>  Issue Type: Wish
>  Components: jclouds-compute, jclouds-core, jclouds-labs
>Affects Versions: 1.7.2
>Reporter: John Muller
>  Labels: director, vCenter, vCloud
>   Original Estimate: 1,008h
>  Remaining Estimate: 1,008h
>
> VMWare is in the process of deprecating vCloud Director:
> http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=2057589
> and
> http://blogs.vmware.com/vsphere/2013/09/vcloud-director-convergence-and-transition-plan-whats-the-scoop.html
> It appears that the directory APIs will be split between vSphere and vCAC.
> The only mention I could find pertaining to jclouds was an email thread from 
> back in November 2013:
> http://mail-archives.apache.org/mod_mbox/jclouds-user/201311.mbox/%3c20131105172317.0blnxbkjuosw0...@webmail.qrmedia.com%3E
> Is it possible to use compute service and blob store without director?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (JCLOUDS-574) Support for vCloud Automation Center and the deprecation of vCloud Director for enterprise

[John Muller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Muller closed JCLOUDS-574.
---

> Support for vCloud Automation Center and the deprecation of vCloud Director 
> for enterprise
> --
>
> Key: JCLOUDS-574
> URL: https://issues.apache.org/jira/browse/JCLOUDS-574
> Project: jclouds
>  Issue Type: Wish
>  Components: jclouds-compute, jclouds-core, jclouds-labs
>Affects Versions: 1.7.2
>Reporter: John Muller
>  Labels: director, vCenter, vCloud
>   Original Estimate: 1,008h
>  Remaining Estimate: 1,008h
>
> VMWare is in the process of deprecating vCloud Director:
> http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=2057589
> and
> http://blogs.vmware.com/vsphere/2013/09/vcloud-director-convergence-and-transition-plan-whats-the-scoop.html
> It appears that the directory APIs will be split between vSphere and vCAC.
> The only mention I could find pertaining to jclouds was an email thread from 
> back in November 2013:
> http://mail-archives.apache.org/mod_mbox/jclouds-user/201311.mbox/%3c20131105172317.0blnxbkjuosw0...@webmail.qrmedia.com%3E
> Is it possible to use compute service and blob store without director?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (JCLOUDS-574) Support for vCloud Automation Center and the deprecation of vCloud Director for enterprise

[John Muller (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Muller resolved JCLOUDS-574.
-
Resolution: Not a Problem

VIO provides openstack as an appliance. 

> Support for vCloud Automation Center and the deprecation of vCloud Director 
> for enterprise
> --
>
> Key: JCLOUDS-574
> URL: https://issues.apache.org/jira/browse/JCLOUDS-574
> Project: jclouds
>  Issue Type: Wish
>  Components: jclouds-compute, jclouds-core, jclouds-labs
>Affects Versions: 1.7.2
>Reporter: John Muller
>  Labels: director, vCenter, vCloud
>   Original Estimate: 1,008h
>  Remaining Estimate: 1,008h
>
> VMWare is in the process of deprecating vCloud Director:
> http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=2057589
> and
> http://blogs.vmware.com/vsphere/2013/09/vcloud-director-convergence-and-transition-plan-whats-the-scoop.html
> It appears that the directory APIs will be split between vSphere and vCAC.
> The only mention I could find pertaining to jclouds was an email thread from 
> back in November 2013:
> http://mail-archives.apache.org/mod_mbox/jclouds-user/201311.mbox/%3c20131105172317.0blnxbkjuosw0...@webmail.qrmedia.com%3E
> Is it possible to use compute service and blob store without director?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Build failed in Jenkins: jclouds-labs-openstack #594

[jenkins-no-reply]

See 

--
[...truncated 2473 lines...]
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/commons-lang/commons-lang/2.1/commons-lang-2.1.jar
 (203 KB at 6995.0 KB/sec)
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/maven-archiver/2.5/maven-archiver-2.5.jar
 (22 KB at 687.2 KB/sec)
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-javadoc-plugin:2.9:jar (javadoc) @ openstack-glance ---
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/shared/maven-invoker/2.0.9/maven-invoker-2.0.9.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/shared/maven-invoker/2.0.9/maven-invoker-2.0.9.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/shared/maven-invoker/2.0.9/maven-invoker-2.0.9.pom
 (6 KB at 376.1 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/shared/maven-common-artifact-filters/1.3/maven-common-artifact-filters-1.3.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/shared/maven-common-artifact-filters/1.3/maven-common-artifact-filters-1.3.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/shared/maven-common-artifact-filters/1.3/maven-common-artifact-filters-1.3.pom
 (4 KB at 301.3 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-site-renderer/1.0/doxia-site-renderer-1.0.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-site-renderer/1.0/doxia-site-renderer-1.0.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-site-renderer/1.0/doxia-site-renderer-1.0.pom
 (5 KB at 332.6 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-sitetools/1.0/doxia-sitetools-1.0.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-sitetools/1.0/doxia-sitetools-1.0.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-sitetools/1.0/doxia-sitetools-1.0.pom
 (10 KB at 720.1 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-core/1.0/doxia-core-1.0.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-core/1.0/doxia-core-1.0.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-core/1.0/doxia-core-1.0.pom
 (3 KB at 167.1 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus-utils/1.5.7/plexus-utils-1.5.7.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/1.5.7/plexus-utils-1.5.7.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/1.5.7/plexus-utils-1.5.7.pom
 (8 KB at 524.9 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-decoration-model/1.0/doxia-decoration-model-1.0.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-decoration-model/1.0/doxia-decoration-model-1.0.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-decoration-model/1.0/doxia-decoration-model-1.0.pom
 (4 KB at 205.3 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-module-apt/1.0/doxia-module-apt-1.0.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-module-apt/1.0/doxia-module-apt-1.0.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-module-apt/1.0/doxia-module-apt-1.0.pom
 (3 KB at 73.3 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-modules/1.0/doxia-modules-1.0.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-modules/1.0/doxia-modules-1.0.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-modules/1.0/doxia-modules-1.0.pom
 (3 KB at 167.0 KB/sec)
Downloading: 
https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-module-fml/1.0/doxia-module-fml-1.0.pom
Downloading: 
http://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-module-fml/1.0/doxia-module-fml-1.0.pom
Downloaded: 
http://repo.cloudbees.com/content/repositories/cen

[jira] [Created] (JCLOUDS-807) org.jclouds.openstack.nova.v2_0.features.ImageApi.listInDetail may fail for some Images with structured metadata

[Pierre Souchay (JIRA)]

Pierre Souchay created JCLOUDS-807:
--

 Summary: 
org.jclouds.openstack.nova.v2_0.features.ImageApi.listInDetail may fail for 
some Images with structured metadata
 Key: JCLOUDS-807
 URL: https://issues.apache.org/jira/browse/JCLOUDS-807
 Project: jclouds
  Issue Type: Bug
  Components: jclouds-labs-openstack
Affects Versions: 1.8.0, 2.0.0
Reporter: Pierre Souchay


In our environment (Openstack Icehouse), the list of images with details may 
return some structured data in metadata, for instance :
{code}
"metadata": {
"block_device_mapping": [
{
"guest_format": null,
"boot_index": 0,
"no_device": null,
"volume_id": null,
"volume_size": null,
"disk_bus": "virtio",
"image_id": null,
"source_type": "snapshot",
"device_type": "disk",
"snapshot_id": "ce746121-7829-4818-bf5b-2b86d48b5ce0",
"destination_type": "volume",
"delete_on_termination": null
},
{
"guest_format": null,
"boot_index": null,
"no_device": null,
"volume_id": null,
"volume_size": null,
"disk_bus": null,
"image_id": null,
"source_type": "snapshot",
"device_type": null,
"snapshot_id": "a659cb24-c84e-472b-8ec2-9e4af8211d08",
"destination_type": "volume",
"delete_on_termination": null
}
],
"container_format": "bare"
[...]
}
{code}
In that case, the deserialization code fails with the following message 
"com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected 
a string but was BEGIN_ARRAY ..." since the class 
org.jclouds.openstack.nova.v2_0.domain.Image contains metadata as a Map but block_device_mapping is an array of objects instead of a String.

This issue seems present in 1.8.x and 2.0.0

A modification of the test case 
jclouds/apis/openstack-nova/src/test/resources/image_details.json explains the 
problem :

put:
{code}
"metadata": {
"ImageType": "Gold",
"ImageVersion": "1.5",
"block_device_mapping": [{"guest_format": null, "boot_index": 0, 
"no_device": null, "volume_id": null, "volume_size": null, "disk_bus": 
"virtio", "image_id": null, "source_type": "snapshot", "device_type": "disk", 
"snapshot_id": "ce746121-7829-4818-bf5b-2b86d48b5ce0", "destination_type": 
"volume", "delete_on_termination": null}, {"guest_format": null, "boot_index": 
null, "no_device": null, "volume_id": null, "volume_size": null, "disk_bus": 
null, "image_id": null, "source_type": "snapshot", "device_type": null, 
"snapshot_id": "a659cb24-c84e-472b-8ec2-9e4af8211d08", "destination_type": 
"volume", "delete_on_termination": null}]
},
{code}

instead of 

{code}
"metadata": {
"ImageType": "Gold",
"ImageVersion": "1.5"
}
{code}

The message is then:
{code}
testGetImageWhenResponseIs2xx(org.jclouds.openstack.nova.v2_0.features.ImageApiExpectTest)
  Time elapsed: 0.006 sec  <<< FAILURE!
java.lang.IllegalStateException: Expected a string but was BEGIN_ARRAY at line 
16 column 38 path $.image.metadata.
{code}




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)

[Andrea Turli]

thanks for that @hsbhathiya!
Btw, it is a bit hard to review this PR all together, can you maybe split it 
into multiple PRs.
In fact, the code looks ok, but I'd like to have time to look at the official 
Azure documentation to see if the Value objects cover the spec correctly. Just 
to give you an example, `Role` doesn't contain `ConfigurationSet`.

For example a PR can contain:
- OSVirtualHardDisk
- OSVirtualHardDiskHandler
- OSVirtualHardDisksHandlerTest
- osvirtualharddisk.xml

so that the review process is quite straightforward?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/124#issuecomment-70641383

Re: [jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)

[Andrea Turli]

>  import com.google.common.collect.ImmutableSet;
>  
>  @Test(groups = "live", testName = "OSImageApiLiveTest")
>  public class OSImageApiLiveTest extends BaseAzureComputeApiLiveTest {
>  
> -   private ImmutableSet locations;

why did you remove this check from the test?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/124/files#r23216164

Re: [jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)

[Andrea Turli]

> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.jclouds.azurecompute.domain;
> +
> +import java.net.URI;
> +import java.util.List;
> +
> +import org.jclouds.javax.annotation.Nullable;
> +
> +import com.google.auto.value.AutoValue;
> +
> +/**
> + * @see  href="http://msdn.microsoft.com/en-us/library/azure/jj157193.aspx"; >api

shouldn't that contain a List ?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/124/files#r23216064

Re: [jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)

[Andrea Turli]

> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.jclouds.azurecompute.domain;
> +
> +import com.google.auto.value.AutoValue;
> +import org.jclouds.javax.annotation.Nullable;
> +
> +import java.util.List;
> +
> +/**
> + * @see  href="http://msdn.microsoft.com/en-us/library/azure/jj157193.aspx"; >api

this points to Role rather than RoleInstance

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/124/files#r23214636

Re: [jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)

[Bhathiya]

@andreaturli  I made chnges to the azure deploy. can you review this?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/124#issuecomment-70632714

[jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)

[Bhathiya]

Added OSVHD and DataVHD

Changes in Role

Added IOTypes

JCLOUDS-664:Azure Role representation

Role Instance handler with tests

JCLOUDS-664: Implemented Azure Role represenstaion

Added OSVHD and DataVHD

Changes in Role

Added IOTypes

JCLOUDS-664:Azure Role representation

Added VHD Handlers

Completed RoleHandler

JCLOUDS-664: Changes in Deployment implementation with test

Minor changes
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/124

-- Commit Summary --

  * JCLOUDS-664: Implemented Azure Role represenstaion

-- File Changes --

M 
azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/RoleSizeToHardware.java
 (8)
A 
azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDisk.java
 (103)
A 
azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDiskParam.java
 (161)
M 
azurecompute/src/main/java/org/jclouds/azurecompute/domain/Deployment.java (78)
A 
azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDisk.java
 (110)
A 
azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDiskParam.java
 (173)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/Role.java (90)
A 
azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleInstance.java 
(203)
A azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleParam.java 
(174)
A 
azurecompute/src/main/java/org/jclouds/azurecompute/xml/DataVirtualHardDiskHandler.java
 (97)
M 
azurecompute/src/main/java/org/jclouds/azurecompute/xml/DeploymentHandler.java 
(98)
M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DiskHandler.java 
(6)
A 
azurecompute/src/main/java/org/jclouds/azurecompute/xml/InstanceEndpointHandler.java
 (61)
A 
azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListDataVirtualHardDisksHandler.java
 (61)
A 
azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListRoleInstancesHandler.java
 (60)
A 
azurecompute/src/main/java/org/jclouds/azurecompute/xml/OSVirtualHardDiskHandler.java
 (103)
A 
azurecompute/src/main/java/org/jclouds/azurecompute/xml/PublicIPHandler.java 
(53)
A azurecompute/src/main/java/org/jclouds/azurecompute/xml/RoleHandler.java 
(146)
A 
azurecompute/src/main/java/org/jclouds/azurecompute/xml/RoleInstanceHandler.java
 (151)
M 
azurecompute/src/test/java/org/jclouds/azurecompute/features/OSImageApiLiveTest.java
 (14)
M 
azurecompute/src/test/java/org/jclouds/azurecompute/xml/DeploymentHandlerTest.java
 (111)
A 
azurecompute/src/test/java/org/jclouds/azurecompute/xml/ListDataVirtualHardDisksHandlerTest.java
 (63)
A 
azurecompute/src/test/java/org/jclouds/azurecompute/xml/OSVirtualHardDisksHandlerTest.java
 (51)
A 
azurecompute/src/test/java/org/jclouds/azurecompute/xml/RoleHandlerTest.java 
(97)
A 
azurecompute/src/test/java/org/jclouds/azurecompute/xml/RoleInstanceHandlerTest.java
 (70)
A azurecompute/src/test/resources/datavirtualharddisk.xml (23)
M azurecompute/src/test/resources/deployment.xml (170)
A azurecompute/src/test/resources/osvirtualharddisk.xml (11)
A azurecompute/src/test/resources/role.xml (43)
A azurecompute/src/test/resources/roleinstance.xml (36)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/124.patch
https://github.com/jclouds/jclouds-labs/pull/124.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/124