Re: [jclouds/jclouds-labs] pb-updates-v3 (#333)
@alibazlamit pushed 1 commit. 6af4e89 minor change to the return type -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/333/files/9c48deeb44a58204d48b025c3fc575189a32c35c..6af4e897014b2d51a1dc42558ebf26db7d783bb3
[jclouds/jclouds-labs] pb-updates-v3 (#333)
@nacx Here is the v3 updates with the fixed two live tests that were failing, ready for review. Thanks. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/333 -- Commit Summary -- * pb-updates-v3 -- File Changes -- M profitbricks-rest/pom.xml (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/ProfitBricksApiMetadata.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/binder/BaseProfitBricksRequestBinder.java (27) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/Nic.java (64) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/Volume.java (187) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/FirewallApi.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/IpBlockApi.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/LanApi.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/NicApi.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/ServerApi.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/SnapshotApi.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/VolumeApi.java (2) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/DataCenterApiMockTest.java (2) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/FirewallApiLiveTest.java (16) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/FirewallApiMockTest.java (4) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/ImageApiMockTest.java (4) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/IpBlockApiMockTest.java (2) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/LanApiMockTest.java (4) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/NicApiMockTest.java (2) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/ServerApiLiveTest.java (115) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/ServerApiMockTest.java (4) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/SnapshotApiMockTest.java (4) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/features/VolumeApiMockTest.java (2) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/internal/BaseProfitBricksApiMockTest.java (4) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/internal/BaseProfitBricksLiveTest.java (29) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/333.patch https://github.com/jclouds/jclouds-labs/pull/333.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/333
Re: [jclouds/jclouds-karaf] JCLOUDS-1191: Avoid NPE and let commands properly print the stacktraces (#85)
andrewgaul commented on this pull request.
> @@ -87,7 +87,7 @@ protected ComputeService getComputeService() throws
> IOException {
String apiValue = EnvHelper.getComputeApi(api);
String identityValue = EnvHelper.getComputeIdentity(identity);
String credentialValue = EnvHelper.getComputeCredential(credential);
- if (providerValue.equals("google-compute-engine")) {
+ if (providerValue != null && credentialValue != null &&
providerValue.equals("google-compute-engine")) {
Should this check `credentialValue`?
--
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/85#pullrequestreview-6304327
Re: [jclouds/jclouds] Fix retryOnRenew classes (#1031)
Closed #1031. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1031#event-840319356
Re: [jclouds/jclouds] Fix retryOnRenew classes (#1031)
ok merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds/commit/9b3e6d91) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1031#issuecomment-256971205
Re: [jclouds/jclouds] Fix retryOnRenew classes (#1031)
+1 as soon as the build is green! :) Thanks @andreaturli! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1031#issuecomment-256960413
[jclouds/jclouds] Fix retryOnRenew classes (#1031)
This port to master the PR #1027 already merged in `1.9.x` These classes should not close the release the payload as they are not reading it. - fix swift - fix openstack-swift v1 and v2 - fix RetryOnRenewTest for v1 and v2 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1031 -- Commit Summary -- * Fix retryOnRenew classes -- File Changes -- M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/handlers/RetryOnRenew.java (77) M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/handlers/RetryOnRenewTest.java (2) M common/openstack/src/main/java/org/jclouds/openstack/handlers/RetryOnRenew.java (71) M common/openstack/src/main/java/org/jclouds/openstack/keystone/v1_1/handlers/RetryOnRenew.java (75) M common/openstack/src/test/java/org/jclouds/openstack/keystone/v1_1/handlers/RetryOnRenewTest.java (4) -- Patch Links -- https://github.com/jclouds/jclouds/pull/1031.patch https://github.com/jclouds/jclouds/pull/1031.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1031
Re: [jclouds/jclouds] Fix retryOnRenew classes (#1031)
this PR is just to double-check everything is alright -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1031#issuecomment-256954646
Re: [jclouds/jclouds] fix jclouds/apis/swift retryOnRenew (#1027)
>ok cool. I think I will volunteer for a new 1.9.x release :) Perfect! :) There is no reason to not release if there are volunteers willing to do so! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1027#issuecomment-256954346
Re: [jclouds/jclouds] fix jclouds/apis/swift retryOnRenew (#1027)
ok cool. I think I will volunteer for a new 1.9.x release :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1027#issuecomment-256953771
Re: [jclouds/jclouds] fix jclouds/apis/swift retryOnRenew (#1027)
Absolutely. There are no plans to release 1.9.x, and it's been a while since we stopped backporting fixes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1027#issuecomment-256953114
Re: [jclouds/jclouds] fix jclouds/apis/swift retryOnRenew (#1027)
merged at [1.9.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/7167b473) @nacx @zack-shoylev shall we port that to `master` as well? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1027#issuecomment-256952293
Re: [jclouds/jclouds-labs] Properly track the status of write operations (#332)
Closed #332. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/332#event-840132742
Re: [jclouds/jclouds-labs] Properly track the status of write operations (#332)
Squashed and pushed to master as [c4e36e72](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/c4e36e72). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/332#issuecomment-256936177
Re: [jclouds/jclouds-labs] Properly track the status of write operations (#332)
@nacx pushed 1 commit. a9b25ad Removed unused import -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/332/files/21e5953d93c896b4a504bc319aeea54ab2167f5c..a9b25addf06a67a67bf6d9d001a7b6e0f48553ff
[jira] [Commented] (JCLOUDS-1192) TIMEOUT_SCRIPT_COMPLETE doesn't work.
[
https://issues.apache.org/jira/browse/JCLOUDS-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15615460#comment-15615460
]
Ignasi Barrera commented on JCLOUDS-1192:
-
The script timeout is not a "connection" timeout. That timeout is used to wait
until the script execution completes, but in this case I think it won't help
you, since jclouds wouldn't be able to connect to the node to determine the
exit status of the script.
You could try running the script asynchronously by calling the
[submitScriptOnNode|http://jclouds-javadocs.elasticbeanstalk.com/org/jclouds/compute/ComputeService.html#submitScriptOnNode(java.lang.String,%20java.lang.String,%20org.jclouds.compute.options.RunScriptOptions)]
method. This method returns a future that behaves exactly as the
{{runScriptOnNode}} method when you call its {{get()}} method, but you should
be able to just let it run in background and forget about it, or cancel it at a
given point in time.
Could you try this?
> TIMEOUT_SCRIPT_COMPLETE doesn't work.
> -
>
> Key: JCLOUDS-1192
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1192
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-scriptbuilder
>Affects Versions: 1.9.2
>Reporter: Andrei
>
> Provided part of source code performs running _host_update.sh_ scripts via
> *runScriptOnNode* method. Mentioned script contains at the end command that
> performs new release in DHCP, and as result *ComputeService* lost connection
> and cannot return the *ExecResponse*. It leads to hung execution app. It has
> been tried to configure any timeouts, but it doesn't interrupt
> *runScriptOnNode* method in configured time.
> Operating System Version - Windows 10
> Java version - 1.8.0_102
> Part of source code could be found
> [here|https://gist.github.com/borodatu/dcf9248786b16a509fbea476f7f01e82]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jclouds/jclouds-labs] Properly track the status of write operations (#332)
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/332 -- Commit Summary -- * Track status of requests that return the Location header * Add mock test for single URI deserialization * Fixed volume creation in snapshot api live test -- File Changes -- M profitbricks-rest/pom.xml (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/ProfitBricksApi.java (32) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/binder/BaseProfitBricksRequestBinder.java (7) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/binder/snapshot/UpdateSnapshotRequestBinder.java (1) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/binder/volume/CreateSnapshotRequestBinder.java (1) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/binder/volume/RestoreSnapshotRequestBinder.java (1) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/compute/ProfitBricksComputeServiceAdapter.java (120) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/compute/concurrent/ProvisioningJob.java (15) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/compute/config/ProfitBricksComputeServiceContextModule.java (1) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/compute/function/ProvisionableToImage.java (16) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/compute/function/ServerInDataCenterToNodeMetadata.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/compute/strategy/AssignDataCenterToTemplate.java (28) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/config/ProfitBricksHttpApiModule.java (50) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/DataCenter.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/FirewallRule.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/Image.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/IpBlock.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/Lan.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/Nic.java (2) A profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/RequestStatus.java (92) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/Server.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/Snapshot.java (2) A profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/Trackable.java (41) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/domain/Volume.java (2) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/DataCenterApi.java (27) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/FirewallApi.java (23) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/ImageApi.java (16) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/IpBlockApi.java (20) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/LanApi.java (21) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/NicApi.java (21) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/ServerApi.java (36) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/SnapshotApi.java (20) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/features/VolumeApi.java (24) A profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/functions/ParseRequestStatusURI.java (39) A profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/functions/RequestStatusURIParser.java (50) D profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/util/ApiPredicatesModule.java (140) M profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/util/ParseId.java (1) A profitbricks-rest/src/main/java/org/apache/jclouds/profitbricks/rest/util/Trackables.java (67) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/binder/server/AttachCdromRequestBinderTest.java (1) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/binder/server/AttachVolumeRequestBinderTest.java (1) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/binder/volume/CreateSnapshotRequestBinderTest.java (1) M profitbricks-rest/src/test/java/org/apache/jclouds/profitbricks/rest/binder/volume/UpdateVolumeR
Re: [jclouds/jclouds] fix jclouds/apis/swift retryOnRenew (#1027)
nacx approved this pull request. lgtm! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1027#pullrequestreview-6243053
