Re: [jclouds/jclouds] Correct regex in ExpandProperties (#1055)
@nacx Please review. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1055#issuecomment-275036651
[jclouds/jclouds] Correct regex in ExpandProperties (#1055)
Previously Android choked on this incomplete regex. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds/pull/1055 -- Commit Summary -- * Correct regex in ExpandProperties -- File Changes -- M core/src/main/java/org/jclouds/functions/ExpandProperties.java (2) -- Patch Links -- https://github.com/jclouds/jclouds/pull/1055.patch https://github.com/jclouds/jclouds/pull/1055.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/1055
Re: [jclouds/jclouds-labs] add compute functions (#346)
@andreaturli pushed 1 commit. 3825f9a improve DeviceToNodeMetadata -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/346/files/d1074295696a9bac88a3a6e9bb1c7581e295ae40..3825f9aea216c127fb948e586a2291c0177af269
Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)
andreaturli commented on this pull request. > @@ -27,7 +27,7 @@ import org.jclouds.aws.filters.FormSigner; import org.jclouds.elb.binders.BindAvailabilityZonesToIndexedFormParams; -import org.jclouds.elb.xml.AvailabilityZonesResultHandler; +import org.jclouds.elb.xml.MemberResultHandler; nice, thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70
Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)
thanks @justinThompson maybe I was unclear, but you don't need both expect tests and mock tests are they are supposed to tests the same things. As you wrote *MockTests, keep just them ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70#issuecomment-274948808
[jclouds/jclouds-labs] add compute functions (#346)
- fix Device and PaginatedCollection You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/346 -- Commit Summary -- * add compute functions -- File Changes -- A packet/src/main/java/org/jclouds/packet/compute/functions/DeviceStateToStatus.java (45) A packet/src/main/java/org/jclouds/packet/compute/functions/DeviceToNodeMetadata.java (118) A packet/src/main/java/org/jclouds/packet/compute/functions/FacilityToLocation.java (55) A packet/src/main/java/org/jclouds/packet/compute/functions/OperatingSystemToImage.java (54) A packet/src/main/java/org/jclouds/packet/compute/functions/PlanToHardware.java (86) M packet/src/main/java/org/jclouds/packet/domain/Device.java (2) M packet/src/main/java/org/jclouds/packet/domain/internal/PaginatedCollection.java (10) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/346.patch https://github.com/jclouds/jclouds-labs/pull/346.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/346
Re: [jclouds/jclouds-labs] JCLOUDS-1208 Implement the TemplateOptions.inboundPorts in ProfitBricks REST (#344)
@nacx updated with the changes -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/344#issuecomment-274831128
Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)
@andreaturli I have added expect tests following the old pattern, as well as mock tests following the new pattern. so now i'm updating the live tests now and fixing the failing tests -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70#issuecomment-274773453
Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)
justinThompson commented on this pull request. > +import javax.inject.Named; +import javax.ws.rs.FormParam; +import javax.ws.rs.POST; +import javax.ws.rs.Path; + +import org.jclouds.aws.filters.FormSigner; +import org.jclouds.elb.binders.BindSubnetIdsToIndexedFormParams; +import org.jclouds.elb.xml.MemberResultHandler; +import org.jclouds.rest.annotations.BinderParam; +import org.jclouds.rest.annotations.FormParams; +import org.jclouds.rest.annotations.RequestFilters; +import org.jclouds.rest.annotations.VirtualHost; +import org.jclouds.rest.annotations.XMLResponseParser; + +/** + * Provides access to Amazon ELB via the Query API updated -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70
Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)
@justinThompson pushed 2 commits. 2d77dec - updated Accept type on Subnet and HealthCheck API to be APPLICATION_XML 4890b7a - updaed some javadoc -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70/files/ade0d1918712634ce498d090f84459558ad67dc7..4890b7a86aa98e5c10d88c02266c44b40d9ff6c2
Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)
justinThompson commented on this pull request. > + @AfterClass + @Override + protected void tearDown() { + super.tearDown(); + if (api.getLoadBalancerApi().get("test") != null) { + api.getLoadBalancerApi().delete("test"); + } + } + + @Test + protected void testConfigureHealthCheck() { + final Set result = api().attachLoadBalancerToSubnets(loadBalancer.getName(), loadBalancer.getSubnets()); + } + + private void checkHealthCheck(HealthCheck healthCheck) { +// checkNotNull(healthCheck.getHealthyThreshold(), "Description cannot be null for InstanceState"); updated -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70
Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)
justinThompson commented on this pull request. > +import org.jclouds.rest.annotations.RequestFilters; +import org.jclouds.rest.annotations.VirtualHost; +import org.jclouds.rest.annotations.XMLResponseParser; + +/** + * Provides access to Amazon ELB via the Query API + * + * + * @see http://docs.amazonwebservices.com/ElasticLoadBalancing/latest/APIReference; + * >doc + */ +@RequestFilters(FormSigner.class) +@VirtualHost +public interface SubnetApi { + + removed -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70
Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)
justinThompson commented on this pull request. > + @Path("/") + @XMLResponseParser(MemberResultHandler.class) + @FormParams(keys = ACTION, values = "AttachLoadBalancerToSubnets") + Set attachLoadBalancerToSubnets( + @FormParam("LoadBalancerName") String loadBalancerName, + @BinderParam(BindSubnetIdsToIndexedFormParams.class) Iterable subnetNames); + + @Named("DetachLoadBalancerFromSubnets") + @POST + @Path("/") + @XMLResponseParser(MemberResultHandler.class) + @FormParams(keys = ACTION, values = "DetachLoadBalancerFromSubnets") + Set detachLoadBalancerFromSubnets( + @FormParam("LoadBalancerName") String loadBalancerName, + @BinderParam(BindSubnetIdsToIndexedFormParams.class) Iterable subnetNames); + removed -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70
Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)
justinThompson commented on this pull request. > @@ -27,7 +27,7 @@ import org.jclouds.aws.filters.FormSigner; import org.jclouds.elb.binders.BindAvailabilityZonesToIndexedFormParams; -import org.jclouds.elb.xml.AvailabilityZonesResultHandler; +import org.jclouds.elb.xml.MemberResultHandler; I renamed this handler because its not specific to availability zones, so it can be used in other places e.g. the subnet responses -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70
Re: [jclouds/jclouds-labs-aws] Health check and Subnet API (#70)
justinThompson commented on this pull request. > +package org.jclouds.elb.features; + +import java.util.Set; + +import org.jclouds.elb.domain.HealthCheck; +import org.jclouds.elb.domain.Listener; +import org.jclouds.elb.domain.LoadBalancer; +import org.jclouds.elb.domain.Protocol; +import org.jclouds.elb.internal.BaseELBApiLiveTest; +import org.testng.annotations.AfterClass; +import org.testng.annotations.BeforeMethod; +import org.testng.annotations.Test; + +import com.google.common.collect.ImmutableList; + +@Test(groups = "live", testName = "HealthCheckApiLiveTest") updated -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-aws/pull/70
Re: [jclouds/jclouds-labs] JCLOUDS-1208 Implement the TemplateOptions.inboundPorts in ProfitBricks REST (#344)
@alibazlamit pushed 1 commit. 373c6fa Updated reviews -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/344/files/41666c890673fff3826e7de78931a81e071c62e9..373c6fa7b5c1f46843d8f1dedb47fcca1ee9
Build failed in Jenkins: jclouds-karaf #2066
https://jclouds.ci.cloudbees.com/job/jclouds-karaf/2066/-- [...truncated 1128 lines...] Downloading: https://repository-jclouds.forge.cloudbees.com/release/commons-io/commons-io/2.2/commons-io-2.2.jar Downloading: https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus-interpolation/1.11/plexus-interpolation-1.11.jar Downloading: https://repository-jclouds.forge.cloudbees.com/release/org/apache/commons/commons-compress/1.5/commons-compress-1.5.jar Downloading: https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-core/1.2/doxia-core-1.2.jar Downloading: https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-logging-api/1.2/doxia-logging-api-1.2.jar Downloading: https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-decoration-model/1.2/doxia-decoration-model-1.2.jar Downloading: https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-site-renderer/1.2/doxia-site-renderer-1.2.jar Downloading: https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-sink-api/1.2/doxia-sink-api-1.2.jar Downloading: https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-module-xhtml/1.2/doxia-module-xhtml-1.2.jar Downloading: https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/doxia/doxia-module-fml/1.2/doxia-module-fml-1.2.jar Downloading: https://repository-jclouds.forge.cloudbees.com/release/org/apache/maven/shared/maven-plugin-testing-harness/1.1/maven-plugin-testing-harness-1.1.jar Downloading: https://repository-jclouds.forge.cloudbees.com/release/org/codehaus/plexus/plexus-utils/3.0.8/plexus-utils-3.0.8.jar Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/rat/apache-rat-core/0.10/apache-rat-core-0.10.jar Downloading: https://repo.cloudbees.com/content/repositories/central/commons-io/commons-io/2.2/commons-io-2.2.jar Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/commons/commons-compress/1.5/commons-compress-1.5.jar Downloading: https://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-interpolation/1.11/plexus-interpolation-1.11.jar Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-core/1.2/doxia-core-1.2.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/apache/rat/apache-rat-core/0.10/apache-rat-core-0.10.jar (115 KB at 2208.4 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-logging-api/1.2/doxia-logging-api-1.2.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-interpolation/1.11/plexus-interpolation-1.11.jar (50 KB at 872.7 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-decoration-model/1.2/doxia-decoration-model-1.2.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/commons-io/commons-io/2.2/commons-io-2.2.jar (170 KB at 2387.6 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-sink-api/1.2/doxia-sink-api-1.2.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-core/1.2/doxia-core-1.2.jar (151 KB at 2181.3 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-site-renderer/1.2/doxia-site-renderer-1.2.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/apache/commons/commons-compress/1.5/commons-compress-1.5.jar (251 KB at 3381.6 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-module-xhtml/1.2/doxia-module-xhtml-1.2.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-logging-api/1.2/doxia-logging-api-1.2.jar (12 KB at 426.2 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-module-fml/1.2/doxia-module-fml-1.2.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-decoration-model/1.2/doxia-decoration-model-1.2.jar (59 KB at 2160.6 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/shared/maven-plugin-testing-harness/1.1/maven-plugin-testing-harness-1.1.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-sink-api/1.2/doxia-sink-api-1.2.jar (11 KB at 548.8 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-utils/3.0.8/plexus-utils-3.0.8.jar Downloaded:
Build failed in Jenkins: jclouds-karaf ยป Apache jclouds :: Karaf #2066
https://jclouds.ci.cloudbees.com/job/jclouds-karaf/org.apache.jclouds$jclouds-karaf/2066/-- [...truncated 954 lines...] Downloading: https://repo.cloudbees.com/content/repositories/central/org/ow2/asm/asm-tree/4.1/asm-tree-4.1.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar (1201 KB at 9377.5 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/ow2/asm/asm-analysis/4.1/asm-analysis-4.1.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/parboiled/parboiled-java/1.1.4/parboiled-java-1.1.4.jar (72 KB at 2165.6 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/ow2/asm/asm-util/4.1/asm-util-4.1.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/parboiled/parboiled-core/1.1.4/parboiled-core-1.1.4.jar (181 KB at 4200.2 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/javax/servlet/servlet-api/2.5/servlet-api-2.5.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/ow2/asm/asm/4.1/asm-4.1.jar (47 KB at 1101.2 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-decoration-model/1.4/doxia-decoration-model-1.4.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/ow2/asm/asm-tree/4.1/asm-tree-4.1.jar (22 KB at 655.8 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-site-renderer/1.4/doxia-site-renderer-1.4.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/ow2/asm/asm-analysis/4.1/asm-analysis-4.1.jar (20 KB at 773.9 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/velocity/velocity-tools/2.0/velocity-tools-2.0.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/ow2/asm/asm-util/4.1/asm-util-4.1.jar (37 KB at 1112.7 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/commons-digester/commons-digester/1.8/commons-digester-1.8.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-site-renderer/1.4/doxia-site-renderer-1.4.jar (52 KB at 1727.9 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/commons-chain/commons-chain/1.1/commons-chain-1.1.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-decoration-model/1.4/doxia-decoration-model-1.4.jar (60 KB at 1359.6 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/commons-validator/commons-validator/1.3.1/commons-validator-1.3.1.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/javax/servlet/servlet-api/2.5/servlet-api-2.5.jar (103 KB at 2053.0 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/dom4j/dom4j/1.1/dom4j-1.1.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/commons-digester/commons-digester/1.8/commons-digester-1.8.jar (141 KB at 3261.3 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/sslext/sslext/1.2-0/sslext-1.2-0.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/apache/velocity/velocity-tools/2.0/velocity-tools-2.0.jar (339 KB at 5051.6 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/commons-chain/commons-chain/1.1/commons-chain-1.1.jar (88 KB at 1757.8 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/antlr/antlr/2.7.2/antlr-2.7.2.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/commons-validator/commons-validator/1.3.1/commons-validator-1.3.1.jar (136 KB at 3015.5 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/sslext/sslext/1.2-0/sslext-1.2-0.jar (26 KB at 673.7 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/dom4j/dom4j/1.1/dom4j-1.1.jar (447 KB at 6466.7 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/apache/maven/doxia/doxia-integration-tools/1.5/doxia-integration-tools-1.5.jar Downloaded: https://repo.cloudbees.com/content/repositories/central/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.jar (117 KB at 3895.0 KB/sec) Downloading: https://repo.cloudbees.com/content/repositories/central/org/codehaus/plexus/plexus-velocity/1.1.8/plexus-velocity-1.1.8.jar Downloaded:
Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)
Closed #345. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/345#event-934203490
Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)
Merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/f749c88e) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/345#issuecomment-274756356
Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)
squashing and merging -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/345#issuecomment-274751245
Re: [jclouds/jclouds-labs] add remaining features to support the abstraction (#345)
@andreaturli pushed 1 commit. 3d7946f fix checkstyle -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/jclouds/jclouds-labs/pull/345/files/b6344958cae8d54fae211316800d85ae5d13ae8f..3d7946fde99e45efbab1788daf9d0b4e629bb5b4