nacx commented on this pull request.
> @@ -54,7 +54,12 @@
public class AzureComputeHttpApiModule extends HttpApiModule {
private static final Pattern OAUTH_TENANT_PATTERN = Pattern
-
.compile("https://login.microsoft(?:online)?.com/([^/]+)/oauth2/token");
+
.compile("https://login.(microsoft(?:online)?.com|chinacloudapi.cn)/([^/]+)/oauth2/token");
+
+ private static final Pattern CHINA_OAUTH_ENDPOINT_PATTERN = Pattern
+ .compile("https://login.(chinacloudapi.cn)/([^/]+)/oauth2/token");
nit. You don't need the first grouping
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1237#pullrequestreview-152388750
