Re: [jclouds/jclouds-site] Replace the ApacheCon banner with 'support the ASF' (#219)
Merged to master: b7e2ab4. Not yet published. @nacx Lazy question: I'm wrestling a bit with the site deployment - any chance you could briefly run that if you have an appropriate environment set up? Many thanks if so, and thanks for taking a look at the PR, of course! -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/219#issuecomment-426845545
[jira] [Commented] (JCLOUDS-1132) Amazon AWS - Create Volume - query params reported as unrecognized
[ https://issues.apache.org/jira/browse/JCLOUDS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637285#comment-16637285 ] Ignasi Barrera commented on JCLOUDS-1132: - Yes, I think it makes sense. And even if it breaks code it is a good thing to upgrade to the current API version and see what needs to be fixed. Given that you already have a patch, mind opening a PR? > Amazon AWS - Create Volume - query params reported as unrecognized > -- > > Key: JCLOUDS-1132 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1132 > Project: jclouds > Issue Type: Bug > Components: jclouds-compute >Affects Versions: 1.9.0, 1.9.2 > Environment: Amazon AWS EC2 management console >Reporter: Tusa Mihail Cristian >Priority: Major > > Let say that I want to create a Volume that is encrypted. So, I set the > encrypted on "true"... in request query params apear "&Encrypted=true". In > this case the error that I got is: > UnknownParameterThe parameter > Encrypted is not > recognizedc874434a-b00e-425d-baf4-18087441603a > > instead it should be: "&Encrypted=1" as it is shown in Amazon docs: > http://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateVolume.html > in Example/Sample request. The problems are also related with Volume Type. If > not specified than creates a standard volume but if anything specified (any > of valid Values: standard | io1 | gp2 | sc1 | st1 ) the same error with > unrecognized param is received. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (JCLOUDS-1455) Update ParseResponse to log error details. Add ParseTests for Domain Objects in NetworkApi and ServerApi
John Clarke created JCLOUDS-1455: Summary: Update ParseResponse to log error details. Add ParseTests for Domain Objects in NetworkApi and ServerApi Key: JCLOUDS-1455 URL: https://issues.apache.org/jira/browse/JCLOUDS-1455 Project: jclouds Issue Type: Task Components: jclouds-labs Affects Versions: 2.1.0 Reporter: John Clarke Fix For: 2.1.2 Update ParseResponse to log error details. Add ParseTests for Domain Objects in NetworkApi and ServerApi -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (JCLOUDS-1407) Add dimensiondata server API v2.7 support
[ https://issues.apache.org/jira/browse/JCLOUDS-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boris Trishkin updated JCLOUDS-1407: Description: Update dimensiondata server API to support v2.7 (was: Update dimensiondata server API to support v2.6) Summary: Add dimensiondata server API v2.7 support (was: Add dimensiondata server API v2.6 support) > Add dimensiondata server API v2.7 support > -- > > Key: JCLOUDS-1407 > URL: https://issues.apache.org/jira/browse/JCLOUDS-1407 > Project: jclouds > Issue Type: Task > Components: jclouds-labs >Affects Versions: 2.1.0 >Reporter: Boris Trishkin >Priority: Major > Labels: dimensiondata > Fix For: 2.2.0, 2.1.2 > > > Update dimensiondata server API to support v2.7 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCLOUDS-1132) Amazon AWS - Create Volume - query params reported as unrecognized
[
https://issues.apache.org/jira/browse/JCLOUDS-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637060#comment-16637060
]
Aled Sage commented on JCLOUDS-1132:
TL;DR: Is it safe to bump the API version to "2016-11-15" in AWSEC2ApiMetadata?
I successfully tested with \{{Encrypted=1}}, which is in the examples at
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateVolume.html#API_CreateVolume_Examples
To do this, you also need to bump the version in
org.jclouds.aws.ec2.AWSEC2ApiMetadata (e.g. to "2016-11-15", from "2012-06-01").
Without the version bump, you still get the error shown below:
{noformat}
j.wire [ager-Z59Bm9lQ-45] >>
"Action=CreateVolume&AvailabilityZone=eu-west-1b&Size=4&Encrypted=1&VolumeType=gp2&Version=2012-06-01"
j.headers [ager-Z59Bm9lQ-45] >> POST https://ec2.eu-west-1.amazonaws.com/
HTTP/1.1
j.headers [ager-Z59Bm9lQ-45] >> Host: ec2.eu-west-1.amazonaws.com
j.headers [ager-Z59Bm9lQ-45] >> X-Amz-Date: 20181003T135559Z
j.headers [ager-Z59Bm9lQ-45] >> Authorization: AWS4-HMAC-SHA256
Credential=/20181003/eu-west-1/ec2/aws4_request,
SignedHeaders=content-type;host;x-amz-date,
Signature=
j.headers [ager-Z59Bm9lQ-45] >> Content-Type: application/x-www-form-urlencoded
j.headers [ager-Z59Bm9lQ-45] >> Content-Length: 100
j.headers [ager-Z59Bm9lQ-45] << HTTP/1.1 400 Bad Request
j.headers [ager-Z59Bm9lQ-45] << Transfer-Encoding: chunked
j.headers [ager-Z59Bm9lQ-45] << Server: AmazonEC2
j.headers [ager-Z59Bm9lQ-45] << Connection: close
j.headers [ager-Z59Bm9lQ-45] << Date: Wed, 03 Oct 2018 13:55:58 GMT
j.headers [ager-Z59Bm9lQ-45] << Content-Type: application/unknown
j.wire [ager-Z59Bm9lQ-45] << "[\n]"
j.wire [ager-Z59Bm9lQ-45] <<
"UnknownParameterThe parameter
Encrypted is not
recognized1da4ed2f-112b-49ab-867e-ef56f5656f72"
{noformat}
For the \{{RunInstances}} with \{{BlockDeviceMapping}}, I think it's right to
use \{{BlockDeviceMapping.1.Ebs.Encrypted=true}}, but you also need a version
like "2016-11-15".
I didn't create an AMI with an encrypted EBS boot volume (see
https://aws.amazon.com/blogs/aws/new-encrypted-ebs-boot-volumes/), so my test
didn't work end-to-end, but the error I got back was sensible:
{noformat}
j.wire [nager-aju8Oj09-5] >>
"Action=RunInstances&ImageId=ami-3548444c&MinCount=1&MaxCount=1&InstanceType=t2.micro&SecurityGroupId.1=sg-0c764025773c2701e&KeyName=jclouds%23brooklyn-pg12a0-aledsage-ebs-e-jdye-vanillasoftwar-ufot%237c6&UserData=I2Nsb3VkLWNvbmZpZwpyZXBvX3VwZ3JhZGU6IG5vbmUK&BlockDeviceMapping.1.DeviceName=/dev/sda1&BlockDeviceMapping.1.Ebs.VolumeSize=8&BlockDeviceMapping.1.Ebs.DeleteOnTermination=true&BlockDeviceMapping.1.Ebs.VolumeType=gp2&BlockDeviceMapping.1.Ebs.Encrypted=true&Version=2016-11-15"
j.wire [nager-aju8Oj09-5] <<
"InvalidBlockDeviceMappingthe
encrypted flag cannot be specified since device /dev/sda1 has a snapshot
specified.da2e8338-c2c2-4c47-95fe-3b476fc51bef"
{noformat}
Here are my code diffs to make this use-case work (against jclouds 2.1.0):
{noformat}
--- a/providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/AWSEC2ApiMetadata.java
+++ b/providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/AWSEC2ApiMetadata.java
@@ -62,7 +62,7 @@ public final class AWSEC2ApiMetadata extends
BaseHttpApiMetadata {
public static final class Builder extends
BaseHttpApiMetadata.Builder {
public Builder() {
id("aws-ec2")
- .version("2012-06-01")
+ .version("2016-11-15")
diff --git
a/apis/ec2/src/main/java/org/jclouds/ec2/options/CreateVolumeOptions.java
b/apis/ec2/src/main/java/org/jclouds/ec2/options/CreateVolumeOptions.java
index 9c2e1821ad..388da7cd43 100644
--- a/apis/ec2/src/main/java/org/jclouds/ec2/options/CreateVolumeOptions.java
+++ b/apis/ec2/src/main/java/org/jclouds/ec2/options/CreateVolumeOptions.java
@@ -92,7 +92,7 @@ public class CreateVolumeOptions extends
BaseEC2RequestOptions {
*/
public CreateVolumeOptions isEncrypted(boolean encrypted) {
if (encrypted)
- formParameters.put("Encrypted", "true");
+ formParameters.put("Encrypted", "1");
return this;
}
diff --git
a/apis/ec2/src/test/java/org/jclouds/ec2/options/CreateVolumeOptionsTest.java
b/apis/ec2/src/test/java/org/jclouds/ec2/options/CreateVolumeOptionsTest.java
index 20f74754ca..88ca91688f 100644
---
a/apis/ec2/src/test/java/org/jclouds/ec2/options/CreateVolumeOptionsTest.java
+++
b/apis/ec2/src/test/java/org/jclouds/ec2/options/CreateVolumeOptionsTest.java
@@ -137,7 +137,7 @@ public class CreateVolumeOptionsTest {
CreateVolumeOpt
Re: [jclouds/jclouds-site] Replace the ApacheCon banner with 'support the ASF' (#219)
nacx approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/219#pullrequestreview-161063677
Re: [jclouds/jclouds-site] Replace the ApacheCon banner with 'support the ASF' (#219)
This looks like already merged? >I have skepticism about any of these banners, but this improves the current >page. I'm fine with removing them. Feel free! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/219#issuecomment-426558375
