Re: [jclouds/jclouds-labs] Expose wait for predicates on relevant API (#451)

2019-01-11 Thread Ignasi Barrera
nacx approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/451#pullrequestreview-191690808

[jclouds/jclouds-labs] Use State enum instead of String state in Domain classes (#452)

2019-01-11 Thread Boris Trishkin

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/452

-- Commit Summary --

  * Use State enum instead of String state in Domain classes

-- File Changes --

M 
dimensiondata/src/main/java/org/jclouds/dimensiondata/cloudcontrol/domain/Account.java
 (6)
M 
dimensiondata/src/main/java/org/jclouds/dimensiondata/cloudcontrol/domain/Disk.java
 (6)
M 
dimensiondata/src/main/java/org/jclouds/dimensiondata/cloudcontrol/domain/NIC.java
 (6)
M 
dimensiondata/src/test/java/org/jclouds/dimensiondata/cloudcontrol/parse/ServerParseTest.java
 (4)
M 
dimensiondata/src/test/java/org/jclouds/dimensiondata/cloudcontrol/parse/ServersParseTest.java
 (4)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/452.patch
https://github.com/jclouds/jclouds-labs/pull/452.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/452


Re: [jclouds/jclouds-labs] Use State enum instead of String state in Domain classes (#452)

2019-01-11 Thread Trevor Flanagan
trevorflanagan commented on this pull request.

Nice one @btrishkin, this should mean that we no longer use String state 
anywhere.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/452#pullrequestreview-191645068

Re: [jclouds/jclouds-labs] JCLOUDS-1407 Add dimensiondata server API v2.7 supportServer API 2.7 support (#447)

2019-01-11 Thread Boris Trishkin
@btrishkin pushed 2 commits.

1e1a8fedc7415e18924356c5f1ad9cd1bac36479  Merge branch 'master' into 
server-api-2.7-support
db3f96bb13267143d88db14095ff0239f0563557  Server API 2.7 support


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/447/files/20b4af52ff8d5963aa7c02d55e72e7a3c62db548..db3f96bb13267143d88db14095ff0239f0563557