Re: [jclouds/jclouds-labs] JCLOUDS-1407 Add dimensiondata server API v2.7 supportServer API 2.7 support (#447)

2019-03-28 Thread Boris Trishkin
> 
> 
> This PR was in pretty good shape. Any chance it can be updated? 😄

Updated!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/447#issuecomment-477585206

[GitHub] [jclouds-labs] trevorflanagan commented on a change in pull request #1: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable

2019-03-28 Thread GitBox
trevorflanagan commented on a change in pull request #1: JCLOUDS-1492 Dimension 
Data Feature API Predicates are not usable
URL: https://github.com/apache/jclouds-labs/pull/1#discussion_r269964513
 
 

 ##
 File path: 
dimensiondata/src/main/java/org/jclouds/dimensiondata/cloudcontrol/domain/OsImage.java
 ##
 @@ -31,6 +32,7 @@
   type = TYPE;
}
 
+   @Nullable
 
 Review comment:
   unrelated to fix, but this is breaking our live tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [jclouds-examples] trevorflanagan opened a new pull request #2: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable

2019-03-28 Thread GitBox
trevorflanagan opened a new pull request #2: JCLOUDS-1492 Dimension Data 
Feature API Predicates are not usable
URL: https://github.com/apache/jclouds-examples/pull/2
 
 
   Updated to handle changes identified in:
   https://issues.apache.org/jira/browse/JCLOUDS-1492


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [jclouds-labs] trevorflanagan opened a new pull request #1: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable

2019-03-28 Thread GitBox
trevorflanagan opened a new pull request #1: JCLOUDS-1492 Dimension Data 
Feature API Predicates are not usable
URL: https://github.com/apache/jclouds-labs/pull/1
 
 
   Fix for issue identified in 
https://issues.apache.org/jira/browse/JCLOUDS-1492


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services