[GitHub] [jclouds] nacx closed pull request #26: JCLOUDS-847: Poor upload performance for putBlob

2019-04-24 Thread GitBox 
nacx closed pull request #26: JCLOUDS-847: Poor upload performance for putBlob
URL: https://github.com/apache/jclouds/pull/26
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [jclouds] dordoriko opened a new pull request #26: JCLOUDS-847: Poor upload performance for putBlob

2019-04-24 Thread GitBox 
dordoriko opened a new pull request #26: JCLOUDS-847: Poor upload performance 
for putBlob
URL: https://github.com/apache/jclouds/pull/26
 
 
   This change improves the performance of writing to sockets with the
   default Java URL connection HTTP client, by enlarging the buffer used
   for socket writes from an implicit hard-coded 4KB / 8KB buffer to a
   configurable 32KB buffer.
   
   The buffer size is now controlled by the following property with the
   following default value:
   
   jclouds.output-socket-buffer-size: 32768
   
   The implementation is based on a variant of ByteStreams.copy (written as
   ByteStreams2.copy) which accepts the buffer size as an argument, unlike
   the original Guava code that uses a hard-coded size.
   
   The change was done directly within the loop that copies the input
   stream to the output stream, and not by wrapping a BufferedOutputStream
   around the existing output stream, in order to avoid copying the payload
   twice.
   
   On some platforms this change can improve both the putBlob throughput
   and the total CPU consumption.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [jclouds] nacx commented on issue #26: JCLOUDS-847: Poor upload performance for putBlob

2019-04-24 Thread GitBox 
nacx commented on issue #26: JCLOUDS-847: Poor upload performance for putBlob
URL: https://github.com/apache/jclouds/pull/26#issuecomment-486390906
 
 
   Looks like a glitch when checking out the code... Let me close and reopen to 
trigger the build again


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (JCLOUDS-847) S3 poor upload performance

2019-04-24 Thread Dori Polotsky (JIRA) 


[ 
https://issues.apache.org/jira/browse/JCLOUDS-847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825388#comment-16825388
 ] 

Dori Polotsky commented on JCLOUDS-847:
---

Closed pull request #1274 and re-opened as pull request #26, this time on the 
apache/jclouds project, and with a minor change to a comment in the code 
(thanks [~nacx]):

[https://github.com/apache/jclouds/pull/26]

 

> S3 poor upload performance
> --
>
> Key: JCLOUDS-847
> URL: https://issues.apache.org/jira/browse/JCLOUDS-847
> Project: jclouds
>  Issue Type: Improvement
>  Components: jclouds-drivers
>Affects Versions: 1.8.1
> Environment: JDK 1.7.0_55, 64bit, Windows 7
> EU bucket, https
>Reporter: Veit Guna
>Priority: Major
>  Labels: performance
> Attachments: s3-upload-test.zip
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Hi.
> I'm using jclouds 1.8.1 together with the Apache HttpClient module to upload 
> files to S3. During tests, I encountered that upload performance is quite 
> poor in comparison to jets3t or windows tools like Cloudberry S3 Explorer.
> Sending a 10MB binary file on a cable connection (100mbit down/5mbit up), to 
> an EU bucket (https, default endpoints), from a Windows 7 machine (JDK 
> 1.7.0_55, 64bit) gives the following results:
> jclouds: ~55 secs
> Amazon Java SDK: ~55 secs.
> jets3t: ~18 secs
> S3 Explorer: ~18 secs
> Using a faster connection upload time increased up to 200 seconds with 
> jclouds/Amazon SDK. The rest kept the same around 18 secs.
> So I wondered, where this difference comes from. I started digging into the 
> source code of jclouds, jets3t, httpclient and took a look at the network 
> packages which are send.
> Long story short: too small buffer sizes!
> Jclouds uses for the payload the "default" HttpEntities which HttpClient 
> provides. Such as FileEntity and InputStreamEntity. These are using an output 
> buffer size of hardcoded 4096 bytes.
> This seems no problem, when the available upload bandwidth is quite small, 
> but slows down the connection on bigger bandwidth - as it seems.
> For testing I simply created my own HttpClient module, based on the shipped 
> ones and made a simple change that adds a 128k buffer to the to-be-send 
> entity. The result is, that upload performance is now up to the other guys 
> like jets3t and S3 Explorer.
> Please find attached a small maven project that can be used demonstrate the 
> difference.
> To be honest, I'm not too deep into the jclouds code to provide a proper 
> patch, but my suggestion would be to provide an own (jclouds) implementation 
> of File- and InputStreamEntity that provide proper output buffer sizes. Maybe 
> with an option to overwrite them by configuration.
> I also tried the HttpClient "http.socket.buffer-size", but that hadn't any 
> effect. Also the 2.0.0-SNAPSHOT version shows no difference.
> What do you guys think? Is this a known problem? Or are there other settings 
> to increase the upload performance?
> BTW: The same problem exists with the default 
> JavaUrlHttpCommandExecutorServiceModule which also
> uses a 4k buffer. Also tried the OkHttp driver with the same results (1.8.1, 
> 2.0.0-SNAPHOT failed with an exception).
> Thanks!
> Veit



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [jclouds/jclouds] JCLOUDS-847: Poor upload performance for putBlob (#1274)

2019-04-24 Thread dordoriko 
dordoriko commented on this pull request.



> @@ -325,7 +325,14 @@
 * 
 */
public static final String PROPERTY_TIMEOUTS_PREFIX = "jclouds.timeouts.";
-   
+
+   /**
+* Integer property. Default (32768).
+* 
+* Buffer size for socket write.

closing this PR, reopened as https://github.com/apache/jclouds/pull/26 - thanks!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1274#discussion_r278237606

[GitHub] [jclouds] dordoriko commented on issue #26: JCLOUDS-847: Poor upload performance for putBlob

2019-04-24 Thread GitBox 
dordoriko commented on issue #26: JCLOUDS-847: Poor upload performance for 
putBlob
URL: https://github.com/apache/jclouds/pull/26#issuecomment-486346250
 
 
   @nacx , @gaul , sorry for the wrong repository, I reopened the PR here.  not 
sure what Jenkins is complaining about though..


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [jclouds/jclouds] JCLOUDS-847: Poor upload performance for putBlob (#1274)

2019-04-24 Thread dordoriko 
closing, reopened as https://github.com/apache/jclouds/pull/26 on the correct 
project (apache/jclouds).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1274#issuecomment-486344685

Re: [jclouds/jclouds] JCLOUDS-847: Poor upload performance for putBlob (#1274)

2019-04-24 Thread dordoriko 
Closed #1274.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1274#event-2297944124

[GitHub] [jclouds] dordoriko opened a new pull request #26: JCLOUDS-847: Poor upload performance for putBlob

2019-04-24 Thread GitBox 
dordoriko opened a new pull request #26: JCLOUDS-847: Poor upload performance 
for putBlob
URL: https://github.com/apache/jclouds/pull/26
 
 
   This change improves the performance of writing to sockets with the
   default Java URL connection HTTP client, by enlarging the buffer used
   for socket writes from an implicit hard-coded 4KB / 8KB buffer to a
   configurable 32KB buffer.
   
   The buffer size is now controlled by the following property with the
   following default value:
   
   jclouds.output-socket-buffer-size: 32768
   
   The implementation is based on a variant of ByteStreams.copy (written as
   ByteStreams2.copy) which accepts the buffer size as an argument, unlike
   the original Guava code that uses a hard-coded size.
   
   The change was done directly within the loop that copies the input
   stream to the output stream, and not by wrapping a BufferedOutputStream
   around the existing output stream, in order to avoid copying the payload
   twice.
   
   On some platforms this change can improve both the putBlob throughput
   and the total CPU consumption.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Build failed in Jenkins: jclouds-cli #68

2019-04-24 Thread Apache Jenkins Server 
See 

--
[...truncated 25.36 KB...]
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at jenkins.maven3.agent.Maven35Main.launch (Maven35Main.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:139)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform (UserRequest.java:212)
at hudson.remoting.UserRequest.perform (UserRequest.java:54)
at hudson.remoting.Request$2.run (Request.java:369)
at hudson.remoting.InterceptingExecutorService$1.call 
(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot 
initialize module SuppressionFilter - Cannot set property 'file' in module 
SuppressionFilter to 'resources/checkstyle-suppressions.xml': unable to find 
resources/checkstyle-suppressions.xml
at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:179)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:184)
at 
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
 (DefaultCheckstyleExecutor.java:219)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute 
(CheckstyleViolationCheckMojo.java:530)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.jvnet.hudson.maven3.launcher.Maven35Launcher.main 
(Maven35Launcher.java:130)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at jenkins.maven3.agent.Maven35Main.launch (Maven35Main.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:139)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform (UserRequest.java:212)
at hudson.remoting.UserRequest.perform (UserRequest.java:54)
at hudson.remoting.Request$2.run (Request.java:369)
at hudson.remoting.InterceptingExecutorService$1.call 
(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Cannot set 
property 'file' in module SuppressionFilter to 
'resources/checkstyle-suppressions.xml': una

Jenkins build is back to normal : jclouds-karaf #69

2019-04-24 Thread Apache Jenkins Server 
See

Build failed in Jenkins: jclouds-labs-openstack #32

2019-04-24 Thread Apache Jenkins Server 
See 

--
[...truncated 59.30 KB...]
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot 
initialize module SuppressionFilter - Cannot set property 'file' in module 
SuppressionFilter to 'resources/checkstyle-suppressions.xml': unable to find 
resources/checkstyle-suppressions.xml
at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:179)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:184)
at 
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
 (DefaultCheckstyleExecutor.java:219)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute 
(CheckstyleViolationCheckMojo.java:530)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.jvnet.hudson.maven3.launcher.Maven35Launcher.main 
(Maven35Launcher.java:130)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at jenkins.maven3.agent.Maven35Main.launch (Maven35Main.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:139)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform (UserRequest.java:212)
at hudson.remoting.UserRequest.perform (UserRequest.java:54)
at hudson.remoting.Request$2.run (Request.java:369)
at hudson.remoting.InterceptingExecutorService$1.call 
(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Cannot set 
property 'file' in module SuppressionFilter to 
'resources/checkstyle-suppressions.xml': unable to find 
resources/checkstyle-suppressions.xml
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:152)
at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:158)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:184)
at 
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
 (DefaultCheckstyleExecutor.java:219)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute 
(CheckstyleViolationCheckMojo.java:530)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.l

Build failed in Jenkins: jclouds-labs #45

2019-04-24 Thread Apache Jenkins Server 
See 

--
[...truncated 127.89 KB...]
at hudson.remoting.InterceptingExecutorService$1.call 
(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot 
initialize module SuppressionFilter - Cannot set property 'file' in module 
SuppressionFilter to 'resources/checkstyle-suppressions.xml': unable to find 
resources/checkstyle-suppressions.xml
at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:179)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:184)
at 
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
 (DefaultCheckstyleExecutor.java:219)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute 
(CheckstyleViolationCheckMojo.java:530)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.jvnet.hudson.maven3.launcher.Maven35Launcher.main 
(Maven35Launcher.java:130)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at jenkins.maven3.agent.Maven35Main.launch (Maven35Main.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:139)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform (UserRequest.java:212)
at hudson.remoting.UserRequest.perform (UserRequest.java:54)
at hudson.remoting.Request$2.run (Request.java:369)
at hudson.remoting.InterceptingExecutorService$1.call 
(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Cannot set 
property 'file' in module SuppressionFilter to 
'resources/checkstyle-suppressions.xml': unable to find 
resources/checkstyle-suppressions.xml
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:152)
at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:158)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:184)
at 
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
 (DefaultCheckstyleExecutor.java:219)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute 
(CheckstyleViolationCheckMojo.java:530)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecu

Build failed in Jenkins: jclouds-labs-aws #32

2019-04-24 Thread Apache Jenkins Server 
See 

--
[...truncated 58.29 KB...]
at hudson.remoting.Request$2.run (Request.java:369)
at hudson.remoting.InterceptingExecutorService$1.call 
(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: cannot 
initialize module SuppressionFilter - Cannot set property 'file' in module 
SuppressionFilter to 'resources/checkstyle-suppressions.xml': unable to find 
resources/checkstyle-suppressions.xml
at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:179)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:184)
at 
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
 (DefaultCheckstyleExecutor.java:219)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute 
(CheckstyleViolationCheckMojo.java:530)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.jvnet.hudson.maven3.launcher.Maven35Launcher.main 
(Maven35Launcher.java:130)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at jenkins.maven3.agent.Maven35Main.launch (Maven35Main.java:176)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:139)
at hudson.maven.Maven3Builder.call (Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform (UserRequest.java:212)
at hudson.remoting.UserRequest.perform (UserRequest.java:54)
at hudson.remoting.Request$2.run (Request.java:369)
at hudson.remoting.InterceptingExecutorService$1.call 
(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run (FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker 
(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run 
(ThreadPoolExecutor.java:624)
at java.lang.Thread.run (Thread.java:748)
Caused by: com.puppycrawl.tools.checkstyle.api.CheckstyleException: Cannot set 
property 'file' in module SuppressionFilter to 
'resources/checkstyle-suppressions.xml': unable to find 
resources/checkstyle-suppressions.xml
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:152)
at com.puppycrawl.tools.checkstyle.Checker.setupChild (Checker.java:158)
at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure 
(AutomaticBean.java:184)
at 
org.apache.maven.plugin.checkstyle.exec.DefaultCheckstyleExecutor.executeCheckstyle
 (DefaultCheckstyleExecutor.java:219)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute 
(CheckstyleViolationCheckMojo.java:530)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apach

Re: [jclouds/jclouds] JCLOUDS-847: Poor upload performance for putBlob (#1274)

2019-04-24 Thread Ignasi Barrera 
nacx commented on this pull request.

LGTM
We have migrated to the Apache GitHub org. Mind closing this PR and reopening 
again here? https://github.com/apache/jclouds

> @@ -325,7 +325,14 @@
 * 
 */
public static final String PROPERTY_TIMEOUTS_PREFIX = "jclouds.timeouts.";
-   
+
+   /**
+* Integer property. Default (32768).
+* 
+* Buffer size for socket write.

Explain here that this is only considered int he default java http driver

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1274#pullrequestreview-230145896

[GitHub] [jclouds] nacx commented on a change in pull request #23: draft - disable AccessPolicy check for SAS Authorised azureblob

2019-04-24 Thread GitBox 
nacx commented on a change in pull request #23: draft - disable AccessPolicy 
check for SAS Authorised azureblob
URL: https://github.com/apache/jclouds/pull/23#discussion_r278148349
 
 

 ##
 File path: 
providers/azureblob/src/main/java/org/jclouds/azureblob/config/InsufficientAccessRightsException.java
 ##
 @@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+ 
+ 
+/**
+ * Handles the inability of SAS Authentication string to authenticate the 
getAcl and setAcl requests.
+ * 
+ */
+ 
+package org.jclouds.azureblob.config;
+
+import com.google.common.util.concurrent.UncheckedExecutionException;
+
+public class InsufficientAccessRightsException extends 
UncheckedExecutionException {
 
 Review comment:
   I think this should just extend Exception or RuntimeException, depending on 
whether you want to make this checked or not.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [jclouds] nacx commented on a change in pull request #23: draft - disable AccessPolicy check for SAS Authorised azureblob

2019-04-24 Thread GitBox 
nacx commented on a change in pull request #23: draft - disable AccessPolicy 
check for SAS Authorised azureblob
URL: https://github.com/apache/jclouds/pull/23#discussion_r278151052
 
 

 ##
 File path: 
providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/functions/BlobPropertiesToBlobMetadata.java
 ##
 @@ -58,6 +59,8 @@ public MutableBlobMetadata apply(BlobProperties from) {
 PublicAccess containerAcl = 
containerAcls.getUnchecked(from.getContainer());
 if (containerAcl != PublicAccess.PRIVATE)
to.setPublicUri(from.getUrl());
+ } catch (UncheckedExecutionException ue) {
+   to.setPublicUri(from.getUrl());
 
 Review comment:
   Would something like the following work?
   ```java
   } catch (Exception ex) {
  InsufficientAccessRightsException iare = 
Throwables2.getFirstThrowableOfType(ex, 
InsufficientAccessRightsException.class);
  if (iare == null) throw ex; // Propagate any other uncaught exceptions
  to.setPublicUri(from.getUrl()); // handle our own exception gracefully
   }
   ``` 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [jclouds] nacx merged pull request #25: JCLOUDS-1496: Update maven-compiler-plugin for increased JDK compatibility

2019-04-24 Thread GitBox 
nacx merged pull request #25: JCLOUDS-1496: Update maven-compiler-plugin for 
increased JDK compatibility
URL: https://github.com/apache/jclouds/pull/25
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (JCLOUDS-1496) Update maven-compiler-plugin for increased JDK compatibility

2019-04-24 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/JCLOUDS-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825191#comment-16825191
 ] 

ASF subversion and git services commented on JCLOUDS-1496:
--

Commit d51d6e44bcd9936f753b87a6407d5394279347e7 in jclouds's branch 
refs/heads/master from Olaf Flebbe
[ https://gitbox.apache.org/repos/asf?p=jclouds.git;h=d51d6e4 ]

JCLOUDS-1496: Update maven-compiler-plugin for increased JDK compatibility (#25)

* JCLOUDS-1496: Update maven-compiler-plugin for increased JDK compatibility

* increase maven-compiler-plugin version

* A space change to trigger jenkins again

* Another space change to trigger jenkins again


> Update maven-compiler-plugin for increased JDK compatibility 
> -
>
> Key: JCLOUDS-1496
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1496
> Project: jclouds
>  Issue Type: Task
>Reporter: Olaf Flebbe
>Priority: Major
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> The maven-compiler-plugin is referenced in the wrong clause of the pom file.
> It should be within .
> (See for instance 
> https://maven.apache.org/plugins/maven-compiler-plugin/usage.html )
> Otherwise you will see Nullptr Exceptions for instance with JDK11.
> For now I propose to only move the plugin and use current version 3.8.0. 
> Increasing the errorprone module version will trigger a lot of diagnostics in 
> errorprone plugins, which should be dealt seperately.
> Doublechecked: Still compiles with java 1.8 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (JCLOUDS-1496) Update maven-compiler-plugin for increased JDK compatibility

2019-04-24 Thread ASF subversion and git services (JIRA) 


[ 
https://issues.apache.org/jira/browse/JCLOUDS-1496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16825190#comment-16825190
 ] 

ASF subversion and git services commented on JCLOUDS-1496:
--

Commit d51d6e44bcd9936f753b87a6407d5394279347e7 in jclouds's branch 
refs/heads/master from Olaf Flebbe
[ https://gitbox.apache.org/repos/asf?p=jclouds.git;h=d51d6e4 ]

JCLOUDS-1496: Update maven-compiler-plugin for increased JDK compatibility (#25)

* JCLOUDS-1496: Update maven-compiler-plugin for increased JDK compatibility

* increase maven-compiler-plugin version

* A space change to trigger jenkins again

* Another space change to trigger jenkins again


> Update maven-compiler-plugin for increased JDK compatibility 
> -
>
> Key: JCLOUDS-1496
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1496
> Project: jclouds
>  Issue Type: Task
>Reporter: Olaf Flebbe
>Priority: Major
>  Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> The maven-compiler-plugin is referenced in the wrong clause of the pom file.
> It should be within .
> (See for instance 
> https://maven.apache.org/plugins/maven-compiler-plugin/usage.html )
> Otherwise you will see Nullptr Exceptions for instance with JDK11.
> For now I propose to only move the plugin and use current version 3.8.0. 
> Increasing the errorprone module version will trigger a lot of diagnostics in 
> errorprone plugins, which should be dealt seperately.
> Doublechecked: Still compiles with java 1.8 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)