[jira] [Created] (JCLOUDS-1509) ParseAWSErrorFromXmlContent uses the default charset

[Roded Bahat (JIRA)]

Roded Bahat created JCLOUDS-1509:


 Summary: ParseAWSErrorFromXmlContent uses the default charset
 Key: JCLOUDS-1509
 URL: https://issues.apache.org/jira/browse/JCLOUDS-1509
 Project: jclouds
  Issue Type: Bug
Reporter: Roded Bahat


ParseAWSErrorFromXmlContent handleError() creates a String from the data byte 
array using the default charset. This breaks on environment in which the 
default char set is not UTF-8 causing JClouds to fail refining the AWS 
exception.

I suspect that the default AWS response charset is UTF-8: 
[https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html]

 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jclouds/jclouds] JCLOUDS-1509: read AWS response data with the UTF-8 charset explicitly (#1278)

[roded]

AWS response data is encoded in UTF-8. Creating a String from said data
using the JVM's default charset results in incorrect encoding on
environments in which the JVM's default charset is not UTF-8.

https://issues.apache.org/jira/browse/JCLOUDS-1509
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1278

-- Commit Summary --

  * JCLOUDS-1509: read AWS response data with the UTF-8 charset explicitly

-- File Changes --

M 
apis/sts/src/main/java/org/jclouds/aws/handlers/ParseAWSErrorFromXmlContent.java
 (3)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1278.patch
https://github.com/jclouds/jclouds/pull/1278.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1278

Re: [jclouds/jclouds] JCLOUDS-1509: read AWS response data with the UTF-8 charset explicitly (#1278)

[roded]

Ideally, the response should be parsed as an XML whose encoding is derived from 
its header. I'm not sure if that's out of scope though, since it seems that 
currently this code is AWS specific and UTF-8 can be expected.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1278#issuecomment-519546430

[jira] [Commented] (JCLOUDS-1509) ParseAWSErrorFromXmlContent uses the default charset

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903070#comment-16903070
 ] 

ASF subversion and git services commented on JCLOUDS-1509:
--

Commit a248697c0668f8f1c442b04e3833d876b125dc2c in jclouds's branch 
refs/heads/master from Roded Bahat
[ https://gitbox.apache.org/repos/asf?p=jclouds.git;h=a248697 ]

JCLOUDS-1509: read AWS response data with the UTF-8 charset explicitly

AWS response data is encoded in UTF-8. Creating a String from said data
using the JVM's default charset results in incorrect encoding on
environments in which the JVM's default charset is not UTF-8.

https://issues.apache.org/jira/browse/JCLOUDS-1509


> ParseAWSErrorFromXmlContent uses the default charset
> 
>
> Key: JCLOUDS-1509
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1509
> Project: jclouds
>  Issue Type: Bug
>Reporter: Roded Bahat
>Priority: Major
>
> ParseAWSErrorFromXmlContent handleError() creates a String from the data byte 
> array using the default charset. This breaks on environment in which the 
> default char set is not UTF-8 causing JClouds to fail refining the AWS 
> exception.
> I suspect that the default AWS response charset is UTF-8: 
> [https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (JCLOUDS-1509) ParseAWSErrorFromXmlContent uses the default charset

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903069#comment-16903069
 ] 

ASF subversion and git services commented on JCLOUDS-1509:
--

Commit a248697c0668f8f1c442b04e3833d876b125dc2c in jclouds's branch 
refs/heads/master from Roded Bahat
[ https://gitbox.apache.org/repos/asf?p=jclouds.git;h=a248697 ]

JCLOUDS-1509: read AWS response data with the UTF-8 charset explicitly

AWS response data is encoded in UTF-8. Creating a String from said data
using the JVM's default charset results in incorrect encoding on
environments in which the JVM's default charset is not UTF-8.

https://issues.apache.org/jira/browse/JCLOUDS-1509


> ParseAWSErrorFromXmlContent uses the default charset
> 
>
> Key: JCLOUDS-1509
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1509
> Project: jclouds
>  Issue Type: Bug
>Reporter: Roded Bahat
>Priority: Major
>
> ParseAWSErrorFromXmlContent handleError() creates a String from the data byte 
> array using the default charset. This breaks on environment in which the 
> default char set is not UTF-8 causing JClouds to fail refining the AWS 
> exception.
> I suspect that the default AWS response charset is UTF-8: 
> [https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (JCLOUDS-1509) ParseAWSErrorFromXmlContent uses the default charset

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903074#comment-16903074
 ] 

ASF subversion and git services commented on JCLOUDS-1509:
--

Commit 95c4443022f9bfaa87952d5ac59befe0b89d755e in jclouds's branch 
refs/heads/2.1.x from Roded Bahat
[ https://gitbox.apache.org/repos/asf?p=jclouds.git;h=95c4443 ]

JCLOUDS-1509: read AWS response data with the UTF-8 charset explicitly

AWS response data is encoded in UTF-8. Creating a String from said data
using the JVM's default charset results in incorrect encoding on
environments in which the JVM's default charset is not UTF-8.

https://issues.apache.org/jira/browse/JCLOUDS-1509


> ParseAWSErrorFromXmlContent uses the default charset
> 
>
> Key: JCLOUDS-1509
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1509
> Project: jclouds
>  Issue Type: Bug
>Reporter: Roded Bahat
>Priority: Major
>
> ParseAWSErrorFromXmlContent handleError() creates a String from the data byte 
> array using the default charset. This breaks on environment in which the 
> default char set is not UTF-8 causing JClouds to fail refining the AWS 
> exception.
> I suspect that the default AWS response charset is UTF-8: 
> [https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (JCLOUDS-1509) ParseAWSErrorFromXmlContent uses the default charset

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/JCLOUDS-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903073#comment-16903073
 ] 

ASF subversion and git services commented on JCLOUDS-1509:
--

Commit 95c4443022f9bfaa87952d5ac59befe0b89d755e in jclouds's branch 
refs/heads/2.1.x from Roded Bahat
[ https://gitbox.apache.org/repos/asf?p=jclouds.git;h=95c4443 ]

JCLOUDS-1509: read AWS response data with the UTF-8 charset explicitly

AWS response data is encoded in UTF-8. Creating a String from said data
using the JVM's default charset results in incorrect encoding on
environments in which the JVM's default charset is not UTF-8.

https://issues.apache.org/jira/browse/JCLOUDS-1509


> ParseAWSErrorFromXmlContent uses the default charset
> 
>
> Key: JCLOUDS-1509
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1509
> Project: jclouds
>  Issue Type: Bug
>Reporter: Roded Bahat
>Priority: Major
>
> ParseAWSErrorFromXmlContent handleError() creates a String from the data byte 
> array using the default charset. This breaks on environment in which the 
> default char set is not UTF-8 causing JClouds to fail refining the AWS 
> exception.
> I suspect that the default AWS response charset is UTF-8: 
> [https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (JCLOUDS-1509) ParseAWSErrorFromXmlContent uses the default charset

[Andrew Gaul (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul updated JCLOUDS-1509:
-
Priority: Minor  (was: Major)

> ParseAWSErrorFromXmlContent uses the default charset
> 
>
> Key: JCLOUDS-1509
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1509
> Project: jclouds
>  Issue Type: Bug
>Reporter: Roded Bahat
>Assignee: Andrew Gaul
>Priority: Minor
> Fix For: 2.2.0, 2.1.3
>
>
> ParseAWSErrorFromXmlContent handleError() creates a String from the data byte 
> array using the default charset. This breaks on environment in which the 
> default char set is not UTF-8 causing JClouds to fail refining the AWS 
> exception.
> I suspect that the default AWS response charset is UTF-8: 
> [https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Resolved] (JCLOUDS-1509) ParseAWSErrorFromXmlContent uses the default charset

[Andrew Gaul (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JCLOUDS-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Gaul resolved JCLOUDS-1509.
--
   Resolution: Fixed
 Assignee: Andrew Gaul
Fix Version/s: 2.1.3
   2.2.0

> ParseAWSErrorFromXmlContent uses the default charset
> 
>
> Key: JCLOUDS-1509
> URL: https://issues.apache.org/jira/browse/JCLOUDS-1509
> Project: jclouds
>  Issue Type: Bug
>Reporter: Roded Bahat
>Assignee: Andrew Gaul
>Priority: Major
> Fix For: 2.2.0, 2.1.3
>
>
> ParseAWSErrorFromXmlContent handleError() creates a String from the data byte 
> array using the default charset. This breaks on environment in which the 
> default char set is not UTF-8 causing JClouds to fail refining the AWS 
> exception.
> I suspect that the default AWS response charset is UTF-8: 
> [https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Re: [jclouds/jclouds] JCLOUDS-1509: read AWS response data with the UTF-8 charset explicitly (#1278)

[Andrew Gaul]

Pushed to master as a248697c0668f8f1c442b04e3833d876b125dc2c and 2.1.x as 
95c4443022f9bfaa87952d5ac59befe0b89d755e.  Thank you for your contribution 
@roded!  Please use the apache/jclouds repository for future pull requests.

-- 
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1278#issuecomment-519583028

Build failed in Jenkins: 2.1.x » jclouds-2.1.x #49

[Apache Jenkins Server]

See 


Changes:

[gaul] JCLOUDS-1509: read AWS response data with the UTF-8 charset explicitly

--
[...truncated 1.45 MB...]
[INFO] allblobstore .. SKIPPED
[INFO] allloadbalancer ... SKIPPED
[INFO] all ... SKIPPED
[INFO] Apache jclouds  SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 16:11.911s
[INFO] Finished at: Thu Aug 08 16:59:34 UTC 2019
[INFO] Final Memory: 158M/3991M
[INFO] 
Waiting for Jenkins to finish collecting data
[ERROR] Failed to execute goal 
org.codehaus.mojo:animal-sniffer-maven-plugin:1.11:check (default) on project 
sts: Signature errors found. Verify them and ignore them with the proper 
annotation if needed. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.codehaus.mojo:animal-sniffer-maven-plugin:1.11:check (default) on project 
sts: Signature errors found. Verify them and ignore them with the proper 
annotation if needed.
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at 
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
at 
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at 
org.jvnet.hudson.maven3.launcher.Maven3Launcher.main(Maven3Launcher.java:117)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launchStandard(Launcher.java:329)
at 
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:239)
at org.jvnet.hudson.maven3.agent.Maven3Main.launch(Maven3Main.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:139)
at hudson.maven.Maven3Builder.call(Maven3Builder.java:70)
at hudson.remoting.UserRequest.perform(UserRequest.java:212)
at hudson.remoting.UserRequest.perform(UserRequest.java:54)
at hudson.remoting.Request$2.run(Request.java:369)
at 
hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: org.apache.maven.plugin.MojoFailureException: Signature errors 
found. Verify them and ignore them with the proper annotation if needed.
at 
org.codehaus.mojo.animal_sniffer.maven.CheckSignatureMojo.execute(CheckSignatureMojo.java:200)
at 
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
at 
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
... 30 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn  -rf :sts
[JENKINS] Archiving 

 to 
org.

Re: [jclouds/jclouds] Add tag support to azure disks (#1277)

[Ignasi Barrera]

Thanks, @pimuzzo! Can you add the corresponding test in the `DiskApiMockTest`? 
It should be as easy as copying the existing create test and checking that the 
payload includes the tags.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1277#issuecomment-519645773

Re: [jclouds/jclouds] JCLOUDS-1509: read AWS response data with the UTF-8 charset explicitly (#1278)

[roded]

Thanks @gual. Will do.

-- 
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1278#issuecomment-519667947

Jenkins build is back to normal : 2.1.x » jclouds-2.1.x #50

[Apache Jenkins Server]

See