Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#175)
@nacx can you review this? . I am working on merging https://github.com/jclouds/jclouds-labs/pull/157 now. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/175#issuecomment-10463
Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#171)
Closed #171. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/171#event-311153739
Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#171)
@nacx Moved to https://github.com/jclouds/jclouds-labs/pull/175 with changes --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/171#issuecomment-104440913
[jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#175)
Conflicts: azurecompute/src/test/java/org/jclouds/azurecompute/features/VirtualMachineApiLiveTest.java Fix Checkstyle Violations Address live test failiures Fix Checkstyle Violations minor changes: fix live and mocktests minor changes Code style changes You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/175 -- Commit Summary -- * JCLOUDS-853: Improve Create VirtualMachine Deployment -- File Changes -- M azurecompute/pom.xml (4) M azurecompute/src/main/java/org/jclouds/azurecompute/binders/DeploymentParamsToXML.java (242) M azurecompute/src/main/java/org/jclouds/azurecompute/binders/RoleToXML.java (5) M azurecompute/src/main/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapter.java (73) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDiskParam.java (156) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/DeploymentParams.java (193) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/LinuxConfigurationSetParams.java (138) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDiskParam.java (175) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleParam.java (194) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Rule.java (2) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/WindowsConfigurationSetParams.java (150) M azurecompute/src/main/java/org/jclouds/azurecompute/util/ConflictManagementPredicate.java (2) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/RuleHandler.java (2) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/StorageServiceKeysHandler.java (2) M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiLiveTest.java (44) M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiMockTest.java (68) M azurecompute/src/test/java/org/jclouds/azurecompute/features/VMImageApiLiveTest.java (50) M azurecompute/src/test/java/org/jclouds/azurecompute/features/VirtualMachineApiLiveTest.java (102) M azurecompute/src/test/java/org/jclouds/azurecompute/internal/AbstractAzureComputeApiLiveTest.java (2) A azurecompute/src/test/resources/newdeploymentparams-linux.xml (1) A azurecompute/src/test/resources/newdeploymentparams-windows.xml (1) M azurecompute/src/test/resources/profiledefinitiontmparams.xml (6) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/175.patch https://github.com/jclouds/jclouds-labs/pull/175.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/175
Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#171)
Sorry. I was bit busy last few days. I'll make those changes tomorrow. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/171#issuecomment-103590397
Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#154)
@ilgrosso Rebase this in https://github.com/jclouds/jclouds-labs/pull/171 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/154#issuecomment-99098159
[jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#171)
hsbhathiya wants to merge 1 commit into jclouds:master from hsbhathiya:JCLOUDS-853-2: Conflicts: azurecompute/src/test/java/org/jclouds/azurecompute/features/VirtualMachineApiLiveTest.java Fix Checkstyle Violations Address live test failiures Fix Checkstyle Violations minor changes: fix live and mocktests minor changes You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/171 -- Commit Summary -- * JCLOUDS-853: Improve Create VirtualMachine Deployment -- File Changes -- M azurecompute/src/main/java/org/jclouds/azurecompute/binders/DeploymentParamsToXML.java (256) M azurecompute/src/main/java/org/jclouds/azurecompute/binders/RoleToXML.java (5) M azurecompute/src/main/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapter.java (845) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDiskParam.java (161) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/DeploymentParams.java (206) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/LinuxConfigurationSetParams.java (141) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDiskParam.java (180) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleParam.java (199) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/WindowsConfigurationSetParams.java (153) M azurecompute/src/main/java/org/jclouds/azurecompute/util/ConflictManagementPredicate.java (2) M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiLiveTest.java (60) M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiMockTest.java (121) M azurecompute/src/test/java/org/jclouds/azurecompute/features/VMImageApiLiveTest.java (50) M azurecompute/src/test/java/org/jclouds/azurecompute/features/VirtualMachineApiLiveTest.java (81) M azurecompute/src/test/java/org/jclouds/azurecompute/internal/AbstractAzureComputeApiLiveTest.java (2) A azurecompute/src/test/resources/newdeploymentparams-linux.xml (1) A azurecompute/src/test/resources/newdeploymentparams-windows.xml (1) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/171.patch https://github.com/jclouds/jclouds-labs/pull/171.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/171
Re: [jclouds-labs] JCLOUDS-852:Added VMImageOpertaions (#167)
@nacx I have addressed issues. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/167#issuecomment-94900399
Re: [jclouds-labs] JCLOUDS-664: Alternate Compute Service Adapter (#157)
@ilgrosso No had some issues with rebasing https://github.com/jclouds/jclouds-labs/pull/154. Shall we merge those it first and then come to this ? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/157#issuecomment-94526094
Re: [jclouds-labs] JCLOUDS-852:Added VMImageOpertaions (#167)
@nacx CaptureVMImage operation is added to the VirtualMachineApi becasuse of its Request URI. All the other VMImage Operations request URIs start with https://management.core.windows.net//services/vmimages. Tests for that method is in VMImgeLiveTests. I will add the CaptureVMImage Mock test as well. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/167#issuecomment-94408140
Re: [jclouds-labs] JCLOUDS-852:Added VMImageOpertaions (#167)
Ok I won't squash by now. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/167#issuecomment-94408687
Re: [jclouds-labs] JCLOUDS-664: Get Cloud Service Properties Operation Support (#155)
Closed #155. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/155#event-283169455
Re: [jclouds-labs] JCLOUDS-664: Get Cloud Service Properties Operation Support (#155)
@nacx Added Mock tests and moved to https://github.com/jclouds/jclouds-labs/pull/168 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/155#issuecomment-93766204
[jclouds-labs] JCLOUDS-664: Get Cloud Service Properties Operation Support (#168)
Rebased https://github.com/jclouds/jclouds-labs/pull/155 on master Added Mock Tests to Cloud Service Properties. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/168 -- Commit Summary -- * JCLOUDS-664: Get Cloud Service Properties Operation Support -- File Changes -- A azurecompute/src/main/java/org/jclouds/azurecompute/domain/CloudServiceProperties.java (96) M azurecompute/src/main/java/org/jclouds/azurecompute/features/CloudServiceApi.java (26) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/CloudServicePropertiesHandler.java (155) M azurecompute/src/test/java/org/jclouds/azurecompute/features/CloudServiceApiMockTest.java (31) M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiLiveTest.java (24) A azurecompute/src/test/java/org/jclouds/azurecompute/xml/CloudServicePropertiesHandlerTest.java (147) A azurecompute/src/test/resources/cloudserviceproperties.xml (120) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/168.patch https://github.com/jclouds/jclouds-labs/pull/168.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/168
Re: [jclouds-labs] JCLOUDS-664:VM Image Operations (#144)
This is moved to https://github.com/jclouds/jclouds-labs/pull/167 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/144#issuecomment-92795506
Re: [jclouds-labs] JCLOUDS-664:VM Image Operations (#144)
Closed #144. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/144#event-280807919
[jclouds-labs] JCLOUDS-852:Added VMImageOpertaions (#167)
Virtual Machine Image Operations. https://msdn.microsoft.com/en-us/library/azure/dn499771.aspx Rebased https://github.com/jclouds/jclouds-labs/pull/144 on master You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/167 -- Commit Summary -- * JCLOUDS-852:Added VMImageOpertaions -- File Changes -- M azurecompute/src/main/java/org/jclouds/azurecompute/AzureComputeApi.java (6) A azurecompute/src/main/java/org/jclouds/azurecompute/binders/CaptureVMImageParamsToXML.java (68) A azurecompute/src/main/java/org/jclouds/azurecompute/binders/VMImageParamsToXML.java (94) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/CaptureVMImageParams.java (117) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/VMImage.java (169) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/VMImageParams.java (247) A azurecompute/src/main/java/org/jclouds/azurecompute/features/VMImageApi.java (98) M azurecompute/src/main/java/org/jclouds/azurecompute/features/VirtualMachineApi.java (13) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DataVirtualHardDiskHandler.java (2) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListVMImagesHandler.java (70) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/OSConfigHandler.java (105) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/VMImageHandler.java (207) A azurecompute/src/test/java/org/jclouds/azurecompute/features/VMImageApiLiveTest.java (205) A azurecompute/src/test/java/org/jclouds/azurecompute/features/VMImageApiMockTest.java (103) A azurecompute/src/test/java/org/jclouds/azurecompute/xml/ListVMImagesHandlerTest.java (106) A azurecompute/src/test/resources/vmimageparams.xml (1) A azurecompute/src/test/resources/vmimages.xml (56) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/167.patch https://github.com/jclouds/jclouds-labs/pull/167.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/167
Re: [jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#154)
@fmartelli I'll look into it change the PR as required --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/154#issuecomment-92381621
[jclouds-labs-google] JCLOUD-875: GCS Copy Object with Updated Metadata (#133)
Now update metadata options is supported in feature API. Note: Working on Windows I'm getting few live test failiures. You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs-google/pull/133 -- Commit Summary -- * JCLOUD-875: GCS Copy Object with Updated Metadata -- File Changes -- M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/ObjectApi.java (24) M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ObjectApiLiveTest.java (51) M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/ObjectApiMockTest.java (15) -- Patch Links -- https://github.com/jclouds/jclouds-labs-google/pull/133.patch https://github.com/jclouds/jclouds-labs-google/pull/133.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/133
[jira] [Commented] (JCLOUDS-875) Google Cloud Storage copy object cannot update metadata
[
https://issues.apache.org/jira/browse/JCLOUDS-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388150#comment-14388150
]
Bhathiya Supun commented on JCLOUDS-875:
[~gaul]
Looks like support is missing in feature API. Method taking ObjectTemplate as
PayloadParam should be added to ObjectApi
GoogleCloudStorageObject copyObject(@PathParam("destinationBucket") String
destinationBucket,
@PathParam("destinationObject") String destinationObject,
@PathParam("sourceBucket") String sourceBucket,
@PathParam("sourceObject") String sourceObject, ObjectTemplate
template);
I'll work on this.
> Google Cloud Storage copy object cannot update metadata
> ---
>
> Key: JCLOUDS-875
> URL: https://issues.apache.org/jira/browse/JCLOUDS-875
> Project: jclouds
> Issue Type: New Feature
> Components: jclouds-blobstore
>Affects Versions: 1.9.0
>Reporter: Andrew Gaul
> Labels: google-cloud-storage
>
> Google documents that this is possible yet jclouds does not expose it:
> https://cloud.google.com/storage/docs/json_api/v1/objects/copy
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jclouds-labs] [JCLOUDS-849] All tests are green (#158)
@ilgrosso No test failiures now. -- Test set: TestSuite --- Tests run: 55, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 5,516.931 sec - in TestSuite --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/158#issuecomment-87701608
[jira] [Updated] (JCLOUDS-868) Complete Virtual Machine Disk Operatiopns
[ https://issues.apache.org/jira/browse/JCLOUDS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bhathiya Supun updated JCLOUDS-868: --- Summary: Complete Virtual Machine Disk Operatiopns (was: Complete Disk Api Support) > Complete Virtual Machine Disk Operatiopns > - > > Key: JCLOUDS-868 > URL: https://issues.apache.org/jira/browse/JCLOUDS-868 > Project: jclouds > Issue Type: Sub-task > Components: jclouds-compute, jclouds-labs > Reporter: Bhathiya Supun > Fix For: 2.0.0 > > > Complete the Support for Operations on Virtual Machine Disks > https://msdn.microsoft.com/en-us/library/azure/jj157188.aspx -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (JCLOUDS-868) Complete Virtual Machine Disk Operations
[ https://issues.apache.org/jira/browse/JCLOUDS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bhathiya Supun updated JCLOUDS-868: --- Summary: Complete Virtual Machine Disk Operations (was: Complete Virtual Machine Disk Operatiopns) > Complete Virtual Machine Disk Operations > > > Key: JCLOUDS-868 > URL: https://issues.apache.org/jira/browse/JCLOUDS-868 > Project: jclouds > Issue Type: Sub-task > Components: jclouds-compute, jclouds-labs > Reporter: Bhathiya Supun > Fix For: 2.0.0 > > > Complete the Support for Operations on Virtual Machine Disks > https://msdn.microsoft.com/en-us/library/azure/jj157188.aspx -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (JCLOUDS-868) Complete Disk Api Support
Bhathiya Supun created JCLOUDS-868: -- Summary: Complete Disk Api Support Key: JCLOUDS-868 URL: https://issues.apache.org/jira/browse/JCLOUDS-868 Project: jclouds Issue Type: Sub-task Components: jclouds-compute, jclouds-labs Reporter: Bhathiya Supun Complete the Support for Operations on Virtual Machine Disks https://msdn.microsoft.com/en-us/library/azure/jj157188.aspx -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jclouds-labs] [JCLOUDS-849] All tests are green (#158)
Hi great work @ilgrosso ! I tested against my azure account. Here is the [results](https://gist.github.com/hsbhathiya/aa94e79ae6a61a618c88#file-azure849live) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/158#issuecomment-87229822
Re: [jclouds-labs-google] Make deleteObject() and deleteBucket() return false on 404 response (#122)
> @@ -422,8 +425,9 @@ public void testDeleteObjectWithOptions() {
>
> @AfterClass
> private void deleteBucket() {
> - api.getBucketApi().deleteBucket(BUCKET_NAME);
> - api.getBucketApi().deleteBucket(BUCKET_NAME2);
> + assertTrue(api.getBucketApi().deleteBucket(BUCKET_NAME));
> + assertTrue(api.getBucketApi().deleteBucket(BUCKET_NAME2));
> + assertFalse(api.getBucketApi().deleteBucket(NONEXISTENT_BUCKET_NAME));
I think just removing asserts would be enough. Delete bucket tests are
available in BucketApiLiveTests
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/122/files#r27332165
Re: [jclouds-labs-google] Fix if-statement that always returns true (#131)
@snotling Perhaps we can optimize jclouds MPU by using GCS simpleUpload in SequentialMultipartUploadStrategy? The second metadata part in GCS multipartUpload does not seem required since compose takes a metadata parameter. I'm not sure whether it is possible. Resumable Uploads may be useful. It is implemented in feature API --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/131#issuecomment-86721837
Re: [jclouds-labs-google] Fix if-statement that always returns true (#131)
@snotling @gaul "I think the term multipart is overloaded here. jclouds single-part upload should map to a GCS multi-part upload which sends a metadata part and a data part. jclouds multi-part upload should map to multiple jclouds single-part uploads followed by a GCS compose operation." yes here is the documentation https://cloud.google.com/storage/docs/json_api/v1/how-tos/upload#multipart --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/131#issuecomment-86720634
[jira] [Created] (JCLOUDS-865) Create Message Queue Abstraction
Bhathiya Supun created JCLOUDS-865: -- Summary: Create Message Queue Abstraction Key: JCLOUDS-865 URL: https://issues.apache.org/jira/browse/JCLOUDS-865 Project: jclouds Issue Type: New Feature Components: jclouds-core, jclouds-labs Reporter: Bhathiya Supun Priority: Minor Most of the cloud providers like AWS, Rackspace,Azure, Google now provide Message/Queue as a Service. Jclouds currently provide API level Amazon SQS and Rackspace Cloud Queues Messaging APIs. Building jclouds messaging abstraction would allow developers to use those messaging services with portable code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jclouds-labs] JCLOUDS-664: Alternate Compute Service Adapter (#157)
Current mapping of Deployment to Node is the assumption that deployment always consist of single roleinststace. 1 - Introduce VirtualMachine in domain 2 - Map DeploymentToVirtualMachines where single deployment produces list of virtual machines 3 - Map VirtualMachineToNodeMetadata 4 - Change AzureComputeServiceAdapter You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/157 -- Commit Summary -- * JCLOUDS-853: Improve Create VirtualMachine Deployment * Introduce VirtualMachine * Get Cloud Service Properties Operation Support * NewComputeServiceAdapter * Added Url to Deployement * Support different names for CloudServices and Deployments -- File Changes -- M azurecompute/src/main/java/org/jclouds/azurecompute/binders/DeploymentParamsToXML.java (269) M azurecompute/src/main/java/org/jclouds/azurecompute/binders/RoleToXML.java (5) M azurecompute/src/main/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapter.java (674) M azurecompute/src/main/java/org/jclouds/azurecompute/compute/config/AzureComputeServiceContextModule.java (19) D azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/DeploymentToNodeMetadata.java (127) A azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/VirtualMachineToNodeMetadata.java (113) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/CloudServiceProperties.java (96) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDiskParam.java (161) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Deployment.java (10) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/DeploymentParams.java (175) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/LinuxConfigurationSetParams.java (141) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDiskParam.java (180) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleParam.java (199) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/VirtualMachine.java (218) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/WindowsConfigurationSetParams.java (153) M azurecompute/src/main/java/org/jclouds/azurecompute/features/CloudServiceApi.java (26) M azurecompute/src/main/java/org/jclouds/azurecompute/features/VirtualMachineApi.java (10) A azurecompute/src/main/java/org/jclouds/azurecompute/functions/DeploymentToVirtualMachine.java (69) M azurecompute/src/main/java/org/jclouds/azurecompute/options/AzureComputeTemplateOptions.java (20) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/CloudServicePropertiesHandler.java (155) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DeploymentHandler.java (10) M azurecompute/src/test/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapterLiveTest.java (28) M azurecompute/src/test/java/org/jclouds/azurecompute/compute/AzureComputeServiceContextLiveTest.java (13) M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiLiveTest.java (80) M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiMockTest.java (83) M azurecompute/src/test/java/org/jclouds/azurecompute/features/VirtualMachineApiLiveTest.java (120) A azurecompute/src/test/java/org/jclouds/azurecompute/functions/DeploymentToVirtualMachineTest.java (49) M azurecompute/src/test/java/org/jclouds/azurecompute/internal/BaseAzureComputeApiLiveTest.java (9) A azurecompute/src/test/java/org/jclouds/azurecompute/xml/CloudServicePropertiesHandlerTest.java (147) M azurecompute/src/test/java/org/jclouds/azurecompute/xml/DeploymentHandlerTest.java (1) A azurecompute/src/test/resources/cloudserviceproperties.xml (120) A azurecompute/src/test/resources/newdeploymentparams-linux.xml (1) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/157.patch https://github.com/jclouds/jclouds-labs/pull/157.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/157
[jira] [Commented] (JCLOUDS-849) Add the live test that extends the BaseComputeServiceLiveTest
[ https://issues.apache.org/jira/browse/JCLOUDS-849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377702#comment-14377702 ] Bhathiya Supun commented on JCLOUDS-849: Hi fabio, I think there won't be any conflict here as https://issues.apache.org/jira/browse/JCLOUDS-853 is on Create Operation and which involve DeploymentParams class than Deployment calss. Deployment class totally based on get deployment [https://msdn.microsoft.com/en-us/library/azure/ee460804.aspx] operation. Anyway I also think getting CloudServiceProperties information in the transformation function would be the best possible option. BTW I have added cloud service properties support here https://github.com/jclouds/jclouds-labs/pull/155 if you need. > Add the live test that extends the BaseComputeServiceLiveTest > - > > Key: JCLOUDS-849 > URL: https://issues.apache.org/jira/browse/JCLOUDS-849 > Project: jclouds > Issue Type: Sub-task > Components: jclouds-compute, jclouds-labs >Reporter: Ignasi Barrera >Assignee: fabio martelli > Labels: azure > Fix For: 2.0.0 > > > The BaseComputeServiceLiveTest provides the contract of the ComputeService > abstraction. All compute providers must have a test that extends the base one > with all live tests passing. > An example implemention can be the DigitalOcean one: > https://github.com/jclouds/jclouds-labs/blob/master/digitalocean/src/main/java/org/jclouds/digitalocean/compute/strategy/DigitalOceanComputeServiceAdapter.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JCLOUDS-839) Complete CloudService support
[
https://issues.apache.org/jira/browse/JCLOUDS-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14365476#comment-14365476
]
Bhathiya Supun commented on JCLOUDS-839:
Get Cloud Service Properties Operation
https://github.com/jclouds/jclouds-labs/pull/155
> Complete CloudService support
> -
>
> Key: JCLOUDS-839
> URL: https://issues.apache.org/jira/browse/JCLOUDS-839
> Project: jclouds
> Issue Type: Sub-task
> Components: jclouds-compute, jclouds-labs
>Reporter: Francesco Chicchiriccò
> Fix For: 2.0.0
>
>
> Complete the support provided in {{CloudServiceApi}} for all operations
> described in https://msdn.microsoft.com/en-us/library/azure/ee460812.aspx
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jclouds-labs] JCLOUDS-664: Get Cloud Service Properties Operation Support (#155)
Support Get Cloud Service Properties Operation with embeded details https://msdn.microsoft.com/en-us/library/azure/ee460806.aspx with You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/155 -- Commit Summary -- * JCLOUDS-664: Get Cloud Service Properties Operation Support -- File Changes -- A azurecompute/src/main/java/org/jclouds/azurecompute/domain/CloudServiceProperties.java (96) M azurecompute/src/main/java/org/jclouds/azurecompute/features/CloudServiceApi.java (26) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/CloudServicePropertiesHandler.java (155) M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiLiveTest.java (24) A azurecompute/src/test/java/org/jclouds/azurecompute/xml/CloudServicePropertiesHandlerTest.java (146) A azurecompute/src/test/resources/cloudserviceproperties.xml (120) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/155.patch https://github.com/jclouds/jclouds-labs/pull/155.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/155
[jira] [Commented] (JCLOUDS-853) Improve Create Virtual Machine Deployment Operation
[ https://issues.apache.org/jira/browse/JCLOUDS-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14362784#comment-14362784 ] Bhathiya Supun commented on JCLOUDS-853: https://github.com/jclouds/jclouds-labs/pull/154 > Improve Create Virtual Machine Deployment Operation > --- > > Key: JCLOUDS-853 > URL: https://issues.apache.org/jira/browse/JCLOUDS-853 > Project: jclouds > Issue Type: Sub-task > Components: jclouds-compute, jclouds-labs >Reporter: Bhathiya Supun > Fix For: 2.0.0 > > > Create Virtual Machine Deployment [1] Implementation should support > different combination that can be used to create a virtual machine > deployment. Also adding multiple roles with a single deployment should be > supported > [1] https://msdn.microsoft.com/en-us/library/azure/jj157194.aspx -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jclouds-labs] JCLOUDS-853: Improve Create VirtualMachine Deployment (#154)
Jclouds-853: Improve Create Virtual Machine Deployment [1] Create Virtual Machine Deployment [2] Implementation should support different combination that can be used to create a virtual machine deployment. [1] https://issues.apache.org/jira/browse/JCLOUDS-853 [2] https://msdn.microsoft.com/en-us/library/azure/jj157194.aspx You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/154 -- Commit Summary -- * JCLOUDS-853: Improve Create VirtualMachine Deployment -- File Changes -- M azurecompute/src/main/java/org/jclouds/azurecompute/binders/DeploymentParamsToXML.java (269) M azurecompute/src/main/java/org/jclouds/azurecompute/binders/RoleToXML.java (5) M azurecompute/src/main/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapter.java (168) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDiskParam.java (161) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/DeploymentParams.java (175) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/LinuxConfigurationSetParams.java (141) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDiskParam.java (180) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleParam.java (199) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/WindowsConfigurationSetParams.java (153) M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiLiveTest.java (56) M azurecompute/src/test/java/org/jclouds/azurecompute/features/DeploymentApiMockTest.java (83) M azurecompute/src/test/java/org/jclouds/azurecompute/features/VirtualMachineApiLiveTest.java (120) A azurecompute/src/test/resources/newdeploymentparams-linux.xml (1) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/154.patch https://github.com/jclouds/jclouds-labs/pull/154.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/154
[jira] [Created] (JCLOUDS-853) Improve Create Virtual Machine Deployment Operation
Bhathiya Supun created JCLOUDS-853: -- Summary: Improve Create Virtual Machine Deployment Operation Key: JCLOUDS-853 URL: https://issues.apache.org/jira/browse/JCLOUDS-853 Project: jclouds Issue Type: Sub-task Components: jclouds-compute, jclouds-labs Reporter: Bhathiya Supun Fix For: 2.0.0 Create Virtual Machine Deployment [1] Implementation should support different combination that can be used to create a virtual machine deployment. Also adding multiple roles with a single deployment should be supported [1] https://msdn.microsoft.com/en-us/library/azure/jj157194.aspx -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (JCLOUDS-852) VMImage Operation Support
Bhathiya Supun created JCLOUDS-852: -- Summary: VMImage Operation Support Key: JCLOUDS-852 URL: https://issues.apache.org/jira/browse/JCLOUDS-852 Project: jclouds Issue Type: Sub-task Components: jclouds-compute, jclouds-labs Reporter: Bhathiya Supun Support Virtual Machine operations in https://msdn.microsoft.com/en-us/library/azure/dn499771.aspx -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [jclouds-labs] JCLOUDS-664:VM Image Operations (#144)
@andreaturli , @nacx Can you review this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/144#issuecomment-76594900
[jclouds-labs] JCLOUDS-664:VM Image Operations (#144)
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/144 -- Commit Summary -- * JCLOUDS-664: Operatioans on VMImages -- File Changes -- M azurecompute/src/main/java/org/jclouds/azurecompute/AzureComputeApi.java (8) A azurecompute/src/main/java/org/jclouds/azurecompute/binders/CaptureVMImageParamsToXML.java (64) A azurecompute/src/main/java/org/jclouds/azurecompute/binders/VMImageParamsToXML.java (94) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/CaptureVMImageParams.java (116) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/VMImage.java (167) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/VMImageParams.java (247) A azurecompute/src/main/java/org/jclouds/azurecompute/features/VMImageApi.java (96) M azurecompute/src/main/java/org/jclouds/azurecompute/features/VirtualMachineApi.java (14) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DataVirtualHardDiskHandler.java (2) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListVMImagesHandler.java (70) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/OSConfigHandler.java (105) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/VMImageHandler.java (207) A azurecompute/src/test/java/org/jclouds/azurecompute/features/VMImageApiLiveTest.java (92) A azurecompute/src/test/java/org/jclouds/azurecompute/features/VMImageApiMockTest.java (103) M azurecompute/src/test/java/org/jclouds/azurecompute/features/VirtualMachineApiLiveTest.java (74) A azurecompute/src/test/java/org/jclouds/azurecompute/xml/ListVMImagesHandlerTest.java (106) A azurecompute/src/test/resources/vmimageparams.xml (1) A azurecompute/src/test/resources/vmimages.xml (56) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/144.patch https://github.com/jclouds/jclouds-labs/pull/144.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/144
Re: [jclouds-labs] AzureCompute: initial work to support ComputeServiceAdapter (#135)
> + @Override
> + public boolean apply(RoleInstance input) {
> + return input != null && input.instanceStatus() ==
> READY_ROLE;
> + }
> +});
> + }
> + }, 30 * 60, 1, SECONDS).apply(name)) {
> + logger.warn("Instances %s of %s has not reached the status %s
> within %sms so it will be destroyed.",
> +
> Iterables.toString(api.getDeploymentApiForService(name).get(name).roleInstanceList()),
> name,
> + READY_ROLE, Long.toString(operationTimeout));
> + api.getDeploymentApiForService(group).delete(name);
> + api.getCloudServiceApi().delete(name);
> + throw new IllegalStateException(format("Deployment %s is being
> destroyed as its instanceStatus didn't reach " +
> + "status %s after %ss. Please, try by increasing
> `jclouds.azure.operation-timeout` and " +
> + " try again", name, READY_ROLE, 30 * 60));
> + }
@andreaturli
I think this is good place to continue the discussion we had so @nacx and
Eduard can share their thoughts
As far as I understand RoleInstance represents a node in azure API. So
InstacneStatus would represent the state of VM. Deployment is more a
collections of nodes .However RoleInstance to NodeMetadata would be bit
problematic as Azure RoleInstance represenation not consist of some important
data
My suggestion is to
1 - Introduce VirtualMachine in domain
2 - Map DeploymentToVirtualMachines where single deployment produces list of
virtual machines
3 - Map VirtualMachineToNodeMetadata
4 - implement ComputeServiceAdapter
Proposed changes are partly implemented here
https://github.com/hsbhathiya/jclouds-labs/blob/MyServiceAdapter/azurecompute/src/main/java/org/jclouds/azurecompute/compute/AzureComputeServiceAdapter2.java
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/135/files#r25013853
Re: [jclouds-labs] Azure support work In progress (Not To Merge) (#133)
Closed #133. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/133#event-238576484
Re: [jclouds-labs] Azure support work In progress (Not To Merge) (#133)
@andreaturli Yeah. We can merge these chages after https://github.com/jclouds/jclouds-labs/pull/135/ --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/133#issuecomment-75105306
[jira] [Commented] (JCLOUDS-805) Google Cloud Storage integration test failures
[
https://issues.apache.org/jira/browse/JCLOUDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317540#comment-14317540
]
Bhathiya Supun commented on JCLOUDS-805:
I couldn't reproduce this. I'm gettung
Failed tests:
GoogleCloudStorageBlobLiveTest.testCopyUrl:63 â•— NullPointer httpStreamUrl
GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutMulti
partByteSource:547->BaseBlobIntegrationTest.testPut:575 â•— HttpResponse
GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutMulti
partInputStream:555->BaseBlobIntegrationTest.testPut:575 â•— HttpResponse
Tests run: 91, Failures: 3, Errors: 0, Skipped: 5
For my case problem is with payload content length it seems. Similar to
http://stackoverflow.com/questions/24525298/unable-to-get-resolve-incomplete-output-stream-error-jclouds
> Google Cloud Storage integration test failures
> --
>
> Key: JCLOUDS-805
> URL: https://issues.apache.org/jira/browse/JCLOUDS-805
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-blobstore, jclouds-labs-google
>Affects Versions: 1.9.0
> Reporter: Andrew Gaul
>Assignee: Bhathiya Supun
> Labels: google-cloud-storage
> Fix For: 1.9.0
>
> Attachments: testresults.txt
>
>
> {noformat}
> Failed tests:
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutByteSource:531->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutIncorrectContentMD5:277
> null
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutInputStream:539->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:372
> » ResourceNotFound
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListContainerGetBlobSize:409
> expected [42] but found [null]
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListMarkerAfterLastKey:88
> » HttpResponse
> ResumableUploadApiLiveTest.testResumableChunkedUpload:120 expected object
> to not be null
> ResumableUploadApiLiveTest.testResumableJpegUpload:83 expected object to
> not be null
> BucketApiLiveTest.testPatchBucket:192 » Authorization {
> "error": {
> "errors"...
> BucketApiLiveTest.testUpdateBucket:133 » Authorization {
> "error": {
> "errors...
> BucketApiLiveTest.testUpdateBucketWithOptions:146 » Authorization {
> "error": ...
> ObjectApiLiveTest.testSimpleJpegUpload:157->checkHashCodes:399 expected
> [8FdApr35Ql5P3B1cOAavYg==] but found [f05740a6bdf9425e4fdc1d5c3806af62]
> ObjectApiLiveTest.testUpdateObject:293 » Authorization {
> "error": {
> "errors...
> ObjectApiLiveTest.deleteBucket:425 » IllegalState {
> "error": {
> "errors": [
> ...
> Tests run: 100, Failures: 14, Errors: 0, Skipped: 17
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (JCLOUDS-805) Google Cloud Storage integration test failures
[
https://issues.apache.org/jira/browse/JCLOUDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317366#comment-14317366
]
Bhathiya Supun edited comment on JCLOUDS-805 at 2/12/15 1:42 AM:
-
[~broudy] Sorry for not finishing this off. I have partly addressed this issue
here
https://github.com/hsbhathiya/jclouds-labs-google/commit/5785612cbbe27fe91f04363bd15f1bd5dbff4ac8
Yes problem is with Update and Patch requests where fullcontrol is needed
https://github.com/hsbhathiya/jclouds-labs-google/blob/5785612cbbe27fe91f04363bd15f1bd5dbff4ac8/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/GoogleCloudStorageOAuthScopes.java#L52-L53
Bucket test failiures were resolved after this change.
was (Author: bhathiya90):
[~broudy] Sorry for not finishing this off. I have partly addressed this issue
here
https://github.com/hsbhathiya/jclouds-labs-google/commit/5785612cbbe27fe91f04363bd15f1bd5dbff4ac8
Yes problem is with Update and atch requests where fullcontrol is needed
https://github.com/hsbhathiya/jclouds-labs-google/blob/5785612cbbe27fe91f04363bd15f1bd5dbff4ac8/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/GoogleCloudStorageOAuthScopes.java#L52-L53
Bucket test failiures were resolved after this change.
> Google Cloud Storage integration test failures
> --
>
> Key: JCLOUDS-805
> URL: https://issues.apache.org/jira/browse/JCLOUDS-805
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-blobstore
>Affects Versions: 1.9.0
>Reporter: Andrew Gaul
>Assignee: Bhathiya Supun
> Labels: google-cloud-storage
> Fix For: 1.9.0
>
> Attachments: testresults.txt
>
>
> {noformat}
> Failed tests:
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutByteSource:531->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutIncorrectContentMD5:277
> null
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutInputStream:539->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:372
> » ResourceNotFound
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListContainerGetBlobSize:409
> expected [42] but found [null]
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListMarkerAfterLastKey:88
> » HttpResponse
> ResumableUploadApiLiveTest.testResumableChunkedUpload:120 expected object
> to not be null
> ResumableUploadApiLiveTest.testResumableJpegUpload:83 expected object to
> not be null
> BucketApiLiveTest.testPatchBucket:192 » Authorization {
> "error": {
> "errors"...
> BucketApiLiveTest.testUpdateBucket:133 » Authorization {
> "error": {
> "errors...
> BucketApiLiveTest.testUpdateBucketWithOptions:146 » Authorization {
> "error": ...
> ObjectApiLiveTest.testSimpleJpegUpload:157->checkHashCodes:399 expected
> [8FdApr35Ql5P3B1cOAavYg==] but found [f05740a6bdf9425e4fdc1d5c3806af62]
> ObjectApiLiveTest.testUpdateObject:293 » Authorization {
> "error": {
> "errors...
> ObjectApiLiveTest.deleteBucket:425 » IllegalState {
> "error": {
> "errors": [
> ...
> Tests run: 100, Failures: 14, Errors: 0, Skipped: 17
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (JCLOUDS-805) Google Cloud Storage integration test failures
[
https://issues.apache.org/jira/browse/JCLOUDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317366#comment-14317366
]
Bhathiya Supun commented on JCLOUDS-805:
[~broudy] Sorry for not finishing this off. I have partly addressed this issue
here
https://github.com/hsbhathiya/jclouds-labs-google/commit/5785612cbbe27fe91f04363bd15f1bd5dbff4ac8
Yes problem is with Update and atch requests where fullcontrol is needed
https://github.com/hsbhathiya/jclouds-labs-google/blob/5785612cbbe27fe91f04363bd15f1bd5dbff4ac8/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/config/GoogleCloudStorageOAuthScopes.java#L52-L53
Bucket test failiures were resolved after this change.
> Google Cloud Storage integration test failures
> --
>
> Key: JCLOUDS-805
> URL: https://issues.apache.org/jira/browse/JCLOUDS-805
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-blobstore
>Affects Versions: 1.9.0
>Reporter: Andrew Gaul
>Assignee: Bhathiya Supun
> Labels: google-cloud-storage
> Fix For: 1.9.0
>
> Attachments: testresults.txt
>
>
> {noformat}
> Failed tests:
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutByteSource:531->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutIncorrectContentMD5:277
> null
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutInputStream:539->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:372
> » ResourceNotFound
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListContainerGetBlobSize:409
> expected [42] but found [null]
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListMarkerAfterLastKey:88
> » HttpResponse
> ResumableUploadApiLiveTest.testResumableChunkedUpload:120 expected object
> to not be null
> ResumableUploadApiLiveTest.testResumableJpegUpload:83 expected object to
> not be null
> BucketApiLiveTest.testPatchBucket:192 » Authorization {
> "error": {
> "errors"...
> BucketApiLiveTest.testUpdateBucket:133 » Authorization {
> "error": {
> "errors...
> BucketApiLiveTest.testUpdateBucketWithOptions:146 » Authorization {
> "error": ...
> ObjectApiLiveTest.testSimpleJpegUpload:157->checkHashCodes:399 expected
> [8FdApr35Ql5P3B1cOAavYg==] but found [f05740a6bdf9425e4fdc1d5c3806af62]
> ObjectApiLiveTest.testUpdateObject:293 » Authorization {
> "error": {
> "errors...
> ObjectApiLiveTest.deleteBucket:425 » IllegalState {
> "error": {
> "errors": [
> ...
> Tests run: 100, Failures: 14, Errors: 0, Skipped: 17
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jclouds-labs] Azure support work In progress (Not To Merge) (#133)
This is just to track the current work in progress and avoid duplication of effort.I will open a new PR with these changes when https://github.com/jclouds/jclouds-labs/pull/131 is merged You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/133 -- Commit Summary -- * Jclouds-664: VMImage Domain Representation * azurecompute: improvements to the domain objects * Addressing Merge conflicts * Added DeploymentAPI initial Commit * Added NewDeploymentParams * List RolSiez Operation with Tests -- File Changes -- M azurecompute/src/main/java/org/jclouds/azurecompute/AzureComputeApi.java (40) A azurecompute/src/main/java/org/jclouds/azurecompute/binders/NewDeploymentParamsToXML.java (145) A azurecompute/src/main/java/org/jclouds/azurecompute/binders/VMimageParamsToXML.java (66) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/Availability.java (36) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/CloudService.java (3) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDiskParam.java (161) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Deployment.java (101) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/DeploymentParams.java (51) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Disk.java (6) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Error.java (3) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/LinuxConfigurationSetParams.java (141) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Location.java (2) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/NetworkConfiguration.java (84) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/NetworkSecurityGroup.java (42) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/NewDeploymentParams.java (144) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSImage.java (3) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSImageParams.java (2) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDiskParam.java (180) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Operation.java (3) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/Role.java (245) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleParam.java (199) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleSize.java (107) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/Rule.java (57) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/StorageService.java (57) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/StorageServiceParams.java (89) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/VMImage.java (167) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/VMImageParams.java (247) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/WindowsConfigurationSetParams.java (153) A azurecompute/src/main/java/org/jclouds/azurecompute/features/RoleSizesApi.java (50) A azurecompute/src/main/java/org/jclouds/azurecompute/features/VMImageApi.java (95) A azurecompute/src/main/java/org/jclouds/azurecompute/handlers/AzureComputeErrorHandler.java (83) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/AddressSpaceHandler.java (54) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/AvailabilityHandler.java (49) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ConfigurationSetHandler.java (104) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DataVirtualHardDiskHandler.java (7) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DeploymentHandler.java (97) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/InputEndpointHandler.java (87) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/InstanceEndpointHandler.java (72) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListNetworkSecurityGroupsHandler.java (59) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListRoleSizesHandler.java (60) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListStorageServicesHandler.java (64) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListVMImagesHandler.java (65) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListVirtualNetworkSitesHandler.java (61) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/NetworkConfigurationHandler.java (70) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/NetworkSecurityGroupHandler.java (78) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/OSConfigHandler.java (105) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/OSImageHandler.java (57) A
Re: [jclouds-labs] JCLOUDS-664: Added DataVirtualHardDisk Representation With Tests (#126)
@nacx I made that change --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/126#issuecomment-72278436
Re: [jclouds-labs] JCLOUDS-664: Added DataVirtualHardDisk Representation With Tests (#126)
@nacx I addressed those issues you mentioned. can we merge this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/126#issuecomment-72078688
Re: [jclouds-labs] JCLOUDS-664: Added DataVirtualHardDisk Representation With Tests (#126)
@andreaturli I have corected the pointed out mistakes. Shall we merge this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/126#issuecomment-71612637
[jira] [Commented] (JCLOUDS-805) Google Cloud Storage integration test failures
[
https://issues.apache.org/jira/browse/JCLOUDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290990#comment-14290990
]
Bhathiya Supun commented on JCLOUDS-805:
[~gaul] I changed ~/.m2/settings.xml to add
YOUR-PROJECT-NUMBER
My setting.xml is ass follows
1234567891234-abcede567...@developer.gserviceaccount.com
-BEGIN RSA PRIVATE KEY-
IMP+fAo74Yfr1LgIdb5eRJzjO816nYxP6x/sEP3UQAB6S2GEa94JOqjZvAxPfAEMaaNv126AFIk/9wSOYHW
fXsMYjfcLxKUCT62t8sCQQCo+sL5+V6BV0LWJCv7onGwUlnxXdbkXBHDOHo8/rbr
BgW/bJbMLidIwtGQ27duziVbtoMHpvfaAlWAjOF4Irt/
-END RSA PRIVATE KEY-
12345678
I'd edit the GCS README file
> Google Cloud Storage integration test failures
> --
>
> Key: JCLOUDS-805
> URL: https://issues.apache.org/jira/browse/JCLOUDS-805
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-blobstore
>Affects Versions: 1.9.0
>Reporter: Andrew Gaul
>Assignee: Bhathiya Supun
> Labels: google-cloud-storage
> Fix For: 1.9.0
>
> Attachments: testresults.txt
>
>
> {noformat}
> Failed tests:
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutByteSource:531->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutIncorrectContentMD5:277
> null
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutInputStream:539->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:372
> » ResourceNotFound
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListContainerGetBlobSize:409
> expected [42] but found [null]
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListMarkerAfterLastKey:88
> » HttpResponse
> ResumableUploadApiLiveTest.testResumableChunkedUpload:120 expected object
> to not be null
> ResumableUploadApiLiveTest.testResumableJpegUpload:83 expected object to
> not be null
> BucketApiLiveTest.testPatchBucket:192 » Authorization {
> "error": {
> "errors"...
> BucketApiLiveTest.testUpdateBucket:133 » Authorization {
> "error": {
> "errors...
> BucketApiLiveTest.testUpdateBucketWithOptions:146 » Authorization {
> "error": ...
> ObjectApiLiveTest.testSimpleJpegUpload:157->checkHashCodes:399 expected
> [8FdApr35Ql5P3B1cOAavYg==] but found [f05740a6bdf9425e4fdc1d5c3806af62]
> ObjectApiLiveTest.testUpdateObject:293 » Authorization {
> "error": {
> "errors...
> ObjectApiLiveTest.deleteBucket:425 » IllegalState {
> "error": {
> "errors": [
> ...
> Tests run: 100, Failures: 14, Errors: 0, Skipped: 17
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (JCLOUDS-805) Google Cloud Storage integration test failures
[
https://issues.apache.org/jira/browse/JCLOUDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290144#comment-14290144
]
Bhathiya Supun commented on JCLOUDS-805:
[~gaul ] I could fix BucketApiLiveTests failiures here
https://github.com/hsbhathiya/jclouds-labs-google/commit/5785612cbbe27fe91f04363bd15f1bd5dbff4ac8
But there are few(4) other test failiures
> Google Cloud Storage integration test failures
> --
>
> Key: JCLOUDS-805
> URL: https://issues.apache.org/jira/browse/JCLOUDS-805
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-blobstore
>Affects Versions: 1.9.0
>Reporter: Andrew Gaul
>Assignee: Bhathiya Supun
> Labels: google-cloud-storage
> Fix For: 1.9.0
>
> Attachments: testresults.txt
>
>
> {noformat}
> Failed tests:
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutByteSource:531->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutIncorrectContentMD5:277
> null
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutInputStream:539->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:372
> » ResourceNotFound
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListContainerGetBlobSize:409
> expected [42] but found [null]
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListMarkerAfterLastKey:88
> » HttpResponse
> ResumableUploadApiLiveTest.testResumableChunkedUpload:120 expected object
> to not be null
> ResumableUploadApiLiveTest.testResumableJpegUpload:83 expected object to
> not be null
> BucketApiLiveTest.testPatchBucket:192 » Authorization {
> "error": {
> "errors"...
> BucketApiLiveTest.testUpdateBucket:133 » Authorization {
> "error": {
> "errors...
> BucketApiLiveTest.testUpdateBucketWithOptions:146 » Authorization {
> "error": ...
> ObjectApiLiveTest.testSimpleJpegUpload:157->checkHashCodes:399 expected
> [8FdApr35Ql5P3B1cOAavYg==] but found [f05740a6bdf9425e4fdc1d5c3806af62]
> ObjectApiLiveTest.testUpdateObject:293 » Authorization {
> "error": {
> "errors...
> ObjectApiLiveTest.deleteBucket:425 » IllegalState {
> "error": {
> "errors": [
> ...
> Tests run: 100, Failures: 14, Errors: 0, Skipped: 17
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jclouds-labs] JCLOUDS-664: Added DataVirtualHardDisk Representation With Tests (#126)
@andreaturli I corrected those mistakes --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/126#issuecomment-71242283
Re: [jclouds-labs] JCLOUDS-664: Added DataVirtualHardDisk Representation With Tests (#126)
@andreaturli Can you review this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/126#issuecomment-71131095
Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)
@andreaturli Thanks.I added https://github.com/jclouds/jclouds-labs/pull/126 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/125#issuecomment-71021138
[jclouds-labs] JCLOUDS-664: Added DataVirtualHardDisk Representation With Tests (#126)
You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/126 -- Commit Summary -- * JCLOUDS-664: Added DataVirtualHardDisk Representation With Tests -- File Changes -- A azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDisk.java (97) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/DataVirtualHardDiskHandler.java (91) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListDataVirtualHardDisksHandler.java (61) A azurecompute/src/test/java/org/jclouds/azurecompute/xml/ListDataVirtualHardDisksHandlerTest.java (59) A azurecompute/src/test/resources/datavirtualharddisk.xml (18) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/126.patch https://github.com/jclouds/jclouds-labs/pull/126.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/126
[jira] [Commented] (JCLOUDS-805) Google Cloud Storage integration test failures
[
https://issues.apache.org/jira/browse/JCLOUDS-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286595#comment-14286595
]
Bhathiya Supun commented on JCLOUDS-805:
[~gaul] I got similar(not same) failiures. Looks like problem is in Acls. I
would work on this issue.
> Google Cloud Storage integration test failures
> --
>
> Key: JCLOUDS-805
> URL: https://issues.apache.org/jira/browse/JCLOUDS-805
> Project: jclouds
> Issue Type: Bug
> Components: jclouds-blobstore
>Affects Versions: 2.0.0
>Reporter: Andrew Gaul
> Labels: google-cloud-storage
> Attachments: testresults.txt
>
>
> {noformat}
> Failed tests:
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutByteSource:531->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutIncorrectContentMD5:277
> null
>
> GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutInputStream:539->BaseBlobIntegrationTest.testPut:574
> » HttpResponse
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.deleteContainerIfEmptyWithoutContents:372
> » ResourceNotFound
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListContainerGetBlobSize:409
> expected [42] but found [null]
>
> GoogleCloudStorageContainerIntegrationLiveTest>BaseContainerIntegrationTest.testListMarkerAfterLastKey:88
> » HttpResponse
> ResumableUploadApiLiveTest.testResumableChunkedUpload:120 expected object
> to not be null
> ResumableUploadApiLiveTest.testResumableJpegUpload:83 expected object to
> not be null
> BucketApiLiveTest.testPatchBucket:192 » Authorization {
> "error": {
> "errors"...
> BucketApiLiveTest.testUpdateBucket:133 » Authorization {
> "error": {
> "errors...
> BucketApiLiveTest.testUpdateBucketWithOptions:146 » Authorization {
> "error": ...
> ObjectApiLiveTest.testSimpleJpegUpload:157->checkHashCodes:399 expected
> [8FdApr35Ql5P3B1cOAavYg==] but found [f05740a6bdf9425e4fdc1d5c3806af62]
> ObjectApiLiveTest.testUpdateObject:293 » Authorization {
> "error": {
> "errors...
> ObjectApiLiveTest.deleteBucket:425 » IllegalState {
> "error": {
> "errors": [
> ...
> Tests run: 100, Failures: 14, Errors: 0, Skipped: 17
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)
> +
> +/**
> + * @see href="http://msdn.microsoft.com/en-us/library/azure/jj157186.aspx#OSVirtualHardDisk";
> >api
> + */
> +@AutoValue
> +public abstract class OSVirtualHardDisk {
> +
> + /**
> +* Specifies the caching mode of the operating system disk.
> +* This setting impacts the consistency and performance of the disk.
> +* Possible values are:
> +* ReadOnly
> +* ReadWrite
> +* The default value is ReadWrite
> +*/
> + @Nullable public abstract String hostCaching();
@andreaturli I addressed this now.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/125/files#r23327681
Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)
@andreaturli can we merge this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/125#issuecomment-70852529
Re: [jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)
@andreaturli Sorry, there is a mistake in the refference link. It Should be http://msdn.microsoft.com/en-us/library/azure/ee460804.aspx#OSVirtualHardDisk I'll correct it. I mapped http://msdn.microsoft.com/en-us/library/azure/jj157186.aspx#OSVirtualHardDisk to OSVirtualHardDiskParam (not in this PR) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/125#issuecomment-70680905
Re: [jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)
This PR wil be splited into few smaller PRs --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/124#issuecomment-70675770
Re: [jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)
Closed #124. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/124#event-221678548
Re: [jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)
@andreaturli Thanks for quick response. I made https://github.com/jclouds/jclouds-labs/pull/125 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/124#issuecomment-70675258
[jclouds-labs] JCLOUDS-664: OSVirtualHardDisk Support With Tests (#125)
Changes in Deployment Representation - Part 1 You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/125 -- Commit Summary -- * JCLOUDS-664: OSVirtualHardDisk Support With Tests -- File Changes -- A azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDisk.java (98) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/OSVirtualHardDiskHandler.java (81) A azurecompute/src/test/java/org/jclouds/azurecompute/xml/OSVirtualHardDisksHandlerTest.java (49) A azurecompute/src/test/resources/osvirtualharddisk.xml (11) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/125.patch https://github.com/jclouds/jclouds-labs/pull/125.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/125
Re: [jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)
@andreaturli I made chnges to the azure deploy. can you review this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/124#issuecomment-70632714
[jclouds-labs] JCLOUDS-664: Change Azure Deploy representation (#124)
Added OSVHD and DataVHD Changes in Role Added IOTypes JCLOUDS-664:Azure Role representation Role Instance handler with tests JCLOUDS-664: Implemented Azure Role represenstaion Added OSVHD and DataVHD Changes in Role Added IOTypes JCLOUDS-664:Azure Role representation Added VHD Handlers Completed RoleHandler JCLOUDS-664: Changes in Deployment implementation with test Minor changes You can view, comment on, or merge this pull request online at: https://github.com/jclouds/jclouds-labs/pull/124 -- Commit Summary -- * JCLOUDS-664: Implemented Azure Role represenstaion -- File Changes -- M azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/RoleSizeToHardware.java (8) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDisk.java (103) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDiskParam.java (161) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Deployment.java (78) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDisk.java (110) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDiskParam.java (173) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/Role.java (90) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleInstance.java (203) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleParam.java (174) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/DataVirtualHardDiskHandler.java (97) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DeploymentHandler.java (98) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DiskHandler.java (6) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/InstanceEndpointHandler.java (61) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListDataVirtualHardDisksHandler.java (61) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/ListRoleInstancesHandler.java (60) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/OSVirtualHardDiskHandler.java (103) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/PublicIPHandler.java (53) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/RoleHandler.java (146) A azurecompute/src/main/java/org/jclouds/azurecompute/xml/RoleInstanceHandler.java (151) M azurecompute/src/test/java/org/jclouds/azurecompute/features/OSImageApiLiveTest.java (14) M azurecompute/src/test/java/org/jclouds/azurecompute/xml/DeploymentHandlerTest.java (111) A azurecompute/src/test/java/org/jclouds/azurecompute/xml/ListDataVirtualHardDisksHandlerTest.java (63) A azurecompute/src/test/java/org/jclouds/azurecompute/xml/OSVirtualHardDisksHandlerTest.java (51) A azurecompute/src/test/java/org/jclouds/azurecompute/xml/RoleHandlerTest.java (97) A azurecompute/src/test/java/org/jclouds/azurecompute/xml/RoleInstanceHandlerTest.java (70) A azurecompute/src/test/resources/datavirtualharddisk.xml (23) M azurecompute/src/test/resources/deployment.xml (170) A azurecompute/src/test/resources/osvirtualharddisk.xml (11) A azurecompute/src/test/resources/role.xml (43) A azurecompute/src/test/resources/roleinstance.xml (36) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/124.patch https://github.com/jclouds/jclouds-labs/pull/124.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/124
Re: [jclouds-labs] JCLOUDS-664:Implement OSImageToImage Function (#117)
@andreaturli , @nacx Shall we get this merged? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/117#issuecomment-69695591
Re: [jclouds-labs] JCLOUDS-664:Implement OSImageToImage Function (#117)
@andreaturli , @nacx I've addressed most of the review suggestions. @nacx Not clear about how Image.Status is used --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/117#issuecomment-68826892
Re: [jclouds-labs] JCLOUDS-664: Implemented Role represenstaion in API (#118)
@andreaturli I'll be working on review suggeations in previous PR (https://github.com/jclouds/jclouds-labs/pull/118). As I undertand "RoleSizeToHarware" in current implementation should be chanegd to "RoleToHardware". P.S.:Tried to contact you over irc. But got some issues with my internet connection. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/118#issuecomment-67856602
[jclouds-labs] JCLOUDS-664: Implemented Role represenstaion in API (#118)
Added OSVHD and DataVHD Changes in Role Added IOTypes JCLOUDS-664:Azure Role representation You can merge this Pull Request by running: git pull https://github.com/hsbhathiya/jclouds-labs azure_m1_v2 Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pull/118 -- Commit Summary -- * JCLOUDS-664: Implemented Azure Role represenstaion -- File Changes -- M azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/RoleSizeToHardware.java (12) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDisk.java (103) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/DataVirtualHardDiskParam.java (161) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDisk.java (110) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSVirtualHardDiskParam.java (173) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/Role.java (90) A azurecompute/src/main/java/org/jclouds/azurecompute/domain/RoleParam.java (174) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/118.patch https://github.com/jclouds/jclouds-labs/pull/118.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/118
Re: [jclouds-labs] JCLOUDS-664:Implement OSImageToImage Function (#117)
@andreaturli @andreaturli Can you review this? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/117#issuecomment-67607141
[jclouds-labs] JCLOUDS-664:Implement OSImageToImage Function (#117)
implement OSImageToImage Function chahnge locations list to location Address test failiures You can merge this Pull Request by running: git pull https://github.com/hsbhathiya/jclouds-labs azure_m1_OSImageStream Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pull/117 -- Commit Summary -- * implement OSImageToImage Function -- File Changes -- M azurecompute/src/main/java/org/jclouds/azurecompute/compute/functions/OSImageToImage.java (45) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/Disk.java (6) M azurecompute/src/main/java/org/jclouds/azurecompute/domain/OSImage.java (12) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/DiskHandler.java (2) M azurecompute/src/main/java/org/jclouds/azurecompute/xml/OSImageHandler.java (18) A azurecompute/src/test/java/org/jclouds/azurecompute/compute/functions/OSImageToImageTest.java (49) M azurecompute/src/test/java/org/jclouds/azurecompute/features/DiskApiLiveTest.java (6) M azurecompute/src/test/java/org/jclouds/azurecompute/features/OSImageApiLiveTest.java (2) M azurecompute/src/test/java/org/jclouds/azurecompute/xml/ListOSImagesHandlerTest.java (31) M azurecompute/src/test/resources/images.xml (11) -- Patch Links -- https://github.com/jclouds/jclouds-labs/pull/117.patch https://github.com/jclouds/jclouds-labs/pull/117.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/117
[jira] [Commented] (JCLOUDS-664) Azure compute support
[ https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248799#comment-14248799 ] Bhathiya Supun commented on JCLOUDS-664: Hi Turil I'm working on this. To start with I worked on OSImageToImage mapping. https://github.com/hsbhathiya/jclouds-labs/commit/439b2f2559f79bc80b13035d14b422421cd01d75 Now having some hard time with RoleSizeToHardware mapping . > Azure compute support > - > > Key: JCLOUDS-664 > URL: https://issues.apache.org/jira/browse/JCLOUDS-664 > Project: jclouds > Issue Type: New Feature > Components: jclouds-compute, jclouds-labs >Affects Versions: 2.0.0 >Reporter: Andrew Bayer > Fix For: 2.0.0 > > Attachments: JCLOUDS-664.patch > > > So we've got a very old, very stale, very incomplete azure-management (a.k.a. > compute) implementation in labs. Let's actually modernize and finish that > thing. Azure is unquestionably the biggest cloud out there that we don't have > viable support for, so it's a really useful target. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (JCLOUDS-664) Azure compute support
[ https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244606#comment-14244606 ] Bhathiya Supun edited comment on JCLOUDS-664 at 12/12/14 6:52 PM: -- Hi [~nacx] Preparing this plan, I reffered Google Compute Engine implmentation and was thinking of a similar approach.ATM I don't have a clear idea about network functionality. We can decide on this as the work progress. was (Author: bhathiya90): Hi [~nacx] Preparing this plan, I reffered Google Compute Engine implmentation and was thinking of a similar approach.ATM I don't have a clear idea on this. We can decide on this as the work progress. > Azure compute support > - > > Key: JCLOUDS-664 > URL: https://issues.apache.org/jira/browse/JCLOUDS-664 > Project: jclouds > Issue Type: New Feature > Components: jclouds-compute, jclouds-labs >Affects Versions: 2.0.0 >Reporter: Andrew Bayer > Fix For: 2.0.0 > > Attachments: JCLOUDS-664.patch > > > So we've got a very old, very stale, very incomplete azure-management (a.k.a. > compute) implementation in labs. Let's actually modernize and finish that > thing. Azure is unquestionably the biggest cloud out there that we don't have > viable support for, so it's a really useful target. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JCLOUDS-664) Azure compute support
[ https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244606#comment-14244606 ] Bhathiya Supun commented on JCLOUDS-664: Hi [~nacx] Preparing this plan, I reffered Google Compute Engine implmentation and was thinking of a similar approach.ATM I don't have a clear idea on this. We can decide on this as the work progress. > Azure compute support > - > > Key: JCLOUDS-664 > URL: https://issues.apache.org/jira/browse/JCLOUDS-664 > Project: jclouds > Issue Type: New Feature > Components: jclouds-compute, jclouds-labs >Affects Versions: 2.0.0 >Reporter: Andrew Bayer > Fix For: 2.0.0 > > Attachments: JCLOUDS-664.patch > > > So we've got a very old, very stale, very incomplete azure-management (a.k.a. > compute) implementation in labs. Let's actually modernize and finish that > thing. Azure is unquestionably the biggest cloud out there that we don't have > viable support for, so it's a really useful target. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JCLOUDS-664) Azure compute support
[ https://issues.apache.org/jira/browse/JCLOUDS-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243705#comment-14243705 ] Bhathiya Supun commented on JCLOUDS-664: [~adriancole],[~abayer] I will be working on remaining part of this issue (as an internship project). As far as I understand we need 1 -Implement compute abstraction 2- Both API and compute support for Virtual Networks (http://msdn.microsoft.com/en-us/library/azure/jj157182.aspx) Correct me if I am missing anything. Further It would be great if you can have a look at my Milestone Plan [1] [1]- https://docs.google.com/spreadsheets/d/17trQZ18l7HMpFHgEGPkfrRP_H_rq5XQU2Ywj9eag7to/edit#gid=187742372 > Azure compute support > - > > Key: JCLOUDS-664 > URL: https://issues.apache.org/jira/browse/JCLOUDS-664 > Project: jclouds > Issue Type: New Feature > Components: jclouds-compute, jclouds-labs >Affects Versions: 2.0.0 >Reporter: Andrew Bayer > Fix For: 2.0.0 > > Attachments: JCLOUDS-664.patch > > > So we've got a very old, very stale, very incomplete azure-management (a.k.a. > compute) implementation in labs. Let's actually modernize and finish that > thing. Azure is unquestionably the biggest cloud out there that we don't have > viable support for, so it's a really useful target. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jclouds-labs-google] Addressing review suggestions in PR 48 (#61)
I have adressed some of the suggestions from https://github.com/jclouds/jclouds-labs-google/pull/48. There are few more suggestions that need bit more work. You can merge this Pull Request by running: git pull https://github.com/hsbhathiya/jclouds-labs-google GCSExamples Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pull/61 -- Commit Summary -- * Addressing review suggestions in PR 48 -- File Changes -- M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GCSBlobStore.java (57) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/BlobMetadataToObjectTemplate.java (3) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/BlobStoreListContainerOptionsToListObjectOptions.java (3) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/ObjectToBlobMetadata.java (3) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/strategy/internal/SequentialMultipartUploadStrategy.java (2) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/GCSObject.java (17) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/ObjectTemplate.java (18) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/fallback/GCSFallbacks.java (3) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/BucketApi.java (2) -- Patch Links -- https://github.com/jclouds/jclouds-labs-google/pull/61.patch https://github.com/jclouds/jclouds-labs-google/pull/61.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/61
[jclouds-examples] GCS-Example initial commit (#66)
Create Container, PutBlob and Multipart Upload wtih Google Cloud Storage You can merge this Pull Request by running: git pull https://github.com/hsbhathiya/jclouds-examples gcs-init-example Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-examples/pull/66 -- Commit Summary -- * GCS-Example initial commit -- File Changes -- M google/pom.xml (10) A google/src/main/java/org/jclouds/examples/google/cloudstorage/GCSExample.java (189) -- Patch Links -- https://github.com/jclouds/jclouds-examples/pull/66.patch https://github.com/jclouds/jclouds-examples/pull/66.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-examples/pull/66
Re: [jclouds-labs-google] Introduce BucketAccessControlTemplate (#54)
@adriancole @andrewgaul Thanks for reviewing and merging. Sure. I will address those issues in seperate PR with suggestions from @demobox in https://github.com/jclouds/jclouds-labs-google/pull/48 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/54#issuecomment-58122482
[jclouds-labs-google] Introduce BucketAccessControlTemplate (#54)
This would make the Bucket Acceess Control API constistent with other GCS access controls. You can merge this Pull Request by running: git pull https://github.com/hsbhathiya/jclouds-labs-google TemplateGCS Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pull/54 -- Commit Summary -- * Introduce BucketAccessControlTemplate -- File Changes -- M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/binders/BucketAccessControlsBinder.java (5) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/BucketAccessControlsTemplate.java (65) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApi.java (19) M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApiExpectTest.java (38) M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketAccessControlsApiLiveTest.java (14) A google-cloud-storage/src/test/resources/bucket_acl_insert_initial.json (4) M google-cloud-storage/src/test/resources/bucket_acl_update_initial.json (9) M google-cloud-storage/src/test/resources/bucket_insert_request_payload.json (2) -- Patch Links -- https://github.com/jclouds/jclouds-labs-google/pull/54.patch https://github.com/jclouds/jclouds-labs-google/pull/54.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/54
Re: [jclouds-site] Announce Google Summer of Code 2014 results (#125)
+1 @rcoedo interesting.. I like that idea :) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-site/pull/125#issuecomment-56710983
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
@demobox Thanks for reviewing. I would address the suggestions (with some other issues I found) as soon as I find some time. Bit busy with uni exams these days. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/48#issuecomment-56260373
Re: [jclouds-labs-google] JCLOUDS-703 missing imageSpaceGb from machineType (#49)
This is the response I got Using API explorer machineTypes/get operations. with
a new instance.
200 OK
{
"kind": "compute#machineType",
"id": "4618642685664990776",
"creationTimestamp": "2013-04-25T13:32:49.088-07:00",
"name": "f1-micro",
"description": "1 vCPU (shared physical core) and 0.6 GB RAM",
"guestCpus": 1,
"memoryMb": 614,
"maximumPersistentDisks": 4,
"maximumPersistentDisksSizeGb": "3072",
"zone": "us-central1-a",
"selfLink":
"https://www.googleapis.com/compute/v1/projects/local-turbine-511/zones/us-central1-a/machineTypes/f1-micro";
}
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/49#issuecomment-55416089
Re: [jclouds] Add copyBlob to portable abstraction and add S3-optimized variant (#511)
This operation is supported in native GCS API and should be easy to implenment . https://developers.google.com/storage/docs/json_api/v1/objects/copy I think overiding metadata options would be useful and with option method can be used for it (if other providers support similar approach)? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/511#issuecomment-55057830
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
Issues remaining 1 - 503 error issue 2- Change DefaultPartSize to 2Mb in LiveTests (It is 32Mb now) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/48#issuecomment-54810483
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
> +import com.google.inject.Inject;
> +import org.jclouds.blobstore.reference.BlobStoreConstants;
> +import org.jclouds.logging.Logger;
> +
> +import javax.annotation.Resource;
> +import javax.inject.Named;
> +
> +public class MultipartUploadSlicingAlgorithm {
> +
> + @Resource
> + @Named(BlobStoreConstants.BLOBSTORE_LOGGER)
> + protected Logger logger = Logger.NULL;
> +
> + @VisibleForTesting
> + // 2MB for testing purposes. Change to a reasonable value
> + static final long DEFAULT_PART_SIZE = 2 * 1024 * 1024; // 2MB //33554432;
> // 32MB
Not sure what could be a resonable value. Swift uses 32MB. Shall I go with
with the same?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17225531
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
> + * (the "License"); you may not use this file except in compliance with
> + * the License. You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.jclouds.googlecloudstorage.blobstore.strategy.internal;
> +
> +public class MultipartUpload {
> +
> + protected MultipartUpload() {
Extended in MultipartUploadStrategy.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17225174
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/org.apache.jclouds.labs$google-cloud-storage/1338/testReport/junit/ Anything wrong with mvn settings? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/48#issuecomment-54756922
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
@andrewgaul I got few issues 1 - I think GCS Locations should be supported from the first release (most probably 1.8.1.) and I will add that feature in next PR 2- mvn integration-test -pl google-cloud-storage runs GCSContainerIntegrationTest offline (not as live test). That is why PRs fail --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/48#issuecomment-54755811
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
> + BlobStore blobStore = view.getBlobStore();
> + long countBefore = blobStore.countBlobs(containerName);
> +
> + addMultipartBlobToContainer(containerName, "const.txt");
> +
> + long countAfter = blobStore.countBlobs(containerName);
> + assertNotEquals(countBefore, countAfter, "No blob was created");
> + assertTrue(countAfter - countBefore > 1, "A multipart blob wasn't
> actually created - "
> + + "there was only 1 extra blob but there should be one
> manifest blob and multiple chunk blobs");
> + } finally {
> + returnContainer(containerName);
> + }
> + }
> +
> + protected void addMultipartBlobToContainer(String containerName, String
> key) throws IOException {
> + ByteSource sourceToUpload = createFileBiggerThan(PART_SIZE);
createFileBiggerThan method uses TestUtils.randomByteSource
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17216208
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
> + return multipartUploadStrategy.execute(container, blob);
> + } else {
> + return putBlob(container, blob);
> + }
> + }
> +
> + @Override
> + public BlobMetadata blobMetadata(String container, String name) {
> + return
> objectToBlobMetadata.apply(api.getObjectApi().getObject(container, name));
> + }
> +
> + @Override
> + public Blob getBlob(String container, String name,
> org.jclouds.blobstore.options.GetOptions options) {
> + PayloadEnclosingImpl impl = api.getObjectApi().download(container,
> name);
> + try {
> + Thread.sleep(1000);
Real problem here is download operation only provide Media part while getObject
provide only the metadata part(Both get requests). Will it be good idea to add
request that would surely fail in its first attempt? Isn't there any other way
to introduce a time gap?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17216113
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
> + return multipartUploadStrategy.execute(container, blob);
> + } else {
> + return putBlob(container, blob);
> + }
> + }
> +
> + @Override
> + public BlobMetadata blobMetadata(String container, String name) {
> + return
> objectToBlobMetadata.apply(api.getObjectApi().getObject(container, name));
> + }
> +
> + @Override
> + public Blob getBlob(String container, String name,
> org.jclouds.blobstore.options.GetOptions options) {
> + PayloadEnclosingImpl impl = api.getObjectApi().download(container,
> name);
> + try {
> + Thread.sleep(1000);
Yep ,I understand it is not nice. But removing it gives 503 errors.What could
be the alternative to introduce a time gap between 2 requests?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17214076
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
> + @Override
> + public String execute(String container, Blob blob) {
> +
> + ObjectTemplate destination =
> blob2ObjectTemplate.apply(blob.getMetadata());
> + ComposeObjectTemplate template = new
> ComposeObjectTemplate().destination(destination);
> +
> + Set sourceList = Sets.newHashSet();
> +
> + String key = blob.getMetadata().getName();
> + Payload payload = blob.getPayload();
> + Long length = payload.getContentMetadata().getContentLength();
> + if (length == null) {
> + length = blob.getMetadata().getContentMetadata().getContentLength();
> + payload.getContentMetadata().setContentLength(length);
> + }
> + checkNotNull(length,
I'm trying to get the length from the blobMetadata if it is not set on the
payload . Moving checkNotNull to top would lead to fail some cases which can
be handle?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17214064
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
> +import org.jclouds.http.HttpResponseException;
> +import org.jclouds.http.internal.PayloadEnclosingImpl;
> +import com.google.common.base.Charsets;
> +import com.google.common.base.Function;
> +import com.google.common.base.Supplier;
> +import com.google.common.base.Throwables;
> +import com.google.common.collect.ImmutableSet;
> +import com.google.common.collect.Iterables;
> +import com.google.common.hash.HashCode;
> +import com.google.inject.Inject;
> +import com.google.inject.Provider;
> +
> +@Singleton
> +public class GCSBlobStore extends BaseBlobStore {
> +
> + private final String PROJECT_ID =
> System.getProperty("test.google-cloud-storage.project-number");//System.getProperty("google-cloud-storage.identity").split("-")[0];
Did similar to GCE but provided project number(extracted from identity) to
supplier, but not identity.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17214049
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
> + return new Function,
> org.jclouds.blobstore.domain.PageSet>() {
> + public org.jclouds.blobstore.domain.PageSet StorageMetadata> apply(ListPage from) {
> +return new
> PageSetImpl(Iterables.transform(from,
> bucketToStorageMetadata), null);
> + }
> + }.apply(api.getBucketApi().listBucket(PROJECT_ID));
> + }
> +
> + @Override
> + public boolean containerExists(String container) {
> + return api.getBucketApi().bucketExist(container);
> + }
> +
> + @Override
> + public boolean createContainerInLocation(Location location, String
> container) {
> +
> + if (containerExists(container)) {
Fixed with a new Fallback NullIfBucketExists
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17214046
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
> + assertEquals(container.size(), 15);
> + } finally {
> + returnContainer(containerName);
> + }
> + }
> +
> + @Override
> + @Test(enabled = false)
> + public void testDirectory() throws InterruptedException {
> + /**
> + * By using slashes in an object name, you can make objects appear as
> though they're stored in a hierarchical
> + * structure. For example, you could name one object
> /europe/france/paris.jpg and another object
> + * /europe/france/cannes.jpg. When you list these objects they appear
> to be in a hierarchical directory structure
> + * based on location; however, Google Cloud Storage sees the objects
> as independent objects with no hierarchical
> + * relationship whatsoever.
> + */
In GCS prefixes are listed separately from objects and there is nothing like
directory either. I think this test is irrevalent to GCS. BTW I removed the
comments
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17214041
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
I have addresses issues other than using "test.google-cloud-storage.project-number" dependency --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/48#issuecomment-54711622
Re: [jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
> +import org.jclouds.googlecloudstorage.options.ListObjectOptions;
> +import org.jclouds.http.HttpResponseException;
> +import org.jclouds.http.internal.PayloadEnclosingImpl;
> +
> +import com.google.common.base.Charsets;
> +import com.google.common.base.Function;
> +import com.google.common.base.Supplier;
> +import com.google.common.collect.ImmutableSet;
> +import com.google.common.collect.Iterables;
> +import com.google.common.hash.HashCode;
> +import com.google.inject.Inject;
> +import com.google.inject.Provider;
> +
> +@Singleton
> +public class GCSBlobStore extends BaseBlobStore {
> + private final String PROJECT_ID =
> System.getProperty("test.google-cloud-storage.project-number");
@andrewgaul As we discussed we would use similar approach to GCE. But I
couldn't find how to assign the identity value( i.e
"google-cloud-storage.identity") to the supplier projectId.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/48/files#r17208404
[jclouds-labs-google] JCLOUDS-458:Added Blobstore Abstraction (#48)
JCLOUDS-458:Added Blobstore Abstraction Minor Changes testCopyUrl You can merge this Pull Request by running: git pull https://github.com/hsbhathiya/jclouds-labs-google BlobAbStream Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs-google/pull/48 -- Commit Summary -- * JCLOUDS-458:Added Blobstore Abstraction -- File Changes -- M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/GoogleCloudStorageApiMetadata.java (4) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GCSAsyncBlobStore.java (289) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GCSBlobStore.java (282) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/config/GCSBlobStoreContextModule.java (35) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/BlobMetadataToObjectTemplate.java (59) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/BlobStoreListContainerOptionsToListObjectOptions.java (51) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/BucketToStorageMetadata.java (47) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/ObjectListToStorageMetadata.java (65) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/functions/ObjectToBlobMetadata.java (79) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/strategy/internal/MultipartNamingStrategy.java (30) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/strategy/internal/MultipartUpload.java (33) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/strategy/internal/MultipartUploadSlicingAlgorithm.java (139) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/strategy/internal/MultipartUploadStrategy.java (26) A google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/strategy/internal/SequentialMultipartUploadStrategy.java (106) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/GCSObject.java (17) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/domain/templates/ObjectTemplate.java (14) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/BucketApi.java (26) M google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/features/ObjectApi.java (4) A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GCSBlobIntegrationLiveTest.java (246) A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GCSBlobLiveTest.java (113) A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GCSContainerIntegrationTest.java (100) A google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GCSContainerLiveTest.java (28) M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/features/BucketApiLiveTest.java (9) -- Patch Links -- https://github.com/jclouds/jclouds-labs-google/pull/48.patch https://github.com/jclouds/jclouds-labs-google/pull/48.diff --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/48
Re: [jclouds-labs-google] JCLOUD-458:Resumable Upload with live tests (#47)
Addressed other issues other than creating ContentRange Class. I would make that change in a later PR? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/47#issuecomment-54001259
Re: [jclouds-labs-google] JCLOUD-458:Resumable Upload with live tests (#47)
@andrewgaul I have addressed the issues
BTW chunkUpload and checkStaus methods are bit complicated as the contentRange
field (Header Param) need to be in a specific format as follows.
Range in {bytes StartingByte - Endingbyte/Totalsize } format
ex: bytes 0 - 1213/2000
I have created generateContentRange(Long lowwerLimit, Long upperLimit, Long
totalSize) in domain utils. i just get the feeling that we should force to use
it. ?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/47#issuecomment-53972529
