[GitHub] gaul commented on issue #1: Remove stale Meetup link
gaul commented on issue #1: Remove stale Meetup link URL: https://github.com/apache/jclouds-site/pull/1#issuecomment-452992023 Test comment 2. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx closed pull request #1: Remove stale Meetup link
nacx closed pull request #1: Remove stale Meetup link URL: https://github.com/apache/jclouds-site/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/community/index.md b/community/index.md index f8c09cf..1a486d6 100644 --- a/community/index.md +++ b/community/index.md @@ -16,7 +16,6 @@ title: Get in touch! https://webchat.freenode.net/?channels=jclouds";>Chat with us on IRC at https://botbot.me/freenode/jclouds/";>#jclouds on Freenode Join the https://the-asf.slackarchive.io/jclouds";>#jclouds Slack channel at the https://the-asf.slack.com/";>ASF workspace. Ask us for an invitation to join! - http://www.meetup.com/jclouds/";>Attend a jclouds event! Get involved! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx commented on issue #1: Remove stale Meetup link
nacx commented on issue #1: Remove stale Meetup link URL: https://github.com/apache/jclouds-site/pull/1#issuecomment-453026301 Made some changes to the PR build config. Closing and reopening to see if it is triggered. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gaul opened a new pull request #1: Remove stale Meetup link
gaul opened a new pull request #1: Remove stale Meetup link URL: https://github.com/apache/jclouds-site/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx closed pull request #1: Remove stale Meetup link
nacx closed pull request #1: Remove stale Meetup link URL: https://github.com/apache/jclouds-site/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/community/index.md b/community/index.md index f8c09cf..1a486d6 100644 --- a/community/index.md +++ b/community/index.md @@ -16,7 +16,6 @@ title: Get in touch! https://webchat.freenode.net/?channels=jclouds";>Chat with us on IRC at https://botbot.me/freenode/jclouds/";>#jclouds on Freenode Join the https://the-asf.slackarchive.io/jclouds";>#jclouds Slack channel at the https://the-asf.slack.com/";>ASF workspace. Ask us for an invitation to join! - http://www.meetup.com/jclouds/";>Attend a jclouds event! Get involved! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit commented on issue #1: Remove stale Meetup link
asfgit commented on issue #1: Remove stale Meetup link URL: https://github.com/apache/jclouds-site/pull/1#issuecomment-453026313 Can one of the admins verify this patch? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gaul opened a new pull request #1: Remove stale Meetup link
gaul opened a new pull request #1: Remove stale Meetup link URL: https://github.com/apache/jclouds-site/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gaul merged pull request #1: Remove stale Meetup link
gaul merged pull request #1: Remove stale Meetup link URL: https://github.com/apache/jclouds-site/pull/1 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@jclouds.apache.org This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #2: PR build test. Do not merge
nacx opened a new pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 PR build test. Do not merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx closed pull request #2: PR build test. Do not merge
nacx closed pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #2: PR build test. Do not merge
nacx opened a new pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 PR build test. Do not merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gmcdonald closed pull request #2: PR build test. Do not merge
gmcdonald closed pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gmcdonald commented on issue #2: PR build test. Do not merge
gmcdonald commented on issue #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2#issuecomment-460002968 test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #2: PR build test. Do not merge
nacx opened a new pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 PR build test. Do not merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gmcdonald commented on issue #2: PR build test. Do not merge
gmcdonald commented on issue #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2#issuecomment-460002983 test re-open This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx closed pull request #2: PR build test. Do not merge
nacx closed pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #2: PR build test. Do not merge
nacx opened a new pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 PR build test. Do not merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #3: Update README.md
nacx opened a new pull request #3: Update README.md URL: https://github.com/apache/jclouds-site/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx closed pull request #2: PR build test. Do not merge
nacx closed pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #2: PR build test. Do not merge
nacx opened a new pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 PR build test. Do not merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #2: PR build test. Do not merge
nacx opened a new pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 PR build test. Do not merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx closed pull request #2: PR build test. Do not merge
nacx closed pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cthistle closed pull request #2: PR build test. Do not merge
cthistle closed pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #2: PR build test. Do not merge
nacx opened a new pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 PR build test. Do not merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cthistle commented on issue #2: PR build test. Do not merge
cthistle commented on issue #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2#issuecomment-460080089 one more close for testing This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cthistle closed pull request #3: Update README.md
cthistle closed pull request #3: Update README.md URL: https://github.com/apache/jclouds-site/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cthistle closed pull request #3: Update README.md
cthistle closed pull request #3: Update README.md URL: https://github.com/apache/jclouds-site/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #3: Update README.md
nacx opened a new pull request #3: Update README.md URL: https://github.com/apache/jclouds-site/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx closed pull request #2: PR build test. Do not merge
nacx closed pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #2: PR build test. Do not merge
nacx opened a new pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 PR build test. Do not merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #3: Update README.md
nacx opened a new pull request #3: Update README.md URL: https://github.com/apache/jclouds-site/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cthistle closed pull request #3: Update README.md
cthistle closed pull request #3: Update README.md URL: https://github.com/apache/jclouds-site/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #3: Update README.md
nacx opened a new pull request #3: Update README.md URL: https://github.com/apache/jclouds-site/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cthistle closed pull request #3: Just testing.
cthistle closed pull request #3: Just testing. URL: https://github.com/apache/jclouds-site/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #3: Just testing.
nacx opened a new pull request #3: Just testing. URL: https://github.com/apache/jclouds-site/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] cthistle closed pull request #3: Just testing.
cthistle closed pull request #3: Just testing. URL: https://github.com/apache/jclouds-site/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jclouds-commentator commented on issue #3: Just testing.
jclouds-commentator commented on issue #3: Just testing. URL: https://github.com/apache/jclouds-site/pull/3#issuecomment-460081534 Go to http://4e30bcaa9f747bb2a07b-821df5eb233d3789e392a93c8961e39e.r18.cf5.rackcdn.com/ to review your changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #15: Verifying PR build. DO NOT MERGE
nacx opened a new pull request #15: Verifying PR build. DO NOT MERGE URL: https://github.com/apache/jclouds/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx closed pull request #15: Verifying PR build. DO NOT MERGE
nacx closed pull request #15: Verifying PR build. DO NOT MERGE URL: https://github.com/apache/jclouds/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx closed pull request #2: PR build test. Do not merge
nacx closed pull request #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jclouds-commentator commented on issue #2: PR build test. Do not merge
jclouds-commentator commented on issue #2: PR build test. Do not merge URL: https://github.com/apache/jclouds-site/pull/2#issuecomment-460082246 Go to http://63cd48bc3a9271c82f5d-1e14af91adbd054a5e78cecba51b2194.r92.cf5.rackcdn.com/ to review your changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jclouds-commentator commented on issue #3: Just testing.
jclouds-commentator commented on issue #3: Just testing. URL: https://github.com/apache/jclouds-site/pull/3#issuecomment-460083021 Go to http://d89adf32bde4f02a60e6-2b380f7352bc7763614da48daa6b2e6b.r71.cf5.rackcdn.com/ to review your changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #4: Update links to point to the Apache org
nacx opened a new pull request #4: Update links to point to the Apache org URL: https://github.com/apache/jclouds-site/pull/4 Update links to point to the Apache org on GitHub. This does not change the links in the release notes (as many point to pull requests that won't exist in the new org repos) and the blog posts; just the guides and permanent documentation pages. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jclouds-commentator commented on issue #4: Update links to point to the Apache org
jclouds-commentator commented on issue #4: Update links to point to the Apache org URL: https://github.com/apache/jclouds-site/pull/4#issuecomment-460091643 Go to http://fa7a7ac5fc492f929256-5e853e0eb9525d15647594c95c8c32f9.r21.cf5.rackcdn.com/ to review your changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx merged pull request #4: Update links to point to the Apache org
nacx merged pull request #4: Update links to point to the Apache org URL: https://github.com/apache/jclouds-site/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx commented on issue #4: Update links to point to the Apache org
nacx commented on issue #4: Update links to point to the Apache org URL: https://github.com/apache/jclouds-site/pull/4#issuecomment-460095147 It feels good to be able to use again he GitHub squash and merge button directly! 😄 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ghyster opened a new pull request #16: switch to signaturev4
ghyster opened a new pull request #16: switch to signaturev4 URL: https://github.com/apache/jclouds/pull/16 V2 signature is not supported across all AWS regions, V4 signature is This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gaul commented on issue #16: switch to signaturev4
gaul commented on issue #16: switch to signaturev4 URL: https://github.com/apache/jclouds/pull/16#issuecomment-460728208 This pull request changes the signature across *all* S3 clone implementations, some of which only support v2. `AWSS3HttpApiModule` already overrides the signer with v4 which applies to all AWS regions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ghyster closed pull request #16: switch to signaturev4
ghyster closed pull request #16: switch to signaturev4 URL: https://github.com/apache/jclouds/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ghyster commented on issue #16: switch to signaturev4
ghyster commented on issue #16: switch to signaturev4 URL: https://github.com/apache/jclouds/pull/16#issuecomment-460732856 Sorry, I didn't find anything about this in the docs, I'll test with AWSS3HttpApiModule, thank you This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx opened a new pull request #5: Started release notes for 2.1.2
nacx opened a new pull request #5: Started release notes for 2.1.2 URL: https://github.com/apache/jclouds-site/pull/5 Work started for the release notes for 2.1.2. Things to be done: * [ ] Fix the release date to the real one once we have it. * [ ] Complete the TODOs (@gaul you've been more involved in the issues in this release. Mind having a look at the summary, known issues and contributors?). * [ ] Once the announcement is out, get the permalink from `lists.apache.org` and generate a short url for it on `s.apache.org` using this ID: `https://s.apache.org/jclouds212` (the page already assumes that). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jclouds-commentator commented on issue #5: Started release notes for 2.1.2
jclouds-commentator commented on issue #5: Started release notes for 2.1.2 URL: https://github.com/apache/jclouds-site/pull/5#issuecomment-460820697 Go to http://c0cdaa4e89863adf0298-fc03ca8d3e40301332464351c9025d6b.r87.cf5.rackcdn.com/ to review your changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jclouds-commentator commented on issue #5: Started release notes for 2.1.2
jclouds-commentator commented on issue #5: Started release notes for 2.1.2 URL: https://github.com/apache/jclouds-site/pull/5#issuecomment-460821947 Go to http://6ecf81c31265b27d35de-5cc7b1fe21c4d38adc53d5a1d1daccae.r82.cf5.rackcdn.com/ to review your changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jclouds-commentator commented on issue #5: Started release notes for 2.1.2
jclouds-commentator commented on issue #5: Started release notes for 2.1.2 URL: https://github.com/apache/jclouds-site/pull/5#issuecomment-460829372 Go to http://6fee1e1f51d37ce32b0e-f542daef83fc99ca3fcbd582ee42e70e.r94.cf5.rackcdn.com/ to review your changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jclouds-commentator commented on issue #5: Started release notes for 2.1.2
jclouds-commentator commented on issue #5: Started release notes for 2.1.2 URL: https://github.com/apache/jclouds-site/pull/5#issuecomment-461175363 Go to http://2ebd327219c65348fb5b-4683bcd44e5f613aaed0bbe5717e0f4e.r34.cf5.rackcdn.com/ to review your changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gaul merged pull request #5: Started release notes for 2.1.2
gaul merged pull request #5: Started release notes for 2.1.2 URL: https://github.com/apache/jclouds-site/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gaul commented on issue #5: Started release notes for 2.1.2
gaul commented on issue #5: Started release notes for 2.1.2 URL: https://github.com/apache/jclouds-site/pull/5#issuecomment-461180118 Does this automatically deploy? Installing Jekyll 1.5.1 on my computer seems like an adventure... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx commented on issue #5: Started release notes for 2.1.2
nacx commented on issue #5: Started release notes for 2.1.2 URL: https://github.com/apache/jclouds-site/pull/5#issuecomment-461182067 No, it doesn't. I'll deploy it now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx commented on issue #5: Started release notes for 2.1.2
nacx commented on issue #5: Started release notes for 2.1.2 URL: https://github.com/apache/jclouds-site/pull/5#issuecomment-461182247 > Installing Jekyll 1.5.1 on my computer seems like an adventure... Installing any Ruby gem kinda is... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx commented on issue #5: Started release notes for 2.1.2
nacx commented on issue #5: Started release notes for 2.1.2 URL: https://github.com/apache/jclouds-site/pull/5#issuecomment-461183256 Done! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] demobox commented on a change in pull request #5: Started release notes for 2.1.2
demobox commented on a change in pull request #5: Started release notes for 2.1.2 URL: https://github.com/apache/jclouds-site/pull/5#discussion_r254836642 ## File path: releasenotes/2.1.2.md ## @@ -0,0 +1,89 @@ +--- +layout: releasenotes +title: Release Notes for Version 2.1.2 +date: 2018-02-06 20:00:00 +release_notes: true +permalink: /releasenotes/2.1.2/ +--- + +1. [Introduction](#intro) +1. [Release Highlights](#highlights) +1. [Known Issues](#knownissues) +1. [Credits](#credits) +1. [Test Results](#test) + +## Introduction + +Apache jclouds 2.1.2 is the second bugfix release after jclouds 2.1.0 and comes with several bugfixes and performance improvements. +You can [read the official announcement here](https://s.apache.org/jclouds212). To get started with jclouds, please see the [jclouds installation guide](/start/install/). + +## Release Highlights + +New features in Apache jclouds 2.1.2 include: + +* 1&1 Baremetal servers +* EC2 r5, t3, and x1 instance types +* GCS REGIONAL storage class + +### Bugs and patches + +* [JCLOUDS-1330](https://issues.apache.org/jira/browse/JCLOUDS-1330) - Azure ARM orphaned networks not cleaned up when node deleted Review comment: Is this list accurate? E.g. [JCLOUDS-1330](https://issues.apache.org/jira/browse/JCLOUDS-1330) is still marked as "open", and the list of issues [from JIRA](https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12314430&version=12343896) looks quite different? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gaul commented on a change in pull request #5: Started release notes for 2.1.2
gaul commented on a change in pull request #5: Started release notes for 2.1.2 URL: https://github.com/apache/jclouds-site/pull/5#discussion_r254880338 ## File path: releasenotes/2.1.2.md ## @@ -0,0 +1,89 @@ +--- +layout: releasenotes +title: Release Notes for Version 2.1.2 +date: 2018-02-06 20:00:00 +release_notes: true +permalink: /releasenotes/2.1.2/ +--- + +1. [Introduction](#intro) +1. [Release Highlights](#highlights) +1. [Known Issues](#knownissues) +1. [Credits](#credits) +1. [Test Results](#test) + +## Introduction + +Apache jclouds 2.1.2 is the second bugfix release after jclouds 2.1.0 and comes with several bugfixes and performance improvements. +You can [read the official announcement here](https://s.apache.org/jclouds212). To get started with jclouds, please see the [jclouds installation guide](/start/install/). + +## Release Highlights + +New features in Apache jclouds 2.1.2 include: + +* 1&1 Baremetal servers +* EC2 r5, t3, and x1 instance types +* GCS REGIONAL storage class + +### Bugs and patches + +* [JCLOUDS-1330](https://issues.apache.org/jira/browse/JCLOUDS-1330) - Azure ARM orphaned networks not cleaned up when node deleted Review comment: I accidentally included unresolved issues which marked 2.1.2 as the fix version. Actually I think that @nacx had this correct in his initial commit and I overwrote them when merging our versions. Fixed in 0a12c4e011ffac0906741ce6ec79782177ab7f84. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] demobox commented on a change in pull request #5: Started release notes for 2.1.2
demobox commented on a change in pull request #5: Started release notes for 2.1.2 URL: https://github.com/apache/jclouds-site/pull/5#discussion_r254888038 ## File path: releasenotes/2.1.2.md ## @@ -0,0 +1,89 @@ +--- +layout: releasenotes +title: Release Notes for Version 2.1.2 +date: 2018-02-06 20:00:00 +release_notes: true +permalink: /releasenotes/2.1.2/ +--- + +1. [Introduction](#intro) +1. [Release Highlights](#highlights) +1. [Known Issues](#knownissues) +1. [Credits](#credits) +1. [Test Results](#test) + +## Introduction + +Apache jclouds 2.1.2 is the second bugfix release after jclouds 2.1.0 and comes with several bugfixes and performance improvements. +You can [read the official announcement here](https://s.apache.org/jclouds212). To get started with jclouds, please see the [jclouds installation guide](/start/install/). + +## Release Highlights + +New features in Apache jclouds 2.1.2 include: + +* 1&1 Baremetal servers +* EC2 r5, t3, and x1 instance types +* GCS REGIONAL storage class + +### Bugs and patches + +* [JCLOUDS-1330](https://issues.apache.org/jira/browse/JCLOUDS-1330) - Azure ARM orphaned networks not cleaned up when node deleted Review comment: > I accidentally included unresolved issues which marked 2.1.2 as the fix version Ah, clear, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] trevorflanagan opened a new pull request #1: Fixing issue in Dimension Data NetworkDomainTearDown
trevorflanagan opened a new pull request #1: Fixing issue in Dimension Data NetworkDomainTearDown URL: https://github.com/apache/jclouds-examples/pull/1 Fixing issue where during the clear down all servers in a Datacenter get deleted instead of just the ones in the Network Domain. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nacx merged pull request #1: Fixing issue in Dimension Data NetworkDomainTearDown
nacx merged pull request #1: Fixing issue in Dimension Data NetworkDomainTearDown URL: https://github.com/apache/jclouds-examples/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gaul opened a new pull request #17: Fix always-true date comparison
gaul opened a new pull request #17: Fix always-true date comparison URL: https://github.com/apache/jclouds/pull/17 Found via error-prone 2.3.3. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] gaul merged pull request #17: Fix always-true date comparison
gaul merged pull request #17: Fix always-true date comparison URL: https://github.com/apache/jclouds/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] danielestevez opened a new pull request #18: Adds two new regions to AWS provider
danielestevez opened a new pull request #18: Adds two new regions to AWS provider URL: https://github.com/apache/jclouds/pull/18 Adds two new regions to EC2 and S3 - EU (Stockholm) | eu-north-1 | ec2.eu-north-1.amazonaws.com - China (Ningxia) | cn-northwest-1 | ec2.cn-northwest-1.amazonaws.com.cn see https://docs.aws.amazon.com/general/latest/gr/rande.html All the regions available right now are in the jclouds provider, except Asia Pacific (Osaka-Local), i didn't include this one since it's a special one that can't be accessed by anyone (similar as the -gov- ones) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] danielestevez merged pull request #18: Adds two new regions to AWS provider
danielestevez merged pull request #18: Adds two new regions to AWS provider URL: https://github.com/apache/jclouds/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] danielestevez opened a new pull request #19: Adds new Generally Available azure locations for South Africa
danielestevez opened a new pull request #19: Adds new Generally Available azure locations for South Africa URL: https://github.com/apache/jclouds/pull/19 Related news: [Microsoft opens first datacenters in Africa with general availability of Microsoft Azure](https://azure.microsoft.com/en-us/blog/microsoft-opens-first-datacenters-in-africa-with-general-availability-of-microsoft-azure/?ranMID=24542&ranEAID=TnL5HPStwNw&ranSiteID=TnL5HPStwNw-tAHfeVMsJxlTB0HTf5u5hg&epi=TnL5HPStwNw-tAHfeVMsJxlTB0HTf5u5hg&irgwc=1&OCID=AID681541_aff_7593_1243925&tduid=(ir__lzno3kzeixnvs0cbi2ggngmlx22xmws0ilole2sf00)(7593)(1243925)(TnL5HPStwNw-tAHfeVMsJxlTB0HTf5u5hg)()&irclickid=_lzno3kzeixnvs0cbi2ggngmlx22xmws0ilole2sf00) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] nacx commented on issue #18: Adds two new regions to AWS provider
nacx commented on issue #18: Adds two new regions to AWS provider URL: https://github.com/apache/jclouds/pull/18#issuecomment-473506618 This does not break backward compat. Cherry-pick to 2.1.x? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] danielestevez commented on issue #18: Adds two new regions to AWS provider
danielestevez commented on issue #18: Adds two new regions to AWS provider URL: https://github.com/apache/jclouds/pull/18#issuecomment-473530568 Sure! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] ak58588 opened a new pull request #20: JCLOUDS-1428 - Support for SAS token based Authentication for Azure Blob Storage - Follow Up
ak58588 opened a new pull request #20: JCLOUDS-1428 - Support for SAS token based Authentication for Azure Blob Storage - Follow Up URL: https://github.com/apache/jclouds/pull/20 Need to remove "sp" and "se" tokens from the SAS check, since there is a possible SAS format without those two tokens; Added a unit test case. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] gaul commented on issue #20: JCLOUDS-1428 - Support for SAS token based Authentication for Azure Blob Storage - Follow Up
gaul commented on issue #20: JCLOUDS-1428 - Support for SAS token based Authentication for Azure Blob Storage - Follow Up URL: https://github.com/apache/jclouds/pull/20#issuecomment-474334430 @nacx any feedback? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] gaul merged pull request #20: JCLOUDS-1428 - Support for SAS token based Authentication for Azure Blob Storage - Follow Up
gaul merged pull request #20: JCLOUDS-1428 - Support for SAS token based Authentication for Azure Blob Storage - Follow Up URL: https://github.com/apache/jclouds/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] nacx commented on issue #20: JCLOUDS-1428 - Support for SAS token based Authentication for Azure Blob Storage - Follow Up
nacx commented on issue #20: JCLOUDS-1428 - Support for SAS token based Authentication for Azure Blob Storage - Follow Up URL: https://github.com/apache/jclouds/pull/20#issuecomment-474812590 cherry-pick to 2.1.x? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] danielestevez merged pull request #19: Adds new Generally Available azure locations for South Africa
danielestevez merged pull request #19: Adds new Generally Available azure locations for South Africa URL: https://github.com/apache/jclouds/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] danielestevez commented on issue #18: Adds two new regions to AWS provider
danielestevez commented on issue #18: Adds two new regions to AWS provider URL: https://github.com/apache/jclouds/pull/18#issuecomment-475282329 Pushed to both commits to [[2.1.x](https://github.com/apache/jclouds/tree/2.1.x)] ([here](https://github.com/apache/jclouds/commit/897713011df990f027c5de9bc2769c0aa2955e4e) and [here](https://github.com/apache/jclouds/commit/cbc24de677ea04316046ab88df070f84c3a3622b)) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] danielestevez commented on issue #19: Adds new Generally Available azure locations for South Africa
danielestevez commented on issue #19: Adds new Generally Available azure locations for South Africa URL: https://github.com/apache/jclouds/pull/19#issuecomment-475300760 Also pushed to [2.1.x](https://github.com/apache/jclouds/commit/1588ef7f7ee8f5b38c72fab0fa60b529a50d003c) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds-labs] trevorflanagan opened a new pull request #1: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable
trevorflanagan opened a new pull request #1: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable URL: https://github.com/apache/jclouds-labs/pull/1 Fix for issue identified in https://issues.apache.org/jira/browse/JCLOUDS-1492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds-examples] trevorflanagan opened a new pull request #2: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable
trevorflanagan opened a new pull request #2: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable URL: https://github.com/apache/jclouds-examples/pull/2 Updated to handle changes identified in: https://issues.apache.org/jira/browse/JCLOUDS-1492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds-labs] trevorflanagan commented on a change in pull request #1: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable
trevorflanagan commented on a change in pull request #1: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable URL: https://github.com/apache/jclouds-labs/pull/1#discussion_r269964513 ## File path: dimensiondata/src/main/java/org/jclouds/dimensiondata/cloudcontrol/domain/OsImage.java ## @@ -31,6 +32,7 @@ type = TYPE; } + @Nullable Review comment: unrelated to fix, but this is breaking our live tests This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds-examples] nacx merged pull request #2: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable
nacx merged pull request #2: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable URL: https://github.com/apache/jclouds-examples/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds-labs] nacx commented on a change in pull request #1: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable
nacx commented on a change in pull request #1: JCLOUDS-1492 Dimension Data
Feature API Predicates are not usable
URL: https://github.com/apache/jclouds-labs/pull/1#discussion_r270677364
##
File path:
dimensiondata/src/test/java/org/jclouds/dimensiondata/cloudcontrol/features/NetworkApiLiveTest.java
##
@@ -42,114 +42,134 @@
import static org.testng.Assert.assertTrue;
@Test(groups = "live", testName = "NetworkApiLiveTest", singleThreaded = true)
-public class NetworkApiLiveTest extends
BaseDimensionDataCloudControlApiLiveTest {
-
- private String networkDomainId;
- private String networkDomainName;
- private String vlanId;
- private String portListId;
- private String firewallRuleId;
-
- private List firewallRuleIds;
-
- @BeforeClass
- public void init() {
- firewallRuleIds = Lists.newArrayList();
- }
-
- @Test(dependsOnMethods = "testDeployVlan")
- public void testCreatePortList() {
- portListId = api()
-.createPortList(networkDomainId,
this.getClass().getCanonicalName(), this.getClass().getCanonicalName(),
- ImmutableList.of(FirewallRuleTarget.Port.create(22, null)),
Lists.newArrayList());
- assertNotNull(portListId);
- }
-
- @Test(dependsOnMethods = "testCreatePortList")
- public void testGetPortList() {
- FirewallRuleTarget.PortList portList = api().getPortList(portListId);
- assertNotNull(portList);
- assertTrue(portList.port().get(0).begin() == 22);
- }
-
- @Test(dependsOnMethods = "testGetPortList")
- public void testCreateFirewallRuleWithPortList() {
- firewallRuleId = api().createFirewallRule(networkDomainId,
generateFirewallRuleName("server-id"), DEFAULT_ACTION,
-DEFAULT_IP_VERSION, DEFAULT_PROTOCOL,
FirewallRuleTarget.builder().ip(IpRange.create("ANY", null)).build(),
-FirewallRuleTarget.builder().ip(IpRange.create("ANY",
null)).portListId(portListId).build(), Boolean.TRUE,
-Placement.builder().position("LAST").build());
- firewallRuleIds.add(firewallRuleId);
- }
-
- @Test(dependsOnMethods = "testCreateFirewallRuleWithPortList")
- public void testListFirewallRules() {
- PagedIterable firewallRulesList =
api().listFirewallRules(networkDomainId);
- assertFalse(firewallRulesList.isEmpty());
-
assertEquals(firewallRulesList.last().get().first().get().networkDomainId(),
networkDomainId);
- }
-
- @Test(dependsOnMethods = "testListFirewallRules")
- public void testDeleteFirewallRule() {
- api().deleteFirewallRule(firewallRuleId);
- FirewallRule rule =
findById(api().listFirewallRules(networkDomainId).concat().toList(),
firewallRuleId);
- assertNull(rule);
- }
-
- @Test(dependsOnMethods = "testDeployNetworkDomain")
- public void testDeployVlan() {
- vlanId = api().deployVlan(networkDomainId,
NetworkApiLiveTest.class.getSimpleName() + new Date().getTime(),
-NetworkApiLiveTest.class.getSimpleName() + new Date().getTime(),
DEFAULT_PRIVATE_IPV4_BASE_ADDRESS,
-DEFAULT_PRIVATE_IPV4_PREFIX_SIZE);
- assertNotNull(vlanId);
- assertTrue(vlanNormalPredicate.apply(vlanId), "vlan is not in a NORMAL
state after timeout");
- }
-
- @Test
- public void testDeployNetworkDomain() {
- networkDomainName = NetworkApiLiveTest.class.getSimpleName() + new
Date().getTime();
- networkDomainId =
api().deployNetworkDomain(datacenters.iterator().next(), networkDomainName,
-NetworkApiLiveTest.class.getSimpleName() + new Date().getTime() +
"description", "ESSENTIALS");
- assertNotNull(networkDomainId);
- assertTrue(networkDomainNormalPredicate.apply(networkDomainId),
-"network domain is not in a NORMAL state after timeout");
- }
-
- @Test(expectedExceptions = ResourceAlreadyExistsException.class)
- public void testDeploySameNetworkDomain() {
- api().deployNetworkDomain(datacenters.iterator().next(),
networkDomainName, networkDomainName, "ESSENTIALS");
- }
-
- @AfterClass
- public void tearDown() {
- if (!firewallRuleIds.isEmpty()) {
- for (String firewallRuleId : firewallRuleIds) {
-api().deleteFirewallRule(firewallRuleId);
- }
- }
- if (portListId != null) {
- api().deletePortList(portListId);
- }
- if (vlanId != null) {
- api().deleteVlan(vlanId);
- assertTrue(vlanDeletedPredicate.apply(vlanId), "vlan is not in a
DELETED state after timeout");
- }
- if (networkDomainId != null) {
- api().deleteNetworkDomain(networkDomainId);
- assertTrue(networkDomainDeletedPredicate.apply(networkDomainId),
- "network domain is not in a DELETED state after timeout");
- }
- }
-
- private NetworkApi api() {
- return api.getNetworkApi();
- }
-
- private FirewallRule findById(List collection, String id) {
- for (FirewallRule rule : collection) {
- if (rule.id().equals(id))
[GitHub] [jclouds-labs] trevorflanagan commented on a change in pull request #1: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable
trevorflanagan commented on a change in pull request #1: JCLOUDS-1492 Dimension
Data Feature API Predicates are not usable
URL: https://github.com/apache/jclouds-labs/pull/1#discussion_r270738485
##
File path:
dimensiondata/src/test/java/org/jclouds/dimensiondata/cloudcontrol/features/NetworkApiLiveTest.java
##
@@ -42,114 +42,134 @@
import static org.testng.Assert.assertTrue;
@Test(groups = "live", testName = "NetworkApiLiveTest", singleThreaded = true)
-public class NetworkApiLiveTest extends
BaseDimensionDataCloudControlApiLiveTest {
-
- private String networkDomainId;
- private String networkDomainName;
- private String vlanId;
- private String portListId;
- private String firewallRuleId;
-
- private List firewallRuleIds;
-
- @BeforeClass
- public void init() {
- firewallRuleIds = Lists.newArrayList();
- }
-
- @Test(dependsOnMethods = "testDeployVlan")
- public void testCreatePortList() {
- portListId = api()
-.createPortList(networkDomainId,
this.getClass().getCanonicalName(), this.getClass().getCanonicalName(),
- ImmutableList.of(FirewallRuleTarget.Port.create(22, null)),
Lists.newArrayList());
- assertNotNull(portListId);
- }
-
- @Test(dependsOnMethods = "testCreatePortList")
- public void testGetPortList() {
- FirewallRuleTarget.PortList portList = api().getPortList(portListId);
- assertNotNull(portList);
- assertTrue(portList.port().get(0).begin() == 22);
- }
-
- @Test(dependsOnMethods = "testGetPortList")
- public void testCreateFirewallRuleWithPortList() {
- firewallRuleId = api().createFirewallRule(networkDomainId,
generateFirewallRuleName("server-id"), DEFAULT_ACTION,
-DEFAULT_IP_VERSION, DEFAULT_PROTOCOL,
FirewallRuleTarget.builder().ip(IpRange.create("ANY", null)).build(),
-FirewallRuleTarget.builder().ip(IpRange.create("ANY",
null)).portListId(portListId).build(), Boolean.TRUE,
-Placement.builder().position("LAST").build());
- firewallRuleIds.add(firewallRuleId);
- }
-
- @Test(dependsOnMethods = "testCreateFirewallRuleWithPortList")
- public void testListFirewallRules() {
- PagedIterable firewallRulesList =
api().listFirewallRules(networkDomainId);
- assertFalse(firewallRulesList.isEmpty());
-
assertEquals(firewallRulesList.last().get().first().get().networkDomainId(),
networkDomainId);
- }
-
- @Test(dependsOnMethods = "testListFirewallRules")
- public void testDeleteFirewallRule() {
- api().deleteFirewallRule(firewallRuleId);
- FirewallRule rule =
findById(api().listFirewallRules(networkDomainId).concat().toList(),
firewallRuleId);
- assertNull(rule);
- }
-
- @Test(dependsOnMethods = "testDeployNetworkDomain")
- public void testDeployVlan() {
- vlanId = api().deployVlan(networkDomainId,
NetworkApiLiveTest.class.getSimpleName() + new Date().getTime(),
-NetworkApiLiveTest.class.getSimpleName() + new Date().getTime(),
DEFAULT_PRIVATE_IPV4_BASE_ADDRESS,
-DEFAULT_PRIVATE_IPV4_PREFIX_SIZE);
- assertNotNull(vlanId);
- assertTrue(vlanNormalPredicate.apply(vlanId), "vlan is not in a NORMAL
state after timeout");
- }
-
- @Test
- public void testDeployNetworkDomain() {
- networkDomainName = NetworkApiLiveTest.class.getSimpleName() + new
Date().getTime();
- networkDomainId =
api().deployNetworkDomain(datacenters.iterator().next(), networkDomainName,
-NetworkApiLiveTest.class.getSimpleName() + new Date().getTime() +
"description", "ESSENTIALS");
- assertNotNull(networkDomainId);
- assertTrue(networkDomainNormalPredicate.apply(networkDomainId),
-"network domain is not in a NORMAL state after timeout");
- }
-
- @Test(expectedExceptions = ResourceAlreadyExistsException.class)
- public void testDeploySameNetworkDomain() {
- api().deployNetworkDomain(datacenters.iterator().next(),
networkDomainName, networkDomainName, "ESSENTIALS");
- }
-
- @AfterClass
- public void tearDown() {
- if (!firewallRuleIds.isEmpty()) {
- for (String firewallRuleId : firewallRuleIds) {
-api().deleteFirewallRule(firewallRuleId);
- }
- }
- if (portListId != null) {
- api().deletePortList(portListId);
- }
- if (vlanId != null) {
- api().deleteVlan(vlanId);
- assertTrue(vlanDeletedPredicate.apply(vlanId), "vlan is not in a
DELETED state after timeout");
- }
- if (networkDomainId != null) {
- api().deleteNetworkDomain(networkDomainId);
- assertTrue(networkDomainDeletedPredicate.apply(networkDomainId),
- "network domain is not in a DELETED state after timeout");
- }
- }
-
- private NetworkApi api() {
- return api.getNetworkApi();
- }
-
- private FirewallRule findById(List collection, String id) {
- for (FirewallRule rule : collection) {
- if (rule.id().eq
[GitHub] [jclouds-site] trevorflanagan opened a new pull request #6: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable
trevorflanagan opened a new pull request #6: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable URL: https://github.com/apache/jclouds-site/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds-site] jclouds-commentator commented on issue #6: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable
jclouds-commentator commented on issue #6: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable URL: https://github.com/apache/jclouds-site/pull/6#issuecomment-478475241 Go to http://ffd4768ce16129a573fb-915d69f270c543467704832fba9063e2.r42.cf5.rackcdn.com/ to review your changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds-labs] nacx merged pull request #1: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable
nacx merged pull request #1: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable URL: https://github.com/apache/jclouds-labs/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds-site] nacx merged pull request #6: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable
nacx merged pull request #6: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable URL: https://github.com/apache/jclouds-site/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds-labs] nacx commented on issue #1: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable
nacx commented on issue #1: JCLOUDS-1492 Dimension Data Feature API Predicates are not usable URL: https://github.com/apache/jclouds-labs/pull/1#issuecomment-478665494 Cherry-picked to 2.1.x too. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] danielestevez opened a new pull request #21: Adds methods listAll and listByLocation to VirtualMachineAPI
danielestevez opened a new pull request #21: Adds methods listAll and listByLocation to VirtualMachineAPI URL: https://github.com/apache/jclouds/pull/21 * https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/listall * https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/listbylocation These methods will be very useful to improve the performance of jclouds provider skipping calls to resourcegroups API (as in [here](https://github.com/danielestevez/apache-jclouds/blob/d621edd79f1d95c7bdaa4803bf36fa4d62cfdd99/providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/AzureComputeServiceAdapter.java#L354)) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] nacx commented on a change in pull request #21: Adds methods listAll and listByLocation to VirtualMachineAPI
nacx commented on a change in pull request #21: Adds methods listAll and
listByLocation to VirtualMachineAPI
URL: https://github.com/apache/jclouds/pull/21#discussion_r271837196
##
File path:
providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/features/VirtualMachineApi.java
##
@@ -139,14 +151,14 @@ VirtualMachine createOrUpdate(@PathParam("vmname")
String vmname,
*/
@Named("capture")
@POST
-
@Payload("%7B\"vhdPrefix\":\"{vhdPrefix}\",\"destinationContainerName\":\"{destinationContainerName}\",\"overwriteVhds\":\"true\"%7D")
- @Path("/{name}/capture")
+
@Payload("%7B\"vhdPrefix\":\"{vhdPrefix}\",\"destinationContainerName\":\"{destinationContainerName}\","
+ + "\"overwriteVhds\":\"true\"%7D")
Review comment:
Put it in one line as it was before
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] nacx commented on a change in pull request #21: Adds methods listAll and listByLocation to VirtualMachineAPI
nacx commented on a change in pull request #21: Adds methods listAll and
listByLocation to VirtualMachineAPI
URL: https://github.com/apache/jclouds/pull/21#discussion_r271837994
##
File path:
providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/VirtualMachineApiMockTest.java
##
@@ -119,6 +119,22 @@ public void testListEmpty() throws Exception {
+ "/virtualMachines?api-version=2018-06-01");
}
+ public void testListAll() throws Exception {
+ server.enqueue(jsonResponse("/virtualmachinesinsubscription.json"));
+ final VirtualMachineApi vmAPI = api.getVirtualMachineApi(null);
+ assertEquals(vmAPI.listAll(), getVMListAll()); //TODO allinsubs
Review comment:
What does this TODO and the other one stand for? Can they be removed or is
there anything else TBD?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] nacx commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI
nacx commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI URL: https://github.com/apache/jclouds/pull/21#issuecomment-479573215 The PR is small enough to go ahead and change the adapter too. Why isn't it changed in this PR? Having a second look I really think changing the adapter could be part of this PR. jclouds is all about the abstractions, so improving them should be the very first main focus. Let's update the adapter too in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] danielestevez commented on a change in pull request #21: Adds methods listAll and listByLocation to VirtualMachineAPI
danielestevez commented on a change in pull request #21: Adds methods listAll
and listByLocation to VirtualMachineAPI
URL: https://github.com/apache/jclouds/pull/21#discussion_r271890370
##
File path:
providers/azurecompute-arm/src/test/java/org/jclouds/azurecompute/arm/features/VirtualMachineApiMockTest.java
##
@@ -119,6 +119,22 @@ public void testListEmpty() throws Exception {
+ "/virtualMachines?api-version=2018-06-01");
}
+ public void testListAll() throws Exception {
+ server.enqueue(jsonResponse("/virtualmachinesinsubscription.json"));
+ final VirtualMachineApi vmAPI = api.getVirtualMachineApi(null);
+ assertEquals(vmAPI.listAll(), getVMListAll()); //TODO allinsubs
Review comment:
That one is already done, forgot to remove it!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] danielestevez commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI
danielestevez commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI URL: https://github.com/apache/jclouds/pull/21#issuecomment-479621115 Well i prefer smaller PRs and these methods are just ready to be used but i can add the work i'm doing on the adapter to this same PR if it's better and merge it all when it's ready. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] danielestevez commented on a change in pull request #21: Adds methods listAll and listByLocation to VirtualMachineAPI
danielestevez commented on a change in pull request #21: Adds methods listAll
and listByLocation to VirtualMachineAPI
URL: https://github.com/apache/jclouds/pull/21#discussion_r271891284
##
File path:
providers/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/features/VirtualMachineApi.java
##
@@ -139,14 +151,14 @@ VirtualMachine createOrUpdate(@PathParam("vmname")
String vmname,
*/
@Named("capture")
@POST
-
@Payload("%7B\"vhdPrefix\":\"{vhdPrefix}\",\"destinationContainerName\":\"{destinationContainerName}\",\"overwriteVhds\":\"true\"%7D")
- @Path("/{name}/capture")
+
@Payload("%7B\"vhdPrefix\":\"{vhdPrefix}\",\"destinationContainerName\":\"{destinationContainerName}\","
+ + "\"overwriteVhds\":\"true\"%7D")
Review comment:
oops yes
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jclouds] ak58588 opened a new pull request #22: Disable PublicAccess enquiry for AzureBlob, when using SAS Auth.
ak58588 opened a new pull request #22: Disable PublicAccess enquiry for AzureBlob, when using SAS Auth. URL: https://github.com/apache/jclouds/pull/22 Since it is impossible (checked with the Azure Storage dev team) to execute getContainerACL with SAS Authorisation, here is a possible solution to omit checking the Public Access policy for Cotnainers and Blobs when using SAS, as it will fail. No test provided yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] nacx commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI
nacx commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI URL: https://github.com/apache/jclouds/pull/21#issuecomment-480350282 Yes, I think you should add your adapter work here. One mistake we've done in the past is not putting abstractions first. Everything should be driven by our abstractions, and efforts should we put around them. The goal of this addition to the Azure APIs should be to optimize the current abstraction, not just add more methods to the API itself, so let's better add the adapter changes to this PR too. Otherwise, we continue with the tendency of adding APIs with no clear commitment to complete the abstractions later and keep growing our API footprint while keeping the abstractions incomplete. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds-labs] gaul opened a new pull request #2: Remove JDBC provider
gaul opened a new pull request #2: Remove JDBC provider URL: https://github.com/apache/jclouds-labs/pull/2 This was written in a confusing way, storing both metadata and data in a SQL database, making it only useful for testing which duplicates the existing transient provider. It has no known users and creates a maintenance burden. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
