Re: [jclouds] JCLOUDS-453. Add OpenStack Keystone v2.0 OS-KSADM Admin Extension support (#303)
Thanks for your help @demobox --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/303#issuecomment-36356863
Re: [jclouds] JCLOUDS-453. Add OpenStack Keystone v2.0 OS-KSADM Admin Extension support (#303)
@demobox I have no idea what's the problem here: https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/623/org.apache.jclouds.api$openstack-keystone/violations/file/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/RoleAdminApiLiveTest.java/ --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/303#issuecomment-36334363
Re: [jclouds] Add keystone user add and delete methods. (#290)
@demobox I think the implementation is incorrect, since these actions are just exposed by Keystone API trough an extension, so depending on the deployments It may be disabled. That's why It should not be implemented in the UserApi, that matches the default actions in the default API, but in a API class in an extension package annotated with the corresponding Extension. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/290#issuecomment-36010284
Re: [jclouds] Add keystone user add and delete methods. (#290)
I'm not OK with this PR. The POST and DELETE operations are included in OS-KASDM extension: https://github.com/openstack/keystone/blob/master/keystone/contrib/admin_crud/core.py#L84. This is way it's been addressed in the OS-KSADM PR: https://github.com/jclouds/jclouds/pull/303 --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds/pull/290#issuecomment-35986674
[jclouds] JCLOUDS-453. Add OpenStack Keystone v2.0 OS-KSADM Admin Extension support (#303)
JCLOUDS-453. Add OpenStack Keystone v2.0 OS-KSADM Admin Extension support for Keystone You can merge this Pull Request by running: git pull https://github.com/StackOps/jclouds OSKADM Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds/pull/303 -- Commit Summary -- * JCLOUDS-453. Add OpenStack Keystone v2.0 OS-KSADM Admin Extension support for Keystone. -- File Changes -- M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/KeystoneApi.java (28) M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/KeystoneAsyncApi.java (28) M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/config/KeystoneRestClientModule.java (12) M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/domain/Service.java (60) M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/domain/Tenant.java (29) M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/domain/User.java (76) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/ExtensionNamespaces.java (30) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/RoleAdminApi.java (66) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/RoleAdminAsyncApi.java (110) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/ServiceAdminApi.java (71) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/ServiceAdminAsyncApi.java (127) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/TenantAdminApi.java (74) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/TenantAdminAsyncApi.java (120) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/UserAdminApi.java (60) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/extensions/UserAdminAsyncApi.java (95) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/functions/internal/ParseServices.java (95) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/options/CreateTenantOptions.java (144) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/options/CreateUserOptions.java (180) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/options/UpdateTenantOptions.java (159) A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/options/UpdateUserOptions.java (193) A apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/RoleAdminApiLiveTest.java (111) A apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/RoleAdminApiMockTest.java (149) A apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/ServiceAdminApiLiveTest.java (110) A apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/ServiceAdminApiMockTest.java (181) A apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/TenantAdminApiLiveTest.java (103) A apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/TenantAdminApiMockTest.java (162) A apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/UserAdminApiLiveTest.java (104) A apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/extensions/UserAdminApiMockTest.java (121) M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/features/ServiceApiExpectTest.java (3) M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/features/TenantApiExpectTest.java (9) M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/features/TokenApiExpectTest.java (2) M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/features/UserApiExpectTest.java (19) M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/functions/internal/ParseUsersTest.java (12) M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/parse/ParseAdminAccessTest.java (3) M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/parse/ParseRandomEndpointVersionAccessTest.java (2) M apis/openstack-keystone/src/test/java/org/jclouds/openstack/v2_0/internal/BaseOpenStackMockTest.java (12) A apis/openstack-keystone/src/test/resources/admin_extensions.json (1) A apis/openstack-keystone/src/test/resources/role_create_response.json (1) A apis/openstack-keystone/src/test/resources/role_list_response.json (1) A apis/openst
