[GitHub] [jclouds] nacx commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI
nacx commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI URL: https://github.com/apache/jclouds/pull/21#issuecomment-479573215 The PR is small enough to go ahead and change the adapter too. Why isn't it changed in this PR? Having a second look I really think changing the adapter could be part of this PR. jclouds is all about the abstractions, so improving them should be the very first main focus. Let's update the adapter too in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] nacx commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI
nacx commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI URL: https://github.com/apache/jclouds/pull/21#issuecomment-480350282 Yes, I think you should add your adapter work here. One mistake we've done in the past is not putting abstractions first. Everything should be driven by our abstractions, and efforts should we put around them. The goal of this addition to the Azure APIs should be to optimize the current abstraction, not just add more methods to the API itself, so let's better add the adapter changes to this PR too. Otherwise, we continue with the tendency of adding APIs with no clear commitment to complete the abstractions later and keep growing our API footprint while keeping the abstractions incomplete. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [jclouds] nacx commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI
nacx commented on issue #21: Adds methods listAll and listByLocation to VirtualMachineAPI URL: https://github.com/apache/jclouds/pull/21#issuecomment-492505274 > after several tests, the case sensitivity problem will not affect the jclouds provider Then I understand adding the changes to the abstraction is not a big deal, right? Look forward to seeing that added to this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
