Re: [jclouds/jclouds] Add OSGi exports to jclouds-gson (#38) (753bd8d)

[Albert Puig]

Ok, cool. It's good to see this merged

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/commit/753bd8d78178112029bb9cc1b13a8d1e9f041cf8#commitcomment-34140121

Re: [jclouds/jclouds] Add OSGi exports to jclouds-gson (#38) (753bd8d)

[Ignasi Barrera]

Yep. It is a PITA to make the maven bundle plugin and the shade plugin work 
together to produce proper OSGi metadata in the generated manifest file.
All this jclouds gson thing and the split in two modules is the only way we've 
found to cleanly 樂 fix that. The idea is that the only stuff exposed and used 
by other projects should be the `jclouds-gson` one, and the exclusion should 
[be implicitly be 
there](https://github.com/apache/jclouds/blob/master/project/pom.xml#L257-L277) 
already. For example, the  gson related dependencies for `jclouds-core` are:
```bash
nacx ~/src/asf/jclouds (master *) $ mvn dependency:tree -pl core | grep gson 
-B2 -A2
[INFO] |  |  \- com.squareup.okio:okio:jar:1.2.0:test
[INFO] |  \- org.bouncycastle:bcprov-jdk15on:jar:1.50:test
[INFO] +- org.apache.jclouds:jclouds-gson:jar:2.2.0-SNAPSHOT:compile
[INFO] +- com.google.guava:guava:jar:21.0:compile
[INFO] +- org.osgi:org.osgi.core:jar:4.2.0:provided
```
Does this address your concern?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/commit/753bd8d78178112029bb9cc1b13a8d1e9f041cf8#commitcomment-34139876

Re: [jclouds/jclouds] Add OSGi exports to jclouds-gson (#38) (753bd8d)

[Albert Puig]

consider ```true``` to not rely on 
```dependency-reduced-pom.xml``` to exclude it.
Currently listed as dep in (but not included) - only if running dependency:tree 
form parent or parent/gson :
```
org.apache.jclouds:jclouds-gson:bundle:2.2.0-SNAPSHOT
+- org.apache.jclouds:jclouds-gson-shaded:jar:2.2.0-SNAPSHOT:compile
|  \- com.google.code.gson:gson:jar:2.5:compile
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/commit/753bd8d78178112029bb9cc1b13a8d1e9f041cf8#commitcomment-34138140