Re: [jclouds/jclouds] Fix an unexpected test failure in Windows path handling (#1162)

[Andrew Gaul]

Closed #1162.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1162#event-3586273602

Re: [jclouds/jclouds] Fix an unexpected test failure in Windows path handling (#1162)

[Andrew Gaul]

Please reopen against apache/jclouds if this is still relevant.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1162#issuecomment-663855747

Re: [jclouds/jclouds] Fix an unexpected test failure in Windows path handling (#1162)

[Andrew Phillips]

demobox commented on this pull request.



>String invalidPathBlobKey = "Ahttps://github.com/jclouds/jclouds/blob/master/apis/filesystem/src/main/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImpl.java#L846)
 is then empty, so the code that throws the error (`directory.toPath()`, a few 
lines down) is never actually called.

@gaul Do you recall what the intention is here? Is `invalidPathBlobKey` 
supposed to represent a blob key **without** path information, or is it 
supposed to represent a path, too?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1162#discussion_r210170364

Re: [jclouds/jclouds] Fix an unexpected test failure in Windows path handling (#1162)

[Andrew Gaul]

gaul commented on this pull request.



>String invalidPathBlobKey = "Ahttps://github.com/jclouds/jclouds/pull/1162#pullrequestreview-80685315

[jclouds/jclouds] Fix an unexpected test failure in Windows path handling (#1162)

[Andrew Phillips]

See http://markmail.org/message/tahusme6svuhpew6.

>From a quick local test, it seems that this test has been failing on Windows 
>since it was added in 6452960c72a5f8, so I'm not sure if the test input was 
>incorrectly constructed at the time, or if the actual functionality has been 
>broken on Windows from the beginning.

@gaul Any light you could shed on that?
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1162

-- Commit Summary --

  * Fix an unexpected test failure in Windows path handling

-- File Changes --

M 
apis/filesystem/src/test/java/org/jclouds/filesystem/strategy/internal/FilesystemStorageStrategyImplTest.java
 (16)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1162.patch
https://github.com/jclouds/jclouds/pull/1162.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1162