Re: [jclouds/jclouds] Missing cleanup was causing testReplaceManifest to fail (#1038)

[Andrew Phillips]

demobox commented on this pull request.



> @@ -117,6 +118,7 @@ public void 
> testDeleteSinglePartObjectWithMultiPartDelete() throws Exception {
  assertThat(resp.deleted()).isZero();
  assertThat(resp.notFound()).isZero();
  assertThat(resp.errors()).hasSize(1);
+ api.getObjectApi(regionId, containerName).delete(objectName);

> but unfortunately other tests here (testreplacemanifest) will fail if it is 
> not cleaned up on success.

Thanks for clarifying, Zack!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1038

Re: [jclouds/jclouds] Missing cleanup was causing testReplaceManifest to fail (#1038)

[Zack Shoylev]

merged

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1038#issuecomment-260710219

Re: [jclouds/jclouds] Missing cleanup was causing testReplaceManifest to fail (#1038)

[Zack Shoylev]

Closed #1038.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1038#event-859780341

Re: [jclouds/jclouds] Missing cleanup was causing testReplaceManifest to fail (#1038)

[Zack Shoylev]

zack-shoylev commented on this pull request.



> @@ -117,6 +118,7 @@ public void 
> testDeleteSinglePartObjectWithMultiPartDelete() throws Exception {
  assertThat(resp.deleted()).isZero();
  assertThat(resp.notFound()).isZero();
  assertThat(resp.errors()).hasSize(1);
+ api.getObjectApi(regionId, containerName).delete(objectName);

Cleanup after the test suite takes care of it if it fails, but unfortunately 
other tests here (testreplacemanifest) will fail if it is not cleaned up on 
success.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1038

Re: [jclouds/jclouds] Missing cleanup was causing testReplaceManifest to fail (#1038)

[Andrew Phillips]

demobox commented on this pull request.



> @@ -117,6 +118,7 @@ public void 
> testDeleteSinglePartObjectWithMultiPartDelete() throws Exception {
  assertThat(resp.deleted()).isZero();
  assertThat(resp.notFound()).isZero();
  assertThat(resp.errors()).hasSize(1);
+ api.getObjectApi(regionId, containerName).delete(objectName);

> Yeah, otherwise cleanup takes care of it.

Ah, OK. In that case, I'm probably confused: if cleanup takes care of it, why 
do we explicitly need to delete it here? Is that more efficient? Or do 
downstream tests fail otherwise? Or..?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1038

Re: [jclouds/jclouds] Missing cleanup was causing testReplaceManifest to fail (#1038)

[Zack Shoylev]

zack-shoylev commented on this pull request.



> @@ -117,6 +118,7 @@ public void 
> testDeleteSinglePartObjectWithMultiPartDelete() throws Exception {
  assertThat(resp.deleted()).isZero();
  assertThat(resp.notFound()).isZero();
  assertThat(resp.errors()).hasSize(1);
+ api.getObjectApi(regionId, containerName).delete(objectName);

Yeah, otherwise cleanup takes care of it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1038

Re: [jclouds/jclouds] Missing cleanup was causing testReplaceManifest to fail (#1038)

[Andrew Phillips]

demobox commented on this pull request.



> @@ -117,6 +118,7 @@ public void 
> testDeleteSinglePartObjectWithMultiPartDelete() throws Exception {
  assertThat(resp.deleted()).isZero();
  assertThat(resp.notFound()).isZero();
  assertThat(resp.errors()).hasSize(1);
+ api.getObjectApi(regionId, containerName).delete(objectName);

@zack-shoylev Is it the intention that this only be called if the assertions 
succeed?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1038#pullrequestreview-8524607

[jclouds/jclouds] Missing cleanup was causing testReplaceManifest to fail (#1038)

[Zack Shoylev]

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1038

-- Commit Summary --

  * Missing cleanup was causing testReplaceManifest to fail

-- File Changes --

M 
apis/openstack-swift/src/test/java/org/jclouds/openstack/swift/v1/features/StaticLargeObjectApiLiveTest.java
 (4)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1038.patch
https://github.com/jclouds/jclouds/pull/1038.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1038