Re: [jclouds/jclouds] Updates the default template so live tests pass again. (#1041)

2017-08-29 Thread Andrea Turli 
backport to 
[2.0.x](http://git-wip-us.apache.org/repos/asf/jclouds/commit/c2a4b8af) as well

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1041#issuecomment-325706503

Re: [jclouds/jclouds] Updates the default template so live tests pass again. (#1041)

2016-11-21 Thread Zack Shoylev 
Closed #1041.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1041#event-867287149

Re: [jclouds/jclouds] Updates the default template so live tests pass again. (#1041)

2016-11-21 Thread Zack Shoylev 
merged

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1041#issuecomment-262077668

Re: [jclouds/jclouds] Updates the default template so live tests pass again. (#1041)

2016-11-21 Thread Zack Shoylev 
zack-shoylev commented on this pull request.



> @@ -80,9 +80,9 @@ public OperatingSystem apply(final Image from) {
 is64Bit = matcher.group(2).equals("x64");
  }
   } else {
- if (imageName.contains("Red Hat EL")) {
+ if (imageName.contains("Red Hat")) {

Well, the imageName string changed from "EL" to "Enterprise Linux" at some 
point, which is why the match was failing, but I don't know the original 
reasoning for being that specific. Seems safe, though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1041

Re: [jclouds/jclouds] Updates the default template so live tests pass again. (#1041)

2016-11-21 Thread Andrew Phillips 
demobox commented on this pull request.



> @@ -80,9 +80,9 @@ public OperatingSystem apply(final Image from) {
 is64Bit = matcher.group(2).equals("x64");
  }
   } else {
- if (imageName.contains("Red Hat EL")) {
+ if (imageName.contains("Red Hat")) {

If we do find out the reason (other than "this one seemed to work" ;-)), 
perhaps add a comment to explain?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1041

Re: [jclouds/jclouds] Updates the default template so live tests pass again. (#1041)

2016-11-21 Thread Ignasi Barrera 
nacx commented on this pull request.

Comment aside, changes LGTM.
Thanks for taking care of this @zack-shoylev!

> @@ -80,9 +80,9 @@ public OperatingSystem apply(final Image from) {
 is64Bit = matcher.group(2).equals("x64");
  }
   } else {
- if (imageName.contains("Red Hat EL")) {
+ if (imageName.contains("Red Hat")) {

It would be good to know (and I'd like to :)), but it looks like a safe change 
anyway?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1041#pullrequestreview-9433122

Re: [jclouds/jclouds] Updates the default template so live tests pass again. (#1041)

2016-11-20 Thread Andrew Phillips 
demobox commented on this pull request.



> @@ -80,9 +80,9 @@ public OperatingSystem apply(final Image from) {
 is64Bit = matcher.group(2).equals("x64");
  }
   } else {
- if (imageName.contains("Red Hat EL")) {
+ if (imageName.contains("Red Hat")) {

@zack-shoylev Do we happen to know why `EL` was chosen in the first place?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1041

Re: [jclouds/jclouds] Updates the default template so live tests pass again. (#1041)

2016-11-18 Thread Zack Shoylev 
zack-shoylev commented on this pull request.



> @@ -80,9 +80,9 @@ public OperatingSystem apply(final Image from) {
 is64Bit = matcher.group(2).equals("x64");
  }
   } else {
- if (imageName.contains("Red Hat EL")) {
+ if (imageName.contains("Red Hat")) {

Not completely sure about this one, though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1041#pullrequestreview-9339328

[jclouds/jclouds] Updates the default template so live tests pass again. (#1041)

2016-11-18 Thread Zack Shoylev 

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1041

-- Commit Summary --

  * Updates the default template so live tests pass again.

-- File Changes --

M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/compute/functions/ImageToOperatingSystem.java
 (4)
M 
compute/src/main/java/org/jclouds/compute/reference/ComputeServiceConstants.java
 (2)
M 
compute/src/test/java/org/jclouds/compute/internal/BaseTemplateBuilderLiveTest.java
 (2)
M 
providers/rackspace-cloudservers-us/src/main/java/org/jclouds/rackspace/cloudservers/us/CloudServersUSProviderMetadata.java
 (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1041.patch
https://github.com/jclouds/jclouds/pull/1041.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1041