Re: [jclouds/jclouds] Use file.separator in tests instead of slash (#1021)

2016-10-24 Thread Zack Shoylev 
https://github.com/jclouds/jclouds/pull/1024

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1021#issuecomment-255812343

Re: [jclouds/jclouds] Use file.separator in tests instead of slash (#1021)

2016-10-24 Thread Zack Shoylev 
Closed #1021.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1021#event-834256009

Re: [jclouds/jclouds] Use file.separator in tests instead of slash (#1021)

2016-10-13 Thread Zack Shoylev 
zack-shoylev commented on this pull request.



> @@ -584,12 +584,12 @@ public void testListMarkerPrefix() throws Exception {
   final String container = getContainerName();
   try {
  blobStore.createContainerInLocation(null, container);
- blobStore.putBlob(container, 
blobStore.blobBuilder("a/a").payload("").build());
- blobStore.putBlob(container, 
blobStore.blobBuilder("b/b").payload("").build());
- ListContainerOptions options = new 
ListContainerOptions().afterMarker("b/").recursive();
+ blobStore.putBlob(container, blobStore.blobBuilder("a" + 
File.separator + "a").payload("").build());

Valid point. I'll look into it some more tomorrow.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1021

Re: [jclouds/jclouds] Use file.separator in tests instead of slash (#1021)

2016-10-13 Thread Andrew Gaul 
andrewgaul requested changes on this pull request.



> @@ -584,12 +584,12 @@ public void testListMarkerPrefix() throws Exception {
   final String container = getContainerName();
   try {
  blobStore.createContainerInLocation(null, container);
- blobStore.putBlob(container, 
blobStore.blobBuilder("a/a").payload("").build());
- blobStore.putBlob(container, 
blobStore.blobBuilder("b/b").payload("").build());
- ListContainerOptions options = new 
ListContainerOptions().afterMarker("b/").recursive();
+ blobStore.putBlob(container, blobStore.blobBuilder("a" + 
File.separator + "a").payload("").build());

This is backwards -- the Filesystem blobstore should map the path separator and 
not the tests.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1021#pullrequestreview-4187901

[jclouds/jclouds] Use file.separator in tests instead of slash (#1021)

2016-10-13 Thread Zack Shoylev 

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1021

-- Commit Summary --

  * Use file.separator in tests instead of slash

-- File Changes --

M 
blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseContainerIntegrationTest.java
 (8)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1021.patch
https://github.com/jclouds/jclouds/pull/1021.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1021