Re: [jclouds/jclouds-site] Document workaround to revert to shared credential store (#200)

2017-07-18 Thread Ignasi Barrera
nacx commented on this pull request.



> @@ -548,3 +548,20 @@ The jclouds API allows many `Statements` to be built 
> entirely from high-level co
 without having to resort to OS-specific scripts. This enables developers to 
express what they mean without having
  to deal with the gory details of various OS flavors.
 To see the commands that will be executed, print the result of 
`Statement.render(OsFamily.UNIX)`, for example.
+
+### Sharing the credential store between ComputeService instances
+
+By default there's a separate credential store per ComputeService instance. To 
change that and share the
+same credential store between instances create your ComputeService as follows:
+
+{% highlight java %}
+public static final Map SHARED_CREDENTIAL_STORE = new 
ConcurrentHashMap();
+...
+Module sharedCredStore = new CredentialStoreModule(SHARED_CREDENTIAL_STORE);

It should make no difference. The important thing is to have every context 
using the same backing map for the credential store. Whether it is static or 
not is not relevant.
I think being the Map the static field (and not the module) better emphasizes 
the fact that what needs to be shared is the backing map? And that anyone can 
switch implementations to whatever meaning of `shared` applies to their use 
case.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/200#discussion_r127891080

Re: [jclouds/jclouds-site] Document workaround to revert to shared credential store (#200)

2017-07-17 Thread Andrew Phillips
demobox commented on this pull request.



> @@ -548,3 +548,20 @@ The jclouds API allows many `Statements` to be built 
> entirely from high-level co
 without having to resort to OS-specific scripts. This enables developers to 
express what they mean without having
  to deal with the gory details of various OS flavors.
 To see the commands that will be executed, print the result of 
`Statement.render(OsFamily.UNIX)`, for example.
+
+### Sharing the credential store between ComputeService instances
+
+By default there's a separate credential store per ComputeService instance. To 
change that and share the
+same credential store between instances create your ComputeService as follows:
+
+{% highlight java %}
+public static final Map SHARED_CREDENTIAL_STORE = new 
ConcurrentHashMap();
+...
+Module sharedCredStore = new CredentialStoreModule(SHARED_CREDENTIAL_STORE);

[minor] Just to clarify: is there any specific reason to pull the 
`SHARED_CREDENTIAL_STORE` out as a constant, or could one e.g. also have the 
module as a constant?

I'm asking to avoid users e.g. inlining the declaration if they feel it's not 
necessary, and ending up with unexpected behaviour.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/200#pullrequestreview-50486268

Re: [jclouds/jclouds-site] Document workaround to revert to shared credential store (#200)

2017-07-17 Thread jclouds-commentator
  Go to 
http://f65b776042714e5b0791-9883cc9304202abd55a5101f881b1528.r52.cf5.rackcdn.com/
 to review your changes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/200#issuecomment-315926669

Re: [jclouds/jclouds-site] Document workaround to revert to shared credential store (#200)

2017-07-17 Thread Andrew Phillips
@demobox pushed 1 commit.

d34f70d  Minor suggested text edit to the "pre-2.1.0" note


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-site/pull/200/files/c87b4acdbd9c7d679ddd9165f8f20533c9ed49be..d34f70de2c03c9013d67916d31a6d703ae17292b


Re: [jclouds/jclouds-site] Document workaround to revert to shared credential store (#200)

2017-07-17 Thread jclouds-commentator
  Go to 
http://f87fb730277b7ff7bcc2-6998e5196134be870bcb4bdbdaf08877.r71.cf5.rackcdn.com/
 to review your changes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/200#issuecomment-315774092

Re: [jclouds/jclouds-site] Document workaround to revert to shared credential store (#200)

2017-07-17 Thread Ignasi Barrera
nacx approved this pull request.

Thansk @neykov!



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/200#pullrequestreview-50331119

Re: [jclouds/jclouds-site] Document workaround to revert to shared credential store (#200)

2017-07-17 Thread jclouds-commentator
  Go to 
http://7980e4076c61b89e82eb-ee8aa8198f8d15624472c3c54569b0e1.r61.cf5.rackcdn.com/
 to review your changes.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/200#issuecomment-315760573

[jclouds/jclouds-site] Document workaround to revert to shared credential store (#200)

2017-07-17 Thread Svet
Depends on https://github.com/jclouds/jclouds/pull/1119 being released.
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-site/pull/200

-- Commit Summary --

  * Workaround to revert to shared credential store

-- File Changes --

M start/compute.md (15)

-- Patch Links --

https://github.com/jclouds/jclouds-site/pull/200.patch
https://github.com/jclouds/jclouds-site/pull/200.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-site/pull/200