[jclouds] Fixes blob-related tests that fail occasionally (#683)

2015-02-13 Thread Zack Shoylev 

You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/683

-- Commit Summary --

  * Fixes blob-related tests that fail occasionally

-- File Changes --

M 
apis/swift/src/test/java/org/jclouds/openstack/swift/blobstore/integration/SwiftBlobIntegrationLiveTest.java
 (11)
M 
blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseBlobIntegrationTest.java
 (3)
M 
blobstore/src/test/java/org/jclouds/blobstore/integration/internal/BaseContainerIntegrationTest.java
 (8)
M 
providers/cloudfiles-us/src/test/java/org/jclouds/rackspace/cloudfiles/blobstore/integration/CloudFilesUSBlobIntegrationLiveTest.java
 (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/683.patch
https://github.com/jclouds/jclouds/pull/683.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/683

Re: [jclouds] Fixes blob-related tests that fail occasionally (#683)

2015-02-13 Thread Jeremy Daggett 
 @@ -432,7 +433,13 @@ public void deleteObject(String name) throws 
 InterruptedException {
String container = getContainerName();
try {
   addBlobToContainer(container, name, name, MediaType.TEXT_PLAIN);
 + if (view.getConsistencyModel() == ConsistencyModel.EVENTUAL) {

It would be great to replace these kinds of comparisons with 
`Assert.isEqualTo(Object expected)` available to us in assertj. Just an idea, 
WDYT?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/683/files#r24683078

Re: [jclouds] Fixes blob-related tests that fail occasionally (#683)

2015-02-13 Thread Zack Shoylev 
needs rebase

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/683#issuecomment-74321426

Re: [jclouds] Fixes blob-related tests that fail occasionally (#683)

2015-02-13 Thread Zack Shoylev 
 @@ -432,7 +433,13 @@ public void deleteObject(String name) throws 
 InterruptedException {
String container = getContainerName();
try {
   addBlobToContainer(container, name, name, MediaType.TEXT_PLAIN);
 + if (view.getConsistencyModel() == ConsistencyModel.EVENTUAL) {

Well but this just applies a wait only the case of eventual consistency 
providers. How will the assert work here?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/683/files#r24693777

Re: [jclouds] Fixes blob-related tests that fail occasionally (#683)

2015-02-13 Thread Zack Shoylev 
merged

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/683#issuecomment-74345276