Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-04-01 Thread Andrew Phillips
Thanks, @jasdeep-hundal and @everett-toews!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-39198738

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-31 Thread Everett Toews
+1

I'm okay with this. I suspect the value is set that way because of a driver in 
Cinder. I could see this being the case for other Cinder driver's as well.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-39128245

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-31 Thread Everett Toews
Merged to master and 1.7.x.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-39129202

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-31 Thread Everett Toews
Closed #327.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-26 Thread BuildHive
[jclouds » jclouds 
#956](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/956/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38728902

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-26 Thread jasdeep-hundal
@nacx : I removed the zone specification from the test and it passed, so I 
think this is good to go. Could add another test to use zone as well, but I'm 
not sure how valuable an additional test just for that will be.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38735446

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-26 Thread Everett Toews
@jasdeep-hundal @nacx I made [a 
comment](https://issues.apache.org/jira/browse/JCLOUDS-515?focusedCommentId=13948419page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13948419)
 that was more appropriate to be made over in the issue.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38736206

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-26 Thread Andrew Phillips
 I made a comment that was more appropriate to be made over in the issue.

Good catch, @everett-toews. Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38738453

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-26 Thread Ignasi Barrera
Yep, I see now (and agree). Thx @everett-toews !

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38744957

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-26 Thread jasdeep-hundal
Thanks @everett-toews , I was a little quick to jump the gun there. Left a 
comment in the ticket, but there is a fix that needs to be made, not sure if it 
is this one though.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38746123

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-26 Thread BuildHive
[jclouds » jclouds 
#960](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/960/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38763497

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-26 Thread CloudBees pull request builder plugin
[jclouds-pull-requests 
#704](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/704/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38764216

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-25 Thread BuildHive
[jclouds » jclouds 
#950](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/950/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38638975

Re: [jclouds] JCLOUDS-515: Don't require availability zone when creating volumes in cinder (#327)

2014-03-25 Thread CloudBees pull request builder plugin
[jclouds-java-7-pull-requests 
#1164](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1164/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/327#issuecomment-38639908