Re: [jclouds] add availability zone to server (#574)

2015-02-12 Thread Jeremy Daggett 
@limorbortman Thanks for the contribution! I pulled your branch and submitted 
#681 to get this into **master**.  /cc @inbarsto 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-74152835

Re: [jclouds] add availability zone to server (#574)

2015-01-16 Thread Jeremy Daggett 
@limorbortman Can you provide an update on this PR? Let's work on getting this 
merged next week.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-70350832

Re: [jclouds] add availability zone to server (#574)

2014-11-18 Thread inbar stolberg 
merge has conflicts @limorbortman you need to fix this ... 
just pull latest master an do a manual merge...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-63495218

Re: [jclouds] add availability zone to server (#574)

2014-10-19 Thread BuildHive 
[jclouds » jclouds 
#1808](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1808/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-59644492

Re: [jclouds] add availability zone to server (#574)

2014-10-19 Thread CloudBees pull request builder plugin 
[jclouds-pull-requests 
#1300](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1300/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-59643887

Re: [jclouds] add availability zone to server (#574)

2014-10-19 Thread CloudBees pull request builder plugin 
[jclouds-pull-requests-java-6 
#211](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/211/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-59643384

Re: [jclouds] add availability zone to server (#574)

2014-10-15 Thread Jeremy Daggett 
For this particular extension, it just adds a field to the response, so the 
field needs to be added to the `Server` domain class :

@Named("OS-EXT-AZ:availability_zone")
private final Optional availabilityZones;

For the tests, since this is _technically_ an extension, I suggest that you 
create both a `ExtendedAvailabilityZoneExpectTest` and 
`ExtendedAvailabilityZoneLiveTest` in the 
`org.jclouds.openstack.nova.v2_0.extensions` package. There are examples of how 
to write the tests in that package. HTH!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-59249079

Re: [jclouds] add availability zone to server (#574)

2014-10-14 Thread limorbortman 
Hi
Thanks for the code review
I just have one question. I add to an existing tests (both live and expected) 
check that the Availability zone is exist. Is this good enough or should i 
create a new tests?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-59158105

Re: [jclouds] add availability zone to server (#574)

2014-10-14 Thread cloudband 
Hi
Thanks for the code review
I just have one question. I add to an existing tests (both live and expected) 
check that the Availability zone is exist. Is this good enough or should i 
create a new tests?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-59155191

Re: [jclouds] add availability zone to server (#574)

2014-10-14 Thread Jeremy Daggett 
Thanks for the contribution @limorbortman! 

Here is a quick overview of what needs to be addressed in this PR:
- The `ServerExtendedAttributes` class is specific to the [Nova Extended Status 
Extension API]
(http://developer.openstack.org/api-ref-compute-v2-ext.html#ext-os-extended-status)
 and should *not* be altered to add this feature.
- This feature is _specific_ to the [Nova Extended Availabilty Zones Extension 
API](http://developer.openstack.org/api-ref-compute-v2-ext.html#ext-os-ext-az).
- Given the above info, the `availabilityZone` field should reside in the 
[Server](https://github.com/jclouds/jclouds/blob/master/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/domain/Server.java#L312)
 domain class. For reference, take a look at how 
[`OS-DCF:diskConfig`](https://github.com/jclouds/jclouds/blob/master/apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/domain/Server.java#L3130)
 is implemented.
- Add the extension API namespace `EXTENDED_AVAILABILITY_ZONE` to 
`ExtensionNamespaces`. This extension just adds a field to the Server object 
and provides no API per se.
- Add unit and live tests.

Once these items have been addressed, please update and we can review it again! 
Thanks. :+1: 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-59100492

Re: [jclouds] add availability zone to server (#574)

2014-10-14 Thread BuildHive 
[jclouds » jclouds 
#1795](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1795/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-59067535

Re: [jclouds] add availability zone to server (#574)

2014-10-14 Thread CloudBees pull request builder plugin 
[jclouds-pull-requests 
#1291](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1291/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-59062571

Re: [jclouds] add availability zone to server (#574)

2014-10-14 Thread limorbortman 
Can you also merge it to 1.8 after the code freeze? Thanks 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-59058437

Re: [jclouds] add availability zone to server (#574)

2014-10-14 Thread CloudBees pull request builder plugin 
[jclouds-pull-requests-java-6 
#202](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/202/) 
SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574#issuecomment-59057901

[jclouds] add availability zone to server (#574)

2014-10-14 Thread limorbortman 
add availability zone to server
You can merge this Pull Request by running:

  git pull https://github.com/limorbortman/jclouds-1 serverAZ2

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/574

-- Commit Summary --

  * add availability zone to server

-- File Changes --

M 
apis/openstack-nova/src/main/java/org/jclouds/openstack/nova/v2_0/domain/ServerExtendedAttributes.java
 (64)
M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/features/ServerApiLiveTest.java
 (3)
M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseServerDetailsStatesTest.java
 (382)
M 
apis/openstack-nova/src/test/java/org/jclouds/openstack/nova/v2_0/parse/ParseServerTest.java
 (4)
M apis/openstack-nova/src/test/resources/server_details.json (1)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/574.patch
https://github.com/jclouds/jclouds/pull/574.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/574