Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

2014-10-27 Thread Chris Custine 
+1 I haven't tested with WIP such as the DO v2 API but the code looks good.  
After seeing some of this Autovalue stuff, I am going to switch the DO v2 
provider to use it ASAP :-)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/67#issuecomment-60615645

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

2014-10-27 Thread Adrian Cole 
Closed #67.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/67#event-184165194

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

2014-10-27 Thread Adrian Cole 
cherry-picked into master, 1.8.x

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/67#issuecomment-60622812

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

2014-10-27 Thread Adrian Cole 
@gk5885 @eamonnmcmanus @cgruber fyi, another several hundred lines saved thanks 
to auto.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/67#issuecomment-60667576

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

2014-10-26 Thread Adrian Cole 
@jdaggett if you don't mind giving a quick review, I can showcase json in 
google storage.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/67#issuecomment-60525721

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

2014-10-26 Thread Adrian Cole 
 +import org.jclouds.oauth.v2.domain.ClaimSet;
 +import org.jclouds.oauth.v2.domain.Header;
 +import org.jclouds.oauth.v2.domain.Token;
 +
 +import com.google.common.collect.ImmutableSet;
 +import com.google.gson.Gson;
 +import com.google.gson.TypeAdapter;
 +import com.google.gson.TypeAdapterFactory;
 +import com.google.gson.reflect.TypeToken;
 +import com.google.gson.stream.JsonReader;
 +import com.google.gson.stream.JsonWriter;
 +import com.google.inject.AbstractModule;
 +import com.google.inject.Provides;
 +
 +/** Configures type adapter factories for {@link Header}, {@link ClaimSet}, 
 and {@link Token}. */
 +public final class OAuthParserModule extends AbstractModule {

Note this is very good form for auth apis such as oauth and keystone. locking 
in serialization here allows any of the dozens of things that use it to adjust 
serialization preferences without concern for how that impacts auth. 

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/67/files#r19382476

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

2014-10-25 Thread CloudBees pull request builder plugin 
[jclouds-labs-google-pull-requests 
#185](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/185/)
 SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/67#issuecomment-60502122

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

2014-10-25 Thread BuildHive 
[jclouds » jclouds-labs-google 
#1554](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1554/)
 SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/67#issuecomment-60502200

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

2014-10-25 Thread BuildHive 
[jclouds » jclouds-labs-google 
#1555](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1555/)
 SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/67#issuecomment-60504360

Re: [jclouds-labs-google] At the cost of fiddling with type hierarchy adapters, remove lots of junk with google auto (#67)

2014-10-25 Thread Adrian Cole 
ok. ready to review. I'm done fiddling :)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/67#issuecomment-60504404